GitLab

Due to loadTimeData inconsistencies between refreshes, it's possible for
"chromeCleanupEnabled" to become true while no ChromeCleanupHandler is
present. 
To avoid showing a blank card or crashing in debug mode for edge cases,
always install the handler.

Also added some documentation to load_time_data.js to hopefully help
other developers avoid this issue.

Bug: 690020
Change-Id: Ifa8e0c0e78c2d6202e11fd378c74781b24401918
Reviewed-on: https://chromium-review.googlesource.com/565327Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485391}

This is part 2 of 6 for FieldTrial refactoring for WebView

Part 1: https://chromium-review.googlesource.com/c/562098/
Part 2: https://chromium-review.googlesource.com/c/561920/
Part 3: https://chromium-review.googlesource.com/c/561922/
Part 4: https://chromium-review.googlesource.com/c/561980/
Part 5: https://chromium-review.googlesource.com/c/562417/
Part 6: https://chromium-review.googlesource.com/c/562021/

This CL makes the reading on the client ID happen synchronously
at WebView startup only if the enable-webview-finch command
line flag is provided. This behavior is necessary in order to be
able to set up field trials as early as possible in the WebView
startup process. GetOrCreateGUID() is now a static member of
the AwMetricsServiceClient class.

BUG=678288

Change-Id: I69153f87243fa84f6816785090bfa963e34cf0b2
Reviewed-on: https://chromium-review.googlesource.com/561920
Commit-Queue: Kyle Milka <kmilka@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485390}

IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY is used in multiple tests,
so this CL creates a matcher in chrome_matchers.h.

Bug: 738363
Change-Id: If0ab68ce67397aa0a0819055fa147aef8f046984
Reviewed-on: https://chromium-review.googlesource.com/563473Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485389}

https://pdfium.googlesource.com/pdfium.git/+log/217644c0d65a..1437643bfaca

$ git log 217644c0d..1437643bf --date=short --no-merges --format='%ad %ae %s'
2017-07-10 dsinclair Reland "typeface double delete"
2017-07-10 dsinclair Add combo box tests.
2017-07-10 dsinclair Fix nits in CFFL_FormFiller

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib48ab9b2a604efab0ea9e68c3be5e2a9efe86c2f
Reviewed-on: https://chromium-review.googlesource.com/565524
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485388}

- Rename process_mitigations_test.cc -> process_mitigations_unittest.cc
- Pull large chunks out of process_mitigations_unittest.cc into unittest
files of their own.  The size was getting way out of hand.
- New files for existing tests: extensionpoints, imageload, win32k.
- NO new functionality tests in this CL - only re-organized things:
  - Note: the existing tests for every process mitigation that just check policy
	enabling have been centralized into one single test target function
	(SBOX_TESTS_COMMAND) called CheckPolicy.  Any new mitigation checks
	should be added here as well.
  - Note: The individual mitigation TESTs that trigger "CheckPolicy" have been
	adjusted to ensure we test both pre and post child-process startup wherever
	they are supported.

TEST= sbox_integration_tests.exe, ProcessMitigationsTest.*
BUG=733739
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=forshaw,wfh

Review-Url: https://codereview.chromium.org/2944493002
Cr-Commit-Position: refs/heads/master@{#485387}

Bug: 716570
Change-Id: I9a81dff8ed17ff9d61b89c9ef887a918770a80a9
Reviewed-on: https://chromium-review.googlesource.com/563862Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485386}

Chaining them all in one test does not make sense, as a module added
by one panel will show up in all dumps done after that.

Change-Id: If329f91bdf78d61338de7511e3669ede096b37e1
Reviewed-on: https://chromium-review.googlesource.com/565440
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485385}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/edde5168..cb9577c6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I0d72f807437dbae94861e5e091576d1f06d9c3ef
Reviewed-on: https://chromium-review.googlesource.com/565652Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485384}

The implementation of ScrollableArea::VisibleContentRect is never used
and would infinite loop if it were used. This patch makes it a pure
virtual so subclasses are required to implement it themselves.

Change-Id: I610361358686590762a1ea4147f89fc1f6bca16b
Reviewed-on: https://chromium-review.googlesource.com/562639Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485383}

TBR=zmo@chromium.org

BUG=668223

Change-Id: I3eeffe7cb4d7165fbe2fffea67fb144e7ebf6a37
Reviewed-on: https://chromium-review.googlesource.com/565111Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485382}

Original CL https://codereview.chromium.org/2956333002/

Bug: 701032
Change-Id: I60e30a7acf9c3380710c4abbeddd87baabac3ce0
Reviewed-on: https://chromium-review.googlesource.com/565361Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485381}

-Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%.

-Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location.

-Fixed the message dialogue for the WebUI.

-Added some extra css.

Note: Tags for the experiments are not added in this issue.
Review-Url: https://codereview.chromium.org/2964693003
Cr-Commit-Position: refs/heads/master@{#485380}

An upcoming version of clang removes the ability to suppress
availability warnings by redeclaring functions. The new way
to suppress warnings is to either annotate the caller with an
availability attribute or enclose the function reference in an "if
(@available)" block.

The functions willContinueUserActivityWithType and continueUserActivity
are called only by the operating system, so we can use availability
attributes. The function passURLToHandoffManager, however, may
be called or overridden from the test suite even before 10.10 (see
SetUpInProcessBrowserTestFixture in app_controller_mac_browsertest.mm),
so we need to use a runtime check.

Any references to NSUserActivity must have availability attributes
because that type was introduced in 10.10. The test-only parts
of HandoffManager are only used in an iOS-specific test, so for
simplicity we disable that code under non-iOS.

Bug: 735328
Change-Id: Ide1dd1cdec9f8a2c286ddd09d6e4ca6da2117e6a
Reviewed-on: https://chromium-review.googlesource.com/564226
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485379}

This reverts commit b68e6af8.

The SDK bug that this worked around was fixed in Xcode 9b2 9M137d.

Bug: 729896
Change-Id: I818ae7b1c0544f7a75281bcdf68192ff14905eec
Reviewed-on: https://chromium-review.googlesource.com/545035Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485378}

Implement SideMenuItem and SideMenuItemsProvider in Chromium to define the list
of items to be shown on the internal build's side menu.

Bug: 740240
Change-Id: I8577024a67b741453b9dbc757f02bede0da6927f
Reviewed-on: https://chromium-review.googlesource.com/563772Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485377}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/30c9d9b85571..f8681638b945

$ git log 30c9d9b85..f8681638b --date=short --no-merges --format='%ad %ae %s'
2017-07-10 etienneb Add end-to-end test for symbolisation on windows.

Created with:
  roll-dep src/third_party/catapult
BUG=737803


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I32594a32994908eb505671932c297b4944b0938f
Reviewed-on: https://chromium-review.googlesource.com/565744
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485376}

TBR=kschimpf@chromium.org

Bug: 736676
Change-Id: Ib3b51e610eab6433d9de2d43f774bcdc5f1f9e43
Reviewed-on: https://chromium-review.googlesource.com/565419Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485375}

BUG=554289

Review-Url: https://codereview.chromium.org/2968253002
Cr-Commit-Position: refs/heads/master@{#485374}

PaymentResponse.details was being JSON-escaped twice.

Bug: 602666
Change-Id: I0b574654353b25ed16d3baf143ac12ac14526953
Reviewed-on: https://chromium-review.googlesource.com/565008
Commit-Queue: mahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485373}

The condition was not quite right, as Mac uses a Cocoa implementation
and views in other places.

Bug: None
Change-Id: I6102b5185cc55c394d3710a7dd0fe0b69c599a9d
Reviewed-on: https://chromium-review.googlesource.com/565070Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485372}

As a temporary fix for bug 721727, we are disabling display list 2D
canvas by default.  With this change, display list mode is only engaged
when specifying the --force-display-list-2d-canvas command line option.

BUG=721727

TBR=zmo@chromium.org

Change-Id: I26f0caa3b62506c8d2d051bec208a94c1f51341f
Reviewed-on: https://chromium-review.googlesource.com/563519Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485371}

This CL is part of the closed CL:
https://codereview.chromium.org/2896583005

This CL fixes issues for //services/device/generic_sensor on Android
and Windows:

On Android, PlatformSensorProviderAndroid::CreateSensorInternal() needs
to return after the callback is called if the |sensor| object returned
from Java side is not valid.

On Windows, PlatformSensorProviderWin::InitializeSensorManager() needs
to check if |sensor_manager_| is valid.

Bug: 735549, 736200
Change-Id: I95f5ba9ee6a07ea8e34b6178ff00a04741e5d765
Reviewed-on: https://chromium-review.googlesource.com/550538
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mikhail Pozdnyakov (OOO till Jul 17th) <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#485370}

This will be used to decide whether we should have refinement arrows in
the UI for URL suggestions (on both Android, which has them, and iOS,
which currently doesn't).

Bug: 679083
Change-Id: I71ee24d703789fbd6631de9568793e04150e5160
Reviewed-on: https://chromium-review.googlesource.com/563882Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485369}

Remove the NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES define and the Mac
OS specific code guarded by it as it is no longer used.

Bug: 740391
Change-Id: If7320d4bf9ec359fb437df644440d4df0e3e3318
Reviewed-on: https://chromium-review.googlesource.com/565464Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485368}

Timing out intermittently on all platforms.

TBR=hbos@chromium.org

Bug: 740650
Change-Id: I829498a29894f74ae211512b427a848ed5add787
Reviewed-on: https://chromium-review.googlesource.com/565222Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485367}

BUG=737946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2966923003
Cr-Commit-Position: refs/heads/master@{#485366}

This looks like transient error.

Bug: 693810
Test: Run bot 10 times and checked output log,
      ShelfAppBrowserTest.ActivationStateCheck never failed or retried.

Change-Id: I8bc7edf66d4c07d316bd50b4d8a35730a023a855
Reviewed-on: https://chromium-review.googlesource.com/549615Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#485365}

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

This also removes the "chromeos touch" option, which was added
in https://codereview.chromium.org/7104002/, but is no longer
needed.

BUG=738178

Review-Url: https://codereview.chromium.org/2967443004
Cr-Commit-Position: refs/heads/master@{#485364}

etiennep (me) is not a chromium committer and should be an owner.

Bug: 729154
Change-Id: I096b621ae8245cf257cd6abde713eb5ffea6bcbe
Reviewed-on: https://chromium-review.googlesource.com/559972Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485363}

An upcoming version of clang removes the ability to suppress
availability warnings by redeclaring functions. The new way
to suppress warnings is to either annotate the caller with an
availability attribute or enclose the function reference in an "if
(@available)" block.

The constant NSFullSizeContentViewWindowMask is only available in
10.10 onwards, so only mask it in from that version onwards.

Bug: 735328
Change-Id: I89c08e31ef887dffc6634a6e7def52b243232cf1
Reviewed-on: https://chromium-review.googlesource.com/564342Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485362}

Previous attempts to enable cross process frames on Android have caused
changes in memory usage on Android Webview tests, resulting in them
being reverted. This might be because the flag changed the behavior of
--single-process, which is no longer the case since r485292 landed.

The regressed benchmark was memory.top_10_mobile under Android Webview
tests. We expect that the problem is now fixed and we can land this
without causing regressions, but this is still a speculative attempt.

BUG=690229, 737264

Review-Url: https://codereview.chromium.org/2965523002
Cr-Commit-Position: refs/heads/master@{#485361}

Revert of [ios showcase] Integrated TextBadgeView with Showcase. (patchset #4 id:80001 of https://codereview.chromium.org/2967113003/ )

Reason for revert:
This CL breaks ios_showcase_egtests suite. PTAL at the failure here: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/29530

and fix:
- SCToolbarTestCase/testRotationSizeClassChange
-
 SCToolbarTestCase/testVerifyToolbarButtonsLabelAndAction

then re-land.

Original issue's description:
> [ios showcase] Integrated TextBadgeView with Showcase.
>
> This CL adds TextBadgeView to iOS Showcase. This involves adding a
> text_badge_view folder to showcase, creating a glue view controller,
> and modifying the Showcase configuration file and BUILD.gn files as
> necessary.
>
> Since TextBadgeView is currently a stub implementation, Showcase
> displays a blank white screen.
>
> BUG=740133.
>
> Review-Url: https://codereview.chromium.org/2967113003
> Cr-Commit-Position: refs/heads/master@{#485302}
> Committed: https://chromium.googlesource.com/chromium/src/+/ac8a93564a2560a5ec54673246c551e04e11ed02

TBR=edchin@chromium.org,gchatz@chromium.org,helenlyang@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=740133.

Review-Url: https://codereview.chromium.org/2978533002
Cr-Commit-Position: refs/heads/master@{#485360}

V8 CL that added the use counter here:
https://chromium-review.googlesource.com/c/548987/

Bug: v8:5536
Change-Id: I13ce225e348e35be6977a81dcbcc309cfad6f099
Reviewed-on: https://chromium-review.googlesource.com/560517
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485359}

For each new major OS version, we need to poke at the internals
of CFAllocator to enable the out-of-memory killer for the default
CFAllocator implementations.

This update is for macOS 10.13 ("High Sierra"), whose CFAllocator
internals are unchanged from 10.12 (and in fact from 10.7). It also
updates the base::mac::IsOS*() family of functions for this new OS
version.

BUG=45650
TEST=base_unittests OutOfMemoryDeathTest.CFAllocator*,MacUtilTest.IsOSEllipsis

Change-Id: I700878b1e0baef658b6d7d618cbeb513386a79eb
Reviewed-on: https://chromium-review.googlesource.com/565467Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485358}

BUG=731324
TBR=kainino@chromium.org

Change-Id: I396ba9077c10a55dd966f218c37b0a31c5b9e6d6
Reviewed-on: https://chromium-review.googlesource.com/565065
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485357}

Use atomics to protect access to write_index_.  This can be read from
multiple threads (performing the convolution stages) and also written
by the audio thread when new data needs to be buffered for
convolution.

Ran the test from the bug to verify the race is gone. (The race was
100% reproducible with that test).

BUG=732918
TEST=none

Change-Id: Iefa3cf1e1fc182e714ad4e330287cc83be75c36a
Reviewed-on: https://chromium-review.googlesource.com/546095Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485356}

This metric is no longer needed.

Bug: 738126
Change-Id: If8baa53178238335d75ccefd8d6ae9065b2d00ad
Reviewed-on: https://chromium-review.googlesource.com/563757Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485355}

Use the new thing instead of the old thing.

BUG=667892

Change-Id: Ibc732bb4a4c285279ed6fa27885bb687a451b366
Reviewed-on: https://chromium-review.googlesource.com/560562Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485354}

Currently in guest mode, there are valid routes that are not visible, which leads to odd behavior when directly visiting those routes. This CL aims to prevent those kinds of routes from being added into settings.Route during initialization.

BUG=733511
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2957153003
Cr-Commit-Position: refs/heads/master@{#485353}

The component updater can look into the BITS queue to see if
a job already exist to download a given component. This stat
provides an insight of whether this optimization is useful.

TBR=waffles

Bug: 737730
Change-Id: I56b31ad7b382197970b2dc49e8b42a7620a8e943
Reviewed-on: https://chromium-review.googlesource.com/564178Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485352}