GitLab

During RenderInline::splitFlow(), floats are cleared on an anonymous containingBlock() for
the inline being split. This is a problem if siblings of the block contain references to
the same floats, since the float removal code in markSiblingsWithFloatsForLayout() will not
later find them.

R=inferno@chromium.org
BUG=245727

Review URL: https://codereview.chromium.org/203483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method is a noop as we first collect names of shortcut edges and then iterate through all non-shortcuts whose names are also in the collection.

BUG=None

Review URL: https://codereview.chromium.org/204913005

git-svn-id: svn://svn.chromium.org/blink/trunk@169657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the partial layout code was removed this changed the conditional
for triggering repaintTree from m_doFullRepaint || !partialLayout.isStopping()
to just m_doFullRepaint. This caused repaint to not happen in a lot of cases
because, typically, !paritalLayout.isStopping() was true and would trigger
repaintTree. I don't think we need the check at all and should be
unconditionally triggering repaintTree and using the information from layout to
determine what repaints.

BUG=283623,320139

Review URL: https://codereview.chromium.org/206413003

git-svn-id: svn://svn.chromium.org/blink/trunk@169656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't actually need to rewind iterators. The iterators should be one-pass only and rewind just complicates the code.

BUG=None

Review URL: https://codereview.chromium.org/206393004

git-svn-id: svn://svn.chromium.org/blink/trunk@169654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This extracts everything related to our tabbed editor from the sources panel to the separate SourcesEditor class.
This class could be later refactored into the view that could be embedded in other places (e.g. Drawer).

R=pfeldman, lushnikov

Review URL: https://codereview.chromium.org/206063003

git-svn-id: svn://svn.chromium.org/blink/trunk@169653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/195953003

git-svn-id: svn://svn.chromium.org/blink/trunk@169652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/201123007

git-svn-id: svn://svn.chromium.org/blink/trunk@169651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduced filtered iterator and iterator over array of indexes. This allowed to decompose HeapSnapshotFilteredOrderedIterator.

BUG=None
R=alph@chromium.org

Review URL: https://codereview.chromium.org/205993003

git-svn-id: svn://svn.chromium.org/blink/trunk@169650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding ability to access objects from printed ObjectPropertySections (console, scopes pane and etc.).

BUG=306120
R=pfeldman

Review URL: https://codereview.chromium.org/201613004

git-svn-id: svn://svn.chromium.org/blink/trunk@169649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is to prepare for auto-dispatching baseValueToString in SVG*Element::parseAttribute.
SVGAnimatedLength required {Forbid,Allow}NegativeValues setting to be passed in as an argument of baseValueToString.
This was making auto-dispatch for baseValueToString calls difficult.

This CL removes the SVGLengthNegativeValuesMode argument from |SVGAnimatedLength::baseValueToString()|. The setting is passed in by |SVGAnimatedLength| ctor.

BUG=349370

Review URL: https://codereview.chromium.org/206133005

git-svn-id: svn://svn.chromium.org/blink/trunk@169648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Remove unneeded willReceiveResourceData instrumentation and reuse didReceiveData instead of didReceiveResourceData.

R=eustas@chromium.org, pfeldman@chromium.org, caseq, pfeldman

Review URL: https://codereview.chromium.org/108103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353961
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/206373002

git-svn-id: svn://svn.chromium.org/blink/trunk@169646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Breakage from r168748 which used the wrong time-source.

BUG=231576

Review URL: https://codereview.chromium.org/204673004

git-svn-id: svn://svn.chromium.org/blink/trunk@169645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By doing this, they can be packed together with the existing bit-field
member NodeRareData::m_connectedFrameCount, and save some space.

Impact according to sizeof(ElementRareData), on 64-bit Linux (GCC and
Clang alike,) is a modest 8 byte saving, from 144 bytes to 136 bytes.

BUG=

Review URL: https://codereview.chromium.org/201153006

git-svn-id: svn://svn.chromium.org/blink/trunk@169644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The RequiredThisAnnotationChecker has been merged into FunctionReceiverChecker,
so it can now make use of the knowledge whether a nested function
references |this| or not. As such, the receiver checks now rely
on the fact of the |this| usage rather than the presence of the @this annotation.

R=aandrey@chromium.org, aandrey, sergeyv, vsevik

Review URL: https://codereview.chromium.org/199733011

git-svn-id: svn://svn.chromium.org/blink/trunk@169643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

allocation by user-defined placement new operators.

Removing the placement new operators will lead to redefinition errors
if a class is marked as DISALLOW_ALLOCATION or STACK_ALLOCATED
and at the same time defines placement new operators.

R=oilpan-reviews@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/199733009

git-svn-id: svn://svn.chromium.org/blink/trunk@169642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer have DRT in Blink.

BUG=327256

Review URL: https://codereview.chromium.org/205323004

git-svn-id: svn://svn.chromium.org/blink/trunk@169641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

What we expect this case is just stability so output string itself is not related to test input.

BUG=

Review URL: https://codereview.chromium.org/206193003

git-svn-id: svn://svn.chromium.org/blink/trunk@169640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is exact copy of r169554 with a fix for inpsector protocol tests.

Uin32Array already has subarray method that returns a new view for the same array buffer.

BUG=None
TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/197533009

git-svn-id: svn://svn.chromium.org/blink/trunk@169639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a typedef for WebFrame so we can start converting
references to WebFrame in embedder implementations. It also updates most
references of WebFrame in the embedding API to WebLocalFrame instead.
Most locations should only ever have to handle WebLocalFrames, so it's
just a fairly straightforward rename. However, there are some corner
cases that need to be adjusted more carefully, since things like the
opener, parent frame, and child frames can be pointers to an eventual
WebRemoteFrame class.

BUG=346764

Review URL: https://codereview.chromium.org/191003006

git-svn-id: svn://svn.chromium.org/blink/trunk@169638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It can avoid reading from previous unchanged WebGL layer content during printing.

BUG=351956

Review URL: https://codereview.chromium.org/197213014

git-svn-id: svn://svn.chromium.org/blink/trunk@169637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Refactoring spelling-hasspellingmarker.js to use asynchronous spellchecking.
In addition, adds some bits for non-DumpRenderTree users.

It's based on WebKit changeset: http://trac.webkit.org/changeset/164100

BUG=295722

Review URL: https://codereview.chromium.org/204383002

git-svn-id: svn://svn.chromium.org/blink/trunk@169636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Fix Heap::isConsistentForGC which only checks the heap for one attached thread at this point.

Thanks for noticing this Peter. :)

R=oilpan-reviews@chromium.org, pkasting@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/206113002

git-svn-id: svn://svn.chromium.org/blink/trunk@169635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354146

Review URL: https://codereview.chromium.org/206023003

git-svn-id: svn://svn.chromium.org/blink/trunk@169634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The format looks like this:

  subtag:byte            // The type of key
  keySpecificProperties  // Block of key specific algorithm info
  usages:uint32          // Bitfield of usages + extractability
  keyDataLength:uint32   // Block of data controlled by embedder
  keyData:byte[keyDataLength]

subtag influences how keySpecificProperties is interpreted:

[If subtag=AesKeyTag]
  keyLengthBytes:uint32  // 16, 24, or 32
  algorithmId:uint32

[If subtag=HmacKeyTag]
  keyLengthBytes:uint32
  hashId:uint32

[If subtag=RsaKeyTag]
  algorithmId:uint32
  type:uint32            // One of {PublicKeyType, PrivateKeyType}
  modulusLengthBits:uint32
  publicExponentLength:uint32
  publicExponent:byte[publicExponentLength]

[If subtag=RsaHashedKeyTag]
  <Same as for RsaKeyTag>
  hashId:uint32

Note that uint32 is encoded as a variable length number. In practice it ends up being a single byte for most of the uses above.

In this design, blink is responsible for serializing all of the key's attributes except for the actual key data which is left to the embedder.

The included tests rely on the chromium side of structured clone landing:
  https://codereview.chromium.org/196513002/

The tests cover serialization of hmac, aes and rsa public keys. I haven't added tests for serialization of rsa private keys yet, since that part is not done on the chromium side.

BUG=245025

Review URL: https://codereview.chromium.org/195543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods from View.

R=lushnikov

Review URL: https://codereview.chromium.org/203603006

git-svn-id: svn://svn.chromium.org/blink/trunk@169632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

addEventListener and removeEventListener should require 2 arguments
(per spec), but legacy content calls these with 0 or 1 arguments.

For background, see this bug:
https://code.google.com/p/chromium/issues/detail?id=249598

This results in a special case in the CG, and an IDL that doesn't reflect
reality.

This updates the IDL to reflect reality, and removes the special-casing
from the CG, removing 3 FIXMEs!

There's now only 1 EventTarget FIXME in the templates, namely
the frame security check (on window).

This changes
addEventListener.length
removeEventListener.length
...from 2 to 0, reflecting reality.

R=haraken
BUG=345503
BUG=249598

Review URL: https://codereview.chromium.org/203603005

git-svn-id: svn://svn.chromium.org/blink/trunk@169631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When MediaQueryParser used valuesList.clear(), clear() cleared the list's values, but not the offset of the current read value.
This fixes that.

BUG=353982

Review URL: https://codereview.chromium.org/204333005

git-svn-id: svn://svn.chromium.org/blink/trunk@169630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Testing IDL files no longer need [NoInterfaceObject],
as we now don't feed them into the list of main interface files
('main_interface_idl_files' in generated_bindings.gyp);
previously it was necessary because we didn't distinguish these files.

This removes the extended attribute, simplifying them.

TBR=haraken
BUG=341748

Review URL: https://codereview.chromium.org/205943003

git-svn-id: svn://svn.chromium.org/blink/trunk@169629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test was added at r150718.  https://src.chromium.org/viewvc/blink?revision=150718

Currently It doesn't cause a crash even if we revert the change. It means the test is useless to keep stability.
Additionally the test looks less sophisticated and it is hard to get what it does.

BUG=

Review URL: https://codereview.chromium.org/206073002

git-svn-id: svn://svn.chromium.org/blink/trunk@169628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web Animations API: Fix KeyframeEffectModel::PropertySpecificKeyframeGroup::addSyntheticKeyframeIfRequired

Synthetic Keyframes:
For each property declared in a KeyframeEffectModel, addSyntheticKeyframeIfRequired adds
a property specific keyframe at offset: 0 if none exists. Similarly, it adds a keyframe
at offset: 1 if required.

The synthetic keyframes have compositeOperation add, and a neutral value for the property.

Partial Keyframes:
Previously, if an animation was constructed with a partial keyframe (a keyframe list with no 
keyframe at offset zero or no keyframe at offset one for any of the properties it declares) 
the renderer would crash. 

This change detects partial keyframes and throws a NotSupportedError in the JavaScript.

Review URL: https://codereview.chromium.org/203463009

git-svn-id: svn://svn.chromium.org/blink/trunk@169626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169605

BUG=354165
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/196243008

git-svn-id: svn://svn.chromium.org/blink/trunk@169625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hopefully the last in a line of compositing sub-pixel
patches. This correctly pixel snaps the clipping layer
used by composited layers with overflow: clip and
accumulates it into their children.

BUG=347521

Review URL: https://codereview.chromium.org/205213006

git-svn-id: svn://svn.chromium.org/blink/trunk@169624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347902

Review URL: https://codereview.chromium.org/205853002

git-svn-id: svn://svn.chromium.org/blink/trunk@169623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are ThreadSafeRefCounted because an object is created in a context thread,
is enqueued into a SQLTransactionBackend, the SQLTransactionBackend is moved to
a database thread, then the database thread takes a SQLStatementBackend in the
queue.
We don't need to care about it in Oilpan. SQLTransactionBackend is correctly
transferred with CrossThreadPersistent.

BUG=347902

Review URL: https://codereview.chromium.org/205823002

git-svn-id: svn://svn.chromium.org/blink/trunk@169622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new Traversal<*Element> API in svg code for clarity. It results in shorter /
simpler code. It also makes it clearer what type of Element we are actually
interested in.

R=
BUG=346733

Review URL: https://codereview.chromium.org/205983004

git-svn-id: svn://svn.chromium.org/blink/trunk@169621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to check TimelinePresentationRecord.expandable(), but it was accidrently replaced
with hasPresentationChildren(), which is not the same now, since we keep hidden records
in the presentation model.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/201823003

git-svn-id: svn://svn.chromium.org/blink/trunk@169620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes our usage of the pseudo style cache so that we will
use a cached pseudo style when creating pseudo-elements if possible
and so that we cache pseudo styles even if they don't get a renderer.
We also move the logic for having styles with animations or transitions
be non-sharable from RenderStyle::isSharable to the StyleAdjuster, so
that animated pseudo-elements will have their parent's style correctly
marked as non-sharable.

As a result, a pseudo-element without a renderer (e.g. display:none
or content:none) to will correctly return its computed style to
getComputedStyle. This also fixes a regression where the pseudo style
cache can end up very large when its parent style is shared.

BUG=345653

Review URL: https://codereview.chromium.org/196143004

git-svn-id: svn://svn.chromium.org/blink/trunk@169619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of HTML Imports: Send credentials for same origin requests (https://codereview.chromium.org/196043002/)

Reason for revert:
The following tests crash on all debug bots.
- fast/shapes/shape-inside/shape-inside-image-set.html
- fast/shapes/shape-outside-floats/shape-outside-image-set.html


Original issue's description:
> HTML Imports: Send credentials for same origin requests
> 
> This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
> The essential part of the change is in HTMLImportsController.cpp.
> Anything else is to make it work with redirect.
> 
> The problem here is that allowCredentials flag is held both
> by ResourceLoaderOptions and ResourceRequest and these two
> can go out-of-sync. This change tries to make them in sync.
> 
> Such a state duplication should be resolved eventually, but
> that is another story.
> 
> BUG=348671
> TEST=import-cors-credentials.html
> R=dglazkov@chromium.org, japhet@chromium.org, abarth
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169496
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169578

TBR=abarth@chromium.org,dglazkov@chromium.org,japhet@chromium.org,morrita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348671

Review URL: https://codereview.chromium.org/199733008

git-svn-id: svn://svn.chromium.org/blink/trunk@169618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this page,while saving the page if images with load error/decode error are saved,
while rendering the mhtml page the broken images are shown in place of those images.

BUG=346254
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/177243005

git-svn-id: svn://svn.chromium.org/blink/trunk@169616 bbb929c8-8fbe-4397-9dbb-9b2b20218538