- 30 Mar, 2020 40 commits
-
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I3c76b0bc60dba08dd87a9fe3ab25c0cf37f679f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126567 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#754490}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ccd8de267fe..3fffd0d4592e git log 0ccd8de267fe..3fffd0d4592e --date=short --first-parent --format='%ad %ae %s' 2020-03-30 tvanderlippe@chromium.org Remove unused global references from ui-legacy.js 2020-03-30 tvanderlippe@chromium.org Use built-in Map instead of object map Created with: gclient setdep -r src/third_party/devtools-frontend/src@3fffd0d4592e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16dd1528b4e69badc502935c5bad95a8a5c0ccf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754489}
-
Timothy Gu authored
This addresses a follow-up to 15c60c50. Fixed: 1061139 Change-Id: Icf29c63041d5ab54be4f3a545e6835fe535acbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114584 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754488}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Iaff5e19ffc5e1e89064a98ff581c16b7e3924ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124713 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#754487}
-
Etienne Pierre-Doray authored
This reverts commit 665132b2. Reason for revert: Causes Jobs tests (e.g. StaleConcurrency) to flakily timeout. Original change's description: > [Jobs]: Boost WaitForConcurrencyIncreaseUpdate timeout to 30sec. > > To avoid flaky failures with slow running tests. > > Bug: 1046343 > Change-Id: Iafb6d15c08fb8c97eaa36d802cee5f993eceacd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107602 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751380} TBR=gab@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046343, 1064953 Change-Id: I6d9e3bbede1c85098ec2bdbca3f25b48a2909e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124527Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#754486}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d19513f3ffbb..7bd282acce65 git log d19513f3ffbb..7bd282acce65 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 phoglund@webrtc.org Remove phoglund as root owner. 2020-03-30 sprang@webrtc.org Fixes issue where dynamic pacer could pace audio. 2020-03-30 olka@webrtc.org Revert "Add interface_id to rtc::Network" 2020-03-30 sprang@webrtc.org Add ability to disable padding prioritization. 2020-03-30 mbonadei@webrtc.org Fix -Wunreacheable-code on Mac. 2020-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 40e53740..dfa4a7a6 (754268:754373) 2020-03-29 mbonadei@webrtc.org Fix msvc bots build. 2020-03-29 kron@webrtc.org Reland "Distinguish between send and receive codecs" 2020-03-28 mbonadei@webrtc.org Revert "Trigger CI bots." 2020-03-28 mbonadei@webrtc.org Add more missing targets to gn_isolate_map.pyl. 2020-03-28 mbonadei@webrtc.org Trigger CI bots. 2020-03-28 mbonadei@webrtc.org Add missing xctest targets to gn_isolate_map.pyl. 2020-03-28 phoglund@webrtc.org Remove the histogram flag and all Chart JSON code. 2020-03-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c9f47595..40e53740 (754134:754268) 2020-03-28 deadbeef@webrtc.org Enforce "comprehension-required" STUN rules. 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7e5c10d3..c9f47595 (753978:754134) 2020-03-27 phoglund@webrtc.org Don't double import protobuf code. 2020-03-27 natim@webrtc.org Audio egress implementation for initial voip api in api/voip. 2020-03-27 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 3 2020-03-27 phoglund@webrtc.org Reland "Flip histograms to true by default, fix unit in isac_fix_test." 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1ca2dc5c..7e5c10d3 (753877:753978) 2020-03-27 phoglund@webrtc.org Add PYTHONPATH entry for proto internal. 2020-03-27 phoglund@webrtc.org Reland: Add in missing protobuf code. 2020-03-27 jonaso@webrtc.org Implement Connection::ForgetLearnedState() 2020-03-27 phoglund@webrtc.org Revert "Add in missing protobuf code." 2020-03-27 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 2 2020-03-27 phoglund@webrtc.org Revert "Flip histograms to true by default, fix unit in isac_fix_test." 2020-03-27 phoglund@webrtc.org Add in missing protobuf code. 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d4ff360..1ca2dc5c (753737:753877) 2020-03-26 phoglund@webrtc.org Use = in flags from flags_compatibility.py. 2020-03-26 crodbro@webrtc.org Allow setting a bandwidth cap for relayed connections. 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 43d15e14..2d4ff360 (753631:753737) 2020-03-26 phoglund@webrtc.org Partial revert of flag simplification. 2020-03-26 phoglund@webrtc.org Flip histograms to true by default, fix unit in isac_fix_test. 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c145d480..43d15e14 (752799:753631) 2020-03-26 danilchap@webrtc.org in RtpExtension constructors pass strings by string_view rather than by value 2020-03-26 phoglund@webrtc.org Fix low bw test. 2020-03-26 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 1 2020-03-26 sprang@webrtc.org Make BitrateProber::IsProbing() inline. 2020-03-26 phoglund@webrtc.org Add debug info to low bw test. 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision c145d480..73b2f9fe (752799:753151)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 73b2f9fe..83822ea8 (753151:753288)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 83822ea8..57d80a05 (753288:753397)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 57d80a05..e8ae36de (753397:753511)" 2020-03-26 crodbro@webrtc.org Handle extended route information in TransportFeedbackAdapter. 2020-03-26 phoglund@webrtc.org Reland "Switch low bw audio test to histograms." 2020-03-26 phoglund@webrtc.org Revert "Switch low bw audio test to histograms." 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 57d80a05..e8ae36de (753397:753511) 2020-03-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 83822ea8..57d80a05 (753288:753397) 2020-03-25 alito@webrtc.org Implement AudioEncoder::GetFrameLengthRange() for all audio encoders. 2020-03-25 agrieve@google.com Chromium refactor: Replace "resources_dirs" with "sources" 2020-03-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 73b2f9fe..83822ea8 (753151:753288) 2020-03-25 saza@webrtc.org Remove unused dependency on APM in audio mixer 2020-03-25 mbonadei@webrtc.org Compile ADM pulse code by default. 2020-03-25 mbonadei@webrtc.org Prefix ALSA and PULSE macros with WEBRTC_. 2020-03-25 phoglund@webrtc.org Switch low bw audio test to histograms. 2020-03-25 danilchap@webrtc.org Make all RtpExtension uris constexpr rather than just const 2020-03-25 jonaso@webrtc.org Add interface_id to rtc::Network Created with: gclient setdep -r src/third_party/webrtc@7bd282acce65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024965,chromium:1029452,chromium:1029737,chromium:1051927,chromium:1062263 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I38ea675897c3f1725a965d1a17aa4f6e88d1c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754485}
-
Colin Blundell authored
This CL adds integration tests of launching an external intent from a link to WebLayer. The tests exercise both launching the intent in the same tab and launching the intent in a new tab. To enable these tests, this CL adds some infrastructure: - InstrumentationActivity now has basic support for multiple tabs. - InstrumentationActivityTestRule's returning of the display URL was changed to return that of the URL view in InstrumentationActivity. The previous logic (returning the URL of the current navigation entry in the active Tab) does not account for the case where there are no committed entries in the Tab but there is a pending entry (a case being tested in this CL). Bug: 1031465 Change-Id: I6261bd063e9a73ef0f274c8a311021a286c204ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127088Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#754484}
-
Richard Knoll authored
Sender and receiver flows of a WebRTC transfer for Sharing messages have different characteristics. This splits the metrics between them so we can better understand the histograms. Bug: 1048630 Change-Id: I72d1a64c60afce3acfd370754758576003ead76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117754 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#754483}
-
Bo Liu authored
This reverts and rewrites r654240. The old implementation caused issues in focus / layouts. This implementation simply avoids sending size down on entering fullscreen since the newly created FullScreenView is guaranteed to be 0x0. Generally FullScreenView is resized directly to its final size, so there is need for more complex workarounds. Bug: 1061837, 1065173 Change-Id: Id182d28b4731f6a3bc097076804e7305b4d8f951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124948Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754482}
-
Dominique Fauteux-Chapleau authored
TBR=boliu@chromium.org Bug: 1065585 Change-Id: Id912c8c6abc3681f58a2e5b4f52e1349e3321b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127426Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754481}
-
Yi Gu authored
The flaky tests are not related to worklet animations because it's the reference file that is not painted correctly. Mac scrollbars have their own painting path and they paint greedily. There might be a race condition on the order of painting that caused the scrollbar being completely black. Bug: 946534 Change-Id: I5e2fab05e7a5ee5ec09dcab2a03606ca5ce1fd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124296 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#754480}
-
Maksim Sisov authored
The SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior should only test SoftwareOutputDevice and it doesn't matter if ozone platforms support that or not. Thus, add a test impl of ozone canvas so that we don't have to check what platform the test is run on and we don't have to expose the platform's name. Change-Id: I3263a0267580df125c0b6ea8348cad6ef3a0461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124374Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#754479}
-
Marc Treib authored
This updates MultiStorePasswordSaveManager to call ComputePendingCredentialsState twice; once for the credentials from each store. MultiStorePasswordSaveManager then decides based on the two results which action(s) to take in each store. Bug: 1012203 Change-Id: I0084c4c1a54e0df9da125904fa1d834a61115725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120497 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#754478}
-
Torne (Richard Coles) authored
Downstream can now set `define_upstream_webview_targets` to cause the upstream version of the WebView targets to always be defined, even when `public_android_sdk` is false. To make the target continue to have the same dependencies as when it was defined downstream, depend on the downstream code required to support the R SDK if the build is targeting R and the SDK is not yet public. Bug: 760187 Change-Id: Iadb62e4da95f8760e420bc264c780d27ba70d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125068 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754477}
-
Ewann authored
This CL moves privacy related files in a common folder. Bug: 1064961 Change-Id: I3ebae63794c64951790ad1eb8ebb115da5b60a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121262Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#754476}
-
Denis Kuznetsov authored
Change-Id: Id5ba62b0f42faa2847cfcd0db39534b4c236d12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127086Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754475}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I847353814c1082a3badb60a162a912355f8fcf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754474}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5269c313..056e6aee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia8d16d06ee210ffb5f9041695bbe899dfd2532e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127347Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754473}
-
Dave Tapuska authored
full-screen-iframe-not-allowed.html isn't required anymore there are sufficient WPT tests to cover this. Also why it was failing is that Chromium allows fullscreen for the same origin. Adjusted video-controls-fullscreen-iframe-not-allowed to ensure fullscreen is disallowed for the same origin frame. BUG=718155 Change-Id: I3576467606cd5f9621ba4ca7f94259a79e69a967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118756Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#754472}
-
Alex Ilin authored
This histogram will be useful for the upcoming browser consent flow experiment. Fixed: 1063927 Change-Id: Ic861cefd048ab35fdb8a44d17d7b52a524ae2f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127208 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754471}
-
Dominique Fauteux-Chapleau authored
This reverts commit a7b569e6. Reason for revert: Closed the tree Original change's description: > Enable -Wunreachable-code in iOS builds (except for internal builds). > > This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes > in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. > earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, > says: > > This macro should be used when the configuration for which the > test should be disabled can only be determined at runtime. > Disabling at compile-time is always preferred. > > So this matches the official guidance, and there are many > egtests that use DISABLED_ already. > > Bug: 346399 > Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754468} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: Ib0ccce331d5063a2f22ed9c25ebdf40bf3bd19d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127487Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754470}
-
Mark Cogan authored
When the BVC owned the CommandDispatcher instance, it made sense for it to be responsible for setting up application-layer dispatch. Now that Browser owns the command dispatcher instances, it's possible to remove this responsibility from the tab-scoped objects (BVC and BVCoordinator). This CL instead has the BrowserViewWrangler set up dispatch to the application and browsing data removing objects; sine this is where these objects are injected into the tab-scoped object graph, this removes two layers of object forwarding. (In the near future, when SceneController and BVWrangler are unified and cleaned up, another layer of object passing will disappear). Change-Id: I37747e349aed98501d133310ae50662aab2577df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124381 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754469}
-
Nico Weber authored
This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, says: This macro should be used when the configuration for which the test should be disabled can only be determined at runtime. Disabling at compile-time is always preferred. So this matches the official guidance, and there are many egtests that use DISABLED_ already. Bug: 346399 Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#754468}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be1957b9b903..8df96b104065 Created with: gclient setdep -r src-internal@8df96b104065 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9e3a044413d9a5c973629489ff2940bbfb361426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754467}
-
Samuel Huang authored
To accommodate .aab files and TriChrome, we'd like SuperSize to handle multiple "containers" and store data in a single .size file. This CL performs refactoring archive.py to prepare for extending SuperSize for multiple containers. Details: * Move temp-file extraction logic with |args.minimal_apks_file| depper, into _DeduceMainPaths(). * Remove |args.extracted_minimal_apk_path|. * CreateSizeInfo(): * Change params to take lists of {metadata, section_sizes, raw_symbols}. * Implementation TODO; keep old behavior by simply using the first element of the above. * _DeduceMainPaths(): * Change to a generator that yield multiple param sets, one for each container. * Resolve |apk_prefix| and |apk_path| as separate concepts. * Move most of the logic to _Inner() function. * Split out _DeduceAuxPaths(). * Run(): * Merge with _RunInternal(). * Main action changes: * Visits param sets generated from _DeduceMainPaths(). * Potentially create multiple {metadata, section_sizes, raw_symbols}, now stored into |*_list| variables. Bug: 900259, 1040645 Change-Id: Ib158f3d5c8b11567f09826fd0c0b31729f4e065c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125388Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#754466}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/47e3be4efd27..50a47bd99229 git log 47e3be4efd27..50a47bd99229 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 55f01953d6e9..9a0f2d99fd5d (4 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 02e15b249b12..1c29477aa06e (19 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src cc481ef27631..b0c27ce32864 (2 commits) Created with: gclient setdep -r src/third_party/angle@50a47bd99229 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7030f1176bc428a313c07aaababa6310f381b883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754465}
-
Peng Huang authored
Tested with swiftshader on Windows 10. Bug: 1065499,963988 Change-Id: Ibce9fbca12332aec8fbc98ed838dfcc9d457ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125302Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754464}
-
Viktor Semeniuk authored
This change adds Show/Hide password functionality to the compromised credentials list menu. Bug: 1061054 Change-Id: I4823aa4edf6f9690f2e17d977123d82b75c245d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116178 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#754463}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/81431f5034b4..29d712f9de99 git log 81431f5034b4..29d712f9de99 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 natlee@microsoft.com D3D12 Immediately release pending commands Created with: gclient setdep -r src/third_party/dawn@29d712f9de99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iee0a2812545c1d55bcced7d116670107d7750d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754462}
-
Robert Sesek authored
This is a reland of 0bd64fcf Original change's description: > Move custom tabs off notSecureIsIntentChromeOrFirstParty() > > Instead, use the CCT session token to determine the connected client > package and verify using that instead. > > Bug: 832124 > Change-Id: I96f9c6831f7dcbf801e3ee48d59904a4788d97b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1324910 > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754033} Tbr: peconn@chromium.org Bug: 832124 Change-Id: I6c9c765e9b055dc660fe2ac653e0e86530359e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127246 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#754461}
-
Fan Yang authored
R=bnc@chromium.org Change-Id: I545916f7602955dae6b9200ee0c3a7f37f76b518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125070Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754460}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5a40bf3491e..0ccd8de267fe git log e5a40bf3491e..0ccd8de267fe --date=short --first-parent --format='%ad %ae %s' 2020-03-30 tvanderlippe@chromium.org Fix logging of page errors in e2e-test Created with: gclient setdep -r src/third_party/devtools-frontend/src@0ccd8de267fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87f9f14dc2f6feec00e80e593e38edbbd61a3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754459}
-
Tim Schumann authored
On ChromeOS and Linux non-dbg builders. BUG:1065399 TBR=rdevlin.cronin@chromium.org Change-Id: I8537c16f154489e1137da612251edf3e9193a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124316 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#754458}
-
Anders Hartvoll Ruud authored
There is currently a bug where font-relative units in the base style are not responsive to font-affecting animations (even with issue 437689 fixed) _if_ the element hits the MatchedPropertiesCache. This can easily happen if two identical elements (with the same MatchResult) undergo the same CSS animation. The reason this bug exists is in StyleResolver:: CascadeAndApplyMatchedProperties. Notice that, when cache_success.IsFullCacheHit() is true in that function, we return immediately, and never Analyze the MatchResult. In other words, the MatchResult is _there_, fully populated (we're using it as the cache key after all), but we never let the StyleCascade actually Analyze it, which is the source of the bug. When we later apply animations (see StyleResolver::ApplyAnimatedStandardProperties), we Analyze the animations/transitions _only_. This was done on purpose, as too much Analyzing is expensive. Hence, during ApplyAnimatedStandardProperties, I assumed that either: - We would hit the base computed style optimization, and hence the MatchResult would be empty, and there is no need to analyze it, or - We would not hit the base computed style optimization, and the MatchResult object would be populated and Analyzed already. But of course, I forgot about the third option: based computed style optimization miss, but a hit on the matched properties cache. In that case the we have a non-empty MatchResult that haven't been Analyzed. To fix this, we could have simply Analyzed the MatchResult in ApplyAnimatedStandardProperties (potentially a second time). But this is inefficient. I don't want to do that. Instead, this CL moves the MatchResult ownership (and CascadeInterpolation ownership) to StyleCascade itself. It also adds flags which tells us what needs to be analyzed. Using this, we can now analyze-on-demand during Apply, which means we analyze exactly the amount we need to analyze, also in the case where an animation frame hits the MatchedProperties cache. It also makes for a far more sensible (but still not perfect) StyleCascade API, compared to "manually" analyzing. Note that this CL also removes filtering Analyze-time. This means that e.g. for ::marker, we add declarations to the CascadeMap that we know aren't going to be applied (as they are filtered in the Apply step). This is because analyze-on-demand is not easily compatible with this kind of filtering. For example, when dealing with inherited-only cache hits, we first try to apply the inherited properties only. If the font or zoom was modified, we need to apply the non-inherited properties after all. And for that second apply pass, we obviously need all properties to have been analyzed before, not just the inherited properties. Bug: 1065387, 437689 Change-Id: I7e9b7f33fc12f055603e789d3ae700d5a7a3dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124649Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#754457}
-
Roman Sorokin authored
Moved DemoSetup* and EnableDebugging* tests to OobeBaseTest Bug: 987587 Change-Id: I1b0860861720d1cbd77be9e2c007c74a7e2f8801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124608Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754456}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a7a5ec8. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 6719ca2d "[AspectRatio] Add parsing support for aspect-ratio: X / Y" 9e853511 "Remove broken icon rendering for loading="lazy" images while loading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I961486f981badaf81b16b758cdfd0e103b0eeba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125666Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754455}
-
Raul Tambre authored
std::auto_ptr is deprecated since C++11 and removed in C++17. Fortunately the strange behaviour of std::auto_ptr isn't used here and we can simply replace it with std::unique_ptr. ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(502,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> buffer(new wchar_t[length]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(543,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> sanitized_url(new wchar_t[url.length() * 3 + 1]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(616,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> browser_path(new wchar_t[length]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(635,10): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> expanded_path(new wchar_t[expanded_size + 2]); ~~~~~^ Bug: 752720 Change-Id: I040bd8412aebebeadfd70008930fbe457f9b8b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124568 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#754454}
-
Finnur Thorarinsson authored
By default, the test will wait for 3 seconds to create the decoder process, which (at least in the emulators) brushes up against the actual time it takes to create the process, so these tests are frequently flaky when run locally. Bug: 656015 Change-Id: Ib8a4ea139d0c79eb41595811c000b6cf54574bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124377 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#754453}
-
Michael Ershov authored
TBR=tiborg@chromium.org,ajgo@chromium.org Bug: 1065812 Change-Id: Ia597186e7488eaf18913ebc1fcdeb8937e13df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124838Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#754452}
-
Raul Tambre authored
A missing noexcept specifier is an error when compiling in C++17 mode. STDMETHOD adds one, but we're missing it in the implementation. ../../chrome/browser/browser_switcher/bho/bho.cc(41,35): error: 'SetSite' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmicrosoft-exception-spec] STDMETHODIMP CBrowserSwitcherBHO::SetSite(IUnknown* site) { ^ ../..\chrome/browser/browser_switcher/bho/bho.h(53,13): note: previous declaration is here STDMETHOD(SetSite)(IUnknown* site); ^ Bug: 752720 Change-Id: I1cfe0c27a9caeb6b450c752a721a7532d872567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124709 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#754451}
-