- 28 Jan, 2020 40 commits
-
-
Wez authored
The waitWithTimeout calls are unnecessary now that browser tests always run with a default RunLoop timeout configured. Bug: 1021777 Change-Id: Icc5eab59b739a9b5c00d9c7820b75d5b092e1c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020762 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736029}
-
Bo Liu authored
Bug: 1042063 Change-Id: I8b61a7ccdbf50703115a0e6b971a02623771756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019603Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736028}
-
Yi Gu authored
The test is flaky on Win and Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BEdW1wQWNjZXNzaWJpbGl0eVRyZWVUZXN0LkRpc3BsYXlMb2NraW5nQWxsDA TBR=rakina@chromium.org Bug: 1043480 Change-Id: Ibaf32c82c5f823717a587c8377aa9484a2b8b803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023480Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736027}
-
Alexei Svitkine authored
This reverts commit 1547c775. Reason for revert: Causes "No module named fieldtrial_util" error when running "git cl try". Original change's description: > Set limit for field trial parameters length. > > Windows has a limit of 32767 on a command line. When testing with field > trails, the command to launch chrome.exe may exceed the limit if there're > too many field trial configs passed as parameters. This was causing > the chrome perf waterfall to completely fail on Windows. > > This CL added a presubmit check to see whether the configs under Windows > will exceed the limit of 31000. > > Bug: chromium:1045530 > Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468 > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735981} TBR=asvitkine@chromium.org,crouleau@chromium.org,wenbinzhang@google.com Change-Id: I42f928aa6bc87b1f5696f8bda50d6d307d53ff7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1045530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025830Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736026}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36331312..0a0715c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60c7023501fe5d2a67414b034172528a283b65dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025228Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736025}
-
Robert Ogden authored
This service is a BrowserContextService which owns the proxy configurator, but more singletons will be added to it over the course of development. Bug: 1023483 Change-Id: I4731a742158133ea304c53e2b54c15063f69302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020885 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736024}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Id47c3c92df05cbff973e86553c63e0af9bd58400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025588Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#736023}
-
Martin Kreichgauer authored
When toggling "Allow apps to control device radios" off in Windows privacy settings, calls to Radio.RequestAccessAsync() seem to always fail with DeniedByUser. The API docs state that the RequestAccess call triggers a permission UI, but that is not the case (perhaps that only works for UWP apps). When in this state, an applciation is unable to control Radio power via SetStateAsync(), but the Radio is otherwise fully usable. BluetoothAdapterWinRt previously early-exited its initialization routines whenever RequestAccessAsync() returned anything other than Allowed. The resulting instance would have a nullptr |radio_| member. Consequently, it would always return false for IsPowered() (but true for IsInitialized() and IsPresent()). Instead, continue initialization even when RequestAccessAsync() fails. Also change CanPower() to consider the RequestAccessAsync() return value. This fixes a WebAuthn bug, where caBLE requests on a device in this state would show a UI telling the user to power on their BLE adapter, even if it was already powered on. Also make BluetoothTestWinrt inject a FakeRadioStaticsWinrt. It was previously using the real implementation. Bug: 1043410, 1006688 Change-Id: I50946ec0c3be12331ac286d6728b2ce58fd0c6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015444 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736022}
-
Mark Yacoub authored
If the device supports atomic APIs, use drmModeAtomicCommit to modeset and disable instead of drmModeSetCrtc. Abstracted Modeset and Disabled code to HDPM to handle both atomic and legacy call. Updated tests to support Connector and CRTC props. BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, HardwareDisplayPlaneManagerLegacyTest.Modeset, HardwareDisplayPlaneManagerLegacyTest.DisableModeset, HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on Nautilus(Intel), Grunt(AMD) and Cave(Legacy). Change-Id: Ic6d3873c94cb657fbe8de6dcd0faf97aeea05bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020809Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#736021}
-
Yulun Wu authored
Bug: 1034168 Change-Id: I1551a4cbf59669c514f46e17919fe7e91bc7bbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020561 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#736020}
-
Thomas Tellier authored
Bug: 1010254, 1010258 Change-Id: If4ec84dd21391b5eb2211d9eea955a7d05f6c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005989 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736019}
-
Chan Li authored
TBR=yigu@chromium.org Bug: 1046440 Change-Id: Iaca3b5b330162e4c2c194a354cddfaea8bc0bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024496Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736018}
-
Gauthier Ambard authored
This CL enforces the assumption that the tests are running in portrait by forcing the orientation to portrait in the setup of the test. Individual test can still override this setting if they want. Bug: 1046339, 1045966, 1046096, 1046253, 1046258 Change-Id: I1a7ec04e06efaee1d558f038b2d333673330a80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023891Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736017}
-
Gabriel Charette authored
TBR=fdoray@chromium.org (TBR for side-effects of mechanical change) Bug: 1026641 Change-Id: Ic0805fa52bd28aa93780749842f094e92a3e2ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994069 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736016}
-
Jérôme Lebel authored
bzanotti no longer works in Chrome sign-in team. Change-Id: I6c6b2e73599c5cc4340d2283059db9b3d2909ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024892 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736015}
-
behdad authored
Unittests are added to test the functionalities of representative perf test scripts. Bug: chromium:1029952 Change-Id: Ie3ab5d1a976d9511fbde6a401fc544ead3e50091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017163 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#736014}
-
Daniel Libby authored
This CL implements percent-based scrolling for Windows. This makes mousewheel initiated scrolls be interpreted as a percentage of the size of the intended scroller, instead of being translated directly into pixels. This is done as a part of the effort to port Edge-style scrolling into Chromium. The deltas reported by the wheel event are unchanged in order to maximize compatibility with the web. Bug: 1009735 Change-Id: I4987cb6916fe5961cdb479018ccd7a464d574ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776898 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736013}
-
Mingjing Zhang authored
Histogram History.DomainCountQueryTime is now emitted with SCOPED_UMA_HISTOGRAM_TIMER instead of an explicitly maintained timer; Typos and other minor nits in HistoryService unittests are also fixed. Change-Id: Idbd3ff3fb676a00ae21db1ef126d67afe947a161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023233 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736012}
-
Sylvain Defresne authored
Change remoting code to only link with MaterialComponents.framework if the code is compiled as a framework (this will allow removing the fake targets that exists in ios/third_party/material_components_ios/BUILD.gn). If using MaterialComponents.framework, then bundle it with the app. This is a reland of https://crrev.com/c/2020960 with a fix for the compilation of ios_remoting_unittests when building a framework for MaterialComponents (which is the default on the internal builder and why the original CL was reverted). Bug: 1040871 Change-Id: I77bb04480bc6b7b1a01133a795f73bc5860b7686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023888Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736011}
-
Daniel Murphy authored
IndexedDB doesn't need to know the file path for V8 File objects, as these work just fine being hooked up to a mojo blob handle. This CL removes all usages of external file paths in IndexedDB, and removes them from even being serialized from the renderer. Bug: 1036415 Change-Id: I6e074c5fe11654faaf2afb56d8fe290ded4f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978848 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736010}
-
Matt Menke authored
The DNS cache is now a per-NetworkContext cache, instead of a global, so clearing the cache when closing incognito is no longer useful - destroying the incognito profile will destroy its own DNS cache. This CL also updates the network::mojom::HostResolver API to allow stale DNS lookups. I'm adding a lot of tests for DNS cache isolation, and this option is needed to avoid tests racily failing due to DNS cache eviction, particularly on slower bots. This option was already supported by the HostResolver; it just wasn't being exposed outside the network service. Bug: 1042354 Change-Id: I8cd4332f6d28b5cc783b256550f720807cfb9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023507Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736009}
-
Gavin Williams authored
-Add a property to cr-searchable-dropdown so we can track whether the user's current text input in the dropdown matches the previously saved value. This flag will be used to disable certain user actions if the dropdown is invalid. Bug: 950887 Change-Id: I578086632568dc0e76ec8bb2726dd002158392dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016334Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#736008}
-
Toni Barzic authored
If no buttons are shown in the shelf navigation widget, we should hide the widget background, too. BUG=1012814 Change-Id: I6763c6719d256b2b07b74c06948af96074ae4851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025636Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736007}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/260c788d77ca..8c52e8a2efb0 git log 260c788d77ca..8c52e8a2efb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 philipp.hancke@googlemail.com remove mention of prebuilt libraries from docs/ Created with: gclient setdep -r src/third_party/webrtc@8c52e8a2efb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib410cf244d99986c8e1df7aa5a309057ca7d9624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736006}
-
Mike Wittman authored
Removes the underscore suffix from the struct field. TBR=gab@chromium.org Bug: 1034758 Change-Id: If333f144770d35753f5d5418071009e7cd9d7575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024690Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736005}
-
Trevor Perrier authored
This CL makes it so that all locales are used during resource_packaging It looks like previously resource_packaging was only called for apk builds. But now that it is also used for bundle builds the locales for Android bundles should be included as well. Before this change all language splits for the 27 + 9 new languages recently added to Clank were about half the size as older languages in monochrome_public_bundle.apks After this change the new languages and old languages are about the same size in monochrome_public_bundle.apks. Example Before (af,as, az, be, bn, and bs are new languages): 158921 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 226815 2001-01-01 00:00 splits/base-as.apk 165763 2001-01-01 00:00 splits/base-az.apk 203683 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 234710 2001-01-01 00:00 splits/base-bn.apk 163986 2001-01-01 00:00 splits/base-bs.apk Example After: 305787 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 569512 2001-01-01 00:00 splits/base-as.apk 325961 2001-01-01 00:00 splits/base-az.apk 468522 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 577862 2001-01-01 00:00 splits/base-bn.apk 324504 2001-01-01 00:00 splits/base-bs.apk Bug: 1035665 Change-Id: I31d3bddba38148931212e6bccb63155376b82bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024159Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736004}
-
Yi Gu authored
SnapAfterLayout is ready to ship in M81 since blocking bugs are fixed. Bug: 866127 Change-Id: I77447e74547f670ecba11cb56696821e294821e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025321Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736003}
-
Vladislav Kuzkokov authored
Bug: None Change-Id: I101957f747559b074fc6dd6fb58f2b544303501a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025368 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736002}
-
Alexander Hendrich authored
This CL adds the bottom status indicator depending on the OobeDialogState. When the extension UI is visible, the bottom status indicator will be hidden. Bug: 1042944 Change-Id: I572c7c022ae0d58e1618a2e2e7cb9add37b036f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023657Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736001}
-
Theodore Olsauskas-Warren authored
Previously within the GetAllSites handler encapsulation was broken by reaching directly into ContentSettingsType::PERMISSION_AUTOBLOCKER_DATA raw data to determine which sites were under embargo. As part of the privacy settings redesign, additional handlers will be interested in this information. This CL extends the permission_decision_auto_blocker to provide this functionality itself and refactors the GetAllSites handler to use it. Bug: 1032584 Change-Id: I57632a4272896ad98079bede96d660578bf1a179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013118Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#736000}
-
Richard Knoll authored
Extract MockSharingDeviceSource, MockSharingMessageHandler and MockSharingMessageSender as they were implemented 3 times each in our tests already. This makes it easier to refactor these base classes in future. Bug: None Change-Id: I5cbcfebe55c2d41f66c91487039ab066db8b55e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023832Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735999}
-
Moe Ahmadi authored
http://screenshot/d4Noo0ggQW3 http://screenshot/XMXnBaPDYDi Bug: 1041124 Change-Id: I4ede6366fc8f639f14208e4f4cb7fc86ab16f58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017931 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#735998}
-
Li Lin authored
Histogram similar to other clicks (with result type NoResult) recorded to understand user clicks when result is not available: * QuickAnswers.Click (enum="QuickAnswersResultType") * QuickAnswers.Click.Duration - Aggregated duration across result types * QuickAnswers.Click.Duration.NoResult - Duration for each result type The duration logged is: * Clicks before fetch finish: 0ms * Clicks after fetch finish: duration between fetch finish and clicks Bug: 1044413 Test: Manual Change-Id: I30a697775147e9b5d642fbac9e4c5dd2fe0ad3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023989Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735997}
-
Yi Gu authored
The tests external/wpt/pointerevents/* timeout on both Linux and Win: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygwELEgVGbGFrZSJ4Y2hyb21pdW1AYmxpbmtfd2ViX3Rlc3RzQGV4dGVybmFsL3dwdC9wb2ludGVyZXZlbnRzL3BvaW50ZXJldmVudF90b3VjaC1hY3Rpb24taW5oZXJpdF9jaGlsZC1wYW4teC1jaGlsZC1wYW4teF90b3VjaC5odG1sDA Sample report: https://test-results.appspot.com/data/layout_results/linux-rel/294631/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html TBR=nzolghadr@chromium.org Bug: 1044715 Change-Id: If376ddf830465b2a930bbcab91d258b05da890d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025489Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735996}
-
Scott Violet authored
User expectations on Android is that if the browser goes into the background and is killed by the OS, and the user switches back to the app state is restored (Chrome does this now). This is true even of incognito data. To limit the potential of leaking private information when incognito this patch adds encryption of the tab/navigation stack. Chrome on Android does this as well. The key used for encryption is randomly generated and stored by the system. This way, if the system doesn't provide the data (because the system has determined the app shouldn't restore state), WebLayer won't be able to decrypt the data. This means restoring state of incognito data has a different lifetime then non-incognito data, but that is by design. Again, this logic matches that of Chrome on Android. BUG=1033924 TEST=weblayer_support_instrumentation_test_apk BrowserFragmentLifecycleTest.restoresPreviousSession Change-Id: Iaeb721ae942efa1db19ee8366d1cfbf30747cd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018482 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#735995}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 210 histograms that show frequent access in the past 90 days. These are the 88% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-26. Change-Id: I637145347866ae7d4453875f0e842fff9beb0082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025407 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#735994}
-
Aga Wronska authored
App activity data are used for Per-App Time Limits feature. Bug: 1015656 Test: ChildStatusCollectorTest Change-Id: I75f27bf409db7d2a0ef941cad7e8f9a3e97b70eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020530 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735993}
-
Toni Barzic authored
Makes shelf control buttons (home, back, overview) show up regardless of kHideShelfControlsInTabletMode if they're needed for accessibiltiy reasons - i.e. if one of the accessibility features is enabled: * spoken feedback * autoclick * switch access BUG=1012814 Change-Id: I83925d201e8551a694a444a8cbc1f69d71892a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024034 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#735992}
-
Friedrich Horschig authored
By introducing an |Update| method, users of the AutofillClient can push updated suggestions to an open popup. It's currently only supported on Desktop platforms. Two smaller methods support this Update case as well: * AnnounceUpdate which prepares the client that an update is planned and * GetSuggestions which returns a const span over the current suggestions TBR=vasilii@chromium.org TBR Reason: API change for autofill client. Bug: 1043963 Change-Id: I375596684af01acf6e3cfbbeb363b8541baca42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019135Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#735991}
-
bttk authored
Bug: 1046181 Change-Id: Iab825c9fe39eb3f2a62696e18326fb0207139446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019476Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735990}
-