- 23 Jan, 2020 40 commits
-
-
Steve Anton authored
WebRTC is moving the implementation of reference counting into the base class which means classes inheriting from RefCountInterface will no longer be able to define a copy operator. Bug: webrtc:11308 Change-Id: I74570c04b7e9724c4a3a4263ea13f3a56667af80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015981 Auto-Submit: Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734450}
-
Colin Blundell authored
All //chrome-level dependencies have been cleaned in preceding CLs, so the componentization is straightforward. We leave the componentization of the unittest to a followup as it still has //chrome-level dependencies to be cleaned. We also defer putting the files in the captive_portal namespace until all of the related componentizations have been completed to avoid churn on files that are currently in //chrome but will shortly be moved to //components/captive_portal/content. This componentization is necessary as part of the ongoing effort to componentize //chrome's SSLErrorHandler. TBR=jochen@chromium.org Bug: 1030692 Change-Id: I84bd90cd026cd461a349f8e5a95a6b8965837b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011926 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5cddf9e222f6..878a52cac350 Created with: gclient setdep -r src-internal@878a52cac350 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I5856bdd8f7bef56cfc75a6bdc5c9491a5b8ec5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734448}
-
Ian Kilpatrick authored
As above. There should be no behaviour change. Change-Id: I2af0b4064569df403bf993f8c32a655c0c1cd149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015053Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734447}
-
Henrique Ferreiro authored
Since obj files are loaded lazily, in order to set up breakpoints for a component build, the program needs to run at least once. Add a notice regarding this behaviour. Bug: 1044564 Change-Id: Id2b90ebcbc658d1d2ad84b4fb8d09ac9a83e16db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014967Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#734446}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Ibe0f4ae6978c6ed62a1d0df7d9afe0fa9d413a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015910Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#734445}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I6f82a9e4ffbd1e5d89d7044646165bb6c9b9c2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016842Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734444}
-
Anatoliy Potapchuk authored
Currently we were displaying permission prompts in web kiosk mode for origins of not the main app. To keep it consistent with other types of kiosks, we should deny those requests. We are not explicitly denying them, but leaving them unanswered, this preventing them from being stored into prefs. Bug: 1044551 Change-Id: Ic6f1a260d3f03b92fc52f8f341c6259155b791d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014403 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734443}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ae5f4f5ce1e..4b64b3f2634c git log 4ae5f4f5ce1e..4b64b3f2634c --date=short --first-parent --format='%ad %ae %s' 2020-01-23 aerotwist@chromium.org [Global] Remap refs to Common.moduleSetting 2020-01-23 mathias@chromium.org Update Chromium builds for tests 2020-01-23 aerotwist@chromium.org [Global] Update refs to Common.settings Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b64b3f2634c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1042269,chromium:1043142,chromium:848823 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4b35bb2f4d5cad4b3e49a6d68f31170bde78ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734442}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1044962 Change-Id: I71932bea0c6fe2814a5a566fcb19752ea9af2e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016646Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734441}
-
Nikita Podguzov authored
Actual usage will be introduced in follow-up CL. TBR=battre@chromium.org Bug: 996785 Change-Id: Iba78e17959c27ed7dee1618b191690559346c066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002622Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734440}
-
Rob Buis authored
Implement the <mspace> element [1] by adding support for it on the DOM and adding a layout algorithm for it. Also map attribute width to the width property and map height and depth to the height property using calc(). Bug: 6606 [1] https://mathml-refresh.github.io/mathml-core/#space-mspace Change-Id: Ic52832edd6a73d896c2d42041756ded5d50fcb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936251 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#734439}
-
Askar Aitzhan authored
The results of rolling out to 1% Stable: * PolicyInvalidationsRegistrationResult: https://screenshot.googleplex.com/pnbpqVwsRU9 * DevicePolicyInvalidations: https://screenshot.googleplex.com/MEWsE7RkOwk * DevicePolicyRefresh2: https://screenshot.googleplex.com/VWuHQvxsKx3 * PolicyInvalidations: https://screenshot.googleplex.com/EqoY7uBTVO7 * PolicyRefresh2: https://screenshot.googleplex.com/qEXcoLEXziK The results are as expected. The issue regarding Klopf-Klopf devices not receiving remote commands b/141327786 was confirmed that it was not caused by "Invalidation Service Migration". Bug: 939039 Change-Id: Idd37c358e7bc9d4a69e204c1a91e6a44c376675b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014966Reviewed-by:Marc Treib <treib@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#734438}
-
Benoît Lizé authored
Local testing shows that async scripts miss more often in the memory cache. Add a histogram to check whether this is the case. As a consequence, extend the expiration date of the related histograms, and add a "team" owner for these histograms. Bug: 1043679 Change-Id: Ia2bf6145d864470f6c964938aba851ed94ca773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010847Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734437}
-
Alex Ilin authored
This CL disables flaky VrBrowserTransitionTest#testIncognitoLearnMoreTriggersDoff test. TBR=bsheedy@chromium.org Bug: 1032769 Change-Id: I3675e75c1b3573acb06b56b786f75308cb9f97c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015027Reviewed-by:
-
Stephen Nusko authored
Both of these are failing: system_health.memory_mobile/background:tools:gmail:2019 system_health.common_mobile/background:tools:gmail:2019 NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org,charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org BUG=1044953 Change-Id: I631729ec70d5a1ebe40c4b31c16b0c71d364ed57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014911Reviewed-by:
-
Stephen Nusko authored
Both of these are failing: system_health.memory_mobile/load:games:bubbles system_health.common_mobile/load:games:bubbles NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org,charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org BUG=1044953 Change-Id: I2fb571bd8f08cdcb4e6615c0af23c40609973237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015086Reviewed-by:
-
Rushan Suleymanov authored
Generate unique identifier for each message and store it in a new field in specifics. This id is used by bridge as storage key and client tag. Changing tag numbers in the proto is fine because it is not used anywhere yet. Bug: 1034932 Change-Id: I5c79fdb70d8897ac300e49e98e78760b8394e52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015024 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734433}
-
Robbie Gibson authored
Bug: 1006215 Change-Id: I3844da9d76e7778c028482e8394a27a61ab0ad47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016632Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#734432}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/313d98ee7b49..5cddf9e222f6 Created with: gclient setdep -r src-internal@5cddf9e222f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8289650be3e1bd36ffe6f53ed1ac4da0834eacb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015527Reviewed-by:
-
Torne (Richard Coles) authored
A number of apps hit cases where they're sure they only have one process but the data dir lock can't be acquired, and there appears to be a possible issue in Android where a process might be restarted in a race with a previous instance being killed under rare conditions. Retry acquiring the lock a few times to allow for the possible race, and write out the process info of the process holding the lock to the file so that if we still fail after retrying, we can show more helpful information. Log a histogram for how many retries it required, so we can validate whether this is helping. Move the data directory locking code into its own class, as it's now more complex and its internal details aren't relevant to the rest of AwBrowserProcess. Bug: 558377 Change-Id: I75a13262138856b58febbcec3203f9984269b215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918160 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734430}
-
Peter Marshall authored
This is a reland of a5afd47a Original change's description: > DevTools: Block SIGPROF during CPU throttling > > The V8 CPU profiler schedules SIGPROF signals. It is very likely that > the signal handler for these will run while the throttling signal > handler is already running. V8 can't properly read the stack when > there is already a signal handler present. > > Fix this by using sa_mask to block V8's SIGPROFs while the > throttling handler is running. This makes more sense overall as well. > Our CPU samples would be skewed by whichever stacks we encounter > during throttling pauses. > > Bug: 1027242 > Change-Id: I80e856ce1e7b4744a9af7e36c2022b6d8610cf60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012280 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733592} Bug: 1027242 Change-Id: I2c5c1e462f9f6f16739e773dda112bacd8b354f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014404 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#734429}
-
Finnur Thorarinsson authored
Bug: 950024, 895776, 656016 Change-Id: I7696bb02113c660069cef0c2083337625c1e0272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010771 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5c6594d..464fe259 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieedbcaa85c11d08b602b7eedb1f3aba12f5fdc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014783Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734427}
-
Maks Orlovich authored
Many platforms (Android, Linux, Mac) have a cache directory that's outside the regular profile directory, and the cleanup code was not taking it in account. Test restored from what was accidentally dropped in https://chromium-review.googlesource.com/c/chromium/src/+/1640718 ... but only in an Android-specific version, since on other platforms *tests* will always have cache directory inside profile directory, even if regular users don't. Bug: 1040115 Change-Id: Ie635b25e40a4f76019b895d6f09f1683ede353fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992563Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#734426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e20606a24add..4ae5f4f5ce1e git log e20606a24add..4ae5f4f5ce1e --date=short --first-parent --format='%ad %ae %s' 2020-01-23 aerotwist@chromium.org [Global] Update refs to SDK.targetManager 2020-01-23 almuthanna@chromium.org Create Karma tests for CharacterIdMap and Settings 2020-01-23 aerotwist@chromium.org Fixes e2e hello world test Created with: gclient setdep -r src/third_party/devtools-frontend/src@4ae5f4f5ce1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I21447508c90693209db93fa2f787832780de88d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015526Reviewed-by:
-
vitaliii authored
They are not needed and get autoremoved on the server side, which impedes the reviews. Change-Id: Ie5a56e2d57946eaf09718b601dc6ddc8e75036f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015025 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 895776, 656015 Change-Id: Ide9f2e54ea68f6f93d62bd7d2beaabb9bb7954c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015100 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. Bug: 1042208 Change-Id: Ib442aa79586586b2495dec1df11497713ee7e442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011800 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734422}
-
Martin Šrámek authored
The "Show suggestions for similar pages when a page can't be found" setting is no longer needed as of crbug.com/1011893#c22. We will remove as a part of the next phase of the privacy settings redesign. Bug: 1032584, 1011893 Change-Id: I94c4a3747b64417ef7def0fc1d009c1a8bfccf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007576 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734421}
-
Ian Kilpatrick authored
Devtools had an issue where elements were sized at 0px height. This was caused by the relayout boundary logic not working correctly. In Devtools these elements had layout and size containment triggering ObjectIsRelayoutBoundary() to return true. The call to NGConstraintSpace::CreateFromLayoutObject for this flex-item was incorrect as it wasn't using the stretched size (as we don't set HasOverrideLogicalWidth(), etc). This refactors the various callers of NGConstraintSpace::CreateFromLayoutObject and create a new method UpdateInFlowBlockLayout which contains the previously (duplicated) logic. This new method will try and use the previous constraint space (if it is a layout root), instead of creating it. Bug: 845235 Change-Id: I52ddb9d58ae010305b980657bb434a30d5b7fbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010983 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If9a98513d2b170381ca4b9097aefbffd325a7a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015061Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734419}
-
Alex Chau authored
Bug: 1044607 Change-Id: Ibe881eb03b538358492539af3330e79e0588944b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015047Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#734418}
-
Colin Blundell authored
After the recent change to have handling of SSL errors go through a //chrome-level wrapper that supplies embedder-level params to SSLErrorHandler::HandleSSLError(), the embedder's NetworkTimeTracker instance can be supplied via that wrapper rather than needing to be routed through SSLErrorNavigationThrottle. Bug: 1030692 Change-Id: I7bcdc5d2ea161ab289cf710df2b99b139a6a37b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014960 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734417}
-
Olga Sharonova authored
This reverts commit c9552c88. Reason for revert: CrostiniPortForwarderTest.AddPortDuplicateFail failing on Linux Chromium OS ASan LSan Tests (1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36750 Failure example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890488549187658624/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniPortForwarderTest.AddPortDuplicateFail__status_CRASH_/0 Original change's description: > Crostini port forwarding activate and add port > > Port forwarding in Cros will allow users to add new ports and activate, > deactivate and remove existing ports. > > When any of the utilities are called, the port forwarding library will > invoke the permission broker client to change the ChromeOS port > forwarding settings. > > In future work we will also save port forwarding preferences such that a > user's preferences will persist over container shutdown. > > Bug: chromium:848127 > Test: crostini_port_forwarder_unittest.cc and everything builds > Change-Id: I9a0478f1486252fb09fab18ab3261e03d00eb480 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999972 > Reviewed-by: David Munro <davidmunro@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Matthew Chen <matterchen@google.com> > Cr-Commit-Position: refs/heads/master@{#734303} TBR=hashimoto@chromium.org,hollingum@google.com,davidmunro@google.com,matterchen@google.com Change-Id: Iabb6d856090b1f34776b547cd1b6ba652ebfb055 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:848127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015085Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734416}
-
Rushan Suleymanov authored
SharingService has dependency on ProfileSyncService. Make SharingMessageBridge a separate service with its own factory to prevent cyclic dependency. This change does not wire the bridge to any existing service but provides the interface for creating and using it. Bug: 1034930 Change-Id: I9907eb2687e48c65b7203d1b10e6ad34ed981010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007269 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
David Roger authored
Dice is now launched and pre-dice codepath can be removed. Bug: 891781 Change-Id: I15efa40c47b6c164f5aae521f19734390ec138a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013283 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/24627fa40a48..2439a3af02eb git log 24627fa40a48..2439a3af02eb --date=short --first-parent --format='%ad %ae %s' 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b766e5e7fbf4..c514ab001bb0 (8 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ca9b61a4455f..aaba1e4e6aec (1 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ac02c61ffc63..8317b28e672a (6 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src af8c7e040f93..37d3a235af2c (2 commits) Created with: gclient setdep -r src/third_party/angle@2439a3af02eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I3833067a4900eae31fab1261f855ef6bdec38381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016472Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20d0f9299138..e4ddb8a7cddc git log 20d0f9299138..e4ddb8a7cddc --date=short --first-parent --format='%ad %ae %s' 2020-01-23 reed@google.com Revert "Specialize SkRectanzier to SkRectanizerSkyline" Created with: gclient setdep -r src/third_party/skia@e4ddb8a7cddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I547a89518739863aa6ca9e85ce085268899e73dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015524Reviewed-by:
-
Mathias Carlen authored
Before this patch when entering the prompt state, the sheet would always be expanded so that the buttons were visible to a user. This patch introduces a new proto field that allows this behavior to be configured from the backend. Additionally, the configure bottom sheet action is extended by a new field to expand or collapse the sheet programmatically. Bug: b/145204744 Change-Id: I9191e3e4f7b6b688d6a9dae800f730b56056b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004868 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#734411}
-
