- 14 May, 2019 21 commits
-
-
Sam Goto authored
Explainer: https://github.com/sso-google/sms-otp-retrieval Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Drmmb_t4eE8 Design Doc: https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit WICG Thread: https://discourse.wicg.io/t/sms-otp-retrieval/3499 Bug: 670299 Change-Id: I990c32cf248200277e50ffb127d9828a62ef3a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590392Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659305}
-
Vladislav Kaznacheev authored
While menu is being shown, it is preventing Chrome from exiting. However, if a menu is opening while Chrome is already shutting down, this currently causes a CHECK failure (see linked bug). The CL is adding shutdown detection logic to ChromeViewsDelegate and avoids showing a menu if a shutdown is detected. Note that no callbacks (such as OnMenuClosed) are called. Bug: 960925 Test: none Change-Id: Ie282f353b94a5c79a29ba5f770808d552d8e2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601419 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/628604eefdb9..65b1e97d13eb git log 628604eefdb9..65b1e97d13eb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Only perform attachment load/store ops for used attachments Created with: gclient setdep -r src/third_party/swiftshader@65b1e97d13eb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ic492f9c3f2dcf402cba9c7d351a8f8eab75fb32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659303}
-
Jinsuk Kim authored
Uses image src url if alt text is missing. This is how image opened in a new tab works. Bug: 960130 Change-Id: Id592a091c445486f8ee81e4d7090366f5719301c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605380Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659302}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2d0ebdef207..8f877b2e3820 git log b2d0ebdef207..8f877b2e3820 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 tsepez@chromium.org Replace CountedFaceCache with RetainPtr<CFX_FaceCache> 2019-05-13 tsepez@chromium.org Rename CXFA_Node::RemoveChild() to RemoveChildAndNotify() 2019-05-13 tsepez@chromium.org Add more helper methods to tree_node.h Created with: gclient setdep -r src/third_party/pdfium@8f877b2e3820 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I49b6e97604e451bff16fa78806332f3f6cf78d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610783Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I7868559255a04fdf354fdd843c91ea0779a33072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603214Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659300}
-
Darwin Huang authored
Ref: https://abseil.io/tips/131 https: //stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11?lq=1 Change-Id: I10dffd5bd13d6f619e4f758ec154947bbef86d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607185 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Separate the "More Info / Remove..." context menu entry for Suggestion Transparency into two context menu entries: - Why this suggestion - Remove suggestion This was vetted by our UX folks, and so we are also committing these strings to our translated strings. The implementation of the "Why this suggestion" info bubble will be in a separate CL. Bug: 929477 Change-Id: Ia406107bf9f6b50354f2b8f9ccf6b472571d799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610846 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659298}
-
Matthew Braithwaite authored
Change-Id: I78d857a03de71c27988793e50b143dd8f4523c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603403 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659297}
-
Vlad Tsyrklevich authored
Linux crashpad support is now sufficiently enabled to allow running the GWP-ASan crash handler unit tests under Linux. (The client tests are still blocked on allocator shim updates.) Change-Id: I409cebaa9cdaed5da546266d0af470d2b25a09ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610605 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659296}
-
Erik Luo authored
Screenshot: https://imgur.com/a/bOoDTny Bug: 959001 Change-Id: Idc6e7303821e4180ec90831341a29aebe594fcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597283Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#659295}
-
Nick Harper authored
Bug: 962666 Change-Id: Iadc9823c3e90d474d0e45c3e49494d29f038f13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610705Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659294}
-
Caleb Rouleau authored
The current code has an assumption that every official benchmark must be scheduled on either pixel2 or linux platform. However, we are hoping to allow benchmarks to choose when platforms are the most important for them instead of having them run across all platforms by default. Bug: 961830 Change-Id: I26de896c921a85213a867e89ff137fce81959550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610484Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659293}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e4b7dee3c41..bbc5238c48bb git log 4e4b7dee3c41..bbc5238c48bb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 yueherngl@google.com sarien: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@bbc5238c48bb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1064259818fae14928c9430650d8097840847c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610786Reviewed-by:
-
Mike Wittman authored
We've captured enough data to answer the relevant questions about jankiness of this function. Bug: 903972, 955601 Change-Id: I23eaffbcb1dc1c41bb37b106e794e4a6e776f6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610506 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659291}
-
Darwin Huang authored
Ref: https://abseil.io/tips/131 Change-Id: I8673de91b4b0bac43d7a7c87fa4b69e45d181e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606824 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for BoxLayout::CrossAxisAlignment enum class is more type safety. Bug: 940736 Change-Id: I76bfd19f4b2b176e1c832590dce9c82c17d50093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605281Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#659289}
-
Rahul Arakeri authored
This CL renames "Enable Compositor Threaded Scrollbar Scrolling" to "Compositor Threaded Scrollbar Scrolling". The flag already has options to enable/disable it. Hence the "Enable" part of the flag name can be removed for improved readability. Bug: 962715 Change-Id: If955ec074b2bd77b7b1a22f4102068950d4c2dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598344Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5fc28b11a029..e62a08a87a6f git log 5fc28b11a029..e62a08a87a6f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 ssilkin@webrtc.org Request key frame on all layers. Created with: gclient setdep -r src/third_party/webrtc@e62a08a87a6f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bea98df30884cc0d41612cf7664d34e33357131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609700Reviewed-by:
-
Aleks Totic authored
Fuzzer caught a NULL deref crash. Running with DCHECK, found a problem before the deref, we were cloning LayoutNGInsideListMarker inside LayoutInline::SplitInlines. This was triggering a DCHECK in LayoutInline::Clone. I am not very familiar with how LayoutInline line splitting works. I have a patch created with my shallow understanding that fixes the crash, but I am not sure if this is the right thing to do. Bug: 962242 Change-Id: I11e4cf3307c257e7c396b4112888bad0cd76ac5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610522 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#659286}
-
Ryan Sturm authored
This CL verifies we are not laying out when analyzing metrics elements. A lifecycle observer is used to wait to record and send metrics until the lifecycle is not in the middle of layout. Subframe anchors do not record size metrics anymore. Bug: 957026 Change-Id: I1fe67350d2c5c800697e412b4604b760fce2f859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592323Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659285}
-
- 13 May, 2019 19 commits
-
-
bsheedy authored
Refactors all the classes in wmr_input_manager.h, wmr_holographic_frame.h, and wmr_holographic_space.h in the same way as crrev.com/c/1603748. Bug: 961020 Change-Id: Ie4dc432823cfdbe506d2616fb9005ce5392035e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610592 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#659284}
-
Ryan Sturm authored
The clicked element will no longer report its size (or relative size) to the browser/UMA. Instead, we plan to see if it is in the Anchors reported on load. Its size would only be valuable if we knew about the anchor from OnLoad. Bug: 957026 Change-Id: I59a98348fd0d58a4dd1a99bd86c2720b36f1af88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602773 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Matt Menke authored
Looks like this is broken in production, and almost no one noticed. We also want to drive down FTP use in Chrome so that we can eventually remove it. It's insecure (which is particularly concerning when downloading files), and requires a lot of code, increasing potential attack surface area. Bug: 925531, 960607 Change-Id: I56792700f913f0af2562cfabec7fa27ea5f444fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606822 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659282}
-
Becca Hughes authored
Add the media metadata to the AX data so that it can be picked up by a screen reader. BUG=962682 Change-Id: I78a0d5c09c13450d5486c94b7d04b5fa36cce9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610028 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659281}
-
khmel@chromium.org authored
At current version there is race that prevents setting default app pins correctly for the new user. Following happens: * Start new user in Chrome * App sync starts asynchronously and flashed existing apps with default unpinned state for each app. * Chrome is restarted automatically * At new session Chrome shelf is activated. * Default pins are created. * App sync starts asynchronously again and pins on previous step are lost. This CL makes applying default shelf pin explicit and under the strict rules. * Reserve sync preference to store rolled default pin layout. * Wait until App sync either started or works locally in case disabled. * Wait until preference to store rolled shelf pin layouts is synced or works locally in case 'settings' sync is disabled. * When conditions above are met and requested shelf pin layout was not rolled, apply default shelf pin layout. This also adds possibility to roll custom layout. There is a drawback of this CL that few apps might re-appear on user's shelf in case they were explicitly unpinned in past. (Gmail, Google Docs, Youtube and Play Store) TEST=Locally BUG=958988 BUG=958389 Change-Id: I980660d359ec496592ba67d245c5101888f08883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606563 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659280}
-
Avery Musbach authored
The present CL is for the animation of the divider and its white handle, when split view is activated by dragging a window, if the window is not minimized and the dragging is not tab dragging. The animation is based on: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop The present CL deviates from the specification in an edge case as shown in the video linked in Comment 14 here: https://bugs.chromium.org/p/chromium/issues/detail?id=934977#c14 See how the divider moves toward the side of the screen where the window is snapped, whereas the mockup shows the divider moving away from that side of the screen. The specification says that the white handle shall spawn from "2dp off centerline of divider (in direction of drop)," which in this case is 2dp to the left of where the divider spawns from. Then the divider would pass through the point where the handle spawns. Because that seems wrong, where the specification says "in direction of drop," I instead use the direction from which the divider spawns, as you see in the video. chrome://flags/#ui-slow-animations affects the divider but not the white handle, because the white handle uses SlideAnimation. The flag therefore desynchronizes the spawning animations, but fortunately, the video referenced above opens in a player where playback speed can be adjusted. Test: manual Bug: 934977 Change-Id: Ide325c36c939fbf4af07b878811207c79afc206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601368Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#659279}
-
Alexei Filippov authored
This reverts commit ae792bea. Reason for revert: Broke build https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913531942624945040/+/steps/compile/0/stdout Original change's description: > [Files Ranking] Add a new Dolphin model for zero-state ranking > > This CL adds a new Dolphin model to the search result ranker for zero > state files ranking. Additionally, it: > > 1. Adds a new Finch flag to guard the construction of the model. > 2. Adds/renames some getters/setters for consistent naming: the app > model is an AppSearchResultRanker (Roselle) object, and the non-app > model is a SearchResultRanker (Dolphin) object. > > This CL also makes a small change to the SearchController's members: > the Mixer is moved above the SearchProviders. This is because, in > future CLs, a search provider will hold a pointer for a model owned > (indirectly) by the Mixer, and this ensures the model outlives the > provider. > > Bug: 959679 > Change-Id: Ib101463c61ed79657e380870eeb749e08188a131 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604387 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659273} TBR=xiyuan@chromium.org,jennyz@chromium.org,jiameng@chromium.org,tby@chromium.org Change-Id: Icebce6483275b23d55621d75bff1b85a7dbf1038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609587Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659278}
-
dpapad authored
Previously extensions::Dispatcher::GetJsResources() relied on a manually specified boolean which had to be kept in sync with a grd file's compress="gzip" attributes (only leveraged by IDR_MOJO_MOJO_BINDINGS_JS). This is no longer necessary since ResourceBundle::IsGzipped() can be used to determine if the file is gzipped or not. Basically this CL undoes a subset of the changes introduced at r516811. Bug: 961063 Change-Id: I03740235f2c0ee62c9f406be336fa524e89d2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602132 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659277}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ef8c134. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Iaae22642525237c35e67ad11f3afe2156f0f2d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610880Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659276}
-
Dave Tapuska authored
Only pause/freeze realtime audio destinations. Offline destinations are controlled by the thread scheduler itself for pausing/resuming tasks. BUG=959191 Change-Id: Ie92111af53e651d9d7d3f193921a504935af9c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604493Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#659275}
-
John Lee authored
Change-Id: Ifafd8ad395939011ce9d48e39d04a8d3fcda90cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610849Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#659274}
-
tby authored
This CL adds a new Dolphin model to the search result ranker for zero state files ranking. Additionally, it: 1. Adds a new Finch flag to guard the construction of the model. 2. Adds/renames some getters/setters for consistent naming: the app model is an AppSearchResultRanker (Roselle) object, and the non-app model is a SearchResultRanker (Dolphin) object. This CL also makes a small change to the SearchController's members: the Mixer is moved above the SearchProviders. This is because, in future CLs, a search provider will hold a pointer for a model owned (indirectly) by the Mixer, and this ensures the model outlives the provider. Bug: 959679 Change-Id: Ib101463c61ed79657e380870eeb749e08188a131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604387Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#659273}
-
Alex Moshchuk authored
LoadDataWithBaseURL is never subject to --site-per-process policy today, since this API is only used by Android WebView where OOPIFs have not shipped yet. Therefore, skip the test in --site-per-process mode to avoid renderer kills which won't happen in practice. This should fix the current failures of this test on Site Isolation FYI bots. Bug: 962643 Change-Id: I6a5e721f0402a764d03e291aa920660c53af39e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610940 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#659272}
-
Rakib M. Hasan authored
Change links pointing to old expectation's files and folders to links pointing to new expectation's files and folders. Bug: chromium:698902 No-Try: True Change-Id: Icbf5220c12b303c838a3ae2a60de95b2b63a4015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606966 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659271}
-
John Lee authored
Bug: 962381, 962386 Change-Id: Ide420cf85b90b11e1b255db279f703a570fec9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609670Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#659270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58d7304e63dc..23a97021347c Created with: gclient setdep -r src-internal@23a97021347c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: Ia5c8e24dd7b4f7da9c1fb12f50f30afd719204ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610351Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659269}
-
tby authored
This CL makes modifications to the architecture of the RecurrenceRanker and RecurrencePredictor to: 1. Allow for better API support for targets and conditions. 2. Store all target and condition strings in the Ranker, and only pass IDs to the predictors. 3. Modify the ZeroStateFrecencyPredictor to work with IDs instead of strings. This will have several follow-up CLs: 1. UMA logging for various error cases, eg. proto serialisation errors. 2. Cleanup logic for the ZeroStateFrecencyPredictor. 3. A general conditional predictor for use with query-based predictions. Change-Id: I86e38c28738adf7d5115d1dcd3b5953fab739ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534583Reviewed-by:Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659268}
-
Martin Kreichgauer authored
This change adds a confirmation step when creating resident credentials with Windows Webauthn DLL version one (currently in 19H1). This version requires the use of native APIs for interaction with security keys, but doesn't show a notice informing the user that creating a resident credential will store information on their security key. However, such a notice is a privacy requirement and therefore a confirmation step is added prior to dispatching the API call. Bug: 941120 Change-Id: Ia39aefe7e2b294a604346a66851dbda67372bd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601299Reviewed-by:
Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#659267}
-
Toni Barzic authored
And use error code key in app list responses expected by the fetcher. (Error code instead of Error Code). BUG=None Change-Id: Ic77ab9d2e7eef7b1cdf4cd55f6879835a4ae7a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607127Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659266}
-
