- 24 Apr, 2019 40 commits
-
-
Javier Ernesto Flores Robles authored
After reviewing the progress so far with UX, 14 seems to be a better radius. Bug: 951300 Change-Id: I66c541c4e5b1ed55fb091665623c47e3591f7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578612 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#653525}
-
Mohamed Amir Yosef authored
Recent patch has added new entries to the PasswordSyncState enum in password_manager_metrics_util.h and didn't update the corresponding enum in histograms/enums.xml. https://chromium-review.googlesource.com/c/chromium/src/+/1552822 This CL updates histograms/enums.xml to match password_manager_metrics_util.h Bug: 949493 Change-Id: Ia432689604385b8e9d482ad4a8dea4e69b3d9569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581341Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#653524}
-
David Roger authored
The test is timing out. TBR=ricea Bug: 955883 Change-Id: Ia780e55b9f3629e91037a1d3795d832925e0fbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581340Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653523}
-
Yutaka Hirano authored
auth-base-https-other-https.html has already been listed as slow, and we don't have a reason to believe auth-other-https.html runs faster. Bug: 955883, 874695, 948056 Change-Id: Id0f044ea2ca94f25cc107f15291d24e813422b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580995 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653522}
-
Darwin Huang authored
of mojom::ClipboardBuffer::kStandard. While it could be useful to allow this argument to have other values, perhaps to use for ClipboardBuffer::kSelection in X11, this is currently not used and always has the same value, so let's remove the unnecessary checks and passing around of this buffer value. SystemClipboard: :Read{Image,PlainText}() have an argument, mojom: :ClipboardBuffer buffer, which always has the same value Change-Id: Ide1d9ecb5b8f2869b14232dc2acbfe4c681419e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576184 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#653521}
-
David Jean authored
Added attributed strings handling to action sheet coordinator. Bug: 953625, 953624 Change-Id: Ic70b68fb8e124c12696a971fafe9d6db47dce65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569938Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#653520}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62e274e86c7e..cb8f677cbfb4 git log 62e274e86c7e..cb8f677cbfb4 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 7aad9653f9a3..736376dbf989 (2 commits) Created with: gclient setdep -r src/third_party/angle@cb8f677cbfb4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia3da882202cb81b90305e7c2d7423cce522262a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653519}
-
Corentin Wallez authored
Shared images are necessary to implement WebGPU on Mac, make sure they are disabled only on the platform that requires them disabled. BUG=chromium:900963 BUG=chromium:877147 Change-Id: Ie588d40e5e2d38b57037422c4dd04213617f20eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579979Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653518}
-
Hiroshige Hayashizaki authored
Bug: 860403 Change-Id: If924817aab40dc90b10c7bce914c53c752f35c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579824 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653517}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/406ebfcf0c41..5825d5fae793 Created with: gclient setdep -r src-internal@5825d5fae793 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic0a871ef0629266e234a909bc7886c39a1ce6c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581299Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653516}
-
Kuo Jen Wei authored
Fix size of mode selector icons to align with size in mock design. Bug: 955572 Change-Id: I99c3bad102437929d166ddd59638c0ee6eab9e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580693 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#653515}
-
Marc Treib authored
GetSyncTokenStatus is otherwise only used for debug UI, and I'd like to clearly mark it as such. It's also *almost* identical to other state exposed from ProfileSyncService. Behavior difference: Before: When the access token expires, the ConnectionStatus in the SyncTokenStatus temporarily changes to CONNECTION_AUTH_ERROR until a new access token is acquired, and so UKM is temporarily disabled. After: UKM remains enabled while a new access token is fetched, and only gets disabled if that fails. Bug: 839834, 953272 Change-Id: I68a6ada78a654290e2267de10d6430cbf2ae7195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1065741 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#653514}
-
Roman Sorokin authored
With different VPD options and missing state keys. Bug: 934224 Change-Id: I84ac96e7375441357a3832c0f582ea6ff1baf948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564085Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1edf0f25..a0c4ebc0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id11f68bfff9cbef9a985d88e84b960102c8d001c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653512}
-
arthursonzogni authored
This is a reland of 2cd39eb0. It was reverted, because I was not fully sure the M75 branch cut happened. Original change's description: > Make renderer-initiated navigation to about:blank to use the default path. > > We used to believe renderer initiated navigation from a document to > about:blank needed to happen sometimes "synchronously". This isn't the > case, a PostTask is currently used. The only real requirement is when > committing the initial empty document. > > This CL makes those navigation to use the default path instead. > > This requires a few tests to be updated: > > 1) The initiator and a few other properties needs to be properly set. There > are DCHECK in BeginNavigationInternal to enforce renderer initiated > navigation always have a defined initiator. > > 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log > can use the 'getter' of the object several times (up to 2) to print the > object. It triggers several about:blank navigations. Since they are now going > to the browser process, they are committed later compared to the script > execution. The test became less reliable. The test was using > dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, > but waiting was started potentially after the event occured. The new test is > now creating the Promise before triggering the action that will later resolve > it. The action is either creating the iframe or making use of the logXXX() > function. This is now fully reliable. > > Bug: 936696 > Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652493} Tbr: dgozman@chromium.org,dcheng@chromium.org,clamy@chromium.org Bug: 936696 Change-Id: I90ff5ba914aab76e15b62037da96c4d570cd72d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578544Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653511}
-
Jeevan Shikaram authored
Show component extensions in App Management if they are shown in the laucher. Disable crostini apps until implementation in App Management. Bug: 953587 Change-Id: I24adbacfeb0b3663a45ef8bf8625d702627cdc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580990Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#653510}
-
Boris Sazonov authored
SigninActivityMonitor tracks sign-in activities started from SigninUtils and exposes this as an observable value. This CL also wires up ConsistencyCookieManager so it tracks this value and exposes it for the native side. Bug: 949562 Change-Id: If2e5f9b596bd3d03a8d73d3606785e1aff020300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578548 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1565621 this CL replaces assert_*() with Promise.reject() or throw, to enable common.js to work without testharness.js and outside promise_test(). Bug: 906850 Change-Id: Iea2b4621c44c0c28aaf1f9bb0a1412e4ef682c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565556 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#653508}
-
Giovanni Ortuño Urquidi authored
InstallFinalizer does not create shortcuts automatically so we have to create them in BookmarkAppInstallation task when installing a place- holder app. Also add a bool to control whether a desktop shortcut will be created in addition to the applications menu one, since policy doesn't always create desktop shortcuts. Bug: 955926 Change-Id: I059257c5aa154caf336400e50cb6cb96f5c2ba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580683Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#653507}
-
Koji Ishii authored
Following bot results are included. 18570 18571 18577 18583 18588 18592 18597 18601 18607 18612 18622 18636 18649 18650 18652 0 lines were removed and 2 lines were deflaked by consecutive results since 18583. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Icd5e6ee09f51df9a604a39a17d4565ba9c94ba0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575302Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653506}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14af258cab9d..406ebfcf0c41 Created with: gclient setdep -r src-internal@406ebfcf0c41 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I3f5ba9ab4fe52f7de462e26d4c96790f652980a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580909Reviewed-by:
-
Friedrich Horschig authored
With this CL, the keyboard accessory component moves into the new folder chrome/android/features/keyboard_accessory/ To keep the public interfaces separated from the implementation, move them into: chrome/android/features/keyboard_accessory/public chrome_junit_test won't include the keyboard_accessory_junit_tests by default anymore which speeds up the compile time of the latter. To ensure that the bots still exercise these tests, they were added to the configs. Summary of changes: - move everything to chrome/android/features - create BUILD.gn file with new targets - add new java targets to chrome/android:java - add new test targets to bot configs - split out public/ interface - add factory to retrieve correct implementation during run-time - temporary use of reflection until injection method is agreed upon? - fix dependencies (subset of chrome/android/ dependencies) - fix DEPS (subset of chrome/android/ DEPS) Intentional side-effects: - keyboard_accessory/OWNER file affects feature res/ folder To generate a gradle file including the feature, make sure to add the java target, like this: . build/android/envsetup.sh && \ build/android/gradle/generate_gradle.py \ --output-directory out/AndroidDebug \ --target //chrome/android:chrome_public_apk \ --target //chrome/android:chrome_public_test_apk \ --target //chrome/android/features/keyboard_accessory:java To run the new robolectric tests: ninja -C out/AndroidDebug -j2000 -l20 keyboard_accessory_junit_tests and ./out/AndroidDebug/bin/run_keyboard_accessory_junit_tests Bug: 945314, 846440 Change-Id: I676d0e22a5cb02eb97459da6047fda00f09a7902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545301Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#653504}
-
Sam Zackrisson authored
The acoustic echo canceler AEC2 is being deprecated. There are already no clients reporting *AecDelayAdjustmentMsSystemValue. *AecDelayAdjustmentMsAgnosticValue reports have drastically decreased since the AEC3 rollout, and are practically non-existent in M73+. Bug: webrtc:10563 Change-Id: I8999169ac4f236296cd1873289c423745edb57d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#653503}
-
Matthew Mourgos authored
Bug: 953525 Change-Id: I3541430056b9924d9d249f4c6329c249b74bb172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574610 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#653502}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a161493942fa..ea1b0983c7b4 git log a161493942fa..ea1b0983c7b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 swiftshader.regress@gmail.com Regres: Update test lists @ ed46cde6 Created with: gclient setdep -r src/third_party/swiftshader@ea1b0983c7b4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I807d1c0b0f96f5608cd4afae5e151bb9b72cf1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580907Reviewed-by:
-
Kuo Jen Wei authored
This CL include following UI changes and bugfixes: 1. Fix CCA window size ratio to 16:9 under all modes. 2. Centered camera-mode icons on preview. 3. Fix bug measuring square mode preview in original video size bug 4. Fix w-letterbox-l not working bug. 5. Fix switch to/from square mode preview position jumping before ready. Bug: 954672 Change-Id: I580e08db2fec3face310ca7cbf20a3edbfee6422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563132Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/792f3c373f12..14af258cab9d Created with: gclient setdep -r src-internal@14af258cab9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I0bc24934c91f8d7dcbb6d913820f823781f9f2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580906Reviewed-by:
-
Dominic Mazzoni authored
This change changed the accessibility tree to be built using LayoutTreeBuilder: crrev.com/c/1547617 This caused crbug.com/951503 - a crash in blink::AXNodeObject::AddChildren, due to a node being deleted while it was in the process of iterating over its children. I can reliably reproduce this crash by loading https://www.komputerswiat.pl/gamezilla when accessibility is enabled. I discovered that the root cause was due to the change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) - specifically code that identifies an old entry in the node mapping that needs to be updated. The problem with the code is that it assumes there's a 1:1 mapping between nodes and layout objects - but this isn't always true. When there's a continuation, you could have two layout objects that correspond to the same Node. The fix is easy - just check node->GetLayoutObject and skip checking the node mapping if it's not the same. Bug: 951503, 835455 Tbr: nektar@chromium.org, aboxhall@chromium.org Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580140Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653498}
-
Yoichi Osato authored
This CL adds a websocket performance test where client receives arrayuffer of 1 mega bytes 100 times. Test: $ cd third_party/blink/perf_tests/websocket $ npm install $ npm start $ python ../../../../tools/perf/run_benchmark run blink_perf --browser=canary --test-path=websocket\receive-arraybuffer-1MBx100.html or open the file directly on browser. Rough result (avg ms of 6 runs) on Windows10, 28-core CPU of 2.6GHz: Chrome Canary(m75): 1709 Canary w/o extension: 637 FireFox: 338 Bug: 954000 Change-Id: Ica622aba18d57af2c97f11019588762544008d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573436Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ed46cde6ee67..a161493942fa git log ed46cde6ee67..a161493942fa --date=short --no-merges --format='%ad %ae %s' 2019-04-24 chrisforbes@google.com Set up input attachment descriptors the same as storage images Created with: gclient setdep -r src/third_party/swiftshader@a161493942fa The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0f7b5d087c3eed903e122cb5df731c62394a12c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580905Reviewed-by:
-
Reilly Grant authored
This change updates ChooserContextBase's GrantObjectPermission() method to take url::Origins instead of GURLs. In the process the internal GetWebsiteSetting() and SetWebsiteSetting() methods have also been modified to take url::Origins. This is part of a migration effort to remove GURL from the interface of ChooserContextBase and its subclasses. Bug: 951785 Change-Id: I88878374ca4c8c1d56cb6f05614fb76f70ac4f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579477Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e81acfb18dab..792f3c373f12 Created with: gclient setdep -r src-internal@792f3c373f12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I280a4f6537b165737343f3c7790ad347b7f2a8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580904Reviewed-by:
-
Tarun Bansal authored
based study to holdback data reduction proxy. Change-Id: Ib3c900ea4bd3441272051b53911a1f46e216a020 Bug: 954958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578127 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#653493}
-
Tsuyoshi Horo authored
This class is used only in the browser process. Bug: 935267 Change-Id: I165997ea73ec8da973a8cade28bdebf9fad532e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580684Reviewed-by:
-
Miyoung Shin authored
Replace the use of std::map of std containers with WTF::HashMap in screen_orientation_controller_impl_test.cc. Bug: 952716 Change-Id: Idb53fa6890aed3120224f5027d8791301416f9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580685Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#653491}
-
Hajime Hoshi authored
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/1536036 This was reverted once since ServiceWorkerTest.UpdateRefreshesServiceWorker became flaky on Windows, but now this doesn't, though the reason is unclear. This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: ./tools/perf/run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:media:soundcloud:2018 As this is a non-standard JavaScript API execution, we adopted kInternalDefault as the task type. Bug: 913912 Change-Id: Id03b1ac9f46e6c69adea8cd42c6af193dd83fa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578144Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653490}
-
Miyoung Shin authored
Replace the use of std::map and std::string of std containers with WTF::HashMap and WTF::String in mhtml_archive_test.cc and unit_test_helpers.cc/h. Bug: 952716 Change-Id: I89a22163c5aafc64fb4f885721129b17cefb965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580979Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: I0b63dcfd3bd7f5a04340e21ed63b5c49a9c7e318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580763Reviewed-by:
-
Kent Tamura authored
According to the HTML standard, updating defaultValue should keep selectionStart/End, and clamp them if the new value is shorter than them. defaultValue setter doesn't have any explicit selection behavior [1], and we should apply default selection adjustment algorithm in such case [2]. The new behavior matches to Edge, Firefox, and Safari. Some test cases in selection-start-end-extra.html were not correct. This CL fixes them. Remove some test cases in textarea-selection-preservation.html because they are covered by WPT. [1] https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:dom-textarea-defaultvalue-2 [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection:concept-textarea/input-relevant-value Bug: 822639 Change-Id: I77db0934bb10774561e947f64b4cb3f88c293679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575317 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7f0d25d9bc6..e81acfb18dab Created with: gclient setdep -r src-internal@e81acfb18dab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Iac5df1d9de07cbb688b290d9030817e2dfca40ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580902Reviewed-by:
-
