- 20 Nov, 2020 40 commits
-
-
Matthew Denton authored
GCC seems to have a bug with constexpr when this flag is present: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97913 So enable it only on clang for now. Bug: 1139129 Change-Id: If657d5e3fac1621adf57c266cfd64ce628dc7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551494 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829585}
-
Makoto Shimazu authored
TBR=michaelpg@chromium.org No-Try: true Bug: 1150349 Change-Id: Ib27007ecf4929f227fa9e7925fefa4bfed903c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551885Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829584}
-
Ian Struiksma authored
Tests have been stable after changes were made in crrev.com/c/2490868, removing debug logging. Also enabling test 'FillChangeSecondFieldRefillSecondFieldClearFirst' which was disabled under same bug. Bug: 967588 Change-Id: I7da6b5c24424d6763d59ea93c9cd067139fc641e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550609 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#829583}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/330b60556789..26ced490899d 2020-11-20 linxinan@chromium.org Improve the readability on variable name added in crrev/c/2528670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ida94502ef59e3ff6a3916e8e54d9a1a3468b3522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551507Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829582}
-
Makoto Shimazu authored
TBR=tbarzic@chromium.org No-Try: true Bug: 1151205 Change-Id: Id39eb0bf84373073db454ba94c0d76c006b12b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551884Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I66ef180d2f9591681fe8e9c8f3c70bf760b18c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536428Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829580}
-
Dominic Mazzoni authored
Bug: 897365 Change-Id: Id88ee9a1a83c4f8b918c688732d30ba037c441bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550527 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#829579}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f660f22d9eb..9dce4d081f8a 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8b76d37f9f9a to 777749aafaac (19 revisions) 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ce207be41fd6 to 1a14e7e02441 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: LEGO MECTest: Test: dEQP-GLES31.functional.copy_image.*renderbuffer* Change-Id: Iacaeb12d720a057ab9e8b89dd2397941a00e5967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551505Reviewed-by:
-
Makoto Shimazu authored
This reverts commit f219c238. Reason for revert: LocalStorageImplTest.CorruptionOnDisk became flaky. Three builds are failing in a row. Example build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/18708 Original change's description: > Constrain DOM Storage backend lifetime > > LocalStorageImpl and SessionStorageImpl are self-owned objects with > lifetime loosely bound to their corresponding Mojo interface receivers. > This means it's possible for them to outlive the service itself (i.e. > the StorageServiceImpl instance) and continue scheduling work during > the service process's shutdown. They also use shutdown-blocking > TaskRunners for some of their tasks, which is problematic given the > potentially too-long lifetime: if a non-shutdown-blocking task races > with shutdown completion and then attempts to schedule a shutdown- > blocking task, we have a bad time. > > This CL fixes the issue by changing LocalStorageImpl and > SessionStorageImpl to have stronger ownership within PartitionImpl > and initiating an explicit shutdown step when the partition is > torn down. This step effectively inhibits the scheduling of any > subsequent non-shutdown-blocking tasks for these objects, ensuring > that any remaining work comes in the form of shutdown-blocking tasks > scheduled prior to or during the explicit shutdown step, or from > other shutdown-blocking tasks posted by those tasks. In other words, > shutdown remains continuously blocked until these objects are done > scheduling work. > > This achieves the same shutdown-blocking behavior without the risk > of a race against shutdown completion. > > Fixed: 1135957 > Change-Id: Ie2fcc25df7fafe390c736d2c56d139433c69bf8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533934 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#829483} TBR=rockot@google.com,pwnall@chromium.org Change-Id: Ibad7482357ba3122fd88afad31ed4a85b6651c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551866Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 32cf67c4. Reason for revert: these two tests added in this CL were flaky - OverlayPopupAdViolationBrowserTest.OverlayPopupAd_AdInterventionTriggered - OverlayPopupAdViolationBrowserTestWithoutEnforcement.OverlayPopupAd_NoAdInterventionTriggered sample builds: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5924 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/39438 Original change's description: > Sticky and Overlay-popup ads recorded in ads intervention manager > > This change propagates signals for sticky ad and overlay-popup ad > detection from the renderer to the ads intervention manager through > the subresource filter component. > > As the ads intervention manager is running in dry run mode and > does not block ads, this allows us to record intervention behavior > when triggered by one of these two interventions. Understanding > the intervention behavior is a precursor to the ads intervention > manager intervening to actively intervening on sites with better > ads standard violations. > > Add base::Feature flags to allow disabling the frequency capping from > either web_tests and browsertests. Move relevant tests into a virtual > test suite that has the flag disabled. > > Bug: 1099741 > Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Eric Robinson <ericrobinson@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829547} TBR=dcheng@chromium.org,szager@chromium.org,alexmos@chromium.org,ericrobinson@chromium.org,yaoxia@chromium.org Change-Id: Ibe952a34ab4cc194f318497a631e01f96d665e71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550017Reviewed-by:
-
Yutaka Hirano authored
- ScriptPromise corresponds to Handle<v8::Promise> and ScriptValue corresponds to Handle<v8::Value>. Hence conceptually ScriptPromise should be convertible to ScriptValue, reflecting the fact that v8::Promise is a subtype of v8::Value. Rename ScriptValue::GetScriptValue to ScriptValue::AsScriptValue, for the explicit conversion. - Add V8Promise() which returns a v8::Local<v8::Promise>. The function is safe because `promise_` always stores a v8::Promise as long as it's non-empty. Bug: None Change-Id: Ie21703e2673a7c0443259c61bfca11379d758e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549320Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#829575}
-
Polina Bondarenko authored
Add ArcDataRemoveRequestObserver to stop TakeSnapshot flow when kArcDataRemoveRequested is set to true. BUG=b:161221001 TEST=components_unittests Change-Id: Ic59bbc3c5b74b7927b4d5bdfead523bb12de46b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537964 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829574}
-
Daniel Hosseinian authored
With the PDF Viewer update, the plugin's viewport no longer takes the size of the entire frame. Additionally, the toolbar no longer overlays the plugin. Consequently, the plugin has an offset relative to the frame. The plugin's size and offset can change with the toggling of the sidenav. Send the plugin offset to PdfAccessibilityTree so accessibility rects can have the correct transformation. Bug: 1150660 Change-Id: Idef25f31cfbfa459e317b6f003a289fcb8daac19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551465Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#829573}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Icd81a140a5c542148b95e7037cf9c44d9e65ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537278Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a241aa984fd6..511da9af8056 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80341f3ee0432527f7c8c9b558c614088f4b78b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551228Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I59c92c79d224aaf14b3a85c6c56d45222ebcd670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536583 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829570}
-
Bao-Duy Tran authored
This enum is only applicable to obsolete InputMethod.ID histogram that's been deprecated since M46. Therefore it should have been marked obsolete together with the histogram's deprecation 6 years ago (July 2014, see https://crrev.com/254e75d880369bf49bdf0e8ccc400ab71f6f2fee). The enum ID needs to be marked obsolete (and not removed), as per UMA guidelines to avoid inadvertent reuse that causes confusion in future. Enum etries can however be completely cleaned up, because InputMethod.ID was a sparse histogram (not an enum histogram) and these reverse mappings from numerical values to labels aren't exhaustive anyway. These removals are akin to adjusting the labels to 'unknown'. These removals only make interpretation of old data inconvenient. It's however unlikely we'd need to analyse data of deprecated InputMethod.ID metric that's no longer been recorded for the past 6 years. In the highly unlikely event we need to do so, repo history is at our disposal. Bug: 1150183 Change-Id: I3f274c038be1b334a4e49ccbef3bae518ede0019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546345Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#829569}
-
Kenichi Ishibashi authored
Before this CL, the callbacks of the following methods were passed directly to mojo remote calls: * UpdateLastUpdateCheckTime * UpdateNavigationPreloadEnabled * UpdateNavigationPreloadHeader As a preparation to support retry for these calls, this CL introduces ServiceWorkerRegistry::DidUpdateRegistration and passes it as the callbacks of remote calls. DidUpdateRegistration keeps the original callbacks and runs the callbacks when ServiceWorkerRegistry gets responses for them. DidUpdateRegistration also checks the result of remote calls. If it's a disk error, it schedules DeleteAndStartOver as the same as other DidXXX callbacks do. This CL doesn't add the retry mechanism for these methods yet. DidUpdateToActiveState is merged into DidUpdateRegistration because it does the same thing. Bug: 1133143 Change-Id: I50bd2f526c9cef03277ae2c3da81a6eb7aa8b63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550112Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829568}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605808617-3dd590b3717c834812eb8652d51332097d715185.profdata to chrome-win64-master-1605819430-f29c6c0acb8066d29cda4fb937b7ae2e0e828814.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id5a80fb4b5238839eb88ea125e490ba264c9092d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551306Reviewed-by:
-
Mason Freed authored
Per the comment, the allowable values come from the enum in feature_policy_features.h. There is no DisableForAll. TBR=iclelland@chromium.org Change-Id: I1509a66c570dbb0c2b34876019f965446f91093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551958Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#829566}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I8e0b2a9a0f23025110e3446410f43bff32cbfed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546505Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82b7546133db..7ab0cbf6d83f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: I0981d4eb895cb411c075a97608ed2a0471695c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829564}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eeca9c6ee7e1..330b60556789 2020-11-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie376592f49379729b41b1bb153a0df9a47db6e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551500Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ifd6d8ed0302fc7ef8d58cb6c8fcb125895e8c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546307Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829562}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I5ddea7c61bbe23ee599dfce9356c79a705e701fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550010 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch adds expected images of wpt/appmanifest/shortcuts-member/* imported on 2020-10-30[1] for linux_layout_tests_layout_ng_disabled bot. [1] http://crrev.com/c/507388 TBR=foolip@google.com Bug: 591099 Change-Id: I3892bc65297576b2efb6912b12aee4255a275508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551879Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829560}
-
Noel Gordon authored
A <script src=strings.js> is used in background page SWA fake to fetch load time data at start-up. The experimental SWA main.js has no script loader that the background page JS can use: create one in-situ. Minor: remove unneeded space from window.chrome.storage get: keys. Tbr: Alex Bug: 1113981 Change-Id: I352456080b85dfa7d75a201b96cd68e4993206e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550107Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829559}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a331d7926b7..6743d1edbf35 2020-11-20 ntfschr@chromium.org Devil: change test runner to use vpython If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Test: Test: ./devil/bin/generate_md_docsTest: Test: ./devil/bin/run_py_devicetestsTest: Test: ./devil/bin/run_py_tests Change-Id: I7cb72f5ce62c1dbaf290f23a99dec83ebfe4ed48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551581Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed289e777cfa..4f660f22d9eb 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 060020166679 to de9e649438ed (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I0921b3647f5fca9335f1b6856a2d9deb598b736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551332Reviewed-by:
-
Hiroshige Hayashizaki authored
Before this CL, for ModuleScript::RunScript(), we entered: - v8::HandleScope in ModuleScript::RunScript(), - v8::Context in ModuleScript::RunScript(), - v8::EscapableHandleScope in V8ScriptRunner::EvaluateModule(), and - v8::Context in V8ScriptRunner::EvaluateModule(). After this CL, we enter: - v8::HandleScope in ModuleScript::RunScript(), and - v8::Context in V8ScriptRunner::EvaluateModule(). This is to remove duplicated scopes and thus simplify the semantics: callers of V8ScriptRunner::EvaluateModule() should enter v8::HandleScope while EvaluateModule() enters v8::Context. Bug: 1111134, 1151165 Change-Id: I84be5b89038fa5fb9f20a36ac9e4996c0e3c7510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476693 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Noel Gordon authored
chrome_file_manager_private_test_impl.js is also being used to provide file manager private fakes to the file manager SWA app. The SWA has no MockVolumeManager, so move MockVolumeManager.resolveLocalFileSystemURL code into the normal (non-swa) if block at the top. Bug: 1113981 Change-Id: I2f7ba86fd8b28860e9319f6f3561b28d9d6fa8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551860Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829555}
-
Amr Aboelkher authored
The PSM helper function GetPrivateSetMembershipCachedDecision is returning the actual base::Value*, not its boolean content. When it's being assigned to a boolean variable directly, that indicates whether that base::Value* exists or not. This CL is getting the actual PSM cached boolean decision to be compared against Hash dance decision. It also makes the signature of GetPrivateSetMembershipCachedDecision function to be Optional<bool>. BUG=chromium:1150373 Change-Id: Id9340183f1c1e72d951a2476c591d25b45b9c088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545308 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829554}
-
Zain Afzal authored
getFile can throw a NotFoundError when called on a handle which has been moved or deleted, this cl adds explicit handling for the cases when this happens. BUG: b/172628918, b/172628918 Change-Id: Ie4dea3e667c821a0ac2d2b2c7e90a958eb4f0271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522802 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#829553}
-
Alan Cutter authored
This CL updates the Google Drive bundled manifest start_url to match what's served by the site: https://drive.google.com/_/AppsNotifyUi/manifest.json (Note that "/?lfhs\u003d2" is the same as "/?lfhs=2".) This maintains the "usp=installed_webapp" query param via launch_query_params. This needed to be fixed up to work properly for bundled manifests. Bug: 1058265 Change-Id: I39a2a5442d56153948c4c2ea1f6a75d1b58e7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#829552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b472168267a0..eeca9c6ee7e1 2020-11-20 ehmaldonado@google.com [owners][git-cl] Use owners client to show all owners for a file. 2020-11-19 ehmaldonado@google.com [owners] Implement GetFilesApprovalStatus for OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5ff5e3fdb080e392504dcd1d61230881b9329dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551722Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46107d3ece07..8930f18245df 2020-11-20 cclao@google.com Vulkan: Add feature flag to fallback rotation to use driver uniform 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 4fe17f3425ee to 3f73b676d6e8 (9 revisions) 2020-11-19 geofflang@google.com roll_aosp: Pass more forceful args to gclient sync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I1878c98fd78e90c31c59b00ad71c1652894cfc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551835Reviewed-by:
-
Mason Freed authored
The allow_shadow_root parameters were recently added [1] to the declarative Shadow DOM fragment parser APIs to provide an opt-in to avoid an XSS sanitizer bypass. However, to make these new changes more parallel to the existing getInnerHTML() API, which uses the plural "include_shadow_roots", the opt-in parameters will be renamed here. This CL also deletes some dead code from document_fragment.h. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530222 Bug: 1042130 Change-Id: Ic553316b799f1b1bfe64c8aa457b2d77b97951a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548181Reviewed-by:
-
Alan Cutter authored
This CL moves the app ID constants in default_web_app_ids.h out of the chromeos directory as chrome/browser/web_applications/components/web_app_id_constants.h. This is in preparation for Chrome Windows/Mac/Linux depending on these app IDs as they migrate their preinstalled Chrome apps over to web apps. See: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Bug: 809304 Change-Id: Iafcab362380a6cc5853dcfb1a57272f51b18a88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546674 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#829548}
-
Yao Xiao authored
This change propagates signals for sticky ad and overlay-popup ad detection from the renderer to the ads intervention manager through the subresource filter component. As the ads intervention manager is running in dry run mode and does not block ads, this allows us to record intervention behavior when triggered by one of these two interventions. Understanding the intervention behavior is a precursor to the ads intervention manager intervening to actively intervening on sites with better ads standard violations. Add base::Feature flags to allow disabling the frequency capping from either web_tests and browsertests. Move relevant tests into a virtual test suite that has the flag disabled. Bug: 1099741 Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#829547}
-
Robbie McElrath authored
This is a reland of d3f64670 Reason for reland: fixed junit test failures Original change's description: > [WebLayer] Update Fragment.getActivity() implementation. > > This CL updates the bytecode modifications we perform on > Fragment.getActivity() to have it call ContextUtils.activityFromContext( > getContext()), and modifies compile_java.py to detect compilation errors > related to this change and print a message pointing you to documentation > about the bytecode modifications. > > A compilation error will now print: > ../...../PasswordEntryEditor.java:144: error: cannot find symbol > getActivity().getSupportFragmentManager(), > ^ > symbol: method getSupportFragmentManager() > location: class Activity > Expecting a FragmentActivity? See docs/.......md > > Bug: 1123216 > Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828643} Bug: 1123216 Change-Id: Id03753fce7da29b914aa02217186b2bb8da5c83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547626 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829546}
-
