- 28 Jun, 2018 40 commits
-
-
Dave Schuyler authored
This CL fabricates a rich suggestion/new answer layout for calculator responses by creating a mimicking a suggestiondetails entry. Change-Id: I5fdc83b2f31d703e0ed8421e9be65233c9be2cb1 Reviewed-on: https://chromium-review.googlesource.com/1111460 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 6/27) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#571332}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2bdac0e55708bc7461041365ac736ad2c5bc7bc1 Reviewed-on: https://chromium-review.googlesource.com/1114204Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571331}
-
Pedro Amaral authored
Custom tabs don't have an overflow menu or menu wrapper which was causing a null pointer exception. This CL adds a null check. Bug: 857416 Change-Id: Ic2604bb7545cb1e94df6c9a720da74e7171e11c0 Reviewed-on: https://chromium-review.googlesource.com/1119150Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#571330}
-
Ryan Sturm authored
This call clears persisted state that is tied to navigation history. Bug: 797981 Change-Id: Ie0e2224f673b07ef6edc80e30f0cbb518dea0029 Reviewed-on: https://chromium-review.googlesource.com/1119157Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#571329}
-
Yuly Novikov authored
Pixel_OffscreenCanvasTransferBeforeStyleResize on Mac Intel HighSierra TBR=kbr@chromium.org Bug: 857578 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie29b7978a7328bb3c47f722bd695839aa76c1eca Reviewed-on: https://chromium-review.googlesource.com/1119070 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571328}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/5e83981..a5c263c Bug: 853978, 857303 Change-Id: I9cf554d30f5f51bcdca25f7fa6b1027312de0e77 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1117894Reviewed-by:
-
sczs authored
Previously history filtering was using selectRowAtIndexPath: to select the rows that were going to be filtered by the searchController. This caused that previously selected cells on edit mode were filtered out when searching. This CL introduces an Array to hold these indexes to filter out later. Also, when there're no results when search filtering, the emptyTableView shouldn't be displayed. Bug: 857088 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I40bd4e5181d84fc23edae1eeea64e899aa120d4f Reviewed-on: https://chromium-review.googlesource.com/1118909Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571326}
-
Nico Weber authored
The leak is now fixed. Bug: 855583,843511 Change-Id: Id8367b404108467783ac5e2c8c186b7ba210df4f Reviewed-on: https://chromium-review.googlesource.com/1117611Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ddf0ed7f771..e2d6bbca629c git log 7ddf0ed7f771..e2d6bbca629c --date=short --no-merges --format='%ad %ae %s' 2018-06-28 benjhayden@chromium.org Remove Test and TestMetadata indexes. Created with: gclient setdep -r src/third_party/catapult@e2d6bbca629c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia282d1c275ce6114148b0ac6e303932141452161 Reviewed-on: https://chromium-review.googlesource.com/1119325Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571324}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66c52be1969a..8bcc71ebebc5 git log 66c52be1969a..8bcc71ebebc5 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 xixuan@chromium.org chromeos_config: Mark reef as experimental. 2018-06-28 yueherngl@google.com octopus: mark paladin as important (not experiment) 2018-06-28 dhanyaganesh@chromium.org CreateTarball: Adding psutil based listening on directories to be tarred Created with: gclient setdep -r src/third_party/chromite@8bcc71ebebc5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854862,chromium:547055 TBR=chrome-os-gardeners@chromium.org Change-Id: I41a1df6c6122c1eb6d6c66cc415ae2518ba3356b Reviewed-on: https://chromium-review.googlesource.com/1119326Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571323}
-
Hitoshi Yoshida authored
This reverts commit aa1b9b70. Reason for revert: Just in case. There comes a concern from a reviewer. Original change's description: > bindings: Clear ScriptState self-reference at disposing worker global scope > > Each v8::Context is wired with a ScriptState, and it clears the > self-reference of ScriptState at its termination. > In worker threads, it means that ScriptState is kept alive until > terminating v8::Isolate, although ScriptState is not used after > disposing global scope. > > This CL explicitly does tasks in weak callback registered in v8::Context > at disposing global scope. Actual tasks are (1)to clear self-persistent > of ScriptState and (2)to drop a weak reference from ScriptState to > v8::Context. > This change makes it possible to release ScriptState at anytime before > v8::Isolate termination. > > > Bug: 773605 > Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7 > Reviewed-on: https://chromium-review.googlesource.com/1117976 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571107} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: Ibf5511ad731ec8c18ad2df32f24060e9be81ba86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773605 Reviewed-on: https://chromium-review.googlesource.com/1119425Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#571322}
-
Ned Nguyen authored
This reverts commit f02c92e1. Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315 Original change's description: > Reland "gtest perf tests: Output well formed test results json" > > This reverts commit 9eeaba4e. > > Reason for revert: Will re-land with fix > > Original change's description: > > Revert "gtest perf tests: Output well formed test results json" > > > > This reverts commit 71b865f4. > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > > > Original change's description: > > > gtest perf tests: Output well formed test results json > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > > test results json. > > > > > > Bug: 855234 > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#570943} > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 855234 > > Reviewed-on: https://chromium-review.googlesource.com/1118238 > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#571083} > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1118789 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571245} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1119445Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571321}
-
Kurt Horimoto authored
This is the TableView equivalent of ReadingListCollectionViewItem. This CL also consolidates logic shared between the table and collection version of these items into helper functions called by the mediator. In addition, the shared logic calculating custom accessibility actions for cells has been moved to a helper object owned by the table/collection views. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If6aed9d4ead9b167c8700e0db0c6c4dac5b6f132 Reviewed-on: https://chromium-review.googlesource.com/1104892 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571320}
-
Jacob Dufault authored
Bug: 854453 Change-Id: I7e1e187ce37a90036a4335ddd333f56b35bf1ac1 Reviewed-on: https://chromium-review.googlesource.com/1117709Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#571319}
-
Aleks Totic authored
Margins were being computed incorrectly in abspos_utils. Margins were not being copied to Legacy. The tricky part is that if node is using old block layout, strange margins get computed because of the way we enforce abspos child size: SetIsFixedSizeInline causes block layout to compute margins wrt that fixed size. The fix is to let Legacy block layout compute margins incorrectly, and set them to correct values afterwards. Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6e9354fdcad0e0703bd35ad849300be9f223f618 Reviewed-on: https://chromium-review.googlesource.com/1119078Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571318}
-
rbpotter authored
Fixing MaterialBookmarksDNDManagerTest.All and MaterialBookmarksStoreTest.All Bug: 738611 Change-Id: I651e9ad57dbd0bd6bf3b453ee2e5dc5a656773ec Reviewed-on: https://chromium-review.googlesource.com/1117891 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571317}
-
Pedro Amaral authored
The ic_search image is gray so that is why there is the black tinting. Change-Id: I51c9c56cf001b2df9a896c3367b9d6c100137f0b Reviewed-on: https://chromium-review.googlesource.com/1117768 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Aldo Culquicondor authored
We want all our rendering paths to use the same ganesh (GPU) provider. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I77deca35580ce552deed6219a10eea7f00d9eed2 Reviewed-on: https://chromium-review.googlesource.com/1119120 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571315}
-
Becca Hughes authored
Add UseCounter metrics for the Display Cutout pinch gesture and expose to UKM so we can cross reference events together. BUG=855739 Change-Id: I89da2effa938380fad5b065ede01e6b757ee17ca Reviewed-on: https://chromium-review.googlesource.com/1112724Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571314}
-
Mike Wasserman authored
ShellDelegateMash does not create a valid keyboard ui instance. TBR=blakeo@chromium.org Bug: 856235, 646565 Test: No keyboard crash on --enable-features=OopAsh device startup. Change-Id: I26ac1c13f46b839a4b77c6aaf478abec745126f1 Reviewed-on: https://chromium-review.googlesource.com/1119088 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571313}
-
Nico Weber authored
Bug: 857393 Change-Id: Ib852b5824b27443f7e1f5176646588fcbef195ed Reviewed-on: https://chromium-review.googlesource.com/1118857Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571312}
-
Jian Li authored
Bug: 852577 Change-Id: Icf852d1a7f454e623368fae5ecfeb523ee835bee Reviewed-on: https://chromium-review.googlesource.com/1119061Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571311}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc4b7b0fac1b5f321e362c86b59437d4a8869f53 Reviewed-on: https://chromium-review.googlesource.com/1119379Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#571310}
-
Donn Denman authored
Adds a new Feature to chrome://flags for Android to use to enable a modern version of the Full-roll animation. BUG=856792 Change-Id: I2b2369f509dd809e12c03bf4ac79c58e764799a4 Reviewed-on: https://chromium-review.googlesource.com/1116186 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571309}
-
Scott Chen authored
This CL provides a more encapsulated way to focus and select the text within cr-input. Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie1bf83d51fd706adc18b879251639c78381dc4fd Reviewed-on: https://chromium-review.googlesource.com/1114254 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571308}
-
danakj authored
If LayerTreeHost is destroyed while TextureLayer has a resource, it should return that resource, not marking it as lost, and not crashing. R=piman@chromium.org Bug: 857262 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e70dd4a17ca9e556d5332ee25d1fd567cb7dad7 Reviewed-on: https://chromium-review.googlesource.com/1119093Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#571307}
-
Matt Falkenhagen authored
Bug: 789577 Change-Id: I10cbc8ad7e7c1052ccabfcc9bc9328367a537faa Reviewed-on: https://chromium-review.googlesource.com/1118077Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3420de4a9ff..a782dcb3c407 git log d3420de4a9ff..a782dcb3c407 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 egdaniel@google.com Reland "Let client pass in full extension to GrVkBackendContext." 2018-06-28 benjaminwagner@google.com Add hello-opencl to BUILD_PRODUCTS_ISOLATE_WHITELIST 2018-06-28 timliang@google.com implemented getting format from texture as virtual in gpu caps 2018-06-28 egdaniel@google.com Reland "Move Vulkan DebugCallback code into tools." Created with: gclient setdep -r src/third_party/skia@a782dcb3c407 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Iedd600b7ce932c93b631fb2571251a4d0a7afda6 Reviewed-on: https://chromium-review.googlesource.com/1118815Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571305}
-
Chris Harrelson authored
Previously it only did so if the PaintLayer was stacked, but it is unclear why that is important. It also misses some cases, such as the test in this CL, which involves a PaintLayer move due to adjustment of continuations under a stacking context inline. Bug:857139 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03bda56e26f6adbabd2ca9492aced66c4c3483cb Reviewed-on: https://chromium-review.googlesource.com/1117926Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571304}
-
Xiaocheng Hu authored
r570447 already fixed the crash in fast/block/positioning/rtl-static-positioning-inline-block.html, and removed the crash expectation line. The crash line was added back in r571221 due to rebase errors. Hence, this patch removes the crash line. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ieba2a9138e47b5f2e0bb91bd0e387412c8a44d6e Reviewed-on: https://chromium-review.googlesource.com/1119152 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571303}
-
Charlie Harrison authored
In M67 we launched activation consumption at the start of main frame navigations. This was used to lock down a partial tab-under case: 1. Site begins to navigate itself to unwanted 3p content 2. Site subsequently launches a popup to the user's true destination This ended up breaking tab focus for navigations with target= that both navigate a different tab and focus it, since before UAv2 gesture state is process-global. This change fixes this bug by avoiding gesture consumption on navigation when the target is in a different page than the initiator. This behavior aligns with: - Behavior when the target is remote - Behavior when UAv2 ships (since gesture consumption is per frame tree) This change also removes the flag controlling gesture consumption as a feature, and moves some core implementation into blink. Bug: 856779 Change-Id: I29e26d5598e32517d025b0f44234e8b9b9a10e59 Reviewed-on: https://chromium-review.googlesource.com/1117028 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571302}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2a3058d0df03faba6b4975672ecfc3557c05d73a Reviewed-on: https://chromium-review.googlesource.com/1117863 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571301}
-
Mike Wasserman authored
Plumb views::WidgetDelegate::ShouldShowWindowTitle to the ws host frame. Move prop to aura/client for MusClient and DesktopWindowTreeHostMus. Make the KSV's delegate return false for ShouldShowWindowTitle. Based on Scott's CL (PS1 matches crrev.com/c/1112587 PS4) BUG=854324 TEST=covered by tests; No title in Chrome OS KSV (Ctrl-Alt-/) Change-Id: I190c8245edbb310a1f03f6ec6ad318b325be04bc Reviewed-on: https://chromium-review.googlesource.com/1113938 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571300}
-
Nicolas Pena authored
Change-Id: I1178f3f84f12b9d9d105f846ce732764aad5952f Reviewed-on: https://chromium-review.googlesource.com/1117750 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571299}
-
Yi Gu authored
TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I2326fc9bbce2224b1c8123e6a91125905b4d5235 Reviewed-on: https://chromium-review.googlesource.com/1119350Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571298}
-
Brian White authored
This reverts commit 4eb39392. Reason for revert: Testing complete. All crashes I looked at showed non-zero values at address zero. Pages are not all zeros so the problem isn't a whole page being cleared. Original change's description: > Check theory that entire mmap page is getting zeroed. > > This is a temporary change that will be reverted once crashes can be > analyzed to confirm the working theory. > > Bug: 836875 > Change-Id: Iaeffbd6c78b604af66b33991392990d71648d4a9 > Reviewed-on: https://chromium-review.googlesource.com/1050071 > Commit-Queue: Brian White <bcwhite@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557159} TBR=asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836875 Change-Id: If65d667029c8f3a1f82dec35c878a32dc96b8343 Reviewed-on: https://chromium-review.googlesource.com/1118826 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#571297}
-
Aleks Totic authored
Added "Unexpectedly flaky" filter. Color unexpected results in red/green for greater visibility. Added "?" shortcut that blinks image failure differences. Added "p" shortcut that prints current expectation to console. Bug: 726520 Change-Id: I14be5b3ec2b86a113dff0e0087ac57332519c108 Reviewed-on: https://chromium-review.googlesource.com/1118004 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#571296}
-
Elad Alon authored
When a remote-bound WebRTC event log is successfully started, its ID is sent to the calling JS code. This ID is incorporated into the log's filename, allowing it to later be retrieved, e.g. if a bug report is submitted. Bug: 775415, 829748 Change-Id: Ie3d68b7b9cf6ee94eb468135ad5e25caf3204603 Reviewed-on: https://chromium-review.googlesource.com/1116958 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571295}
-
Ryan Landay authored
This reverts commit cb125363. Reason for revert: crbug.com/857447 Original change's description: > Fix some math in Android tab_layer.cc causing tab cropping > > Currently, even if Stack#getMaxTabHeight() returns the maximum possible value > (beyond which it's clamped to that value), we crop the tabs in the Android tab > switcher somewhat when we scale them down. The overlapping tab switcher uses 90% > scale, where this is not very apparent. It is apparent, however, in the > nonoverlapping tab switcher, where we use 60% scale if there's more than one tab > (we use 80% if there's only one). > > The root cause here is there's some odd/incorrect math that's causing certain > sizes to not scale properly with the tab scale, so we actually end up cropping > the tab too high and drawing the bottom border too high when content_scale < 1. > After fixing that, it turns out that there's a small gap that appears between > the tab thumbnail and the bottom border. I resolved this by raising the bottom > border up by an amount equal to its own height. So there's still some cropping > on the bottom of the tab with this CL, but it's an extremely small amount. > > Bug: 849401 > Change-Id: I06c20e4a881e2d7a5b38bfc9e95ef8522c7c3921 > Reviewed-on: https://chromium-review.googlesource.com/1115777 > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570993} TBR=dtrainor@chromium.org,rlanday@chromium.org Change-Id: Ia4537e0d69a4e40d35751854cfc33cb428c9ac4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849401 Reviewed-on: https://chromium-review.googlesource.com/1119307Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#571294}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/37c0f8c6bbd2..66c52be1969a git log 37c0f8c6bbd2..66c52be1969a --date=short --no-merges --format='%ad %ae %s' 2018-06-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@66c52be1969a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I65f8ad06ee02ba38f63de8df7d16eddf4a26afa0 Reviewed-on: https://chromium-review.googlesource.com/1118810Reviewed-by:
-
