GitLab

Moves one more method from PersistentPrefStore to WritablePrefStore. This allows most "writing" operations to be possible without the more complex PersistentPrefStore API.

BUG=None

Review URL: https://codereview.chromium.org/389333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282967 0039d316-1c4b-4281-b951-d872f2087c98

Whenever a video playback finishes, the users are required to manually
skip to the next video on the list. This patch enables the next video to
be loaded automatically, but only if the current one is not playing in
loop mode.

BUG=393318
R=yoshiki@chromium.org
TEST=manually tested
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>

Review URL: https://codereview.chromium.org/385113007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282966 0039d316-1c4b-4281-b951-d872f2087c98

Reported from the compositor thread.

BUG=253919

Review URL: https://codereview.chromium.org/375093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282964 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/350183002/

This CL renames (hopefully) all remaining C++/ObjC code apart from CrOS-specific code.
It also renames a test data folder.

Still missing:
- ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/
- JavaScript, HTML, CSS
- The global ENABLE_MANAGED_USERS define

TBR=msw@chromium.org (c/b/ui)
TBR=atwilson@chromium.org (c/b/sync)
The TBRs are simple renames.

BUG=385113

Review URL: https://codereview.chromium.org/384023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282962 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes libaddressinput_util.h, which was left over after a
bad merge. This file is identical to addressinput_util.h.

TBR=estade@chromium.org
BUG=393587

Review URL: https://codereview.chromium.org/392633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392016

Review URL: https://codereview.chromium.org/368243009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282960 0039d316-1c4b-4281-b951-d872f2087c98

Previously we used a single blacklist file per sanitizer. The same file was used
for Chromium and for every instrumented package. This change allows choosing a
different blacklist file for each package, which means that package targets may
now depend on the blacklist files, avoiding expensive clobbers.

This CL also blacklists two known issues in instrumented libraries.

BUG=313751, 367509
R=glider@chromium.org
NOTRY=true
TEST=MSan interactive_ui_tests, ASan compile

Review URL: https://codereview.chromium.org/390093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393346
R=yoshiki@chromium.org
R=bauerb@chromium.org
TEST=Manually tested with external USB keyboard
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>

Review URL: https://codereview.chromium.org/385263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282948 0039d316-1c4b-4281-b951-d872f2087c98

Also optimize the swapends function.

R=mark@chromium.org,rsleevi@chromium.org,yukawa@chromium.org
BUG=348333

Review URL: https://codereview.chromium.org/382423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282946 0039d316-1c4b-4281-b951-d872f2087c98

This removes all the unnecessary stuff. Only base and url libraries are
necessary to compile data_element.cc.

BUG=None
TEST=None
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/392503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282945 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an API so that the platform can clear the HTTP auth cache
at will. This can be useful when clearing private browsing data to prevent
cached credentials from being re-used.

BUG=63723

Review URL: https://codereview.chromium.org/351833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282944 0039d316-1c4b-4281-b951-d872f2087c98

Calling DecryptWithSystemSalt() with an empty string results in a WARNING in the log.

BUG=393341

Review URL: https://codereview.chromium.org/384383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282943 0039d316-1c4b-4281-b951-d872f2087c98

> Make the policy fetch for first time login blocking
>
> The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users.
>
> BUG=334584
>
> Review URL: https://codereview.chromium.org/330843002


Reason for revert:
The "Linux Chromium OS ASan LSan Tests (3)" tester found memory leaks.

TBR=kaliamoorthi@chromium.org

Review URL: https://codereview.chromium.org/390843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282942 0039d316-1c4b-4281-b951-d872f2087c98

Basically DriveEntryKind is used for clasifying files into one of {Folder, Hosted document, Normal file}.
We can classify them without DriveEntryKind by using FileResource::IsDirectory() and their mime type.
Utility functions for clasification are now indepenent with ResourceEntry, and placed in drive_api_util.h.
ResourceEntryKind is defined to provide users of ResourceEntry (e.g. sync file system) with similar accessor to file kind.

BUG=357038
TBR=rogerta@chromium.org for one line removal in .gyp file and .gn file.  
TEST=run google_apis_unittests and unit_tests

Review URL: https://codereview.chromium.org/384543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/389983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282940 0039d316-1c4b-4281-b951-d872f2087c98

Cleaned up a couple of spaces and also make sure the local storage
mechanism handles first time visits by checking for null instead of 'undefined'
since localStorage.getItem(key) returns null when it cannot find the key[1]. 

[1]http://www.w3.org/TR/webstorage/#dom-storage-getitem

BUG=NONE
TEST=Manual, setup P2P call
NOTRY=TRUE

Review URL: https://codereview.chromium.org/384353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282939 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit_tests --gtest_filter="LocalFileChangeTracker.*"

Review URL: https://codereview.chromium.org/391653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282938 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282937 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178038:178042&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282936 0039d316-1c4b-4281-b951-d872f2087c98

In PasswordManager::ProvisionallySavePassword, PasswordFormManager instances are sought, which could be managing the form being saved. Some of those managers may not be ready, because they still did not complete matching against the PasswordStore. There might also be more form managers suitable for the form being saved, with some having completed the matching, and some not.

Currently, the code first finds the first suitable form manager, and then drops it if it has not completed matching. This ignores the fact that there might be a second choice form manager, which has completed matching. This happens currently on live.com (see the bug).

This CL ignores form managers which did not complete matching when looking for a suitable form manager for the form being saved.

This CL also improves a poorly phrased log message related to the situation when form managers have not completed matching.

BUG=367768

Review URL: https://codereview.chromium.org/331593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282935 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends task throttling algorithm to multiple task case.
Comparing to previous algorithm, new one backs off the throttling duration by elapsed time.
So that consecutive failure doesn't throttle the next task too long time.


BUG=344769
TEST=unit_tests --gtest_filter="SyncProcessRunnerTest.*"

Review URL: https://codereview.chromium.org/386523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769
TEST=unit_tests --gtest_filter=LocalFileChangeTrackerTest.DemoteAndPromote

Review URL: https://codereview.chromium.org/386373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282933 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282932 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/389263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282931 0039d316-1c4b-4281-b951-d872f2087c98

The zoom is reset when it goes into the edit/mosaic/slideshow modes.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/392543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282930 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282929 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178021:178037&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/384553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282928 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393345
TBR=stevenjb@chromium.org,tbarzic@chromium.org

Review URL: https://codereview.chromium.org/389933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282926 0039d316-1c4b-4281-b951-d872f2087c98

The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users.

BUG=334584

Review URL: https://codereview.chromium.org/330843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282925 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorker is designed to delay stopping the worker thread (30 sec) when all
controlled documents are closed so that the next navigation can save the startup
time.

In the current code, this improvement also applies to the unregistration with no
controllees, but in that case we should immediately stop the thread because the
worker doesn't work anymore.


BUG=392735,393127
TEST=content_unittests --gtest_filter=ServiceWorker*

Review URL: https://codereview.chromium.org/385143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282922 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282921 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178013:178020&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/384033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282920 0039d316-1c4b-4281-b951-d872f2087c98

Gcc 4.9 has a bug in reporting false positive array out of bound
warning. This cl adds progma to disable the warning.

BUG=chromium:392872
TEST=The warning is gone.

Review URL: https://codereview.chromium.org/384843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282914 0039d316-1c4b-4281-b951-d872f2087c98

    
ScriptExecute has changed to ScriptLoader.
(crrev.com/18261015)
HTMLElement::setInnerHTML has changed to Element:setInnerHTML.
(crrev.com/44333002)
CachedResource has changed to ResourceFetcher with cached property.
Node::createRendererIfNeeded is deprecated and replaced to
[a-zA-Z0-9_]*Element::createRender.
    
Bug=None
NOTRY=True

Review URL: https://codereview.chromium.org/392443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282911 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282909 0039d316-1c4b-4281-b951-d872f2087c98

Unable to reproduce locally even on a Debug build. Reverting the revert and
monitoring carefully.

> Revert 282890 "[fsp] Add an option for mounting in R/W mode."
> 
> > [fsp] Add an option for mounting in R/W mode.
> > 
> > Files app fetches information whether a volume is read only or R/W from
> > file_manager::VolumeManager, which used to always have the isReadOnly option
> > set to true for any provided file system.
> > 
> > However, since R/W operations are now under development, we should be able to
> > mark a volume as R/W.
> > 
> > In order to achieve that, a "writable" option has been added to the File System
> > Provider API mount() call. The argument is by default false, so file systems
> > are by default read only.
> > 
> > TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
> > BUG=391362
> > 
> > Review URL: https://codereview.chromium.org/372163006
> 
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/391613002

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/389243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282908 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this change is to disable the menu for write-protected
SD cards that anyhow fails to format.

Strictly speaking this is excessive, because there may be a volume with
read-only file system that still is formattable. We however assume that
the practical need for the case is low (see discussion in the BUG.)

BUG=334108

Review URL: https://codereview.chromium.org/386333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282907 0039d316-1c4b-4281-b951-d872f2087c98

A no-cache loaded page should still have registration capability. If
the document URL is not set, the registration will fail with "SecurityError".

BUG=392405

Review URL: https://codereview.chromium.org/362183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282906 0039d316-1c4b-4281-b951-d872f2087c98