- 15 Dec, 2020 40 commits
-
-
Emilio Cobos Álvarez authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/d4UdwpPDXJM/m/J-o_C_kqAwAJ Fixed: 1086855 Change-Id: Ib37d2d8bf4a983ce93445ca0efdf765d3f98935f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584810 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#837061}
-
sebsg authored
Bug: 1158587 Change-Id: I3e58732dd4eccaa1ec05ea028433c4bc09878bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591409 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#837060}
-
Robbie Gibson authored
When using the thumb strip, when the user is in the tab grid, they can swipe the BVC up from the bottom of the screen to go back to it at any time. Because of this, when switching tab grid pages, the BVC at the bottom of the screen has to switch as well. In general, the idea is that the BVCContainerViewController will always be present. In the tab grid, if the user is on a page with a tab, it the container will have the appropriate BVC. If they are on a page without a tab (Recent Tabs or incognito with no open incognito tabs), it will have no BVC but still be onscreen, ready to be filled. All of the tab grid/scene controller presentation methods now take an additional argument of whether to dismiss the tab grid after activating the given Browser/UIViewController. This allows the tab grid to request changes to only the active BVC without leading to dismissal of the tab grid. Bug: 1094335 Change-Id: I876ccaf01416caccc3bb85cccc5701527a45840a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577462 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837059}
-
Elizabeth Popova authored
Prior to this CL, dependent locality was a part of address scheme, but was never detected in forms by Autofill. The missing parsing is implemented behind kAutofillEnableDependentLocalityParsing flag. Bug: 1154727 Change-Id: I1c3869549b0aca9f803c88d733239ed1414abc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584843 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#837058}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/47ad0e88719e..0ca983b04e6b 2020-12-15 jacktfranklin@chromium.org Disable legacy patching in Lighthouse If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fa4d71b6fa5a5843c3a17b309f9bbaf87376bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837057}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03894b364c7d..d9efbf74cf61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: treib@google.com Change-Id: Iea71419e21c02d384c59f93be1726ea5d3d93da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837056}
-
Ewann authored
This CL fixes the background color of ChromeTableViews. Bug: 922511 Change-Id: I47662d867da44444902de17c40a399c9b20f4399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593111Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#837055}
-
Benoit Lize authored
This reverts commit 8724c134. Reason for reland: Updated the tests. iginal change's description: Original change's description: > [PartitionAlloc] Don't perform expensive allocations to fill the thread cache. > > Bug: 998048 > Change-Id: Ie18db70f78188e4541aa4d5a0f44da2ce166524e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569664 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833771} Bug: 998048 Change-Id: I8bf3543b248eb2ddc30fc2b73342470b06208cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574855 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837054}
-
Xida Chen authored
This CL converts the base::Bind in this file to base::BindOnce. There should be no behaviour change. Bug: 1152278 Change-Id: I7b3e30d51bd7d33de64458b163bb0fdbb14151fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585819Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837053}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a349be15. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I9f956b521b986568d1810454095bfc164f60da65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592131Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837052}
-
Marc Treib authored
This reverts commit 645c8058. Reason for revert: Appears to have broken PhysicsBasedFlingCurveBrowserTest.TargetScrollOffsetForFlingAnimation, see crbug.com/1158664 Original change's description: > Make sure lifecycle updates proceed enough for IntersectionObserver > > IntersectionObserver may require sticky position information, so if > a lifecycle update is forced by IntersectionObserver, make sure it > proceeds far enough to update sticky position. > > As noted in the code comments, even if sticky position update is > moved up to the layout phase (which is planned, I think), if the > document is servicing any IntersectionObservers with > track_visibility=true (i.e. V2 features), then we will still need to > force the lifecycle update to continue far enough to enable hit > testing. That's the root cause of the bug. > > Bug: 1156937 > Change-Id: I809d822d7abf0789aea97113bc87907fdd11b345 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583159 > Commit-Queue: Stefan Zager <szager@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836900} TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic75ec8f9d9b3d075c16f26718df781d377676bc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156937, 1158664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593096Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#837051}
-
Marc Treib authored
Tbr: petermarshall@chromium.org Bug: 1046784 Change-Id: I075a6331f966f5f362a624210e70dc20600b71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592993Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#837050}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb8903b14336..1bfc1c90a146 2020-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0c234289 to 5a03bdd6 (963 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ice977fdbd8e3ae2b1b890d8f973a5364c6d860b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593051Reviewed-by:
-
Hitoshi Yoshida authored
We design IDL dictionary members separated from IDLOptional, and hence we use IDLOptional only in arguments. This CL makes a utility function native_value_tag to output IDLOptional iff its target is an argument. Bug: 839389 Change-Id: I3b95e870b38ed4e1917408cac0a923a17db88307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589233Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#837048}
-
Ben Mason authored
This reverts commit 938da203. Reason for revert: Trialing this configuration again. Original change's description: > Ensure WebView 64_32 target uses 32-bit abi as default. > > Chrome will run in 64-bit, but WebView will run in > 32-bit mode by default. > > Change-Id: Idc240b62a5c18c9109c02853459c073e4c53d851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536784 > Commit-Queue: Ben Mason <benmason@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828936} TBR=rmcilroy@chromium.org,torne@chromium.org,rmcilroy@google.com,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9a0251f06a83159fded60f9e0a53f240d177ec64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593093Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#837047}
-
Koji Ishii authored
Also change |NGInlineChildLayoutContext| to own |NGFragmentItemsBuilder| because it is always needed when |FragmentItem| is enabled. This simplifies allocations and call sites slightly. Bug: 1154531 Change-Id: I7458f80978bc9ef7348fb6836f44ca9adf4574f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592568 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#837046}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af081e82fec2..47ad0e88719e 2020-12-15 petermarshall@chromium.org Fix line height in service worker view 2020-12-15 wolfi@chromium.org [Issues] Add UMA metrics for which types of issues are created 2020-12-15 sigurds@chromium.org Factor out AffectedResourcesView to its own file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072335 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ab9a035e87c338925481d8f40b240827deba847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593054Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59570b2d..bf6b965f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78f1bce5023a1059867393d47d477f20f853c0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837044}
-
Wei Lee authored
To enable CCA on guest mode, CameraAppWindowManager cannot be a KeyedService since it does not work under guest mode. Therefore, this CL changes CameraAppWindowManager as a singleton object. Bug: b/172343942 Test: Manually Change-Id: Ia4e8970e2e2083af6db58f20d22f00ab17f20b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592184 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837043}
-
Rainhard Findling authored
Bug: 1152336 Change-Id: Id5c0474e3ce8affdd42c33139ffa28f7d99aa9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584851Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837042}
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachineTest to signin.ui target. Bug: 1156609 Change-Id: I8ebcd3384e29b43c13dec3320fbb9b75c2c05182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587064 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837041}
-
Eugene But authored
Bug: 688063 Change-Id: I85ab8f46cca8570c7807b12f1f57a2cbf90c2c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590551 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
PrerenderContents::SetPrerenderMode() is called with mojom::PrerenderMode::kPrefetchOnly right after an instance of PrerenderContents is constructed. For code simplification, that should be set in the constructor instead of the public setter function. Historically, the setter function was meaningful because that can be called with another value of mojom::PrerenderMode ("kPrerender") but that was removed due to deprecation of the legacy prerender. Bug: 755921 Change-Id: I01d9987765411ef79d8596c71a14d3d9674dcbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589574Reviewed-by:Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837039}
-
Michael Checo authored
- In the nearby onboarding sharesheet, the device name field is not autofocused when the page appears. To fix the issue, This CL adds a call to RequestFocus() when building up the sharesheet's UI. Bug: 1156395 Change-Id: Ibd3db9a5e0d51521a259b38f70cd741d6c1597c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582815 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#837038}
-
Devon O'Brien authored
Change-Id: Id635635a4ebb9b525c3027b363d91a886d5fb65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552759Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Cr-Commit-Position: refs/heads/master@{#837037}
-
Christoph Schwering authored
The feature is enabled by default and is not subject to an active experiment. Bug: 1007974 Change-Id: I9898e020efdae18170ad2146d20ccb0afbd1b22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409897Reviewed-by:
-
arthursonzogni authored
Due to a bug, the sandox_flags computed from the browser process were taking into account the Content-Security-Policy:sandbox of the original response, even for error pages. This fixes the bug and add regressions tests. Bug: 1158370,1158306 Change-Id: Idc1c575b0a4e578542c66b3f7153c6dac5d1e43d Fixed: 1158306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587047 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#837035}
-
Shik Chen authored
This reverts commit c7326b7f. Reason for revert: https://crbug.com/1157151#c20 and http://b/175665181 Original change's description: > Use skia.mojom.BitmapN32 in Detection mojoms > > These bitmaps are safer for transport from untrustworthy sources since > all bitmaps should be in N32 format and the browser can make bad > assumptions as a result. > > R=dcheng@chromium.org, reillyg@chromium.org > > Bug: 1144462 > Change-Id: I7d02cb187c62be37259f445a182f8c971aa03661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580483 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835685} TBR=danakj@chromium.org,dcheng@chromium.org,reillyg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144462 Change-Id: I5c90bd0f3765590612d29938899659f1bf51a2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591841Reviewed-by:
-
Marc Treib authored
This reverts commit e2eec62f. Reason for revert: Depends on crrev.com/c/2586246 which needs to be reverted, see crbug.com/1158739 Original change's description: > Remove pre-initialization OptimizationGuideKeyedService logic > > In practice, this doesn't happen at all and cannot happen at all after > the incognito CL goes in > > Change-Id: I0daf1c4cbb189840913ee4a368dda437e07efaca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587396 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836699} TBR=sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2710ea9316e355c8e435d185f49828a11974a0c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593108Reviewed-by:
-
Kuo-Hsin Yang authored
When PSI memory pressure is high, triggers the moderate memory pressure. Add feature flag CrOSLowMemoryNotificationPSI. BUG=b:159299004 TEST=check moderate memory pressure is triggered properly when using \ disk swap. Change-Id: Iba533d5e4733619e2df7480eb2851b955b7ec99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428503 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837032}
-
Vaclav Brozek authored
When a GURL's path is canonicalized, the code is trying to handle nested escape sequences. It keeps the index of the last seemingly invalid "%" in a variable called last_invalid_percent_index, so that ssequences like "%%41B" can be transformed to "%AB". However, it can happen, that an already output part of the path is invalidated and cut off, such as in "abc/../", which is equivalent to "". The bug in the current code is that last_invalid_percent_index is not reset if the part of the output which it points to gets invalidated. This resulted in the mysterious inserting of the hex code of "%" in the middle of the escape sequence of ">" when canonicalizing the path "5%/../>%41". This CL simply makes sure that last_invalid_percent_index is reset whenever it points beyond the end of the current output. Bug: 1080890 Change-Id: I04a5246ecbb66b645d796ec88babd74383d18661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587060 Auto-Submit: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837031}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/691fc1df0d5c..03894b364c7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: treib@google.com Change-Id: Id53e089e73be7e7bb9488a99c793d43b3922bf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593068Reviewed-by:
-
Ahmed Mehfooz authored
This CL refactors previous animations for tray background views to use layer transforms and also adds a new bounce animation to be used for holding space and screen recorder tray buttons. Bug: 896739 Change-Id: I29ce064d44eda7ebb3b98f856ba9b2171be0c549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589454 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837029}
-
Maggie Cai authored
Currently when we share files to ARC, it does not accept any extra data. However, with the web share support, it is possible to share files with title and text. This CL adds the support to share extra strings to ARC. BUG=1127670 Change-Id: I2eeaf4199ad1c2df94be77df0574f046c26f1f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589200Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#837028}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2584978 Re-enable tests CL: https://crrev.com/c/2587035 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: Ifbf983bd55c181a2cff6582128a1de167c851c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584848 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#837027}
-
Javier Fernández García-Boente authored
The original test we landed in r824804 was not using the property we wanted to test (white-space: pre-wrap) and there was no space at all, which was key to reproduce the issue. This CL updates the test, keeping both expected files, since FF needs an alternate result due to collapsing trailing spaces. It's worth mentioning that FF fails with this new test, but I think it's due an actual FF bug. Bug: 316409, 1142926 Change-Id: I6eafcf5edc5350c6ccfd227d5cc89ef2b47ed1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573081Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#837026}
-
Eugene But authored
Bug: 688063 Change-Id: I274b578a76090f7bbd1a608fcd3da2d704e11fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591882 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit b8cd7ece. Reason for revert: Seems to have broken NearbyPreviewTest.All on linux-chromeos-dbg, see crbug.com/1156833 Original change's description: > [Nearby] Add GetShareType to Attachment. > > Moves the logic for determining the ShareType into the *Attachment > classes. This cleans up some static casts and also allows this logic to > be reused when generating the preview for the receive dialog page, > coming in a subsequent CL. > > To avoid a dependency cycle I've moved the ShareType mojo struct > definition into its own build target, which required importing new mojo > gen files in a number of places. > > Fixed: 1144942 > Change-Id: I7fe151470c9067a918363152d2e0520a08dc0298 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582523 > Commit-Queue: Michael Hansen <hansenmichael@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#836953} TBR=khorimoto@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,ajgo@chromium.org,vecore@google.com,hansenmichael@google.com Change-Id: I1c7f146adaf4bf76a032a1fe7a469fcd6a05ee65 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592991Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2e0f172ecff..af081e82fec2 2020-12-15 wolfi@chromium.org Rename BlackboxManager.js to IgnoreListManager.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifaa8dbdb28f6c5f2e21100962899ee90df6344c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593167Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a03bdd6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iac39778157981cba26425b6d8a5c6badd53a1359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592130Reviewed-by:
-
