- 15 Dec, 2017 40 commits
-
-
Henrik Grunell authored
This reverts commit 613ce4af. Reason for revert: Breaks linux-chromeos-dbg bot (https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3205) Original change's description: > Remove |mode| from ChromeVox > > ChromeVox Classic is no longer available to users. > This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc). > > This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop. > > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ic9270ab7e3cc3ba734f21bc84c00738bb0d43e56 > Reviewed-on: https://chromium-review.googlesource.com/825169 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524343} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: Ic60ba55115d1788dd392fde31997beee13f5fe3f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/828735Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524358}
-
Daniel Bratell authored
To avoid clashes between test data variables and similar changes, this patch puts tests that would collide in custom namespaces following a pattern used successfully in Blink. content unittests needs about 60 CPU minutes to compile normally. With jumbo that can be brought down to 4-6. Bug: 746953 Change-Id: Ic573361fed81bbd46a97823e9761f94088d51814 Reviewed-on: https://chromium-review.googlesource.com/826637 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524357}
-
Daniel Cheng authored
This allows mocking of TimeTicks inside Blink once WTF::TimeTicks is merged into base::TimeTicks. base::TimeTicks::Now() will be explicitly disallowed in Blink to ensure that there is a consistent global view of the mocked time ticks. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I356da09d27694c4d4323a8b494a2afef6a80baf3 Reviewed-on: https://chromium-review.googlesource.com/827545Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524356}
-
Siddhartha authored
There is flakiness on bots that show features in gmail failed to load. So, re-record in case the bug was fixed in gmail. BUG=750147,776889 Change-Id: Ie9d6be28d5d6e8de3bda54ed5418786665d67c4d Reviewed-on: https://chromium-review.googlesource.com/822510 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#524355}
-
Olivier Robin authored
When autofilling credit card, the CVC prompt View disables the webState. JS processing may be different when view is not visible. This makes some sites like walgreens.com flaky. This CL queue the JS if the webState is not visible and executes it after |webStateWasShown| is called. Bug: 728606 Change-Id: I7a9ffd5e15d403a7faf9f7f4f4151371474676d5 Reviewed-on: https://chromium-review.googlesource.com/817277 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#524354}
-
yoshiki iguchi authored
Previously the width was 362px, which is 360px (notification width) plus 2px (notification border). This CL removes the border and shrinks the width of sidebar by 2px. Bug: 726250 Change-Id: Iae5a14a9057561223e5e2afe39fee840a3073de1 Reviewed-on: https://chromium-review.googlesource.com/825042 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524353}
-
Aleks Totic authored
The reason for this change is test failure: fast/block/positioned-bottom-margin.html <style> #abs { position:absolute; width:auto; height:auto; top:0px;bottom:0px;left:0px;right:0px; min-height:200px; } #mrg { height: 1000px; margin-top: 50px; margin-bottom: 50px; } </style> <body> <div id="abs"><div id="mrg"></div></div> </body> In this document, #mrg margin affects body overflow. The overflow is computed by Legacy code ComputeOverflow() ComputeOverflow() uses margin structs stored on Legacy. I've talked to Ian about it, and he suggested this change. It fixes this bug, and lots of grid ones, with 2 new border-image failures. I do not understand this code well, WDYT about always calling SetMargin() Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I29816e4bea210d63874124a50a65b7001525d752 Reviewed-on: https://chromium-review.googlesource.com/827548Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524352}
-
Jens Widell authored
This avoids collisions in jumbo/unity builds. Change-Id: Ibd47b3c0be950c6f9fb5baf206612203c99e9b35 Reviewed-on: https://chromium-review.googlesource.com/827132Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#524351}
-
Zhuoyu Qian authored
This patch makes EFillSizeType to be an enum class for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I61fd98a1fd15ae4b1dbbd39bfe68d1776cfb4df1 Reviewed-on: https://chromium-review.googlesource.com/828182Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524350}
-
Donna Wu authored
Define mojo format MtpFileEntry to mirror the MTP protobuf message. Use this struct in MediaTransferProtocolManager and related code. This is a preparation work for MTP servicification. BUG=769630 Change-Id: Ia01f5bc7c00fdcc258f50ae02e7a375caa83d6c9 Reviewed-on: https://chromium-review.googlesource.com/812964 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524349}
-
Zhuoyu Qian authored
As the comment in PluginView.h by joelhockey@, The only implementation of class PluginView is WebPluginContainerImpl, remove PluginView, use WebPluginContainerImpl directly. BUG= Signed-off-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/069dd4fa6b05..41d9d87e9653 $ git log 069dd4fa6..41d9d87e9 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 iannucci [recipe_modules/depot_tools] Add on_path helper. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I380050b47934f68e2f6045ce1bff050a286d05d3 Reviewed-on: https://chromium-review.googlesource.com/827572Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524347}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I41835980c53b4a509f339a0af71868724633b152 Reviewed-on: https://chromium-review.googlesource.com/827986Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524346}
-
Thomas Guilbert authored
The ChromeCastSessionManager's purpose is to manage the lifetime of CastSessions, and to notify the appropriate MediaRouteProvider when their CastSession's state changes (via the ChromeCastSessionObserver interface). This CL adds the ChromeCastSessionManager, decouples CastSessionImpl from CastMediaRouteProvider, decouples MediaRouteProviders from CreateRouteRequest, and extracts CastListener from CreateRouteRequest. It also moves the logic of stopping the current session out from the MediaRouteProvider into the manager. Bug: 790766 Test: Added UTs Change-Id: I2177c9f6918fc572b0c70df01411c574cda98fec Reviewed-on: https://chromium-review.googlesource.com/794711 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#524345}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7f846f273cea..800f5541bb0f $ git log 7f846f273..800f5541b --date=short --no-merges --format='%ad %ae %s' 2017-12-15 reed Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Idc0b62e57da2fd972b5acedcae76c4c3fcf15bdc Reviewed-on: https://chromium-review.googlesource.com/828697Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524344}
-
David Tseng authored
ChromeVox Classic is no longer available to users. This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc). This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9270ab7e3cc3ba734f21bc84c00738bb0d43e56 Reviewed-on: https://chromium-review.googlesource.com/825169 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524343}
-
Darren Shen authored
Currently CSSSkew and CSSPerspective do not accept calc values (CSSMathValues) because it requires type checking the calc value to see if they match the right type. Since type checking and matching are now implemented, we have all the machinery to accept CSSMathValues too. This patch uses CSSNumericValueType.Matches* functions to check if the CSSNumericValues passed in resolve to the right type. We also (re)moved some DCHECKs. We also deelted redundant tests in inlinestyle/properties/transform.html Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssperspective-cssperspective https://drafts.css-houdini.org/css-typed-om-1/#dom-cssskew-cssskew Bug: 789370 Change-Id: Ice30511b022885004a3a13cca21c8316dd82a271 Reviewed-on: https://chromium-review.googlesource.com/828001Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524342}
-
Hwanseung Lee authored
CSSMatrixComponentOptions's is2D should be not have default value present, it has default value as false. when second paramter is not CSSMatrixComponentOptions in CSSMatrixComponent's constructor, is2D will be false. it seems work well like spec but it was not match spec. so sync up with spec. https://drafts.css-houdini.org/css-typed-om-1/#dictdef-cssmatrixcomponentoptions Bug: 795151 Change-Id: Ib6ac6ad3793b029d079f50d787994b4bf058b7fe Reviewed-on: https://chromium-review.googlesource.com/824282 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524341}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/3dad0ccfee63..51f8305b51e9 $ git log 3dad0ccfe..51f8305b5 --date=short --no-merges --format='%ad %ae %s' 2017-12-08 vovoy Fix tracing CPU slices overlapping Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iad3a1e837e0747b3e5f3fad144a8055a9b155aab Reviewed-on: https://chromium-review.googlesource.com/828472 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524340}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/760ef9c24a40..069dd4fa6b05 $ git log 760ef9c24..069dd4fa6 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 iannucci [bot_update] Put depot_tools at the end of $PATH on LUCI. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Icd7fa7972c0e65b4907f473aa8207522840aeb3e Reviewed-on: https://chromium-review.googlesource.com/827937Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a088365e2fac..7f846f273cea $ git log a088365e2..7f846f273 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 reed remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I01a2785ce52948803987e6c3bfbd16b33383da7b Reviewed-on: https://chromium-review.googlesource.com/828405Reviewed-by:
-
Albert J. Wong authored
This reverts commit 8c29b757. Reason for revert: <INSERT REASONING HERE> Original change's description: > Enable frame pointers on arm32. > > LLVM fixed the bug where framepointers were not located next to the return > address in thumb mode. https://bugs.llvm.org/show_bug.cgi?id=18505 > > With that fix, enabling framepointers on arm32 bring it in line with other > build configurations and allows for better stack traces. > > Bug: 786450 > Change-Id: I01a1c9f82fac22b2bbc15c6f52deed8aca7263ea > Reviewed-on: https://chromium-review.googlesource.com/826255 > Reviewed-by: Brett Wilson <brettw@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524127} TBR=ajwong@chromium.org,brettw@chromium.org Change-Id: Ie327529394021473cfffd0ee80baecce4bd83e2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 786450 Reviewed-on: https://chromium-review.googlesource.com/828607Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#524337}
-
Emil A Eklund authored
Change signature of the NGTextFragmentPainter::Paint method to match the signature of other Paint methods, specifically by dropping document arg. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9c752b2c7f56c333c76b1815f69c3691e490fdc7 Reviewed-on: https://chromium-review.googlesource.com/827632 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Bryan McQuade authored
Page load metrics browser tests sometimes want to assert that no page load metrics are logged for a given page load. They do this by checking to see that no PageLoad.* histograms were logged, but excluding PageLoad.Internal.* histograms, which are considered internal and thus allowed to be logged during non tracked page loads. Recently, the PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl test started flaking on Windows, due to PageLoad.Experimental.Renderer.* metrics being logged during this page load. These are really internal metrics, so should use the PageLoad.Internal.* naming convention, which also allows them to be ignored by this test. Bug: 794408 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I593adf3b8c995e50b74431cc89e782cf4456abff Reviewed-on: https://chromium-review.googlesource.com/826386Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524335}
-
Andrey Kosyakov authored
This fixes a problem where we were using a loader id on the blink side that is different from DevTools navigation token on the browser side. Change-Id: Ieb82d2a7fea7f0e233eeeaf2158d46803cbb7e80 Reviewed-on: https://chromium-review.googlesource.com/828074 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524334}
-
Emil A Eklund authored
Expose whether a fragment has an associated layer on NGPhysicalFragment, with the implementation defering to the LayoutObject. Aditionally expose the type of block on NGPhysicalBoxFragment. Both are needed for painting directly from the LayoutNG fragment tree as it affects the paint order. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9f2d123acec104b1c61b9bd1297c49541713ac18 Reviewed-on: https://chromium-review.googlesource.com/827635 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Eric Willigers authored
x, y, width, height are presentation attributes. Spec: https://svgwg.org/svg2-draft/single-page.html#embedded-ForeignObjectElement When specified using stylesheet rules and as attributes, the stylesheet rules have higher specificity. https: //svgwg.org/svg2-draft/single-page.html#styling-PresentationAttributes Change-Id: I62101c1e41e6dcca19de74231104dd809e68a306 Reviewed-on: https://chromium-review.googlesource.com/828241Reviewed-by:
-
Sasha Bermeister authored
Moved QuotaStatusCode from storage/common to WebKit/common. This is pre-work to onion soup the QuotaDispatcherHost mojo API and remove WebStorageQuotaType and WebStorageQuotaError. This patch: * Moves QuotaStatusCode to WebKit/common and updates users to use blink:: instead of storage:: for the types * Moves QuotaStatusToString to a function in an anonymous namespace in the only file it's used (sync_file_system_api.cc) * Removes kQuotaStatusLast, since it's not used anywhere * Makes QuotaStatusCode an enum class in preparation for converting it to a mojo enum (where it will be an enum class) * Updates the DEPS files for android_webview/browser to depend on WebKit/common/quota, since aw_quota_manager_bridge.cc uses QuotaStatusCode * Removes the dependency of QuotaStatusCode on WebStorageQuotaError - reversed the dependency * Added a TODO to remove WebStorageQuotaError and replace it with blink::QuotaStatusCode General strategy: * Renamed storage:: to blink:: for each value of the enum * Removed includes from files where the include was the only change (also removed includes of quota_types where it was being used to transitively include quota_status_code) * IWYUs where includes were previously missing; except in unit tests (where the include is transitive), and when interfaces are implemented (and the type is included from the virtual method decl) * Generally removed `using` declarations, except in files with 4/5+ uses, where they were added if not already there * Added visibility of WebKit/common to storage/ Bug: 781643 Change-Id: I7f31493dfee4934d5ed6e400e2c0723191549057 Reviewed-on: https://chromium-review.googlesource.com/821802Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#524331}
-
Andrey Lushnikov authored
This patch rebaselines test expectations for automapping-sourcemap and automapping-sourcemap-nameclash tests. BUG=659456 TBR=dgozman Change-Id: Icd635ad1e5da1369b168a91c752374675ca8d4f5 Reviewed-on: https://chromium-review.googlesource.com/828263Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524330}
-
Kunihiko Sakamoto authored
This adds variants of PageLoad.Clients.MultiTabLoading.* metrics that are recorded only when there are >=2 (or >=5) inflight loading tabs. Bug: 792759 Change-Id: Ic1c8711d6424752dd80685b7740ec12fcc1c885e Reviewed-on: https://chromium-review.googlesource.com/826706Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Pavel Feldman authored
Bug: 790909 Change-Id: I80f47d2619ef1109ca9c60bf484f270db9d012e1 Reviewed-on: https://chromium-review.googlesource.com/826710 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#524328}
-
Andrey Lushnikov authored
The test was mocking time only partially: the window.performance.now() should be mocked as well. BUG=610464 TBR=dgozman Change-Id: If9c81662235e43ee2ffafef2ed772158f3a74968 Reviewed-on: https://chromium-review.googlesource.com/828443Reviewed-by:
-
Fady Samuel authored
In order to track bugs in the wild, this crash key reports the details of the invariants violation. Bug: 672962, 791154 TBR: danakj@chromium.org for trivial change to selection_bound.{h|cc} Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I344f91b92cf06f9eddebdc573df35a8de5b6920e Reviewed-on: https://chromium-review.googlesource.com/826166 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524326}
-
Dave Schuyler authored
This CL adds a View in store link row that links to the extension home page as well as a link row for the Chrome Web Store page for the extension. Bug: 794286 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06a8c078f0659adc3c69e6139133ec9cf6a81d9a Reviewed-on: https://chromium-review.googlesource.com/826473 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524325}
-
Stuart Langley authored
In ui/base/Clipboard kMimeTypeText = "text/plain" In platform/clipboard/ClipboardMimeTypes kMimeTypeText = "text" When I onion souped the code I did not realize that these two constants with the same name had different values. The fix is to use platform/clipboard/ClipboardMimeTypes kMimeTypeTextPlain so we have the same value on both sides. A future cleanup might be to amalgamate these constants. Bug: 794517 Change-Id: I9631430bc6c232afc38f12dcfad6b78f683add0b Reviewed-on: https://chromium-review.googlesource.com/828320Reviewed-by:
-
Xianzhu Wang authored
I often copy flagged tests. This can be achieved by clicking "Flagged" then one of the copy buttons, but this is sometimes incovenient because - "Flagged" query is interuptive because it resets the current filters making it difficult to return to where I was working on before clicking it; - I often forgot to click the "Flagged" button before copying resulting all tests were rebaselined after pasting the list of tests into the command line. Now add a "flagged only" checkbox to indicate whether to copy all or just flagged tests. Change-Id: I6a30e5070c724718bb59766f0535153849320d76 Reviewed-on: https://chromium-review.googlesource.com/820682 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524323}
-
Gyuyoung Kim authored
Member<> now supports const types. This CL removes an unnecessary const_cast in ScopedFocusNavigation and makes a Member<> const in SelectionModifier so we can do the same there. Bug: None. Change-Id: Ica178eed562e19f9042872d162b6b7f37ed51fe3 Reviewed-on: https://chromium-review.googlesource.com/826843Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#524322}
-
Kentaro Hara authored
Bug: 784252 Change-Id: Iaf2c709ddd12134382a621205d3b34b08474f86e Reviewed-on: https://chromium-review.googlesource.com/823863 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Scott Violet authored
AFAICT these aren't necessary. BUG=none TEST=none Change-Id: Iacda5ff8e2fceebf921ad26d5f074fedb58cd607 Reviewed-on: https://chromium-review.googlesource.com/827538Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524320}
-
Yuzu Saijo authored
This CL adds PrepareForLeakDetection in CSSDefaultStyleSheets which sets the members back to the constructor state in order to stabilize the number of resources for leak detection. Bug: 763280 Change-Id: Ia91831594c6607cf316967d2d4b841d274ca8a10 Reviewed-on: https://chromium-review.googlesource.com/826344 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524319}
-
