GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6


Created with:
  gclient setdep -r src-internal@6166365225d6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
Reviewed-on: https://chromium-review.googlesource.com/c/1329043Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606838}

This CL introduces ManagePasswordsUIProvider, a class which aims to allow
for alternative UI surfaces to be shown if available.

Bug: 903249
Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
Reviewed-on: https://chromium-review.googlesource.com/c/1326488Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606837}

Bug: 872904
Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
Reviewed-on: https://chromium-review.googlesource.com/c/1327331Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606836}

Currently WorkerFetchContext has the ownership of
some objects originated from WebWorkerFetchContext.
To create multiple WorkerFetchContexts
for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
this CL moves these ownership outside WorkerFetchContext.
Namely,
- url_loader_factory_ and script_loader_factory_
  from WorkerFetchContext to WebWorketFetchContext subclasses, and
- subresource_filter_ from WorkerFetchContext to
  WorkerOrWorkletGlobalScope.
  Still |WorkerFetchContext::subresource_filter_| is kept, but
  it is created in WorkerOrWorkletGlobalScope and passed to
  WorkerFetchContext.

This CL doesn't change the observable behavior.
This CL creates WebURLLoaderFactory a little more eagerly, i.e.
when WorkerFetchContext is created,
while previously it was created when
WorkerFetchContext::CreateURLLoader() is called for the first time.

Bug: 880027, 903579
Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
Reviewed-on: https://chromium-review.googlesource.com/c/1193385
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606835}

BUG=None

Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
Reviewed-on: https://chromium-review.googlesource.com/c/1326487Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606834}

I don't know whether to trust these numbers, but this is what I see
for my local Windows release 32 bit build.

Uncompressed:
3,034,139 browser_resources.pak
233,038,336 mini_installer.exe

Compressed:
2,869,382 browser_resources.pak
232,873,472 mini_installer.exe

Bug: 891310
Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
Reviewed-on: https://chromium-review.googlesource.com/c/1327406Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606833}

Bug: skia:2664
Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
Reviewed-on: https://chromium-review.googlesource.com/c/1318416
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606832}

The account storage is now used for both server cards and server
addresses.

Bug: 864519
Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
Reviewed-on: https://chromium-review.googlesource.com/c/1329241
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606831}

Currently, this makes no functional difference: In full Sync mode, the
local DB and the server DB are the same thing anyway, and in
lightweight/Butter mode, we don't store server addresses at all.
However,
1) this change will unlock actually supporting Wallet addresses in
   Butter mode, and
2) it's just less confusing if "server" things are actually stored in
   the "server" DB.

Bug: 864519
Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
Reviewed-on: https://chromium-review.googlesource.com/c/1326492Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606830}

Instead of applying custom properties via the static Variable instance,
use the new CustomProperty class (which knows about its name and
registration) to apply values. This brings the custom property code path
closer to the standard property code path.

To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
class CSSPropertyName. The idea is that CSSPropertyName can be used instead
of CSSPropertyID/AtomicString where both standard and custom properties are
expected. My intent is to store a CSSPropertyName in
CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
change, as everything that creates property/value pairs must carry the
CSSPropertyName. So, for now PropertyReference.Name() is faking it by
digging the name out of the associated CSSValue.

Note that CSSPropertyName::ToAtomicString intentionally does not return
a const AtomicString&. This is because 1) I want to try and reduce the
size of CSSPropertyName to one pointer, which means it will contain a
StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
be something that can be passed to other threads if needed, which again
means StringImpl* (or String, at least) rather than AtomicString.

In general, this CL is a step on the path to achieve these things:

 1. Removing the useless and dangerous static Variable instance.
 2. Not having to piggy-back the custom property name in a CSSValue.
 3. Not having to smuggle initial/inherit/unset via the
    CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
    holding these values, like civilized individuals).

R=flackr@chromium.org, futhark@chromium.org

Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
Reviewed-on: https://chromium-review.googlesource.com/c/1323113
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606829}

This reverts commit 002dfaef.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1

Original change's description:
> Mac: Disallow dragging tab into blocked tabstrip
> 
> This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
> though I'm pretty sure the thing that happens right now when you open
> a certificate prompt and drag a tab into the parent window is bad.
> 
> This introduces a new method because we're not sure if it matches the
> Aura semantics, and this is better than the nothing we were doing previously.
> 
> Bug: 825834
> Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
> Reviewed-on: https://chromium-review.googlesource.com/c/1315956
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606619}

TBR=ellyjones@chromium.org,lgrey@chromium.org

Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825834
Reviewed-on: https://chromium-review.googlesource.com/c/1329341Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606828}

This CL:
- Makes the generated AndroidManifest.xml a data dependency of
h2o_junit_manifest_target_name
- Reenables LaunchTest.*

BUG=902325

Change-Id: I47e3c5c2226c78c696716712a4307127493c5903
Reviewed-on: https://chromium-review.googlesource.com/c/1324875Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606827}

Before this patch, navigation triggered by clicking on a link or through
javascript (renderer-initiated navigation) was considered an end state
for Autofill assistant.

With this patch, such actions are only considered an end state if the
page that's navigated to has no scripts. This is necessary, as such
navigation is part of the expected flow of some scripts.

Going back a page or refreshing through the UI (non renderer-initiated
navigation) are still considered an end state with this patch.

Bug: 806868
Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d
Reviewed-on: https://chromium-review.googlesource.com/c/1329242Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606826}

This CL decouples the addition of a tab completion block from the other
tab opening code in the BVC. This will allow the tab opening logic
(which is just tab model manipulation) to be moved out of the BVC.

Bug: 903338
Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c
Reviewed-on: https://chromium-review.googlesource.com/c/1323558
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606825}

Bug: 806868
Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594
Reviewed-on: https://chromium-review.googlesource.com/c/1324239Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606824}

The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available.

Bug: 806868
Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c
Reviewed-on: https://chromium-review.googlesource.com/c/1317911
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606823}

This reverts commit 0f0d0b74.

Reason for revert: super flaky on win7_chromium_rel_ng

BUG=chromium:872776

Original change's description:
> Add resource load priority Service Worker tests
> 
> This CL adds resource load priority tests ensuring that the priority of
> requests that pass through a Service Worker is preserved.
> 
> R=​kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org
> 
> Bug: 872776
> Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
> Reviewed-on: https://chromium-review.googlesource.com/c/1316104
> Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606689}

TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com

Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872776
Reviewed-on: https://chromium-review.googlesource.com/c/1329245Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606822}

The previous early return shortcut required invalidation of fixed-attachment
background etc.

Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange():
- always invalidate for fixed-attachment background
- correct invalidation of local-attachment background for SPv2
- remove the SetNeedsRepaint() logic for change of existence of
  ScrollTranslation because now PaintPropertyTreeBuilder will do that
  whenever a paint property node is created or removed

Bug: 529963
Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0
Reviewed-on: https://chromium-review.googlesource.com/c/1308988
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606821}

This reverts commit 05e6d611.

Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. 

==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128
READ of size 8 at 0x608000011e50 thread T0
    #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28

See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests.

Original change's description:
> Fix page slip issue after dragging
> 
> Changes:
> Update the selected page to be the target page of dragged item at the
> end of dragging.
> 
> Bug: 893832
> Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
> Reviewed-on: https://chromium-review.googlesource.com/c/1324851
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606585}

TBR=newcomer@chromium.org,weidongg@chromium.org

Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893832
Reviewed-on: https://chromium-review.googlesource.com/c/1329170Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606820}

We're planning to not use cross origin ScriptStates everywhere,
especially in IDL callback function and callback interface.
Given that, we'd like to minimize use of ScriptState of callbacks,
which will be nullptr in case of cross origin, so that the call sites
of callbacks do not need to handle a SecurityError.

This patch is a preparation of https://crrev.com/c/1314023 and
removes the use of the ScriptState from custom elements.

Bug: 886588, 892755
Change-Id: I52068920b659efe119496ec092448cdc107e0631
Reviewed-on: https://chromium-review.googlesource.com/c/1325585Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606819}

It is flaky. See for instance
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816.

Bug: 903658, 903657
Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b
Tbr: mdjones@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1329161
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606818}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6130e69e..31b2546b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2a2852bb93f2c67cb5e6a1f0ed39315bab81006f
Reviewed-on: https://chromium-review.googlesource.com/c/1329062Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606817}

On every start up, the bookmarks sync metadata are compared to the
local model to check the integrity of the persisted data.
If the model and the metadata don't match, sync infrastructure assumes
the metadata are corrupted and start syncing from a clean state.

Before this CL:
Unsyncable bookmarks where considered at comparison. This resulted in the
models to always never match, and issue an initial update at every
start up.

After this CL:
Only syncable bookmarks are considering when comparing the model
and the metadata.

This issue could be observed using the UMA metric
Sync.ModelTypeEntityChange3.BOOKMARK
which should how frequently the client asks for initial updates.
Before this patch, the client was unnecessarily asking for initial
updates at every start up, and hence resulted in huge increase in
the bucket in REMOTE_INITIAL_UPDATE of
Sync.ModelTypeEntityChange3.BOOKMARK

Bug: 516866
Change-Id: I61c453359c4265af09a91253f2e13139034b2a53
Reviewed-on: https://chromium-review.googlesource.com/c/1329001
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606816}

https://android.googlesource.com/platform/external/perfetto.git/+log/486203eeaffd..606ed681f4ea


git log 486203eeaffd..606ed681f4ea --date=short --no-merges --format='%ad %ae %s'
2018-11-09 treehugger-gerrit@google.com Merge "Add comment on ftrace pid"


Created with:
  gclient setdep -r src/third_party/perfetto@606ed681f4ea

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: If0bd022a39477de441941826e42f178807d978bc
Reviewed-on: https://chromium-review.googlesource.com/c/1329042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606815}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73158cecda02..c458532c0628


Created with:
  gclient setdep -r src-internal@c458532c0628

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8311db5f4432ad7184b609969b5a2ecd787fbe9f
Reviewed-on: https://chromium-review.googlesource.com/c/1329041Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606814}

This reverts commit a8228cdc.

Reason for revert: Reverting as we've cycled through the waterfalls and the other flag change on the content layer already got reverted.

Original change's description:
> Enable unified garbage collections
> 
> Enables unified heap garbage collection across V8 and Blink. The GC
> computes a single transitive closure across V8's API boundary before
> starting the separate sweepers.
> 
> Sheriffs: This is a dry-run of the feature and will be reverted after
> cycling through the waterfall and performance bots.
> 
> Bug: 843903
> Change-Id: I0d3e9fc76fa9b116f32d92a234c45afe11120cf9
> Reviewed-on: https://chromium-review.googlesource.com/c/1290869
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605634}

TBR=ulan@chromium.org,haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843903
Change-Id: I1d1f695431919864cb15dffe0d9b1e4ba85fd3c5
Reviewed-on: https://chromium-review.googlesource.com/c/1329021Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606813}

Due to many ads being loaded and certain requests will not work.
    [console:error:js]:       ~30
    [console:error:network]:  ~30

Bug: 878390
Change-Id: I3e09c9302514b1fb089d77b4671c59fb44afb22f
Reviewed-on: https://chromium-review.googlesource.com/c/1296172
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606812}

Flakily fails like this:
../../media/audio/audio_output_device_unittest.cc:411: Failure
Actual function call count doesn't match EXPECT_CALL(env.callback,
    Render(kDelay, env.time_stamp, kFramesSkipped, NotNull()))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

See for instance
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/
    Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30025

Tbr: olka@chromium.org
Bug: 903696
Change-Id: I621eab844322e47a36cfa55ddf6c09c04d825266
Reviewed-on: https://chromium-review.googlesource.com/c/1328987
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606811}

This reverts commit eec86ff6.

Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190

Original change's description:
> Reenable direct composition without video layers
> 
> Reenable direct composition surface on devices without hardware overlays
> since it enables other power improvements like flip mode swap chain and
> disabling DWM redirection surface.
> 
> To mitigate the original concerns about direct composition, this change
> makes DCLayerTree lazy initialize the video context and processor when
> a video layer is first used.  On devices that don't support hardware
> overlays, the video context and processor will never be initialized.
> 
> Bug: 894675, 900702
> Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219
> Reviewed-on: https://chromium-review.googlesource.com/c/1318808
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606312}

TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894675, 900702
Change-Id: I094721159277c50d9061dfded252bbac1084977f
Reviewed-on: https://chromium-review.googlesource.com/c/1328965Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606810}

This CL removes GmsCoreSyncListener class and some harness around it.
This class was implemented for https://crbug.com/552106, but that
feature was never finished. This CL also removes
ProfileSyncService::GetCustomPassphraseKey that became unused.

Bug: 903284
Change-Id: I096b2ab74915d2ed93b4c4077902a1de9abb4cee
Reviewed-on: https://chromium-review.googlesource.com/c/1326502Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606809}

This reverts commit dcb55ce2.

Reason for revert: Appears to cause crashes in LoginCursorTest.CursorHidden. See https://chromium-swarm.appspot.com/task?id=410f91874d359810&refresh=10&show_raw=1:
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x55c75309100f base::debug::StackTrace::StackTrace()
#1 0x55c752aa8075 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f17e8b21cb0 <unknown>
#3 0x55c751991a1d chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
#4 0x55c751991c8e chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
#5 0x55c7553a6063 views::WebDialogView::OnDialogClosed()
#6 0x55c7553a5d92 views::WebDialogView::WindowClosing()
#7 0x55c752f81eb0 views::Widget::OnNativeWidgetDestroying()
#8 0x55c7548080ff views::DesktopWindowTreeHostMus::CloseNow()

Original change's description:
> Fix a crash when switching to tablet mode in Unified Desktop mode
> 
> 1) The Home Launcher used to use the wrong display ID when in
>    Unified Desktop mode.
> 2) If (1) is fixed, we hit https://crbug.com/902601. The captive
>    portal dialog widget used to be leaked and never destroyed.
> 3) If (2) is fixed, we crash on the first attempt to press the
>    app list button. The reason is tablet mode triggers a switch
>    to mirror mode. This switch happens asynchronously after the
>    Home Launcher had already been created. Switching from Unified
>    to mirror mode destroys the Unified host and the Home Launcher.
>    That's why we need to ensure that the Home Launcher is
>    recreated.
> 
> BUG=900956, 902601
> TEST=Added a test that crashes without the fix.
> 
> Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7
> Reviewed-on: https://chromium-review.googlesource.com/c/1325389
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606687}

TBR=xiyuan@chromium.org,oshima@chromium.org,afakhry@chromium.org,jdufault@chromium.org,weidongg@chromium.org

Change-Id: I2e0cacc2c29bbc44e8e8c9dfcb86fd8106c008ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900956, 902601
Reviewed-on: https://chromium-review.googlesource.com/c/1329004Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606808}

This reverts commit 68d8dbc0.

Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 

../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
Expected equality of these values:
  1U
    Which is: 1
  GetLinkPrerenderCount()
    Which is: 2

Original change's description:
> Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
> 
> Importantly, non-visible RenderWidgets include swapped out RenderWidgets
> which are zombies, without a frame, and which should not be used.
> 
> This can happen if the RenderWidget swap out races with the posted task
> from the compositor to make a LayerTreeFrameSink. When swapping out, the
> compositor would be marked as not-visible, which would stop it from
> making such requests, but one could already be in flight.
> 
> In the other case, honoring the request for a non-visible compositor is
> more benign, but we can delay it until the compositor is actually
> visible again. This means if a context is lost, backgrounded tabs would
> not all attempt to reconnect to the Gpu process at once.
> 
> This is a better followup for the hacky
> https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
> was meant only for merge to a release branch. It reverts that change as
> part of this one.
> 
> R=​piman@chromium.org
> 
> Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
> Bug: 896836, 419087
> Reviewed-on: https://chromium-review.googlesource.com/c/1292714
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606655}

TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org

Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896836, 419087, 903696
Reviewed-on: https://chromium-review.googlesource.com/c/1329003Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606807}

Now that a distinct GN target exists just for the code backing
IdentityManager/Identity Service, change the Identity Service
implementation to depend only on that target. The change worked right
out of the box -- good validation of the initial split.

Bug: 901859
Change-Id: I9b04ef952c34d9e9c0efcf137c55d41c8d616aff
Reviewed-on: https://chromium-review.googlesource.com/c/1323649
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606806}

Bug: 806868
Change-Id: Ic6cb7c2450e41e6d4555e9950b15866a7167747d
Reviewed-on: https://chromium-review.googlesource.com/c/1323651
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606805}

This reverts commit aaeff5e6.

Reason for revert: Findit thinks this CL makes delaying_onload_link_preload_after_discovery.html flaky with 70% confidence. Let's give it a shot and see if this fixes the flaking. Sorry, and let's hope the 5th reland goes better!

Original change's description:
> Reland^4 "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 31bcf8aa
> which was a reland of 5528336d,
> which was a reland of dd9df78c,
> which was a reland of 7bd91635.
> 
> Relanding with no changes, seems that this wasn't the cause of
> https://crbug.com/902832 after all.
> 
> Original change's description:
> > Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
> >
> > This is a reland of 5528336d, which
> > was a reland of dd9df78c, which was
> > a reland of 7bd91635.
> >
> > VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> > is otherwise unchanged.
> >
> > Original change's description:
> > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit c564235f.
> > >
> > > No changes from the original, VR flakes are caused by issues with
> > > loadUrl and have been deflaked (see 894796 for details)
> > >
> > > Original change's description:
> > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > > >
> > > > This reverts commit dd9df78c.
> > > >
> > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > > >
> > > > Original change's description:
> > > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > > >
> > > > > This is a reland of 7bd91635
> > > > >
> > > > > No changes from the original, revert reason is fixed with
> > > > > https://chromium-review.googlesource.com/c/1283037
> > > > >
> > > > > Original change's description:
> > > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > > >
> > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > > preload.
> > > > > >
> > > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > > long run, we want all scripts to go through the streaming interface,
> > > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > > maintain the current behaviour, and be able to control it with a
> > > > > > runtime flag.
> > > > > >
> > > > > > Bug: chromium:865098
> > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > > >
> > > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > > >
> > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#602310}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#605295}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> >
> > Bug: chromium:865098
> > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605815}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
> Reviewed-on: https://chromium-review.googlesource.com/c/1325921
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606448}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I6d2bbe9085376921d819c015bf37832efe8d2d11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098, chromium:903732
Reviewed-on: https://chromium-review.googlesource.com/c/1328966Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606804}

This reverts commit 95c8ebc6.

Reason for revert: Breaks FillJsTest: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/1004

JavaScript error: TypeError: __gCrWeb.fill.getAriaDescription is not a function.

Original change's description:
> [autofill] add iOS helpers to get aria-label and aria-description
> 
> This CL adds the getAriaLabel() and getAriaDescription() helper
> functions to the __GCrWeb.fill "namespace". These functions return
> the ARIA label and description strings associated with an element.
> 
> The ARIA Label is the text referenced by one or more containing element
> ids in the labelled elements aria-labelledby attribute, or the value
> of the element's aria-label attribute, with preference given to the
> aria-labelledby attribute. For example:
> 
>     <div id='foo-label'>Label for Foo</div>
>     <input name='foo' aria-labelledby='foo-label'>
>     <input name='bar' aria-label='Label for Bar'>
> 
> The aria-description is similar to aria-labelledby. For example:
> 
>     <div id='foo-description'>Long descriptive text for Foo</div>
>     <input name='foo' aria-describedby='foo-descrition'>
> 
> Bug: 896719
> Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
> Reviewed-on: https://chromium-review.googlesource.com/c/1325032
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606534}

TBR=rogerm@chromium.org,sebsg@chromium.org,mahmadi@chromium.org

Change-Id: I00eb534e6639c829f6ed5b312406ce51ba2aa429
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896719
Reviewed-on: https://chromium-review.googlesource.com/c/1329002Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606803}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ee41cbd4bf0..73158cecda02


Created with:
  gclient setdep -r src-internal@73158cecda02

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie142f038c6f81038911815c552aa5de603838b62
Reviewed-on: https://chromium-review.googlesource.com/c/1328730Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606802}

[Autofill Assistant] All messages to the server now contain the active field trials of the client as part of the ClientContextProto.

This will allow the server to log the field trial state, which in turn will allow us to analyze how user behavior changes with respect to the active field trials. Serializing all active field trials makes this easier to maintain at the cost of some additional message overhead and log storage. For each active field trial, the trial name and the name of the randomly selected trial group are sent.

Bug: 806868
Change-Id: I0417b3d548f36ca8c98c80182ec314e8bb20eba0
Reviewed-on: https://chromium-review.googlesource.com/c/1326014Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#606801}

Records the total size of parkable strings, the total compressed size, the
average compression ratio and the total savings from compression. As these
values are correlated, separate histograms are required.

The recording happens 30s after compression tasks are kicked off, provided that
the renderer's state (foreground/background) hasn't changed in the meantime, to
help with the interpretation of results. 30s is chosen as it's long enough for
compression to be done, and short enough to minimize the risk of the renderer
getting killed and/or moving back to foreground.

Also remove an outdated comment in parkable_string.cc.

Bug: 877044
Change-Id: Ic8cf4a410d182387ffd1d37b23d84b5426d227cb
Reviewed-on: https://chromium-review.googlesource.com/c/1323549Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606800}

Using wpt-import in Chromium f038ea34.
With Chromium commits locally applied on WPT:
270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-text/overflow-wrap

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I89a829c659b10bbbdfb07c86d8e997b9e9edbc08
Reviewed-on: https://chromium-review.googlesource.com/c/1328711
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606799}