- 14 Apr, 2020 40 commits
-
-
Wez authored
Add a set of owners for Fuchsia-specific security reviews, which will apply to CLs which have: - Changes to Chromium-defined FIDL APIs. - Changes to component sandbox specifications. - Changes to critical integration code, e.g. the sandbox policy. The new //fuchsia/SECURITY_OWNERS file is applied to specific files in //base, //fuchsia and //services, that are critical to the security of WebEngine and other Chromium packages published for use on Fuchsia. Bug: 1053551 Change-Id: I809cc07843ff06167b596f3fea21307e599803bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128079Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758932}
-
Natalie Chouinard authored
Re-enable render test with updated goldens on API 23. Remove goldens for KitKat based on clank-frontend recommendation (see bug for more detail). Bug: 888129 Change-Id: Icb86ec7adc8975ec1d417aa2f0449d9b3256f861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148160Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#758931}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from MemoryInfo request. Bug: chromium:1041153 Change-Id: I42a0056f028327a57f7e6afc1bca361b332390df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145704 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758930}
-
Lin Sun authored
Add new 4th/5th generation and corresponding GPU series. Add latest GPU series for 11th/12th generation. Also fixed a few nits in GpuControlList. Bug: 1062334 Change-Id: Iea0aa505cf75ab79efb12b345d9a2e2e4bd6d367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142747 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758929}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bd8517d1. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 2f3bb77d "[device-orientation] Upstream web tests to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 8ab053d0 "[css-flexbox] Move stretch-table-child.html test to WPT" 304e175c "[css-masking] Migrate clip-path-reference-nonexisting-existing-local.html to WPT" e6dd3701 "[css-grid] Migrate grid-element-bad-cast-addchild.html to WPT" 21c12d22 "[css-grid] Migrate column-property-should-not-apply-on-grid-container.html to WPT" 087501ad "[css-grid] Migrate auto-margins-ignored-during-track-sizing.html to WPT" 761bbfa3 "[ContentIndex] Rename ContentIndexDescription's launchUrl to url" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I1b211ce90133ed78fb8bbf8e5ccc4e174f0eb93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147959Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758928}
-
Donn Denman authored
Adds a new StateChangeReason to the Bottom Sheet Controller for promoting a sheet into a separate tab. Updates the metrics for Preview Tab (aka Ephemeral Tab) to record metrics base on the fact that promoting to a new tab closes the sheet. BUG=1070323 Change-Id: Ieabaa98288268a0922e6bc5103aa91dcfb058552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145469 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758927}
-
Timothy Gu authored
Bug: 793406 Change-Id: Ibce079364e229ddddc9c76fd7929a2e7866f0f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149283 Auto-Submit: Timothy Gu <timothygu@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#758926}
-
Sujie Zhu authored
Update the suggestion value (title) for all platforms when user focuses on credit card number field, using NicknameOrNetworkLastFourDigitsAndDescriptiveExpiration. Here is the display text change for suggestion value (title) on credit-card-number field: All platforms(Desktop/Clank dropdown/Clank keyboard accessary/iOS) share the same display text: Before: "Network ****2345" After: "Nickname ****2345" When nickname feature is not enabled or nickname is not valid, fall back to display network. Extract credit card suggestion tests (related with nickname & keyboard accessary features) as CreditCardSuggestionTest. Note that we don't enforce that the card has to be Masked server card when we display suggestions. We will display nickname as long as nickname is available (However, as of now, nickname is only available for server card). Later we don't need to update this logic if local nicknames share the same UI. UI deck(googler only): https://docs.google.com/presentation/d/1i-C4SeAHgpvn5Q-DXlHIM-In2ORURXN6nDlY05BtBsE/edit?usp=sharing Bug: 1059087 Change-Id: I486838caf6acbc3cc175709d5f27151561bfccb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144868 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#758925}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@chromium.org Change-Id: I95278b58a7da6cee0b268937f25328fb3d555144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147190Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#758924}
-
Yi Xu authored
In some size.attributes.parse.* tests, we try to test the enforce incorrect integer conversion: ex: enforce "#?!" to integer in size.attributes.parse.junk. In this cl, I update the expectation to throw type error. Bug: 1067639 Change-Id: I9573187de770a6beb2a5aeccea589e0e7440f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144447Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#758923}
-
Collin Baker authored
Ash's DragDropController is modified to specially handle drags from the WebUI tab strip when a flag is enabled. Dropping a tab over an area that doesn't support accepting the drop will open a new window with only that tab. Bug: 1069869 Change-Id: I9ee06a497f8557a3c8e0defff10c8edc1993514c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130812Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#758922}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d894d87b25b..83678e516e5f git log 3d894d87b25b..83678e516e5f --date=short --first-parent --format='%ad %ae %s' 2020-04-14 cnorthrop@google.com Tests: Update dEQP KHR GLES 3.1 expectations Created with: gclient setdep -r src/third_party/angle@83678e516e5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I7535ffbf250d082cd88f83b0e9c50a436e36fd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758921}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 154 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-10-11. TBR=bcwhite@chromium.org Change-Id: I98bd635226403ce6fd3a5eceec7a27b6a9e97183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143868Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#758920}
-
Kevin Babbitt authored
Enable these tests to catch regressions in the system caret accessibility object. Two changes were needed to get them passing: - When looking for the caret at a particular point on the screen, add the window offset to the expected position. - One test was checking that the caret position changed when the window position changed, including when maximizing the window. The handling for window maximize causes our internal caret object to be re-created on Win7 but not on Win10. The fix is to adjust the test to accept either behavior. Bug: 1067743 Change-Id: Ic6c0f4b7248874abb6a72c1419927e3677a8b453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146085Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758919}
-
Jérôme Lebel authored
When AddAccountSigninCoordinator is interrupted, the signinCompletion needs to always be called. This was not the case when the coordinator shows |identityInteractionManager|. Bug: 971989 Change-Id: Ia7156313c5f5b723a847b6759db90fa9d5f83e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144275Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758918}
-
Mugdha Lakhani authored
PageInfoControllerDelegate has been introduced to allow customization of PageInfoController java code, currently focussing on everything that requires Profile or ChromeActivity. The end goal is to have no chrome dependencies in PageInfoController so it can be moved to //components. Bug: 1052375 Change-Id: I8adf97cb400b99f964b86779c2a3116d1e3b458a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142261 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#758917}
-
dpapad authored
After this CL the features::kSettingsPolymer3 flag is no longer respected and will be removed in a later CL. Bug: 1069258 Change-Id: I93bc9b746ace6a2d982f98bc0bbd1e365347e475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142754 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758916}
-
Mei Liang authored
Favicon in GTS updates via a callback. The latest tab index should be used in the callback because the original tab index can become invalid. This CL avoids using stale tab index by using the same favicon callback for single/group tab in GTS. Change-Id: I322793bb2ce0979b9f36986873ddc7f7b9963ae5 Bug: 1070135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148127 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758915}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38cf748e7a5f..95e8d00d85d0 git log 38cf748e7a5f..95e8d00d85d0 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 primiano@google.com Merge "Tracing protocol: chunk QueryServiceStateResponse" Created with: gclient setdep -r src/third_party/perfetto@95e8d00d85d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I366b6bbed0c08a2bd8bd9780bc8aa5a3f3950edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758914}
-
Xiaohan Wang authored
This reverts commit e7ea3e9e. Reason for revert: causing compile failure https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10837? Original change's description: > Move caBLE v2 authenticator to a dynamic module. > > By moving the authenticator code to a dynamic module we eliminate > code-size concerns in the base module for a feature that is flag > protected and, for a while at the very least, will be used by a tiny > fraction of users. > > BUG=1002262 > > Change-Id: I9418d7873091741e189629755033842023166ed6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145759 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Commit-Queue: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758880} TBR=agl@chromium.org,isherman@chromium.org,martinkr@google.com,fhorschig@chromium.org,tiborg@chromium.org Change-Id: I535fa461c641edd4ba2a41d94f2fccf828cecb71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148818Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758913}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia4765d32f2e946d28434fc4421fc95df26916096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148742Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758912}
-
Sam Bowen authored
* Allow null author in mojo struct. Author is only needed for video type, not tv series/movie. * Remove number of seasons. * Remove number of episodes on media feed item, should only be embedded in the season now. * Add type sort key in JS so more than one item can be displayed. * Only get live data for movie/video. TV live data should be embedded in the episode (future CL). Change-Id: I9dfa2fa0bd3b9a9dfa947669f455ecb57dd6f5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144673Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#758911}
-
kylechar authored
Modify SurfaceAggregator so that it disables the |ignore_undamaged| optimization when there is one (or more) RenderPasses with pixel-moving backdrop filters. The root damage rect can be expanded after SurfaceAggregator and if that happens the DrawQuads necessary to draw background pixels that have a filter applied are dropped already. It would theoretically be possible to do all damage rect expansion before deciding what DrawQuads are necessary, but this would require a large refactor of damage rect calculations which risks breaking things. There are already a number of conditions under which the |ignore_undamaged| optimization is disabled, so adding another condition should have limited performance impact. Bug: 1037830 Change-Id: Ief5d79ed120a89105566a9ab529c0d3f78bce700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137589Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#758910}
-
Sadrul Habib Chowdhury authored
If the client stops requesting begin-frames, then it is unlikely to submit any compositor-frames for any begin-frame it may still be handling. So terminate the associated reporters in this case. BUG=790761 Change-Id: I2db257af67ea1827b97703280c12ab202b9be89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146785Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#758909}
-
Erik Staab authored
Add wrapper script to run arbitrary versions of weblayer instrumentation tests, client, and implementation. Bug: 1041619 Change-Id: I033a4d2263d5b0028dd7b7c80c506e02ac4b49cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031717 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758908}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5fe03bb8982..62d5d8e82707 Created with: gclient setdep -r src-internal@62d5d8e82707 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069294 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ie5c252ed8e1960526d2611b82c4e14cb9b806b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149259Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758907}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from FanInfo request. Bug: chromium:1041153 Change-Id: I929f0dcb0dba53a8c8db7e41782bfab91a675ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147799 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#758906}
-
Charlie Hu authored
This CL implements default endpoint support for Document-Policy/ Document-Policy-Report-Only header according to https://w3c.github.io/webappsec-feature-policy/document-policy.html#reporting section 6.1.2 ~ 6.1.3 Bug: 993790 Change-Id: I227c12d51a409b35beb5de248c87ec8b96656252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134583Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#758905}
-
Olivier Tilloy authored
- use the correct icon for the desktop file for all channels - special case the desktop file name when running as a snap Change-Id: I9e4d03a96754bd51d798a13d6476210b9f6a8ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137328 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758904}
-
Xiaohan Wang authored
This reverts commit db19268d. Reason for revert: test failure, see crbug.com/1070676 Original change's description: > [ios] Add eg2 tests for managed bookmarks > > This CL adds eg2 tests for changes in crrev.com/c/2140953. > > The test fixture in this CL must enable certain command-line flags > to be able to run the managed bookmarks enterprise policy. > > The eg2 tests for managed bookmarks include testing: > - disabling long-press for managed items (URLs and folders) > - disabling swipe-to-delete for managed items (URLs and folders) > - disabling new folder context menu button when inside a managed folder > - disabling edit context menu button when inside a managed folder > > Bug: 1065187 > Change-Id: Ide92b87f03585d186b133f192d1e39a4fbbaa1cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145260 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758848} TBR=edchin@chromium.org,sczs@chromium.org Change-Id: Ie6b374a26d85cd99d52417ee52aabee8ff2d2683 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065187, 1070676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149287Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758903}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: Iaf002daa7d743e9bf7bf725a86566f984c2ae0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148533 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758902}
-
Kyle Horimoto authored
Screenshot: https://screenshot.googleplex.com/8hf9ZVFEaNc.png Bug: 1067212 Change-Id: I2f16184b5b72aa68f57597161ecca40eac3a6bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145964Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#758901}
-
David Bertoni authored
The EventsApiTest.NewlyIntroducedListener test isn't flaky on Windows, although it still flakes on other platforms. Bug: 833854 Change-Id: Ib524f61b79d6ae83c1e7e39c63c0522429a3f118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139450Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758900}
-
Owen Min authored
Add two tests to verify the claim in the WallClockTimer documentation. 1) Restart a running timer will replace the current task and reset the desired run time. 2) Stop a non-running timer is a no-op. Bug: 1062410 Change-Id: Id5f9b7cc7d55db66cccf085d8260965633a23a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144414 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758899}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I90a58a2cad2cc7da9a5512b327f3b4d16567154f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112894 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758898}
-
Ian Prest authored
This change caches the strokes (converting them to separate paths) used for hit-testing in SVG, so they don't need to be recomputed on every hit-test / mouse-move. This change is motivated by a subsequent change that will increase hit-testing precision while significantly worsening performance. By caching the stroke path, the aggregate result of the two changes is expected to perform better than the current status quo. Bug: 964614 Change-Id: I48de70a22c2f8137604f214a699bae258ff741d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140819Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758897}
-
Alex Turner authored
Reenables the previously flaky test AdTaggingBrowserTest. ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged, with the following changes. The scripts added by createFrameWithWindowStopAbortedLoad now have async set to false to ensure that they are loaded in insertion order. This allows the last script's onload handler to correctly signal that all three scripts have loaded. This change was made for create*Ad*FrameWithWindowStopAbortedLoad (crrev.com/c/2144832), but this function also needs to be changed to avoid flakiness. Bug: 1069346 Change-Id: I32733290cb41a03351b969b62e8118c5be1401e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148544Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758896}
-
Chris Hamilton authored
This will be used in upcoming page load prioritization logic. BUG=1064763 Change-Id: I6290b4e500edc39759411f9a00f6f4255e1e0acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144312Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#758895}
-
Haiyang Pan authored
Bug: 922145 Change-Id: Ica6b8f94bf47b7c10dadad6e6ecdddf31b14166c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146060Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#758894}
-
Stephen Chenney authored
It is possible for the renderer to navigate and reset the have_emitted_uma_ flag while the compositor thread is processing input and checks the flag. Make it atomic to avoid this problem. Bug: 1068119 Change-Id: If6d633f18a6bb645a479cc27317ab6bb99fed708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144776Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#758893}
-