- 26 Feb, 2020 40 commits
-
-
Gauthier Ambard authored
Bug: none Change-Id: Id47a70da1b939512fe893c64819daac7545f28e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074440 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744770}
-
jonross authored
Some tests were recently re-enabled in the default configuration. But they failed under SkiaRenderer and were marked for triage. These tests are showing small variance when ran with --enable-gpu-rasterization, software SkiaRenderer is fine. So I've updated the FlagExpectations for them. I've also marked associated to the bug tracking the need for flag specific baseline variations. Bug: 1052768, 993384 TEST= skia_renderer_*_blink_web_tests TBR=backer@chromium.org Change-Id: I7de40a09381b91a755263a4c46558b27d12a9019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072859Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#744769}
-
Peng Huang authored
If Vulkan doesn't support VK_KHR_external_semaphore_fd or VK_KHR_external_memory_fd, ExternalVkSharedImage will fallback to use pixel copy. Bug: 1049864 Change-Id: I6ec7787ed55311ba43989c3c61aa773abfb50385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074797 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#744768}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e0fbe99. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ida885dd0df211a3f8f980899ff58e0ef11bbc197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074755Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744767}
-
Steven Bennetts authored
While slightly less readable, this formats the UI logs consistently with other logs (net.log, messages), making it easier to identify coincident events and to integrate with tooling. Note: This only affects logs in Feedback reports, not in chrome://device-log (at least for now). Bug: 1054951 Change-Id: I7c5cca90aba840e45e9320d2130b0ffb42356dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072593 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#744766}
-
Matthew Mourgos authored
This change adds the required icons to the gesture navigation OOBE screen. Lottie animations are added as well, with one lottie animation on each page (go back, go home, overview). Bug: 976949 Change-Id: Ida70ee09793383ad29c94dd5719f9bc7e64440d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066078Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744765}
-
Jeffrey Kardatzke authored
This adds bi-planar NV12 support in this class. This is needed since we are changing the ImageProcessor input storage format to be MOJO_SHARED_BUFFER in the next CL. BUG=b:147411004 TEST=media_unittests pass, VEA NV12 non-DMA test passes on trogdor Change-Id: I05799f4a00078b373214688a6e267a0ffbcf7946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063262 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744764}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19f466d399f1..8ec13300cd6d git log 19f466d399f1..8ec13300cd6d --date=short --first-parent --format='%ad %ae %s' 2020-02-26 jvanverth@google.com Fill in more D3DCaps 2020-02-26 senorblanco@chromium.org Dawn backend: update to accommodate recent Skia changes. 2020-02-26 robertphillips@google.com Hide GrFillRRectOp's implementation 2020-02-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8ec13300cd6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ib5e9a77d959e14a3ce928790f7a02bc14f3a4ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744763}
-
Mehran Mahmoudi authored
This fixes the following problems: 1. NullPointerException in PlayerFrameBitmapPainter#onDraw() for when mBitmapMatrix contains null bitmaps. 2. Scrolling using GestureDeterctor. PlayerFrameGestureDetector#onDown() should return true. 3. No calls for PlayerFrameView#onDraw(). setWillNotDraw(false) should be called. 4. PlayerFrameView not getting notified of changes to the model. Because we reuse the same objects for the PropertyModel in the PlayerFrameMediator class, PropertyModelChangeProcessor doesn't notify the model when they are reset with the same object. Change-Id: I73fe4e4d3299a8dd3aa3fc74b83462ea6c82b27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072909 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744762}
-
Daniel Murphy authored
These metrics are used as heartbeat signals for IndexedDB. Mark them as never expiring. Bug: 1026889 Change-Id: I9a101281551e6d71cf7e46da7b240d31af8a0f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064787 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#744761}
-
Oksana Zhuravlova authored
This change updates the wpt tests in web-nfc/ to use the mockNFC object in the tests that simulate a 'no implementation available' case. MockNFC now has a new method simulateClosedPipe() which results in the pipe being closed on a connection request. This unblocks https://crrev.com/c/2062696, which adds code to crash the renderer if no binder was found for a requested interface. Bug: 1047680 Change-Id: Ib8f16f73a78982b2c17bf518d37d05e59ea384ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072923 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#744760}
-
Tom Anderson authored
R=pkasting BUG=914974 Change-Id: I55b5a93b9e217ec0bc5a81f5246db5efbc568b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073272 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744759}
-
edchin authored
There were two changes to NTP frame and inset calculation that broke NTP snapshot insets and resulted in a snapshot with a smaller frame than needed. https://chromium-review.googlesource.com/c/chromium/src/+/1392956 https://chromium-review.googlesource.com/c/chromium/src/+/2019244 The NTP's fullscreen behavior is different from a regular webpage in that the bottom toolbar stays fixed (in compact width size class). Since the NTP's frame is always above the bottom toolbar, there is no need to further inset the snapshot frame on the bottom. This CL fixes the snapshot inset. Fixed: 1040101 Change-Id: I0f5c0289b873a031ac66550d1c4aca1f5a3e73cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073011Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744758}
-
Phillis Tang authored
This patch makes the callback params optional for BluetoothDiscoverySession::Stop and removes all the passed callbacks from the callers. Further changes will be made to completely removes the callback params. Bug: 991682 Change-Id: I6c7a3b1a8bd7a06a5d724618609cad8d8dbba898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068886Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744757}
-
Parastoo Geranmayeh authored
on all chrome os. TBR=thestig@chromium.org Bug: 1056295, 920684 Change-Id: Ic5b6e0fc7fff5427e2a7c72ad49077713e1a7937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075082 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#744756}
-
Joshua Peraza authored
Bug: 1055971 Change-Id: I7a8c24f555fafa4937481b341b4590adb6b1c64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073000 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#744755}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1815c5422a39..8995c0468a44 git log 1815c5422a39..8995c0468a44 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 lalitm@google.com tp: fix test failure 2020-02-26 lalitm@google.com Merge "tp: fix android_cpu metric unit dimensionality" 2020-02-26 lalitm@google.com tp: allow empty end events from systrace print events Created with: gclient setdep -r src/third_party/perfetto@8995c0468a44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149804989,chromium:150213213 Tbr: perfetto-bugs@google.com Change-Id: I5d9e97898cfaca391c45dce4ec0d414a495067b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075359Reviewed-by:
-
Frank Li authored
This CL replaces IFACEMETHOD with IFACEMETHODIMP and override in .h files. It also replaces IFACEMETHODIMP with HRESULT in .cc files. In addition, it updates MediaFoundationSourceWrapper::XxxEvent methods to not checking |state_| for kShutdown. Otherwise, I have observed Media Foundation rendering pipeline does not release its reference count on MediaFoundationSourceWrapper when QueueEvent fails after the shutdown of MediaFoundationSourceWrapper. Bug: 999747 Change-Id: I9dbf666ac9f6c33edcc0357f442e4d16a5dd0d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070817Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Li <frankli@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744753}
-
Peng Huang authored
Since vulkan swap chain will not modify the content of images, so we can set preserve_buffer_content in output surface capabilities, and then the SkiaRenderer will only draw damage area instead of the whole buffer to save CPU and GPU cycles. Note: we are using FIFO Vulkan swap chain, so the swap chain should return images in presenting order. Bug: 1043388 Change-Id: I6f3a4f84027607fe5cb6ecd992552c535c72ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042766 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Joey Arhar authored
Bug: 1055922 Change-Id: If998e7d3e7f8e07d19a034104c425a3266c79cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073221 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#744751}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a9042f8a77b..b847c567e717 git log 2a9042f8a77b..b847c567e717 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 vapier@chromium.org Reland "cros: switch CrOS programs to python3" Created with: gclient setdep -r src/third_party/depot_tools@b847c567e717 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:997354 Tbr: agable@chromium.org Change-Id: I53fbd052eeb847a73643bd108bc7b5b667579552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074592Reviewed-by:
-
Maksim Ivanov authored
This makes the buttons of the LoginPinView view untabbable. It affects the quick_unlock and smart card PIN keypad UI in the user pod in Ash, and also the Parent Access Code dialog. This should NOT be an accessibility regression, since these buttons don't provide any extra functionality: i.e., the PIN can still be directly entered into the input field via other methods. The change was also approved by the a11y team (see the attached bug). This also makes it consistent with the HTML/Polymer-based PIN keyboard, which was recently changed to not support tabbing through the buttons (see the attached bug). The main motivation is to avoid struggling with the a11y behavior of these buttons (specifically, issues of keeping the focus and of pronouncing the "bullet" word of the screen reader). Bug: 1043194 Test: log in via a smart card, log out, start a login again, in the PIN dialog press Tab a few times, verify that the buttons of the PIN keyboard ("1", "2", etc.) don't get selected Change-Id: I650878e2fcecb2fd5e35d9fe847664fa8e4a6d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074441 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: -
Maksym Onufriienko authored
Bug: 1011498 Change-Id: Ie72335fb20a8ee5c47ba8edaf4ed8299068a7f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067325 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744748}
-
Mark Schillaci authored
This CL adds unit tests for WebContentsAccessibility. These tests expand on an existing test and cover more cases. This set of tests checks the ToIndex and FromIndex of the accessibility events being sent from Chrome to the system. In some cases not all indices are important, and so the incorrect indices can be sent and a defect will only appear in the rare edge or corner case that that index is relevant. A previous CL level-set all these indices to correct values: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 This CL now unit tests all these indices to ensure we do not deviate from the API expectations again. The unit tests cover every combination of: - Traversing forwards vs backwards - Navigating by line or word - Checking ToIndex and FromIndex - Checking indices of both traverse and selection events - Navigating with and without selection mode on Change-Id: I5c59017380ea0f8e5c59b4bc0c535dfb20f2930c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068887 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744747}
-
Mia Glaese authored
This reverts commit e4d87e3b. Reason for revert: This is not the culprit CL, the fix has been landed Original change's description: > Revert "[Start Surface] Add toolbar animations" > > This reverts commit a70166fd. > > Reason for revert: May cause crashes on Canary crbug.com/1052744 > > Original change's description: > > [Start Surface] Add toolbar animations > > > > Screen capture: > > https://drive.google.com/drive/folders/1VSZGz0yMwmYBV0uG0Zv5jgtLzKQt8DVM?usp=sharing > > > > Bug: 1025296 > > Change-Id: I6d3671252578fa9f37e5f1173b8d55b364a898c1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981853 > > Commit-Queue: Mia Glaese <glamia@chromium.org> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741772} > > TBR=yusufo@chromium.org,gogerald@chromium.org,pnoland@chromium.org,glamia@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1025296 > Change-Id: I1b86c55bf43601536eff5cc3b8f24ce867aed1fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058819 > Reviewed-by: Mia Glaese <glamia@chromium.org> > Commit-Queue: Mia Glaese <glamia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741973} TBR=yusufo@chromium.org,gogerald@chromium.org,pnoland@chromium.org,glamia@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025296 Change-Id: I8dd7efa70e967bba81ac31195f685b230d50ae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063663Reviewed-by:
Mia Glaese <glamia@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#744746}
-
Esmael El-Moslimany authored
When a history item is removed, we want to move the focus to next menu button. This was done by updating the items and focusing on the item with the same index. When removing the last item, this was causing an error since the index is now out of bounds of the items. This CL focuses on the new last item if there is one. Fixed: 1055956 Change-Id: I41934486f01c1c10afcf34a296585cb23d955592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073149 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744745}
-
Istiaque Ahmed authored
ContentVerifier::ShouldVerifyAnyPaths forces verification of JavaScript and html files by checking the extension of the resource (.js or .html/.htm) as they are considered sensitive resources. However, it didn't used to take case variants of extension into account, this CL fixes that by turning comparison of extension of files case-insensitive on all platforms. Added unit test for the behavior change. Bug: 1051396 Test: See bug description Change-Id: I0fed253ad5241db5b89c8abf6d0ab445dd403b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071486 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744744}
-
Omer Katz authored
Visiting a TraceWrapperV8Reference checked whether the reference is empty or not. If that check happens on a concurrent thread, it could race with v8 setting that reference. The fix is to check only on main thread. For concurrent threads, the reference is put into the worklist regardless of whether it is empty or not. The main thread then checks if its empty when popping from the worklist before pushing that reference to v8's worklist. Bug: 986235, 1054852 Change-Id: I877844c72994b0b6cb97559d25d225a78a2b3649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075278Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744743}
-
Michael Lippautz authored
Same as with HeapVectorBacking, move the GC support for HeapHashTableBacking into its own file instead of distributing it over the GC internals. Bug: 1056170 Change-Id: Ie4d26fd4135258c5cf4f4a133e7084d8105e02fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074617 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744742}
-
David Tseng authored
TBR=dmazzoni Change-Id: Ide2a25f35c31dbee75096a96c480c8b149cf6761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074810Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744741}
-
Andy Locascio authored
ARIA trees were previously un-navigable with VoiceOver on macOS. This was because it didn't properly fulfill the NSAccessibilityRowsAttribute attribute. In webkit, this attribute is fulfilled by diving on the row's children and surfacing any TreeItem elements. This CL represents a port of their implementation. Additionally, I noticed a confusing spot where the subrole is being compared in a long line of role comparisons. I moved this around to be less foot-gunny/confusing and added more attributes for the OutlineRow subrole that macOS accessibility suggests are necessary (and exist in the webkit implementation). Link to webkit impl: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm#L2836 https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp#L1804 Bug: 868480 Test: Use VoiceOver to navigate the table at https://cookiecrook.com/test/aria/tree/ariatree2.html. Note that the table is no longer announced as empty. Change-Id: Ibb86049efa23e12875aa9aeda541e0145242e3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062913Reviewed-by:
-
Evan Stade authored
1. Tab#dismissTabModalOverlay is added to hide the active tab modal dialog, if any. This is useful so the client can hide the dialog on system back, for example. 2. TabCallback#onTabModalStateChanged informs the client of changes to tab modal state, so the client can disable parts of its chrome. For example, Chrome disables the app menu and hides the contextual search manager. Bug: 1045499 Change-Id: I2f2f51a91dc24092a789769b5361ee23fd0c1c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065403 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744739}
-
Qingwen Pi authored
This is part of an effort to remove //media dependency from chromecast/media. Merge-With: eureka-internal/365986 Bug: b/149771309 Change-Id: I6b8c9b2233295d44214273171315590afcc6d36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065417 Commit-Queue: Qingwen Pi <qwp@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#744738}
-
Sergio Collazos authored
This reverts commit 2472108d. Reason for revert: A bad rebase broke reverted the change in https://crrev.com/c/2067642. Will land again with that fix. Original change's description: > [ios] Prevents InfobarBanner from being dismissed twice. > > Bug: 1049088 > Change-Id: I435c8b4c0bbec9130cecf845321391914df529d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071241 > Reviewed-by: Chris Lu <thegreenfrog@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744388} TBR=sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I08e153ee5b79af6988cef1c36b36ffcf04769359 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075139Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744737}
-
Natalie Chouinard authored
Move Notification settings alongside Notification code. Bug: 1047357 Change-Id: I973fa65703b5f0cc2efce0885e7cf93461d56a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073340Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744736}
-
Andrew Xu authored
Bug: 1045269 Change-Id: Iffd263f44955be6247a5fcdce0d82e6bd1f5e9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067649 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
This CL provides a fallback for cases where the trace processor can't be found in the output directory. The necessary binary is downloaded from the cloud. Bug: b/148777584 Change-Id: Ie7e39bf7b0927cc41ef92675e71482ac7106841b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059998 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744734}
-
Fredrik Söderquist authored
Would assert a tuple not the actual expression. Remove parentheses. Bug: 1056217, 1051750 Change-Id: Id21e440ea5f095b167bf3906b192021210d5cbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#744733}
-
Tim Song authored
This is the first of a series of CLs to implement the UI for the built-in privacy screen feature. BUG=1040648 Change-Id: I0dc9d559dabd4ea4819d5e7977ae4b52add60db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071742 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#744732}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6426a06c..68e2a460 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf47662cbed691442a1bea3d59279cb38a6b62cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744731}
-
