GitLab

Change-Id: I6af5df47bef38156f7e6237da3edb5ef84fb1be0
Reviewed-on: https://chromium-review.googlesource.com/1005014Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550691}

Bug: 721408

Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a
Reviewed-on: https://chromium-review.googlesource.com/1006231
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550690}

Contextual Search show/hide events are not 1:1. Show can be called
multiple times when the text selection changes (which is pretty
often). This would cause the bottom sheet to remain hidden after
Contextual Search was gone.

This patch checks if Contextual Search is already showing in the
BottomSheetController as not to change the behavior of other
Contextual Search observers.

Bug: 827353
Change-Id: Ib133224042cef6509d3cd7b81df78810093190f8
Reviewed-on: https://chromium-review.googlesource.com/1012193Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550689}

I believe there's a bug in URLLoader that's causing them to occasionally
crash, when the data pipe is closed before reading the entire response
body.

TBR=jam@chromium.org
NOTRY=true

Bug: 755309
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id3f98fdea01b56b1c0c3b0edf927701579afa38d
Reviewed-on: https://chromium-review.googlesource.com/1012443Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550688}

Bug: 784495
Change-Id: I8a797815817b364b0dcdd5e836cad40c571cb2fa
Reviewed-on: https://chromium-review.googlesource.com/978862
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550687}

This flag is a no-op in WebRTC.

Bug: None
Change-Id: I2342618483bdd9b0458962c3773b98e9d28380ab
Reviewed-on: https://chromium-review.googlesource.com/1011394Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550686}

Changes OnceCallbacks to use TestCallbackReceiver.

Bug: 799044
Change-Id: Ifdad6592537490cdae8d9a8c95809db350fd4f11
Reviewed-on: https://chromium-review.googlesource.com/1011628Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550685}

Because the first policy cache will be loaded synchronously before local_state
creation. We'll miss its OnStoreLoaded/Error event as CloudPolicyService
has to be created after |local_state|. It means we won't know the result of
cache loading.

To resolve this, check the initialization status once the CloudPolicyService
has been created. Fetch policy from server if cache is not loaded properly.

Bug: 832694
Change-Id: Idd0b9e35ea2afded586b73c765197b5574ba3900
Reviewed-on: https://chromium-review.googlesource.com/1011211
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550684}

Also added web-platform-tests.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA

Closes https://github.com/w3c/pointerevents/issues/167

Bug: 827271
Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5
Reviewed-on: https://chromium-review.googlesource.com/986877Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550683}

The format should be:

/**
 * Description.
 *
 * @param {Foo} foo The foo
 * @return {Bar}
 * @private
 */

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48fbf027e16a07a37c5688cac41084bf500e7f93
Reviewed-on: https://chromium-review.googlesource.com/1005908
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550682}

One of the use-cases of auto is to remove duplicated type information:
  std::unique_ptr<X> x = std::make_unique<X>(...);
then becomes just
  auto x = std::make_unique<X>(...);
The benefit is code which is easier to read, without losing any
information about the type.

This CL is a follow-up after https://crrev.com/c/998194, which
introduced a line
  std::unique_ptr<ArcAppResult> copy = std::make_unique<ArcAppResult>(
That line is being shortened using auto.

Bug: 733662
Change-Id: I694330c283a453b5d2020c8ec237fafdf6572f20
Reviewed-on: https://chromium-review.googlesource.com/1011604Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550681}

We have a new way to trigger perf tests, migrating those
that run on mac and linux.

Bug: 757933
Change-Id: Ic6fda31c34d288b584d28a523d848944a0724519
Reviewed-on: https://chromium-review.googlesource.com/1010863Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550680}

This patch adds the Settings to launcher apps grid.
1. Added class InternalAppItem.
2. Added class InternalAppModelBuilder.

Bug: 824437
Test: InternalAppModelBuilderTest.Build
Change-Id: I0dd06e767527b73e7ed14ca4dbab3e26d5c6e075
Reviewed-on: https://chromium-review.googlesource.com/1007496Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550679}

TBR=nednguyen@chromium.org
NOTRY=true

Bug: 832686
Change-Id: Ia03388a34d307ddea50cd8158a4e09a2243dfe6e
Reviewed-on: https://chromium-review.googlesource.com/1012483Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550678}

Bug: 819793
Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db
Reviewed-on: https://chromium-review.googlesource.com/1012190Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550677}

Bug: 832380
Change-Id: I0f059b801826147a8e86a7ba141215e95f57c734
Reviewed-on: https://chromium-review.googlesource.com/1011646Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550676}

This avoids distributing STHs and SCTs to it and spending time verifying STH signatures
when they won't be used for anything.

Bug: 828665
Change-Id: I8cb6b67fcd12d9e4f875331d1eae9c44d9e74925
Reviewed-on: https://chromium-review.googlesource.com/1009913Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550675}

This CL reverts this commit which actually removes building the
unittests. It also adds the unittests to cast_tests.

https://chromium-review.googlesource.com/c/chromium/src/+/1005027

Bug: 73746352
Test: unittests

Change-Id: I341649507f0440a62905f8eccd442215388130dd
Reviewed-on: https://chromium-review.googlesource.com/1007842
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550674}

Two tokens were missing from the list: allow-orientation-lock and
allow-presentation. In addition, allow-downloads was reported as being
supported, when it actually depends on a runtime flag which is off by
default.

Bug: 739787
Change-Id: Iadea9ebf45c7c0b63e8775f5c10aaa0c764a6807
Reviewed-on: https://chromium-review.googlesource.com/1005414
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550673}

This partially reverts commit 0d72bb14.

Now libwidevinecdmadapter.so has been removed, fix the TODO and remove
default_fatal_linker_warnings since it's not needed anywhere.

Bug: 795158
Change-Id: Icbc62d55657f56cac45b252393d86a3e533f7597
Reviewed-on: https://chromium-review.googlesource.com/1011566Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550672}

Those fields are private. This removes one more obstacle to making
SSL_SESSION opaque.

Bug: none
Change-Id: I77f8ee631c6b1e0e2f26618d4b6fe8cb1aede9fe
Reviewed-on: https://chromium-review.googlesource.com/1011111
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550671}

Bug: 829773
Change-Id: I54489ef9b232a20065d3fe78d884609bb65b4a87
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1011411Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550670}

Allows iOS code in components/, e.g., AutofillManager, to use the class.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie43f72dc09bdce3e4165da9ad9700b79d83f6f5e
Reviewed-on: https://chromium-review.googlesource.com/1011102Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550669}

Without persisting them, server-side provided intervals are less efficient on
platforms with relatively short app lifetime.

This also allows lower poll intervals for latency-sensitive use cases in cases
when our notifications are not reliable enough (yet).

Bug: 832019
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I69abdc89273dd16301fb32f3a0df6ba51712adf3
Reviewed-on: https://chromium-review.googlesource.com/1010662
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550668}

- Creates a RestoreMounts() function that gets the remembered file systems
from the FSP service and then attempts to remount them. Any shares that fail
to remount will be unmounted from FSP so they are not remounted again.
- Logs when an attempted remount fails.

Bug: chromium:757625
Change-Id: Id7edf64150ddde1df912c8cc733dc2c834b42797
Reviewed-on: https://chromium-review.googlesource.com/990581
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550667}

This CL also adds some infrastructure for a more general "condition
tracker" in the throttle.

Bug: 829042
Change-Id: Ib8399025bed474395fa9b709c1b68469ccc34476
Reviewed-on: https://chromium-review.googlesource.com/1006378
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550666}

TBR=cmumford@chromium.org

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9e976ebd5d9a345f86980fe5b1e963c0c3f4b1fe
Reviewed-on: https://chromium-review.googlesource.com/1012128Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550665}

Removed section referencing Electron.

Bug: none
Change-Id: I37267cf9ca3a70cd004f3f96ae3b5a3b3c7c4af2
Reviewed-on: https://chromium-review.googlesource.com/1012188Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550664}

This CL implements UnifiedSystemTrayView::ChildPreferredSizeChanged so
that the bubble size grows when a notification is added dynamically
during the bubble is open.

TEST=manual
BUG=828752

Change-Id: I2a1146dd8d43b857d72d767987c7d31a8dfe8471
Reviewed-on: https://chromium-review.googlesource.com/1011462Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550663}

This CL adds a UI updater for the popup menu. This updater is in charge
of spotlighting the button acting as an anchor for the popup menu and
dimming all the other controls of the toolbar, reducing their alpha.

This new UI updater replace the TabHistoryUIUpdater as the TabHistory
is replaced by the popup menu.

Bug: 830552
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5dd7391d184c5177ffa3fb1fb5c2479098acb615
Reviewed-on: https://chromium-review.googlesource.com/1010348
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550662}

Creates a new class, SelfSizingTableView, which is a table view that
is capable of calculating its intrinsic size.
Use this class for the omnibox popup table view.

Bug: 821817
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc01dfcd20ed1f14e15162ac0085f40273747eac
Reviewed-on: https://chromium-review.googlesource.com/973617
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550661}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If6cd3d0db570e157d76183d5fc5a832340144dc3
Reviewed-on: https://chromium-review.googlesource.com/1005890
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550660}

We'd like to remove redundant enums from content/ and chrome/ related
to the Presentation API, and the associated typemapping code.

Eventually we will eliminate all the Presentation API typemaps from content/.

This change eliminates one enum from content, others will follow.

Bug: 817903
Change-Id: I944f114886bee6a10348f33a4355262f3feb5901
Reviewed-on: https://chromium-review.googlesource.com/1003772Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550659}

The target width can be set to zero when the action bar has no
icons. Zero in this case is a valid target width that should be
used instead of the current width when animating.

BUG=831560

Change-Id: Ib6604a9c56a6b922025cd3d3bce2773f78d3eda4
Reviewed-on: https://chromium-review.googlesource.com/1008871
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550658}

This is primarily motivated by the chrome://settings case, which
currently is never autocompleted because the builtin provider only
autocompletes in cases where there is a single suggestion. And any input
that matches chrome://settings also matches subpages such as
chrome://settings/autofill.

However, this change also affects one other current case,
chrome://chrome and chrome://chrome-urls. The former will now be inline
autocompleted.

Bug: 816450
Change-Id: I9671033c27c7f8bab1f7cfcbb2989e507e1aeee5
Reviewed-on: https://chromium-review.googlesource.com/976397
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550657}

TBR=jbudorick@chromium.org

Bug: 832374
Change-Id: I7500d930c5e8de66661e10867e35333d13d04355
Reviewed-on: https://chromium-review.googlesource.com/1011622
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550656}

The recording could have already being stopped by the time auto stop kicks in.

BUG=832332

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550655}

Bug: 758632
Change-Id: I12b77b94313845e2b38d03313915a23663363a5e
Reviewed-on: https://chromium-review.googlesource.com/1011574Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550654}

Currently media gallery api reads media data from a blob in browser
process with extension's blob reader.

This CL abstracts a factory class to create MediaDataSource, so that
Android can implement a different source that read data from local file.

Eventually, media gallery api will not depend on extension, which is
not supported on Android, and can have different data source.

Bug: 826021,826975
Change-Id: I6d9d6c0ffc8cbae42cd036af34fb4944cf25e685
Reviewed-on: https://chromium-review.googlesource.com/997012
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550653}

BUG=824954

Change-Id: I473641d51907cdab567df7110b6c4415876c03f8
Reviewed-on: https://chromium-review.googlesource.com/1011583Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550652}