- 25 Apr, 2018 40 commits
-
-
Alex Moshchuk authored
Now that last committed URLs are tracked on RFH instead of FrameTreeNode, there's no harm in keeping this URL around after a RFH becomes pending deletion. Keeping it might be useful for security checks on such RFHs, and not keeping it might actually lead to correctness issues when last committed URLs are checked for pending delete RFHs. Bug: 836211 Change-Id: I2090732bd1f1583430e2eafcf732965f43e00c44 Reviewed-on: https://chromium-review.googlesource.com/1026971 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553793}
-
Daniel Murphy authored
Creates the browser-side implementation of the SessionStorageNamespace mojo interface. The namespace holds the per-origin storage area and provides ways to both connect to the data and shallow-clone the data. TBR: jam@chromium.org for content/browser/BUILD.gn Bug: 716490 Change-Id: I9df5812afdacf4330728c590d47ecfdf93e320bd Reviewed-on: https://chromium-review.googlesource.com/1015894 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#553792}
-
Hwanseung Lee authored
unprefixed versions of the "grab" and "grabbing" CSS cursors were not supported at blink. Bug: 708197 Change-Id: I4d4b7e61884bc565526fb92374e40c9dc7ec36a6 Reviewed-on: https://chromium-review.googlesource.com/1012047 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#553791}
-
Manuel Rego Casasnovas authored
This is an issue that happens in Flexbox and Grid Layout and any other layout method that uses OverrideLogicalHeight. In LayoutBox::PerpendicularContainingBlockLogicalHeight() we were returning the OverrideContentLogicalHeight() plus the scrollbar height. That caused issue with orthogonal flows between flex/grid items and their children. The issue is fixed just following the suggestion in the TODO and using OverrideContentLogicalHeight() (which doesn't include the scrollbar height). BUG=836827 TEST=external/wpt/css/css-flexbox/percentage-size-subitems-001.html TEST=external/wpt/css/css-grid/grid-items/percentage-size-subitems-001.html Change-Id: I0c7586449067aab78430defc831b2774136e2f0b Reviewed-on: https://chromium-review.googlesource.com/1028012 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#553790}
-
Shimi Zhang authored
|PopupTouchHandleDrawable| is reacting to both native and Java for its visibility. When WebView is moved under other window/view, Java side will hide the handles and set their visiblity to |INVISIBLE|. Previously, Java setOrigin() only do invalidation when the view is visible, but if we do a selection and move the selection to under other window, and then do another selection, the visiblity will be preserved, so handles are not showing again. Native treated the second selection as selection handles moved event, there is no need to update the visibility from native's perspective. We should scheduleInvalidate() when native thinks the handle should be visible, scheduleInvalidate() will calculate the real visiblitiy against the current view hierarchy and do invalidation if necessary. Bug: 808701 Change-Id: I50dfa80d0299fd4692abba2c33b8a335bd455372 Reviewed-on: https://chromium-review.googlesource.com/1026834Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#553789}
-
Erik Luo authored
Marks common callbacks that produce no JS-observable side-effect, including - window.window - window.location - location.href - navigator.userAgent Bug: 829571 Change-Id: I9404104dc2cd30ffeafbfae83c53c0176a28e1b1 Reviewed-on: https://chromium-review.googlesource.com/1026991 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553788}
-
Steven Holte authored
Bug: 754892 Change-Id: I423630306e0a83cc02a78e4b0e1f99f908bfc24e Reviewed-on: https://chromium-review.googlesource.com/1022812Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#553787}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/26ad1acbcb4c..2157d8fa6f7e $ git log 26ad1acbc..2157d8fa6 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 bungeman [base] Avoid undefined behaviour in lcd filtering code (#53727). 2018-04-22 wl * src/base/ftoutln.c (FT_Outline_Decompose): Improve error tracing. 2018-04-22 apodtele [base] Fix bitmap emboldening. 2018-04-22 wl Revert "[base] Fix bitmap copying where the new pitch is smaller." 2018-04-22 wl [base] Fix bitmap copying where the new pitch is smaller. 2018-04-22 wl Another fix for handling invalid format 2 cmaps. 2018-04-19 apodtele Documentation tweaks. 2018-04-19 wl [autofit] Add support for Georgian Mtavruli characters. 2018-04-19 wl Fix handling of invalid format 2 cmaps. 2018-04-17 wl [truetype] Integer overflow issues. 2018-04-16 wl CHANGES: Mention CVE-2018-6942. 2018-04-16 wl [truetype] Integer overflow issues. 2018-04-15 ankit97dhankhar [docmaker] Make it work with python3. 2018-04-15 apodtele [build] Use `info' function of make 3.81. 2018-04-15 wl [truetype]: Limit `SLOOP' bytecode argument to 16 bits. 2018-04-14 wl [truetype] Integer overflow issues. 2018-04-14 wl [autofit] Update to Unicode 11.0.0. 2018-04-07 madigens Modernize CMake build. 2018-04-09 wl [truetype] Integer overflow issues. 2018-04-06 apodtele [windows, wince] Clean up legacy project files. 2018-04-04 wl [cff, type1] Sanitize `BlueFuzz' and `BlueShift'. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org BUG=chromium:834853 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1070 ChromiumOS-Issue: chromium:836302 Change-Id: Ibd486fc3983625a7a621ffd0680118c9794585ac Reviewed-on: https://chromium-review.googlesource.com/1025069Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553786}
-
Jun Choi authored
As hashing function is used frequently in converting parsing device response, add CreateSHA256Hash() to fido_parsing_utils scope. Bug: 798573 Change-Id: Ifc6ed40db6aca682548a75068701f6c0af7cfdce Reviewed-on: https://chromium-review.googlesource.com/1024924 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#553785}
-
https://chromium.googlesource.com/catapult.git/+log/55650fadabf7..d43ffede2b5c $ git log 55650fada..d43ffede2 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 simonhatch Dashboard - Clean up some histogram tests to use _CreateHistogram 2018-04-23 simonhatch Dashboard - Move Row._pre_put_hook contents to UpdateParentAsync() Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0d2db24d9ce4f3261c7e1a318857bed95c47cbd1 Reviewed-on: https://chromium-review.googlesource.com/1028557Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553784}
-
Takumi Fujimoto authored
MRUIService is instantiated at startup to show the Cast toolbar icon. This CL prevents that if the Media Router feature is disabled. Bug: 834719 Change-Id: I02fdecb1ca50940c2311d6491698764bc6275ec1 Reviewed-on: https://chromium-review.googlesource.com/1026975Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#553783}
-
Michael Spang authored
Since the surfaceless renderers inherit the surface renderers, we actually initially post two tasks to render frame. This results in tearing. Remove the duplicate post. As a followup, this inheritance should be removed since it is too error prone. Bug: 836971 Test: ozone_demo on eve Change-Id: If79edf65f6aba2cc239f0e349860d6b56ba82450 Reviewed-on: https://chromium-review.googlesource.com/1028844Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553782}
-
Lei Zhang authored
To make it possible to write a test client without having to write too many empty implementations. Change-Id: I45139957848a4d48e02740cc349605ab4b75e3a0 Reviewed-on: https://chromium-review.googlesource.com/1013997 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#553781}
-
Ian Kilpatrick authored
This if-stmt is now invalid as inside the NGExclusionSpace there is always at least one opportunity which has a block-end offset of LayoutUnit::Max(). Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4ca866e38b4aa764b3181c59e642e2a5be422a55 Reviewed-on: https://chromium-review.googlesource.com/1028351Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Doug Turner authored
This CL allows this test to toggle SetShouldNotRequireCTForTesting. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I31108cbbec240660c87209f65be067a0b30c9339 Reviewed-on: https://chromium-review.googlesource.com/999099Reviewed-by:
-
sunxd authored
RenderWidgetHostInputEventRouter sends all pinch gesture event to root frame, but this might be a problem when the subframe has touch action restrictions. To avoid allowing pinch zoom when the target element in the subframe has touch-action:none property, this CL makes RWHIER checks the target frame and drop the event if touch action filter rejects the pinch. Bug: 827182 Change-Id: Ifa566446e8c695d934aad4bcaaef49af0cde76e2 Reviewed-on: https://chromium-review.googlesource.com/1007892Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#553778}
-
Fredrik Söderquist authored
unitlessZeroFeature -> unitless_zero_feature negativeSize -> negative_size threeValuePosition -> three_value_position Change-Id: Id42906e518e6780bfa601031d8ad00430b2f48b4 Reviewed-on: https://chromium-review.googlesource.com/1027878 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This is a reland of be8138a4 The issues with the previous attempt were addressed in the latest Clang roll (#553415). Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > Reviewed-on: https://chromium-review.googlesource.com/983632 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551367} Bug: 792131 Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b Reviewed-on: https://chromium-review.googlesource.com/1028374Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553776}
-
Michael Thiessen authored
Some apps roll their own intent dispatching code, and their intent dispatching code is incorrect, so they end up erroneously firing 2D intents explicitly to the VR launcher. If either the intent doesn't have the Daydream category, or the system isn't in a VR session (meaning launchInVr definitely wasn't used), retarget the intent back to the 2D launcher. Tested on a local Chrome dev build, verified it fixes b/78239314 too. Bug: 836209 Change-Id: I779c7bf3820ddd50650eb6752d720246a86d24b1 Reviewed-on: https://chromium-review.googlesource.com/1028572 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553775}
-
Luke Zielinski authored
Bug: 817377 Change-Id: I5eb7768bdd8e20b5841de3cf56f6f8ed47ec6922 Reviewed-on: https://chromium-review.googlesource.com/1020062Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL adds two metrics in drm_util.cc: - DrmUtil.CreateDisplaySnapshot.HasEdidBlob (boolean): to detect whether an EDID blob is detected in the CreateDisplaySnapshot function. There are no existing unit tests for this function, so no tests are added for this metric. - DrmUtil.GetColorSpaceFromEdid.ChecksOutcome (histogram): to detect whether the sanity checks pass in the GetColorSpaceFromEdid function (or which one fails). Existing unit tests are modified to test this metric. Also, some unused includes are removed from drm_util_unittest.cc. Bug: 829506 Change-Id: Ib1cfc14577630e6649640da9b0a0b663a36296d5 Reviewed-on: https://chromium-review.googlesource.com/1014522 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#553773}
-
Oksana Zhuravlova authored
This change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. Bug: 646113,799482 Change-Id: Iebebef972fc8e503c030639c8aefa0909bfcdbf9 Reviewed-on: https://chromium-review.googlesource.com/1024286 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553772}
-
Joy Ming authored
Include in-product help to let users know that there is the option to change download storage location through the download settings option in downloads home. Screenshot: https://drive.google.com/file/d/1EcJkOUnKa0W3DldtmMPgugG6rGIdNqd8/view Bug: 792775 Change-Id: I90932e6c647e2d46a24a13e80d71fc30df8a4da1 Reviewed-on: https://chromium-review.googlesource.com/1020458 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#553771}
-
James Hawkins authored
The state is 'Enabled' if the user has enabled the feature, 'Disabled' if the user has disabled the feature, and 'Unset' if the user has never enabled the feature. R=asvitkine@chromium.org, hansberry@chromium.org Bug: 831371 Test: none Change-Id: Id7f6207d2763d259cbb117457bc0e968fa6fcd3b Reviewed-on: https://chromium-review.googlesource.com/1026936Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#553770}
-
Daniel Cheng authored
WebContentsImpl now tracks the last time it received an input event that could be considered user interaction. When the browser process receives a WebUI message that requires a user gesture, it checks the WebContents hosting the WebUI to make sure that the user recently interacted with it. This also cleans up a few incidental bits of code: - RenderWidgetHost no longer prefilters events before notifying the delegate. This exposed some broken event filtering, tracked at https://crbug.com/827659. - Since the delegate method no longer prefilters input events, RenderWidgetHostDelegate::OnUserInteraction() is now named RenderWidgetHostDelegate::DidReceiveInputEvent(). TBR=isherman@chromium.org Bug: 823864 Change-Id: I9237052dbd325d8e578bfa904a8779533b63b2f9 Reviewed-on: https://chromium-review.googlesource.com/1028484Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL handles key events (onKeyUp, dispatchKeyEvent) by forwarding them to native first like the others. They are consumed by content components such as ImeAdapter, TapDisambiguator, etc. Introduced a couple of new classes for this flow to work: KeyEventAndroid: New object for Android key event, used to let it through the ViewAndroid tree and hit testing logic like other types of events. Hit testing is not necessary for key events since they don't have location information, but devised to process them in the same pattern. First EventHandlerAndroid (which is WCVA) is regarded to have the focus, and always expected to consume it. ContentUiAndroid: Bridges native and Java for the new events. Used to pass them back up to Java layer from EventHandlerAndroid(WCVA). Bug: 622847 Change-Id: I991274f9ecb49b739ab0f798390d7918a7e4bb37 Reviewed-on: https://chromium-review.googlesource.com/1018682Reviewed-by:Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553768}
-
Ryan Daum authored
New interface (with default stub implementations) with the following: * Pass the event location rather than the underlying event (so that touch events or other data sources can be used instead of gesture events) * Method to query the handler whether it can handle a given event origin so we can avoid detecting (or blocking) margin events unnecessarily. * Adds a method for continuation/drag events. Bug: internal b/78462154 Bug: internal b/78461207 Change-Id: I1bba715e98b6458bf079cacd71b4ef3403ae7260 Tested: manual test Reviewed-on: https://chromium-review.googlesource.com/1028656 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#553767}
-
Minh X. Nguyen authored
Change-Id: I8476314132a3c8f48a8043f620658bc48276f2aa Reviewed-on: https://chromium-review.googlesource.com/1026704Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553766}
-
Daniel Murphy authored
Bug: 716490 Change-Id: Ie4ace578d7076c515d9ed1ef3dbb1494eeb3a550 Reviewed-on: https://chromium-review.googlesource.com/1028717 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Min Qin authored
Chrome annotates downloads with the source URL to allow platform security features to treat downloads with appropriate suspicion. If the download was conducted in off-the-record mode, we should not annotate the download with the real URL to avoid a privacy leak. On Windows, using an empty URL results in marking the download as originating from "about:internet", a generic Internet-zone URL. BUG=813764 Change-Id: I1dfe652051d43a0c4f3ee2742882b1affa946c57 Reviewed-on: https://chromium-review.googlesource.com/1026455Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553764}
-
Daniel Cheng authored
The type isn't super obvious from the context, so just write it out. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1781ddea2b744141c6fc2c4e9bb5b9788cb25333 Reviewed-on: https://chromium-review.googlesource.com/1028567Reviewed-by:
-
Artur Khachatryan authored
Test ObjectStateAssumptionsTest.testinitializedWebDriverDoesNotThrowNPE is flaky on Android Chromium build bot. Disabling test for now. Bug: chromedriver:2401 Change-Id: Ib7038e3de7108eceb8c5092400ae9b4a6747b60e Reviewed-on: https://chromium-review.googlesource.com/1028762Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553762}
-
Charlie Harrison authored
These metrics are not tracked, and the code is not really being maintained. Bug: None Change-Id: I030919ac8a2cf4e744ed120cdbcab282dcc6aea1 Reviewed-on: https://chromium-review.googlesource.com/1027800 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553761}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=dominickn@chromium.org Bug: 825327 Change-Id: I5c912f4262563d87f0043f3a8eff0e7792751256 Reviewed-on: https://chromium-review.googlesource.com/1024431Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553760}
-
Fredrik Hubinette authored
On X11, primary monitor is often set to an inactive output. However, nvidia-control-panel and other tools will still show that one of the active montiors is the primary one. While I'm not sure how this works, the list of monitors returned by xrandr --listmonitors should always have the primary monitor first, so let's fall back on the order of the monitors if available. Change-Id: I9f06754d95130957338a8dfcc4541ef350794b49 Reviewed-on: https://chromium-review.googlesource.com/1020150Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553759}
-
https://skia.googlesource.com/skia.git/+log/27988f76b25e..25af671a3d7d $ git log 27988f76b..25af671a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 egdaniel Add GrCap check for whether we can do a copy or not, and implement in Vk backend 2018-04-25 borenet [infra] Run presubmit like a normal bot 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms a893aa3..2c9b55f (1 commits) 2018-04-25 enne Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 bungeman Clean up xfermodes3 gm. 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 509a65e..a893aa3 (1 commits) 2018-04-25 liyuqian Snap bitmap for SkThreadedBMPDevice::drawBitmapRect 2018-04-25 bsalomon Revert "Revert "Add arcs as a specialized geometry to GrShape."" 2018-04-25 kjlubick Move Baytrail to stretch 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits) 2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits) 2018-04-25 brianosman Don't 'require' external image extensions, 'enable' them 2018-04-25 reed Experiment to track coverage in a layer 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits) 2018-04-24 ethannicholas cache SkSL headers 2018-04-24 benjaminwagner Upgrade Win Radeon driver. 2018-04-25 robertphillips Fix GrRRectBlurEffect.fp 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 40a5028..f3a576b (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 86807d3..40a5028 (1 commits) 2018-04-25 kjlubick Migrate ShuttleA bots to Debian9 stretch Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I573306e5aee3463fe005e9f9ae679ee0fa7bdf95 Reviewed-on: https://chromium-review.googlesource.com/1028625 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553758}
-
Esmael El-Moslimany authored
Bug: 781703 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If6fda4644b20764c0561d03a826c97e561f80337 Reviewed-on: https://chromium-review.googlesource.com/1024967 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553757}
-
https://pdfium.googlesource.com/pdfium.git/+log/d9da586dd3db..7132ee35925f $ git log d9da586dd..7132ee359 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 thestig Clean up CCodec_FlateScanlineDecoder. 2018-04-25 tsepez Introduce ScopedFPDF types in public/cpp/fpdf_scopers.h 2018-04-25 rharrison Allow failing to build CFXA_FWLTheme if unable to load fonts 2018-04-25 thestig Remove unused PNGEncode() code. 2018-04-25 thestig Roll third_party/googletest/src/ a325ad2db..4bd8c4638 (125 commits) 2018-04-25 thestig Use WindowsPrintMode in more places in place of ints. 2018-04-25 hnakashima Fix behavior of Delete key in XFA edit. 2018-04-25 tsepez Fix slight type inconsistencies discovered with strict FPDF API types. 2018-04-25 thestig Remove CDWriteExt. Created with: roll-dep src/third_party/pdfium BUG=chromium:835608,chromium:820104 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib3baadc56b41581755208c483b861b5587ef7953 Reviewed-on: https://chromium-review.googlesource.com/1028661 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553756}
-
Ken MacKay authored
Add a new content type with no per-type volume control (only per-stream). Bug: internal b/78533406 Change-Id: If0d7280c54ba95fd583e7292814e476862d52335 Reviewed-on: https://chromium-review.googlesource.com/1026452 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#553755}
-
Jun Choi authored
Implement anonymous set of functions that extract U2F request commands from WebAuthN style Ctap{MakeCredential GetAssertion} Request. Bug: 798573 Change-Id: I3431b0769db20b39a2e590d5a7d4136a3a920fe8 Reviewed-on: https://chromium-review.googlesource.com/1018739 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
-
