- 20 Feb, 2020 40 commits
-
-
Fredrik Söderquist authored
Bug: 109224 Change-Id: I67ef67e356e67797c90d296fe411c96a2f76cfea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065007 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#743233}
-
Rayan Kanso authored
Bug: 1051508 Change-Id: I7204e38b3542c322c67030435339a943d7a0c0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054229 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#743232}
-
Lei Zhang authored
Still slowly working through the launch. Also add another owner. Bug: 477699 Change-Id: I3c6dd7e7f0236a0e803a23c32e6716c493bd3c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066278 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#743231}
-
Sylvain Defresne authored
Since AppDistributionProvider is a base class with no-op method implementation, TestAppDistributionProvider is unnecessary (its method have the same implementation as the base class). Remove the sub-class. Bug: none Change-Id: I73ba4d5e0cb3bf4a39efccb694fa77c421eece57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064187Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743230}
-
Wenyu Fu authored
Bug: 1053131 Change-Id: I7c4f445a22b3fef2c56eab573b884d3e163e37cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063534 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/74d3f371f201..3cfba7f05be4 git log 74d3f371f201..3cfba7f05be4 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com Revert "VK_EXT_shader_stencil_export support" 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support Created with: gclient setdep -r src/third_party/swiftshader@3cfba7f05be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I96f168f531234543a96e93a20e36c479fac9201e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/099ad342..c9de129a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I44c73b32049b674baa1da7c01edae315b2ce5263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067297Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743227}
-
Nazerke authored
HistoryLocalCommands isn't configured through the dispatcher. This CL renames this protocol (HistoryLocalCommands) to "HistoryUIDelegate", and renames all of the "localDispatcher" properties to be named "delegate". Change-Id: I7fc79e2053292e994ef2db1129b78575fee5112d Bug: none. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062446 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#743226}
-
Jochen Eisinger authored
Bug: 1051415 Change-Id: I2b535953f2fc90a755bd784ceeae2fb86dc9ba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063002 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#743225}
-
Yue Li authored
Bug: None Test: git cl format Change-Id: I1d8938e550b36186d0edd2d9ab5f0034f6e0127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065737Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#743224}
-
Oksana Zhuravlova authored
This change adds a condition so that the renderer part of the contextual search code is only created when the corresponding build flag is defined. It also updates the browser-side ContextualSearchJsApiService interface binder registration depend on the same build flag rather than the more generic OS_ANDROID condition. Bug: 1047680 Change-Id: Ia0c88558736b028b96b0092acb6dde4a7a526b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055992Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743223}
-
Mehran Mahmoudi authored
This fixes a problem in chrome/android/BUILD.gn that caused the paint preview instrumentation test suite to run on monochrome_public_test_ar_apk. Bug: 1050548 Change-Id: I5837016a7ae08d67fc2bf9012a31294aa61c6e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057499Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743222}
-
Avi Drissman authored
Bug: none Change-Id: I355076b24666e0b17fe56ca52c7c878e0f1975fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065854 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#743221}
-
Oriol Brufau authored
Before this patch, list markers were anonymous boxes in legacy layout. This patch makes them be pseudo-elements instead. This is a follow-up of r731964, which did the same for LayoutNG. Just like r731964, this patch improves the flexbox_with_list_item.html performance test by a 30-40% (this time for legacy). BUG=457718 TEST=editing/execCommand/create-list-1.html-disabled TEST=editing/pasteboard/drag-selected-image-to-contenteditable.html TEST=editing/pasteboard/input-field-1.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/move-by-line-002.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html TEST=editing/unsupported-content/list-delete-001.html TEST=editing/unsupported-content/list-type-after.html TEST=editing/unsupported-content/list-type-before.html TEST=external/wpt/css/css-pseudo/marker-content-014.html TEST=external/wpt/css/css-pseudo/marker-content-019.html TEST=external/wpt/css/css-pseudo/marker-content-020.html TEST=inspector-protocol/resources/dom-snapshot-pseudo-element.html TEST=paint/invalidation/list-marker-2.html TEST=paint/invalidation/offset-change-wrong-invalidation-with-float.html Change-Id: I58c8d49e1f2168add3c78a024a2b9371b34262d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007733 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#743220}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4386ad19fb62..7b0ed557a98e git log 4386ad19fb62..7b0ed557a98e --date=short --first-parent --format='%ad %ae %s' 2020-02-20 robertphillips@google.com Start precompiling DDL shaders Created with: gclient setdep -r src/third_party/skia@7b0ed557a98e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ic2d64bd9090c2fffb886338c12ce89de89e9b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067125Reviewed-by:
-
Klaus Weidner authored
Instead of depending on Fullscreen API's styling, use a separate :xr-dom-overlay pseudoclass with its own copy of the relevant styles. Lazy-load this stylesheet when DOM Overlay mode is active. Update the Fullscreen API integration to specifically allow XR session setup to configure the fullscreen element, while blocking app-side element changes to avoid inconsistent behavior. Update the WPT test to cover more scenarios and improve compatibility with potential implementations that aren't screen space. Bug: 991747 Change-Id: I2b578570f695f72019c7efccb4c797cdb90e87f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057120Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743218}
-
Rakib M. Hasan authored
Instead of using typ's methods to get the test expectations, we should use blinkpy's methods. Bug: 986447 Change-Id: I58508a44536ccc73864c1acd10c2be06af82a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067377Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#743217}
-
Tim van der Lippe authored
Has to be updated for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067057 TBR=jacktfranklin@chromium.org Bug: 1050549 Change-Id: I79583541c6e1ae13311d55e1c72e762b4da3ed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066780Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#743216}
-
rajendrant authored
This previews bit should be set only when SaveData is enabled and irrespective of LazyLoad feature. Bug: 1047330 Change-Id: I709b96b9518c449a7846634ff44c20b5bf96535d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039895 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#743215}
-
Samuel Huang authored
This reverts commit 4eb9ce3d. Reason for revert: Compile error: Moved file (e.g., vector_icons.cc.template) needs to have #include updated as well. Original change's description: > Move shortcut viewer to ash/ > > Next step: > * Consolidate string grd file into single shortcut_viewer_strings.grd > * Remove NewWindowDelegate::ShowKeyboardShortcutViewer > and open it directly. > * Remove KSV_EXPORT > > Bug: 1046624 > > Change-Id: I4241bd00d5c27520ac11c09e7264e8c8c9729a84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065852 > Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743191} TBR=jamescook@chromium.org,oshima@chromium.org,thakis@chromium.org,wutao@chromium.org Change-Id: I1de5281e9e8ff07850b200dc798d27e0b0b340cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067245Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743214}
-
Jonah Chin authored
This reverts commit 2a3b1189. Reason for revert: crbug.com/1054408 Original change's description: > Add a PaintRecorder to CanvasResourceProvider > > This CL is the first step in creating a PaintRecord backed resource > provider for canvas OOP-R. > > Changes of ownership: > - PaintRecorder entirely moved from Canvas2DLayerBridge to > CanvasResourceProvider. > - Management of needs_flush_ for MemoryManagedPaintRecorder moved to > CanvasResourceProvider. > - RestoreCanvasMatrixClipStack logic centralized to CanvasResourceHost > and can be accessed via callback > - Backing SkiaPaintCanvas now private to CanvasResourceProvider with no > external access. Any users of the backing SkiaPaintCanvas in > Canvas2DLayerBridge had their functionality moved to > CanvasResourceProvider (ie. new RestoreBackBuffer() function) > > Updates to test files: > - Addition of explicit FlushCanvas() calls in tests that used to expect > SkiaPaintCanvas to immediately update. > - Some tests expected the CanvasResourceProvider to be created on first > draw. This expectation has been changed since the > CanvasResourceProvider now gets set up on SetCanvasResourceHost(). > > Other new functionality: > - Display Item List now has a bit that tracks if it contains any draw > operations. This is used to see if there are draw ops to flush. > > Bug: 1019288 > Change-Id: I717b18e22d6699dc876d8f8121a25d147738579d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891292 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743002} TBR=senorblanco@chromium.org,fserb@chromium.org,khushalsagar@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org,jochin@microsoft.com Change-Id: Icd1e97d26d3b4b46598f02c03b163ba31a1c2881 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067239Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743213}
-
Nicolás Peña Moreno authored
This CL adds a test for FID that tests equality between the JS value and the value reported in UKM and in UMA. Change-Id: I00de8c947895700d86788ee4a95ea228458bb25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067077 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#743212}
-
David Black authored
In response processing v2, the pending response will be committed at the earliest opportunity so that it can begin rendering. This CL should *not* affect response processing v1. Follow up CLs will make additional changes to processing logic and rendering logic to accommodate this new streaming model. Bug: b:129411551 Change-Id: I86c22929eb24945f104a06fbbe5ae0b1468caa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063264 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743211}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: I83081fc50722f30217ce10f689f197372dc6e636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065408 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#743210}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2156c444568a..b4357d46c6c6 git log 2156c444568a..b4357d46c6c6 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 courtneygo@google.com Update expectations after swiftshader fix 2020-02-20 cnorthrop@google.com Vulkan: Update ES 3.1 test expections 2020-02-20 jmadill@chromium.org Const-ify the validation layer. 2020-02-20 xinyi.he@arm.com Vulkan: Implement eglWaitNative function 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 113d07a6ebda..c12493ff69e2 (3 commits) 2020-02-20 tobine@google.com Vulkan:Skip appendToStartedRenderPass() 2020-02-20 wez@chromium.org [fuchsia] Migrate to SDK-provided FIDL & package targets. 2020-02-20 jmadill@chromium.org Vulkan: Fix image queue changes with graph disabled. 2020-02-20 syoussefi@chromium.org Update status of ANGLE conformance 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 8def9063c4fd..74d3f371f201 (1 commits) Created with: gclient setdep -r src/third_party/angle@b4357d46c6c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050703 Tbr: cwallez@google.com Change-Id: Id3154867665a8d4c323b259863d20c1133042ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067078Reviewed-by:
-
Demetrios Papadopoulos authored
This is in preparation of further refactoring of the settings-site-settings-page UI element. Bug: 1032584 Change-Id: I0b93a853d97d1141eb7bca215ad23e2a36e27851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065913 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743208}
-
Wez authored
Blink's heap tracing has been fixed to scan safe-stack stacks correctly so we can now defer to the toolchain default setting. Bug: 821951, 1050703 Change-Id: Iaa3204fcd8f22e8f2334e4b4b3a7adc3dad612c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064938 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743207}
-
Jose Lopes authored
This is meant to be called at most once if the CDM creation fails: https://cs.chromium.org/chromium/src/media/base/cdm_factory.h?rcl=35ac0b549d21e712319c0bc304fd9de6cba74ecf&l=20 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I1e7bfb134fe90a9f3e239b8dd45a69d6253347d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047188 Auto-Submit: Jose Lopes <jabolopes@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743206}
-
Victor Costan authored
This CL should not introduce any functional change. introduced that blocks its usage. Its occurrence in AppCacheURLLoaderJob blocks upcoming changes to the class. mojo: :DataPipe was documented as deprecated, and a presubmit check was Change-Id: Ib0213d83d41ad2149a7928bcad9180482efb7ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066299 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a9f14d4ed59b..eed27fa60f1b Created with: gclient setdep -r src-internal@eed27fa60f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094 Tbr: jbudorick@google.com Change-Id: I03b70c01eb2e87c3c2c497fccd6f19e487f80742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067120Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743204}
-
Ella Ge authored
Test is flaky. TBR=benwells@chromium.org No-try: true Bug: 1054196 Change-Id: I0d82f7d1b3c1350bf0d97b22fc2388d5de8a0b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067281 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#743203}
-
Omer Katz authored
Bug: 1053542 Change-Id: Ifb2fa71cb1a806187663a0f393103f20cff73711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066839Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743202}
-
Matt Wolenetz authored
Renames HTMLMediaSource (in core/html/media) to be MediaSource, and renames MediaSource (in modules/mediasource) to be MediaSourceImpl. This follows more recent practice in core/html/media. See also related code review comment [1]. [1] http://crrev.com/c/2003402/9/third_party/blink/renderer/core/html/media/html_media_source.h#50 BUG=878133 Change-Id: I143718c2b9bf8a2e32ad29e31c15094ae32da3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065421Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Victor Costan authored
This CL breaks down a long if/else if/.../else block into smaller blocks, using early returns. No functional changes are introduced. Change-Id: I329599ac5a8bb54408e8c0c657b40d330b76765f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065357 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Victor Costan authored
The base::SupportsUserData::Data superclass seems to be left over from a previous architecture. It adds cognitive overhead, as it implies that AppCacheRequestHandler may be used in a base::SupportsUserData container. Change-Id: Ibe61b6cec71ebd513eb8ccd896845d4c04b47f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066104 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf2de16258dc..8ef250cfe144 git log bf2de16258dc..8ef250cfe144 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 tvanderlippe@chromium.org Remove typedefs from {perf_ui,persistence,protocol}-legacy.js 2020-02-20 tvanderlippe@chromium.org Add e2etest for cacheable responses in the network panel 2020-02-20 tvanderlippe@chromium.org Add test for utf-8 character encoding Created with: gclient setdep -r src/third_party/devtools-frontend/src@8ef250cfe144 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie96e85bdabc6c432b4ab251cc069912b827a782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066089Reviewed-by:
-
Ella Ge authored
TBR=kyleju@chromium.org No-Try: true Bug: 856601 Change-Id: I08b33a249252e2615cd26fb26ac43e1113d1a028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067243Reviewed-by:
-
Changwan Ryu authored
Currently, it takes 120 seconds for 2,000 Hz sampling, and it takes more than 5 minutes for 10,000 Hz sampling. This is slow because of the use of double loops. This can be avoided by using a hashmap (dict) and a single loop with a more lenient pattern matching. (ntfschr@'s idea) With this change, the address matching part takes < 1 second. Also, this adds some more logging to understand what is going on, and adds a test case around the address that was not recognized. Test: run_simpleperf_test covers this Test: output result looks correct. Bug: 1048428 Change-Id: I795c83133baeb07f8b78342d94e6d3b227eebd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063811 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743196}
-
Toni Barzic authored
Back button tests - update test setup to set accessibility setting that forces the back button to be shown (as the tests verify actual button functionality). ShelfLayoutManagerWindowDraggingTest.DraggedMRUWindow - for drag from bottom tests, use the shelf bottom directly instead of current test case widget bounds (to handle the case where navigation widget is hidden, and thus has 0 size). ShelfLayoutManager.PressHomeButtonOnAutoHideShelf, and ShelfViewTest.HomeButtonMetricsInTablet- the tests verify the button functionality, so set accessibility setting to force it to be shown. BUG=1051714 Change-Id: If6f65ef16530af2ca655101698a8a00857dc6da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063730 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743195}
-
Kenneth Russell authored
Per request on https://chromium-review.googlesource.com/2029236/ . Bug: 1048907 Change-Id: If19466721c616114affbde9d65cdd19bd69c5980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040445Reviewed-by:
-
