- 25 Jan, 2018 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b6f7025955d6..be84b720c778 $ git log b6f702595..be84b720c --date=short --no-merges --format='%ad %ae %s' 2018-01-25 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 68981eb56..2e551f6bc (1 commit) 2018-01-24 reed compose and combine maskfilters 2018-01-24 scroggo Remove unused field/methods 2018-01-24 fmalita [skottie] Cache the last keyframe 2018-01-24 stani Revert "Increase depth threshold for SkClipStack::isRRect." 2018-01-24 fmalita [skottie] Animator scrubbing 2018-01-24 benjaminwagner [bazel] Add third_party to skia_all_hdrs 2018-01-24 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 01b21b194..68981eb56 (2 commits) 2018-01-09 mtklein Start of cross process SkScalerContext. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I838b444c69bf53a668abe9cf1fb54b2e79ef7256 Reviewed-on: https://chromium-review.googlesource.com/885861Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531845}
-
Takuto Ikuta authored
This is follow up of pool support in action https://codereview.chromium.org/2926013002 Using action pool can remove some overhead of many running process. Pool support of action_foreach gives better control for some python generator step when using goma. e.g. https://codereview.chromium.org/2726103005 Bug: 695864 Change-Id: Ibd0bbaffc59513db42119138520aee3505762eee Reviewed-on: https://chromium-review.googlesource.com/882625Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#531844}
-
Matt Falkenhagen authored
The non-PlzNavigate code path is no longer supported. R=shimazu Bug: 789577 Change-Id: Id0b61bd9042769d3afdcb78df6913632d833d831 Reviewed-on: https://chromium-review.googlesource.com/885687Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#531843}
-
Han Leon authored
BUG= Change-Id: I6b5b28230390de1f3b8a105c1f750fc394dfe923 Reviewed-on: https://chromium-review.googlesource.com/886004Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
As of crrev.com/531516, all of the WTF counterparts of those base classes are now simple aliases to the base ones. Now, we can start using the base classes in Blink. Bug: 763980, 794845 Change-Id: Ica8d81549ed6d7fd4f56ed03d22562c973e8a00e Reviewed-on: https://chromium-review.googlesource.com/886041Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531841}
-
Takuto Ikuta authored
rebase_path("//.") is resolved to the path like "$HOME/chromium/src". But it is necessary to be like "$HOME/chromium/src/out/Release" for higher cache hit rate when using goma. This patch allows us to share goma backend cache where we build in different out directory like out/feature_a and out/feature_b if compile requests has only difference of cwd and -fdebug-prefix-map flag. If we use same args.gn with linux_chromium_rel_ng, this patch allows us to use cached result generated by buildbot even if we do not clone chromium to path like '/b/c/b/linux/src/' and 'out/Release'. Note that some generated files having directive like `#include "out/Release/..."` is not normalized, but there is a few such tasks. Change-Id: I1232415aeedc98dc203e9d7582839bcc1cdbefc6 Reviewed-on: https://chromium-review.googlesource.com/882712 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531840}
-
Rakina Zata Amni authored
crrev.com/c/808446 is reverted because of failure in ASAN Buildbot Revert CL Link: crrev.com/c/880264 Failure link: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618 The failure is accessing *target_ancestor_iterator when it is out of bounds. Link: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeScope.cpp?q=Treescope.cpp&sq=package:chromium&rcl=dd944882a245a5117b50cb417138d92f32d931d6&l=393 as there were no bound checks for target_ancestor_iterator. It wasn't caught by layout tests because it's still returning the correct results, because it doesn't crash when getting *target_ancestor_iterator when it's out of bound. It just stops the while-loop and returned at https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeScope.cpp?q=Treescope.cpp&sq=package:chromium&rcl=dd944882a245a5117b50cb417138d92f32d931d6&l=398 Also, since the ASAN buildbot is not done before the CL is merged, this wasn't caught by trybots prior to committing. The fix is just adding a bound check for target_ancestor_riterator here: https://chromium-review.googlesource.com/c/chromium/src/+/880741/2..3/third_party/WebKit/Source/core/dom/TreeScope.cpp I have confirmed by using ASAN locally that it is fixed now. Before the fix, running the failing tests with ASAN build fails. Bug: 759947,805039 Change-Id: I9934af8131f285045e0eb80923f190b6d88cef7d Reviewed-on: https://chromium-review.googlesource.com/880741 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531839}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/adcf0ae6162d..2e551f6bc5f2 $ git log adcf0ae61..2e551f6bc --date=short --no-merges --format='%ad %ae %s' 2018-01-24 ynovikov Vulkan: Fix DebugReportCallback definition 2018-01-23 oetuaho Track parameter qualifiers of functions in call nodes 2018-01-23 ynovikov Vulkan: use supported composite alpha 2018-01-23 ynovikov Vulkan: get render target format from config 2018-01-24 lucferron Revert 3 files from previous merge 2018-01-23 lucferron Support correct validation for samplerParameterf with GL_TEXTURE_MAX_ANISOTROPY_EXT 2018-01-23 jmadill Vulkan: De-couple Program from VertexArrayVk dirtyiness. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I88519d7de8f6b8e9a4a8b4429db4363f676f5a99 Reviewed-on: https://chromium-review.googlesource.com/886002 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531838}
-
Xianzhu Wang authored
Setting descendants MayNeedPaintInvalidation() is not enough for invalidation of objects with fixed attachment background because they can't figure out the requirement during paint invalidation. We must invalidate them explicitly. The test (paint/overflow/fixed-background-scroll-in-frame.html) happened to succeed in SPv1 and fail in SPv175 because LocationInBacking of the target object changed in SPv1 but SPv175 doesn't use that. Bug: 805049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9726715fc0e9ebb30b53ac59b7bad299a273d598 Reviewed-on: https://chromium-review.googlesource.com/884831Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531837}
-
Megumi Hattori authored
This CL adds the paper plane icon as the reply button. The icon is placed to the right of the text field in the inline reply. In this CL, the name of NotificationInputMD is changed to NotificationInputTextfieldMD, and another container view, NotificationInputMD is added on top of NotificationInputTextfieldMD and NotificationInputReplyButtonMD. This CL does not include the following features. - Change the icon color when the textfield is clicked - Send message when the icon is clicked Bug: 803759 Change-Id: I20fe6455a8f3184d188d93892b1fc7c03764b1f4 Reviewed-on: https://chromium-review.googlesource.com/876182Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#531836}
-
Takashi SAKAMOTO authored
- virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html, - virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html, and - virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html TBR=joedow NOTRY=true Bug: 805794 Change-Id: Id7710e3d04f23d84ab289669c588f6c486803b71 Reviewed-on: https://chromium-review.googlesource.com/885667 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#531835}
-
Olga Sharonova authored
There is no need in a extra jump to IO thread, since AudioSystem can handle requests on UI one. Change-Id: Icb0413f1ec7af23254303824fe2da28734a79b1d Reviewed-on: https://chromium-review.googlesource.com/883128 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531834}
-
Olga Sharonova authored
This is a spin-off from a WIP https://chromium-review.googlesource.com/c/chromium/src/+/875927 Bug: 792441 Change-Id: I1d6e256653fa7fa81dd6c6b23edd9be9446b0640 Reviewed-on: https://chromium-review.googlesource.com/883203Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#531833}
-
Koji Ishii authored
This patch rebaselines 23 image failures due to only text rendering differences in editing/selection and editing/unsupported-content. Tests to rebaseline are picked up by manual review. TBR=yosin@chromium.org, yoichio@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib981d1312a1fed8274351daa74c6a5043046461f Reviewed-on: https://chromium-review.googlesource.com/885662Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531832}
-
Christian Fremerey authored
This reverts commit 2e8b1501. Reason for revert: Failing tests on webrtc bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/24669 Original change's description: > Reland: Win video capture: use IMFCaptureEngine for Media Foundation > > Fixes for reland number 5: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > > Fixes for reland number 4: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 3: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 2: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 1: > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Original description: > - Full rewrite of the MediaFoundation implementation video part to use > IMFCaptureEngine > - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities > - takePhoto triggers a still image capture with the highest available > resolution without stopping the video stream thanks to IMFCaptureEngine > > TEST=adapted video_capture_device_unittest.cc and > webrtc_image_capture_browsertest.cc; launch Chrome with > --force-mediafoundation on Win8+ and capture video using > e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ > > TBR=mcasas@chromium.org > > Bug: 730068 > Change-Id: If081d29402e9f595a3fd1906e45a3bec1d712b3a > Reviewed-on: https://chromium-review.googlesource.com/734042 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#521435} > Reviewed-on: https://chromium-review.googlesource.com/810766 > Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#524417} > Reviewed-on: https://chromium-review.googlesource.com/843974 > Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#527139} > Reviewed-on: https://chromium-review.googlesource.com/852455 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Original-Commit-Position: refs/heads/master@{#528005} > Reviewed-on: https://chromium-review.googlesource.com/858138 > Cr-Original-Commit-Position: refs/heads/master@{#531109} > Reviewed-on: https://chromium-review.googlesource.com/880944 > Cr-Commit-Position: refs/heads/master@{#531791} TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com Change-Id: Idae6023d22c51e2df66687729ea0df5232c67fc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730068 Reviewed-on: https://chromium-review.googlesource.com/886081Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531831}
-
Keishi Hattori authored
Rename CrossThreadPersistentRegion to CrossThreadPersistentRegions as we will be adding a second PersistentRegion for weak persistents: BUG=757440 Change-Id: I751747470c5ddc1481270e181cdd1edcf9ae5291 Reviewed-on: https://chromium-review.googlesource.com/882626Reviewed-by:
-
Yutaka Hirano authored
Some features defined in content/public/common/content_features.h prevented us moving files from content/network to services/network. This CL unblocks that by defining such features in services/network. Bug: 754918, 804769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I378bef8d314003530019c9e4aab01bdb2f91a2b7 Reviewed-on: https://chromium-review.googlesource.com/874980 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Scott Violet authored
Classic ash doesn't do grabs when in unified mode. For compatibility this patch makes the window-service not execute a grab when in unified mode. To execute a grab leads to ash doing the wrong event conversion. BUG=804460,773348 TEST=covered by test Change-Id: I6d402ec4eb5d68946f98757cc4a56e850bd1e8b0 Reviewed-on: https://chromium-review.googlesource.com/884569 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#531828}
-
Yoshifumi Inoue authored
This patch expands |FindRightNonPseudoNodeInlineBox()| into the call site since it is used once to reduce source code size for improving code health. This patch is a follow-up of the patch[1]. The patch[2] does same thing for |FindLeftNonPseudoNodeInlineBox()| [1] http://crrev.com/c/882791 LineEndpointComputationMode to template parameter in StartPositionForLine() [2] http://crrev.com/c/885683 Expand FindLeftNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp Change-Id: I57ae8c462a3b76ee07f41f3cabd6579765ee1a20 Reviewed-on: https://chromium-review.googlesource.com/885663 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#531827}
-
Yoshifumi Inoue authored
This patch expands |FindLeftNonPseudoNodeInlineBox()| into the call site since it is used once to reduce source code size for improving code health. This patch is a follow-up of the patch[1]. The patch[2] does same thing for |FindRightNonPseudoNodeInlineBox()| [1] http://crrev.com/c/882531 Convert LineEndpointComputationMode to template parameter in EndPositionForLine() [2] http://crrev.com/c/885683 Expand FindRightNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp Change-Id: I11df57f02eaa2f7681751f299948ab0ee8da8e8d Reviewed-on: https://chromium-review.googlesource.com/885683 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Chris Nardi authored
calc() was previously unsupported in CSS media queries. This change adds in support for parsing calc() values in media queries, transitioning MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare CSSParserTokens. Bug: 421909 Change-Id: I81fea4dc6c70caaab79874722f114d261c26c886 Reviewed-on: https://chromium-review.googlesource.com/884571Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531825}
-
Yoichi Osato authored
This patch moves PositionInGraphicsLayerBacking() after IsVisible(). Bug: 789870 Change-Id: Ia4c7bcd590ea36cfefc97ae3f92eca01142304f8 Reviewed-on: https://chromium-review.googlesource.com/885665Reviewed-by:
-
Austin Tankiang authored
Mojo InterfacePtrs need a way to be automatically revoked, so wrap them in a WeakInterfacePtr class. This class is associated with an InterfaceInvalidator class that revokes the weak interface pointer when the invalidator is destroyed. Add tests to verify that invalidation works well with the existing InterfacePtr functions. Change PingService to be [Sync] so both async and sync calls can be tested. Also introduce a new typedef for blink code, |WeakFooPtr|. Existing code will be gradually changed to use the new typedef. Bug: 800641 Change-Id: I29778b233b81eec14ffca048a70f84cc3e31fb44 Reviewed-on: https://chromium-review.googlesource.com/848432Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@google.com> Cr-Commit-Position: refs/heads/master@{#531823}
-
Timothy Loh authored
The enums PermissionAction::REENABLED and PermissionAction::REQUESTED don't seem to have ever been used, so this patch removes them. TBR=nparker Bug: 638076 Change-Id: Iadcbc6f44a8c33233b702287167baef56c807699 Reviewed-on: https://chromium-review.googlesource.com/867794 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#531822}
-
Aaron Leventhal authored
Setting an attribute to the same value it had before should never change the accessibility tree. For example, setting the role attribute to the same value, although not a recommended authoring practice, has negative consequences as the accessible object must be recreated to be safe. In general it is not necessary to update the AX tree unless the value changes. Bug: 801293 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab61b3a9a4c30c5183046c9de073e71ab216d6cb Reviewed-on: https://chromium-review.googlesource.com/876309 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531821}
-
Hajime Hoshi authored
media: Use per-frame task runners at WebRTCMediaStreamAdapterMap and WebRtcMediaStreamTrackAdapterMap This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I300a38816bef6bb8f371203aaad52cb31154309a Reviewed-on: https://chromium-review.googlesource.com/882713Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531820}
-
Khushal authored
We lock all at-raster images for the duration of a tile, which is contrary to the aim of this mode of minimizing peak memory usage. This was initially added for OOP raster potentially needing all decodes to be ready before serialization, but that is no longer the case. R=ericrk@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic6dfc54718413bc808f60eccdc36d7f43be664d2 Reviewed-on: https://chromium-review.googlesource.com/882188Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#531819}
-
Chris Morin authored
Since we will only support the mini-container start up flow, we can simplify the code by eliminating code paths which required to support launching the full instance directly. Bug: 65548422 Test: Ensure container boots and upgrades successfully. Change-Id: Ibb1c2f7af66e3f1ea7f3495f26f34b5e47a4270a Reviewed-on: https://chromium-review.googlesource.com/821650 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#531818}
-
Ken Rockot authored
This race was introduced by r531093. It causes intermittent flakiness on mash_browser_tests runs and would probably eventually turn up with subtly broken behavior in the wild (e.g., spellcheck failing randomly). The gist is that ChromeService modifies some exclusive IO-thread state from the main thread and this can race, leaving the browser's "chrome" service Connector in a defunct state unable to reach other services. In developer builds the failure mode is a more obvious (but still quite rare and flaky) DCHECK caused by sending an invalid ConnectorRequest over a Clone() message. Bug: None Change-Id: I5776005269bef1307b7fc2225bf22cd72bb706fa Reviewed-on: https://chromium-review.googlesource.com/884577Reviewed-by:
Ben Goodger <ben@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531817}
-
Han Leon authored
Before, we avoid sending clients back to those STOPPED/STOPPING workers via the legacy IPC ServiceWorkerMsg_DidGetClients, maybe this is in order to avoid stray IPC in the workers side. After mojofication of GetClients(), we do not need to consider stray message anymore, because we start to send clients back by running response callback of the Mojo interface method GetClients(), which is guaranteed to be safe no matter the other side endpoint has destroyed or not. BUG=772793 Change-Id: I2ae3e4ccf76bc4dc12d6312c694ab90cd7b9fcd7 Reviewed-on: https://chromium-review.googlesource.com/882348 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f8e8f899c7a..8af6931d8777 $ git log 6f8e8f899..8af6931d8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I1239268da73fec12f7ad414e35a23d3462bb4ea6 Reviewed-on: https://chromium-review.googlesource.com/885643Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531815}
-
Alan Cutter authored
This CL prevents animations from running on the compositor when they contain neutral keyframes and apply on top of existing animaions on the same property. Bug: 805323 Change-Id: Iba19882454211f127358b78fcbfa32bfdf183048 Reviewed-on: https://chromium-review.googlesource.com/884781Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#531814}
-
Yuri Wiitala authored
A recent change added new content_browsertests, and the tests are flaky. Root cause analysis shows it to be caused by initial instability in the content shell window size; and so the tests will have to account for that before being re-enabled. NOTRY=true TBR=xjz@chromium.org Bug: 754872 Change-Id: I8017d5d6b451eaedd7c8d9803780ffa7d67327a4 Reviewed-on: https://chromium-review.googlesource.com/885821Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531813}
-
Giovanni Ortuño Urquidi authored
This reverts commit 6252427a. Reason for revert: Fails site_per_process_webkit_layout_tests https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/66700 Original change's description: > Add WPT tests for feature policy > > 1. Added tests for header policy. > a. document.policy shows correctly parsed policy > b. local / remote iframes without allow attribute correctly inherit > document.policy > c. dynamically update allow attribute updates the policy correctly. > > 2. Added tests for nested policies. > > Bug: 732003 > Change-Id: I869449f6bba89fc58997355df27249f403d76808 > Reviewed-on: https://chromium-review.googlesource.com/796952 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531698} TBR=iclelland@chromium.org,loonybear@chromium.org Change-Id: I7b12b6809313f91df3f742e949439719adf8b867 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732003 Reviewed-on: https://chromium-review.googlesource.com/885741Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#531812}
-
Kunihiko Sakamoto authored
- Use SharedDesktopPageState instead of SharedMobilePageState - Re-record the story set - Disable stories that WPR could not record the page correctly Note for perf sheriffs: This is expected to affect loading.desktop benchmark. Bug: 805115 Change-Id: I60d6b455c9553bc6b7202bf9082d2a12096a981e Reviewed-on: https://chromium-review.googlesource.com/883004 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#531811}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I7def16389a4fd40bdf285207411361c596684213 Reviewed-on: https://chromium-review.googlesource.com/885303Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531810}
-
Giovanni Ortuño Urquidi authored
Test keeps timing out on Windows and Linux TBR=alancutter@chromium.org NOTRY=true Bug: 805788 Change-Id: Id1eeb9a0c6629af693131456dc24a5dce532c211 Reviewed-on: https://chromium-review.googlesource.com/885661 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
This hack was added in https://codereview.chromium.org/601733002. I planned to remove it after a few weeks, but forgot to do so. BUG=None TEST=build Change-Id: Ifdfadc62f4b46fedf8e0f8dca98cb6810ed278f5 Reviewed-on: https://chromium-review.googlesource.com/880541Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531808}
-
Siddhartha authored
The histroy db tasks are run using the location of history service. But in reality they are started by various other components. Using the location from the original location is easier for tracing. BUG=803822 Change-Id: I97bc4aa03aa202903dd8346c39d3b284be078a6c Reviewed-on: https://chromium-review.googlesource.com/884725 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LineEndpointComputationMode| parameter to template parameter in |EndPositionForLine()| to avoid runtime checking of parameter and remove unused enum |LineEndpointComputationMode|. The patch[1] does same thing for |StartPositionForLine()|. [1] http://crrev.com/c/882791 Convert LineEndpointComputationMode to template parameter in StartPositionForLine() Change-Id: I325faeeeac8abc3fb971221de047e09f4ffb2341 Reviewed-on: https://chromium-review.googlesource.com/882531 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531806}
-
