- 27 Jan, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
OmniboxPopupTestCase.testIncognitoSeparation crashes constantly on devices. TBR=stkhapugin@chromium.org Bug: 1045950 Change-Id: Ie6ccd8308d39e53d1ea66da1269fd5b1e8282f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020781 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735426}
-
Guillaume Jenkins authored
This is the first step towards making the native spell checker class (WindowsSpellChecker) more testable. Right now, it can't be easily tested because its life cycle is tied to a base::NoDestructor pointer, but it holds references to thread pools. So, between tests, the WindowsSpellChecker is kept alive, but its references to the thread pools are invalidated. The next step will be to move the WindowsSpellChecker from a static base::NoDestructor pointer to the BrowserProcessImpl object, which is destroyed and recreated for every test. In addition to the above, the spellcheck_platform_win.cc file was getting very large, so that's another reason to split it up. There are no functional change as part of this; only code being moved around to new files. Bug: 463364, 1035044 Change-Id: I0b621ad2beba6ed57856dd3cff1910aebebbb710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008031Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#735425}
-
Jan Krcal authored
This CL removes expectations in tests that were introduced to investigate an issue that is closed for more than 7 months. Bug: 904390 Change-Id: Id70f9f9042104ab5ba4120d9158e835663f02683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022651 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735424}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/732248c2f1dc..2c5b856a7f09 git log 732248c2f1dc..2c5b856a7f09 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 bryct@amazon.com Add drawOnce() API to SkSurface. Created with: gclient setdep -r src/third_party/skia@2c5b856a7f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I0f312facfc7b7e125c5279d8959640294560f07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735423}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c2484f8..82608c5b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If50f75fe5d785d1fe16f41215582086af16bfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022324Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735422}
-
Rushan Suleymanov authored
DummyMetadataChangelist may be useful for data types which do not store any data in the bridge. Bug: 1034930 Change-Id: I2cb2f548f1874bba1edb8fa04afe31b15f0b42d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019206 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9c0a83ea4dae..ff0e4dbd1f0b git log 9c0a83ea4dae..ff0e4dbd1f0b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 minyue@webrtc.org Reland "Send absolute capture time through audio coding module." 2020-01-27 jonasolsson@webrtc.org Cleanup log formatting in modules/audio_processing Created with: gclient setdep -r src/third_party/webrtc@ff0e4dbd1f0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e36f1c9f62483904f0215621bb872c4ab9ad5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021973Reviewed-by:
-
Fredrik Söderquist authored
This is in preparation for fixing the behavior of SMIL events wrt to seeking. This also makes these tests pass in Gecko with a single exception. svg/animations/begin-event.svg, svg/animations/end-event.svg, svg/animations/repeat-event.svg, svg/animations/onbegin.svg, svg/animations/onend.svg and svg/animations/onrepeat.svg Adjust the seeked-to time so that the beginEvent/endEvent/repeatEvent is dispatched. Convert from reftests to testharness.js. svg/animations/repeatn-event-1a.svg, svg/animations/repeatn-event-1b.svg, svg/animations/repeatn-event-1c.svg, svg/animations/repeatn-event-1d.svg and svg/animations/repeatn-event-1e.svg 'repeatEvent's are not dispatched while seeking, so seek to just before the relevant repeat and then wait for the event. Convert from reftests to testharness.js. svg/animations/repeatn-event-2a.svg Switch to "stepping through" all the repeat points rather than to the end directly. Convert from reftest to testharness.js. wpt/svg/animations/repeatn-remove-add-animation.html Need to make sure that 'repeatEvent's are actually dispatched, so this test cannot use smil_async_test() which steps while paused. Bug: 1039886 Change-Id: I500f5005a29ed22a920dd3835f8070b52d4def7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017527Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#735419}
-
John Delaney authored
This change implements a storage layer in sqlite for persisting impressions and conversions from the API to disk. The storage for the API consists of two tables, an impression table and a conversion table. Every row in the conversion table is associated with an impression in the impression table to reuse common data such as conversion and reporting origins. The storage layer does not implement specific functionality like last clicked attribution, bit limits, or reporting delays. Instead it abstracts that functionality to an injectable delegate class. This change also includes some common structs that are used by the API, such as a new mojo struct blink::mojom::Conversion. The functionality of the API is described on https://github.com/csharrison/conversion-measurement-api Reference prototype change: https://chromium-review.googlesource.com/c/chromium/src/+/1967220 Bug: 1014604 Change-Id: Icff2d720fe7c595398835fcfd026f6d321cb9c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965450 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#735418}
-
Robert Flack authored
The other commitStyles tests are not affected by the underlying style. This test verifies that applying a partial composite: add stack correctly applies to the underlying style. Bug: 981905 Change-Id: Ia32a51a50e5c537b29c4848248ab94e7de56f19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021741 Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#735417}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I4bc3751593aeab88d33c9c5b051023daedb5cecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020950 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735416}
-
Rushan Suleymanov authored
Do not send messages to server while sync is in pause state. Bug: 1045896 Change-Id: I3d4bcdcc9357836dc66ce30a107dab48b255960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020775Reviewed-by:
-
Wez authored
- Migrate to range for loops in KeycodeConverter. - Fix naming of DOM |key| and |code| mapping table constants. - Replace NULL with nullptr. Change-Id: I1d4ae6146afa9bb32083e40c474653a1f6d1ec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022666 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735414}
-
Yi Gu authored
cc::WorkletAnimation has both scroll_timeline_ and animation_timeline_. When a worklet animation updates its ScrollTimeline, it is the scroll_timeline_ that should be updated. However, the other timeline gets updated due to function inheritance. This will be fixed after crbug.com/1023508. Until then we should apply a temporary fix. This patch allows WorkletAnimation to override the base function to update the scroll_timeline_ correctly. Bug: 1045812 Change-Id: I7e83e7930c4d236e88198ef645c81db8f4041555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020573Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735413}
-
Ian Clelland authored
Bug: 993790 Change-Id: I7d90f98cd3a2b1ef63441a39ed51512b8068c927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015782Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735412}
-
Xi Han authored
The FeatureUtilities#isAllowToRefetchTabThumbnail() checks ChromeFeatureList and requires initializing native. In this CL, we make this function to check a cached value. Thus, this function can be called before native is initialized. Bug: 1041865 Change-Id: I029f18ffe96eeb8f3d997775c51662363e9aac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011166 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735411}
-
Peng Huang authored
In low end device mode, the GLContext is created to be compatible to GLSurfaces with RGB565 format. Right now, SkiaOutputSurfaceDependencyImpl::CreateGLSurface() creates GLSurface with default format which is RGBA8888. It isn't compatible to the GLContext. It causes MakeCurrent fail. Bug: 1033170 Change-Id: Id372e0dee73a01b8e7511bbef6740481b890d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016338Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735410}
-
Boris Sazonov authored
Disables StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail on L and before. Reason: flaky. TBR=wychen@chromium.org Bug: 1045938 Change-Id: I4f508e7005d0cc558308a53851b2541d31e9c766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022647Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735409}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. This comparison did not consider that responses' inputTexts are trimmed of whitespace. This CL likewise trims the requests' inputTexts when comparing the two. Bug: 1045343 Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019927 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#735408}
-
Ali Juma authored
This CL builds PingManager and VerdictCacheManager on iOS, and makes the corresponding unit tests run as part of components_unittests on iOS. To make the VerdictCacheManagerTests pass on iOS, this CL also modifies WebsiteSettingsRegistry so that ContentSettingsType::PASSWORD_PROTECTION and ContentSettingsType::SAFE_BROWSING_URL_CHECK_DATA are registered as settings on iOS. Bug: 1028755 Change-Id: Ia364f1c782b6612c7f41f73f87f3f2493ed6ac33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020551 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735407}
-
Dominik Röttsches authored
When font-optical-sizing: is set to auto (the default) do apply a value to the opsz axis even if font-variation-settings is not explicitly specified. TEST: virtual/text-antialias/mac-system-ui-trak.html Bug: 1005969 Change-Id: I4baf448c6bc465b98eda4cf2538f3ef48e9c5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020767 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735406}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0deb202d1620..a3114e177561 Created with: gclient setdep -r src-internal@a3114e177561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iadd84ab9c8d9c902c9681639cb2294b559fa2140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021972Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735405}
-
Dominik Röttsches authored
Add null check for font-variation-settings, rephrase reconfigured and found axes. TEST: virtual/text-antialias/mac-system-ui-trak.html Bug: 1005969 Change-Id: If235b4518c801fe46bd5a7deb64d102310bc50f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022709 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds a missing integration test that checks that wallet data gets properly replaced by sign-out and sign-in to a different account. Technically, the test does not sign in to a different account, only replaces the data on the fake server as the server anyway does not distinguish users. Bug: 972181 Change-Id: I5ac89bf232bddbebd81a831bb405a0d1a2bf0147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012953 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL recreates the |permission_service_context_| on-demand in RenderProcessHostImpl::CreatePermissionService to avoid accessing the nullptr. Bug: 1036779 Change-Id: I1f464de70a6e4b281380b9b83fee06e012831236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014720Reviewed-by:
-
Himanshu Jaju authored
Tests flow for adding remote ice candidates received and checks if histogram samples are reported correctly for the scenarios. Bug: 1031147 Change-Id: I35536e4068b7f5b564865cd2d02acb099fb658c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019268Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#735401}
-
Greg Thompson authored
MigrateShortcutsInPathInternal uses the command line within a task bar pin to determine the pin's expected AppId. If the command line in the shortcut contains "--user-data-dir" without a value, Chrome itself ignores the switch and uses the default. This change does the same for the AppId calculation in MigrateShortcutsInPathInternal. BUG=1045019 R=gab@chromium.org Change-Id: Ia337c6d0d30fed1525e97e341b0ae4b0e5edef15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022788Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#735400}
-
Boris Sazonov authored
[Sheriff][Android] Disable PaymentRequestMultiplePaymentInstrumentsTest.testCreditCardSuggestionOrdering TBR=sahel@chromium.org Bug: 1045923 Change-Id: Iba072fd223f984f9be79ae86e9ba3aba4ace3c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020777Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0fb0a21bd999..732248c2f1dc git log 0fb0a21bd999..732248c2f1dc --date=short --first-parent --format='%ad %ae %s' 2020-01-27 nifong@google.com Use html tags instead of markdown for images in debugger user guide Created with: gclient setdep -r src/third_party/skia@732248c2f1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I1fb78b6cb1a72abe9acad5d5c84299c7d32f90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021971Reviewed-by:
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: Ic4ee0a4bbf79c4a28f2434ebd8dacb1733bc690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019265Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#735397}
-
Adithya Srinivasan authored
This CL adds a new accessibility role (kPortals) for portals, which is eventually implemented as a button on platform implementations (with the exception of ChromeVox, impl will be in a follow up). This CL also omits a portal's AX tree from the root AX tree. Change-Id: I2b6b27d7c2d04116e7e4cfa23792bbd1188d7628 Bug: 1045608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980898Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#735396}
-
Hiroki Sato authored
CHROMEOS macro is defined in third_party/webrtc. This CL replaces it with more appropriate macro. Bug: None Change-Id: Ib027e5f8c35f5318919f515d97a22d3991607ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022126 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735395}
-
Dominique Fauteux-Chapleau authored
Following discussion in crrev.com/c/1991710 about using dark mode PNGs, the preferred approach is using color_utils::IsDark() instead of GetNativeTheme()->ShouldUseDarkColors(). Change-Id: I821e28edb287715293b3eb8fb4a59b4b15337c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019782 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735394}
-
Omer Katz authored
This CL simplifies Node tracing logic and avoid manual write barriers without increasing size of neither Node nor NodeRareDate. Note that size of NodeRenderingDate does increase, but isn't prohibited. Bug: 986235 Change-Id: Ifd9795db150346fdf85710c6ce8eeaf5841c8776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019106Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735393}
-
Jacobo Aragunde Pérez authored
This would be translated to ATK_ROLE_ALERT by the auralinux accessibility code. Assistive technologies are expected to respond to this role by reading the contents of the ALERT container. Bug: 1023822 Change-Id: I763ee4047c8ba4fb09f2e77f9ddc9f6e8eaabbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010846 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735392}
-
Dominique Fauteux-Chapleau authored
The added images support dark mode and vary depending on if the data being scanned is "text" (dragged web content or pasted text) or an "upload" (dragged file or file upload via a dialog). Bug: 999145 Change-Id: I7f4e583bedf92a308dcc65b90f9c7714b0c891e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991710Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1dc09c63. With Chromium commits locally applied on WPT: 82459860 "SharedWorker: Add WPT for testing data URL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1b2d962b40641804a1c56b1a440c79adda27fb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020844Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735390}
-
Yi Gu authored
AttachCompositorTimeline requires a compositor_animation_ which can only be created during Animation::PreCommit(). Bug: None Change-Id: I8fea8c9f787ad07fe77e3aaebedaa3bcbf9c5098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019470Reviewed-by:
-
Andrew Solovey authored
Extract header ASCII graphic emitting code (WriteAsciiHeader) out of the histogram content drawing method (WriteAsciiImpl) to add more flexibility in style setup. Rename method [WriteAsciiImpl] to [WriteAsciiBody]. Move newline symbols to constants. R=dcheng@chromium.org, sinhak@chromium.org Bug: 1006447 Change-Id: If4af4c82efffaca10a0c34a9bb8abc98000235b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019204 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735388}
-
Rushan Suleymanov authored
Add switch to fallback to default latency value. Bug: 1034928 Change-Id: I5b4bf1bb5e3d80ab854b1c6b9758c4c06c26152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022765Reviewed-by:
-
