- 12 Nov, 2019 40 commits
-
-
Wez authored
DiscardableSharedMemory::Purge() attempts to proactively discard pages to prevent slow-to-respond clients from keeping the pages live longer. If the instance is in-process then these kernel calls are unnecessary since the memory is about to be unmapped anyway. Bug: 1023693 Change-Id: I2bc19eb64f3fdc009c5bf8c4ed6369b2b5081045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911487 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714684}
-
W. James MacLean authored
This test seems to be flaking more frequently as of late. Disabling it to reduce jank on the bots. TBR=tgupta@chromium.org Bug: 1023950 Change-Id: Iad61dfb317f4bec5b0278c038c1e44c6b912e9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913104Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714683}
-
Regan Hsu authored
Currently, the 'Set up' Messages button has no margin-inline-end. It's corresponding toggle button does, however, have a margin (see "After screenshot" of https://chromium-review.googlesource.com/c/chromium/src/+/1879445). This is because CL 1879445 removes padding when the .no-padding class is applied, which is the case for the settings-box ancestor of the button, a feature-controller slot. As a result, bookend children of settings-box must account for the padding loss via a .margin-matches-padding class. CL 1879445 should have applied margin-matches-padding class around the slot instead of only applying the .margin-matches-padding class to the toggle contained within the slot. Before screenshot-- https://screenshot.googleplex.com/WDtZVWyZDbB After screenshot-- https: //screenshot.googleplex.com/ZgLoy8DPEYq Bug: 1008361 Change-Id: I6583795757f4bf3685132a2543481e777f64a898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910873 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714682}
-
Adam Langley authored
Feature flag remains for Finch control should we need to switch it off. Bug: 930812 Change-Id: I23701f27d5352d563b16ca4cda9fa796587c348e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913021 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#714681}
-
Yuke Liao authored
To clarify that ChromeOS is now supported. Change-Id: I2ef92ac00baad6407cedd39b8ba173f1c7a47845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910767Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714680}
-
Vasiliy Telezhnikov authored
This CL adds exception for VizCompositorThreadRunnerWebView to use base sync primitives to allow blocking UI/Android Renderer thread on viz thread for viz for webview implementation. Bug: 805739 Change-Id: I25d6b7494d6b722f1f1d1c6faaff84b552279d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911386Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714679}
-
Mitsuru Oshima authored
crrev.com/c/1885219 broke SwitchToNonLayerBlur. Bug: 1015886 Test: manually tested. Change-Id: I831be4daa0c97596963a1603343f6735724423c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911225Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714678}
-
Ian Clelland authored
This serializes the values returned from parsing structured headers, according to https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-13. Bug: 1011101 Change-Id: I33c0a80bd7cbe17c96bf9ef9803af32a1a7506ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872940 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714677}
-
Bailey Berro authored
In order to make more sense for a variety of device form factors, update the OS Settings Power Page strings to use "Cover" rather than "Lid" Bug: 997473 Change-Id: I9f36aed5dcaab03cc25d8f68b18a89a23306598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913057 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714676}
-
Josh Karlin authored
What: Add a feature to cause AdTagging to only tag a v8 stack as an ad stack if the top of the stack is an ad script. E.g., ignore the bottom. Why: Because sometimes an event on an ad script is used to create content (e.g., the ad finishes showing so now reveal the page content by calling content script). Bug: 1022802 Change-Id: I54ef3f0930f886df01320a714e72e8e4554a0357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906467Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.13-1572864139-benchmark-80.0.3961.0-r1 to 80-3945.24-1573469012-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I167cc8b42def818ecc91cca5601f1c144a2086c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714674}
-
Hazem Ashmawy authored
Add a target for merging the manifest file where a launcher icon is added for WebView dev UI. This removes manifest merging from "dev_ui_resources" definition and consequently from "//android_webview:apk:apk_java". This makes it safe to depend on "apk_java" target without triggering any manifest merging for targets like WebView instrumentation tests. Fixed: 1020444 Test: `webview_devui_show_icon=true` and bin/run_webview_instrumentation_test_apk Test: Manually verify launcher icon after building SystemWebView, MonoChrome and Trichrome Change-Id: Iba7e714ddb0b525828445565696e94327c9dfd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904674 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#714673}
-
Kent Tamura authored
- Unify multiple |focus(); return;| in SetFocusForDialog() into one. - Add origin check and FinalizeAutofocus() call to SetFocusForDialog(). Bug: 985637 Change-Id: Ibb9a7161f384c9d15452dd2559c69cb0d458b9da Experimental implementation for https://github.com/whatwg/html/pull/4918 Bug: 985637 Change-Id: I321736d512d6d8c76095f0f6de8751cd0a5e44e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911061Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#714672}
-
Vladimir Levin authored
This patch adds a CSS version of render-subtree into the css properties. This doesn't use the new property in any way yet, just adds tests to ensure that parsing is correct. R=futhark@chromium.org, chrishtr@chromium.org Change-Id: Icbd89b4d5d99977861e797d31e963b1c605e0778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906937 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#714671}
-
Daniel Hosseinian authored
Append a new field to the initial settings sent to the print preview UI to disable the 'Save as PDF' destination option. Currently, the option can be disabled with the |isInAppKioskMode| initial settings field, but that field also controls other behavior. Now the destination option can be hidden if either |isInAppKioskMode| or |pdfPrintDisabled| is set to true in the initial settings. Remove ChromeOS only flags in parts of the UI code that handle the state in which there are no destinations. Bug: 487875 Change-Id: I92729e0a05860f3ab50c04fe2ad1ad1750818d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904094 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714670}
-
Tommy Steimel authored
This CL updates the a11y popup type for the media toolbar button to fix an issue where JAWS would tell the user to use arrow keys instead of the tab key. Bug: 1022971 Change-Id: I6523bdd9380ec61cfbb05a86923c654877e818e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906636 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#714669}
-
Wez authored
Bug: 927411 Change-Id: Ia2fabf76ef8faa3b8d875b8625572c81eef20946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911488 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714668}
-
Dan Beam authored
Bug: 1020450 Change-Id: Ic865cbaf3c38b39c1dc840510fb5ad5190deb7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898808 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714667}
-
Anastasiia Nikolaienko authored
This reverts commit 85bd68c7. Reason for revert: for transitions from Child to Regular account, and from Regular to Child account all secondary accounts are going to be removed from Chrome OS Account Manager (so we don't need to remove the accounts from ARC). Original change's description: > Disallow secondary accounts in ARC for Child users > > Project Beaker on Chrome OS is going to allow child users the addition > of secondary accounts, but it's going to be limited to web only. > > - If user has transitioned from child account to regular - > TriggerAccountsPushToArc will add accounts to ARC on startup. > - If user has transitioned from regular account to child - > HandleSupervisionTransition will remove all secondary accounts from > ARC. > > Update is going to be executed on startup, since to transition to > another type, user need to sign-out and sign-in again (I think). > > ARC CL: http://ag/9615344 > > Bug: 1017160 > Change-Id: I323a18aca9c9f63e6a3869d9b9dd4dd34432c31c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876089 > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711171} Bug: 1017160 Change-Id: Ie44780d372a2c4b9a85327e93be29a2ede0ad9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904073Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#714666}
-
Martin Kreichgauer authored
Fix a typo when setting the property to control whether the dialog's cancel button should be disabled. This lead to the cancel button being disabled in certain states where it should have been enabled instead. Bug: 974046 Change-Id: I1ad70ce61e68f45d1998b9837b02137256c2d2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900571 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714665}
-
Tommy Li authored
Currently, AutocompleteResult doesn't really support the no-default-match case. The first match is set to be the default match, even if none of the matches are |allowed_to_be_default_match|. This is problematic, because there's three known cases where there's genuinely no default match: - NTP ZeroSuggest - Enterprise policy where there's no default search provider - ChromeOS launcher ChromeOS launcher already supports the no-default-match case properly. The other two are subtly broken. This CL does two things: - It updates AutocompleteResult to set default_match() == end() when there's no valid default match. - It updates a bunch of logic OmniboxPopupModel (runs on Views and iOS) to support the no-default-match case. Bug: 1016845, 363656 Change-Id: Ib684efba92b05cb677bdabf9265e35e2bfbeab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906882 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#714664}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia561e98b6a504e25237453cd3ac210721c2fa64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912921Reviewed-by:
-
Dana Fried authored
Change-Id: Iba6f775a30f9325f1704a52cce3a5d2cf5202395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912625 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#714662}
-
Christopher Grant authored
The module system added a suffix to libraries to better identify them as partitions. VR's factory needs to be updated to work with this convention. There is an open bug tracking moving VR to be opened by the module system. Once that's done, this issue can't happen again. Bug: 1023634 Change-Id: I690fd1cc14e957818571a1b0384186d807d3d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912633Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#714661}
-
Tommy Steimel authored
This CL adds a "global_media_controls" entry to WATCHLISTS and adds me to it. Change-Id: I1aa99dae305adacdde76d4f6f02a524af4641ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907422Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714660}
-
Vasiliy Telezhnikov authored
This CL moved kVizForWebView from android_webview:: to viz so it can be reachable in renderers code to support viz for webview. Bug: 805739 Change-Id: If89de11e2efa2acc49fc1920b2c240f08bcebd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911389Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Willie Koomson authored
This change adds a throttle observer that activates when an ARC window is added to the PipContainer, and deactivates when an ARC window is removed. This has the effect of unthrottling ARC when an ARC PIP window is visible. unthrottled when a YouTube app PIP window is visible. Bug: b:142365466 Test: Unit tests; build/flash/run and check that container is Change-Id: I496e5a6ba67e433891e98601cec50f7079addd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902523 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714658}
-
Sidney San Martín authored
There was multi-platform fallout from making activation less aggressive in r701411 so that when a session is restored on Mac with windows in multiple spaces, the system won't switch spaces as those windows are created and activated. This rolls back all of the cross-platform changes from r701411 and r710397, replacing them with behind one tweak to skip activating windows after restoring their tabs, currently guarded to macOS-only. Bug: 1019048, 1018885 Change-Id: Id45d2029cf8a5f2af08e7ec3aba911ff2b664a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910282Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714657}
-
Jeffrey Cohen authored
This reverts commit 5d7b5565. Reason for revert: This CL causes a failure in the sync integration test TwoClientSendTabToSelfSyncTest.SendTabToSelfReceivingDisabled. Original change's description: > Add UnidoOnSignIn to fieldtrial_testing_config.json > > - Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when > UnidoOnSignIn is on as it no longer applies > - Disabled Sharing registration when device is in local sync mode if > deriving VAPID key as derived key is not availalbe in local sync mode > - Add DeviceInfo to allowed type in transport mode in > sync_integration_tests when UnidoOnSignIn is on > > Bug: 1009516 > Change-Id: I59a48d6feb2aee941ae6adb867c3a72c1ce70f98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 > Commit-Queue: Alex Chau <alexchau@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714467} TBR=mvanouwerkerk@chromium.org,holte@chromium.org,mastiz@chromium.org,alexchau@chromium.org Change-Id: Ib58259d22a2792a225dc21ba7e8aa542a2a8669d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913106Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714656}
-
James MacLean authored
This reverts commit ceb2e12c. Reason for revert: Suspect this CL broke the biuld: https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/6885 Original change's description: > Implement PermissionWizard checker > > This adds a PermissionWizard::Delegate implementation which runs the > Me2Me or IT2Me binary with a command-line for checking permissions. > > This can be used to create a PermissionWizard which checks the > permissions on either the ME2ME or IT2ME host. > > Bug: 1015201 > Change-Id: I24f24e5b1928608bbf310b33a6802db86c9f80bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903934 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714621} TBR=lambroslambrou@chromium.org,garykac@chromium.org Change-Id: I95b8aafdd23cb0b551f476f0bc93bde6e16c41cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912881Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9e0cc38..edafde28 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I756e53793f3f8d925b18090e3317d5d07119b12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913099Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714654}
-
David Vallet authored
Change-Id: If5571ec114544bd69bef816b53e138ae6b5709b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900509Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714653}
-
Haiyang Pan authored
Bug: 1003532 Change-Id: Ia6da252f2eae264c383c154e722591e4e3567582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824130 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714652}
-
Joshua Peraza authored
93f8aa8df989 posix: fix parameter name in signals test a8d66ae7839a linux: don't set ptracer if yama doesn't exist Change-Id: I1786c96dff5a0768dda8a7c32b274f3189e525bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906899 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#714651}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7cb52cb5e67c..581108137b46 git log 7cb52cb5e67c..581108137b46 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-12 csmartdalton@google.com Add 'numRasterSamples' and 'isMixedSampled' to GrProgramInfo 2019-11-12 ccross@android.com [SkQP/Android] Replace -Weverything with -Wextra 2019-11-12 robertphillips@google.com Use a priori knowledge about the number of stencil bits in Dawn, Metal and Vulkan backends Created with: gclient setdep -r src/third_party/skia@581108137b46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:b/143713277 Change-Id: I1535fd13099cb00e843c84632c1610f71609d673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912685Reviewed-by:
-
James Vecore authored
The cr-network-list-item already has an attribute show-buttons but does not have an aria-role set. This change exposes the role top-level attribute with the value of "button" when show-buttons is true. When showButtons is false, the role is set to ''. Fixed: 1007452 Change-Id: I20f076e54c857d55bd8fd2763fb9f02d51498c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911481Reviewed-by:
-
Nate Fischer authored
No change to logic. This only adds copyright headers to existing XML files. These files were committed without copyright headers, but there's no reason they should not have them. Fixed: 1023573 Test: N/A Change-Id: I7af8539a877784b8205ff56ce3ccfc5bc0c7a9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910860 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This cl is an android only change which allows service worker based payment handlers on Android to declare their supported delegations during registration. The payment sheet is also changed to adaptively show/hide shipping/contact details section depending on whether or not the user selected payment handler will provide shipping address/payer's contact information. Whenever multiple payment handlers exist, payment handlers which provide merchant requested information are sorted before the rest. With this change skipping the payment sheet to the payment handler window when shipping/contact details are requested will be possible as long as the payment handler can provide this information. Bug: 984694 Change-Id: I5693a7bd60d7a65b0f9ff5d1c0734867240b57fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902077Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d565d557945e..119ab23ab620 Created with: gclient setdep -r src-internal@119ab23ab620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:984162,chromium:1004848,chromium:1018879,chromium:None,chromium:None Change-Id: I8392ef4c764779c03f3df2ecb65ce0643188de6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714646}
-
Ionel Popescu authored
This CL removes the background-color added for date/month/time controls in order to continue using the highlight and highlightext colors to match the active selection background and foreground colors (specified in input_multiple_fields.css?l=54). Bug: 1021328 Change-Id: Ic064697f14f508e3336b41c2c4801122d0175ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907595 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714645}
-
