GitLab

This overload is deprecated: prefer the std::unique_ptr<Value> version,
which helps the compiler enforce that ownership transfer occurs.

BUG=581865
R=danakj@chromium.org
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2285933003
Cr-Commit-Position: refs/heads/master@{#417396}

This patch re-enables js/mozilla/strict/13.1.html and fixes lexical
redeclaration of arguments.

BUG=v8:4577

Review-Url: https://codereview.chromium.org/2318933007
Cr-Commit-Position: refs/heads/master@{#417395}

This patch sets the device scale factor on cc's root transform node,
fixing several layout tests. This approach is different from how
cc builds property trees (see post_local_scale_factor in
property_tree_builder's AddTransformNodeIfNeeded) where a post_local
transform is used, but aligns closer to blink's approach of using a
single transform per transform node.

This approach is temporary and will need to be refactored when we
begin supporting viewport transforms such as pinch-zoom.

BUG=642240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2318933006
Cr-Commit-Position: refs/heads/master@{#417394}

This reverts commit 9cdba144.
https://codereview.chromium.org/2308153002/

BUG=645177,645181
TBR=qyearsley

Previous commit message:
Import wpt@65954a35b4e0a5cee1f4839271ba0e44f187c0a6

Using update-w3c-deps in Chromium c7eb73ac.

Review URL: https://codereview.chromium.org/2323113002 .

Committed: https://crrev.com/9cdba1441437ab946977a224cc45971cfadd8abb
Cr-Original-Commit-Position: refs/heads/master@{#417302}
Cr-Commit-Position: refs/heads/master@{#417393}

This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but
also includes the 10.11 SDK.

BUG=474373, 626093

Review-Url: https://codereview.chromium.org/2323523003
Cr-Commit-Position: refs/heads/master@{#417392}

Reland of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #1 id:1 of https://codereview.chromium.org/2319093004/ )

Reason for revert:
With the revert in place, the Linux MSAN is still failing:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12113

This proofs this patch to be innocent.

Original issue's description:
> Revert of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #3 id:40001 of https://codereview.chromium.org/2303753003/ )
>
> Reason for revert:
> Speculative revert: this patch is a suspect to cause Linux MSAN failures:
>
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091
>
> The other suspected patch, the only one related to canvas, was reverted and didn't help.
>
> Original issue's description:
> > [Fetch API] Start reading blob only when the reader wants to read contents.
> >
> > BUG=643174
> >
> > Committed: https://crrev.com/f1ca96c413912ff1768e4274b8b7ac78eb41de64
> > Cr-Commit-Position: refs/heads/master@{#416923}
>
> TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=643174
>
> Committed: https://crrev.com/2cbd2420c74783570442264a3e9a1c76cc42152e
> Cr-Commit-Position: refs/heads/master@{#417338}

TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643174

Review-Url: https://codereview.chromium.org/2327583002
Cr-Commit-Position: refs/heads/master@{#417391}

https://chromium.googlesource.com/angle/angle.git/+log/9df01f8..c955058

BUG=

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2320863003
Cr-Commit-Position: refs/heads/master@{#417390}

BUG=641412

Review-Url: https://codereview.chromium.org/2321063003
Cr-Commit-Position: refs/heads/master@{#417389}

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

BUG=622400

Review-Url: https://codereview.chromium.org/2318123002
Cr-Commit-Position: refs/heads/master@{#417388}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8917fb02c5d6..2c67e5988500

$ git log 8917fb02c..2c67e5988 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Disable Show all in value-set-table when all values are source values.
2016-09-08 benjhayden Move value/time_display_mode.html to base/time_display_modes.html
2016-09-08 benjhayden Linkify url strings in generic-object-view.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2320233002
Cr-Commit-Position: refs/heads/master@{#417387}

The grid-column-gap and grid-row-gap allow now percentage as one of the
possible values. This patch adds the required support for both parsing
and layout logic.

This is based on a patch by Javier Fernández http://crrev.com/2057113002/.
However it uses a different approach to compute the percentage gaps
based on the sizing operation.
During intrinsic size phase the percentage gaps are considered 0px.
Also for indefinite heights the percentage row gaps are 0px too.

BUG=615248
TEST=fast/css-grid-layout/grid-gutters-as-percentage.html

Review-Url: https://codereview.chromium.org/2323793002
Cr-Commit-Position: refs/heads/master@{#417386}

The comment on connect_start and connect_end incorrectly stated that DNS
lookup time is included in connect time. The comment above about order
of events has the correct order.

Review-Url: https://codereview.chromium.org/2326693002
Cr-Commit-Position: refs/heads/master@{#417385}

Review-Url: https://codereview.chromium.org/2322673003
Cr-Commit-Position: refs/heads/master@{#417384}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a12446e2..0cb5bdd1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2324493004
Cr-Commit-Position: refs/heads/master@{#417383}

BUG=408658

Review-Url: https://codereview.chromium.org/2212663003
Cr-Commit-Position: refs/heads/master@{#417382}

This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2323443003
Cr-Commit-Position: refs/heads/master@{#417381}

The multisample test seems to be passing on new AMD.
Also there is an NVIDIA test that still seems to fail.

BUG=617290
TBR=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2320173002
Cr-Commit-Position: refs/heads/master@{#417380}

Review-Url: https://codereview.chromium.org/2316233003
Cr-Commit-Position: refs/heads/master@{#417379}

This benchmark is almost identical to the existing WebView startup
benchmark, but with the --webview-sandboxed-renderer flag set.

Setting the pageset_repeat option for the WebView start-up benchmarks.
May make metric more stable to smooth out WebView loading from a cold
start vs. WebView being already loaded into Android's memory.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2307873003
Cr-Commit-Position: refs/heads/master@{#417378}

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319373004
Cr-Commit-Position: refs/heads/master@{#417377}

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972

Review-Url: https://codereview.chromium.org/2321163002
Cr-Commit-Position: refs/heads/master@{#417376}

https://pdfium.googlesource.com/pdfium.git/+log/d827111fb10c..a31da74cffa8

$ git log d827111fb..a31da74cf --date=short --no-merges --format='%ad %ae %s'
2016-09-08 tsepez Pass CFX_WideString further down widget callers
2016-09-08 tsepez Remove unused context parameter from JSGetStringFromID
2016-09-08 tsepez Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2326683002
Cr-Commit-Position: refs/heads/master@{#417375}

ANGLE still uses GYP for a standalone build. Until we switch to full
GN (not currently being worked on) we need this script for all of our
build files.

BUG=605987

Review-Url: https://codereview.chromium.org/2320743002
Cr-Commit-Position: refs/heads/master@{#417374}

Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to
fix download request limiter test for renderer-initiated case in
PlzNavigate.

R=clamy@chromium.org, dominickn@chromium.org
BUG=510836

Review-Url: https://codereview.chromium.org/2319733002
Cr-Commit-Position: refs/heads/master@{#417373}

Keeps track of scripts injected by extensions installed. Checks if a script is
already injected, and injects a script only if it has not been injected.

BUG=248627, 631247
TEST= Run target browser_tests with
--gtest_filter="ExtensionApiTest.ContentScript*"

Committed: https://crrev.com/90d8dd145246616da02f5a54f1da1f5bfe6680e9
Review-Url: https://codereview.chromium.org/2213603002
Cr-Original-Commit-Position: refs/heads/master@{#407016}
Cr-Commit-Position: refs/heads/master@{#417372}

BUG=

Review-Url: https://codereview.chromium.org/2320003002
Cr-Commit-Position: refs/heads/master@{#417371}

Discussion resulted in zero-ish cases where this would be useful.

BUG=644848

Review-Url: https://codereview.chromium.org/2328703002
Cr-Commit-Position: refs/heads/master@{#417370}

BUG=644050

Review-Url: https://codereview.chromium.org/2316303004
Cr-Commit-Position: refs/heads/master@{#417369}

This CL removes the implementation of -[TabView mouseUp:] which should never be
called, since -[TabView mouseDown:] always triggers a nested run loop that
swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView
mouseUp:] on inappropriate views, so it's doubly important that the
implementation not do anything.

BUG=511095

Review-Url: https://codereview.chromium.org/2314873004
Cr-Commit-Position: refs/heads/master@{#417368}

https://chromium.googlesource.com/skia.git/+log/4cea3b9e9d98..85c922acec37

$ git log 4cea3b9e9..85c922ace --date=short --no-merges --format='%ad %ae %s'
2016-09-08 msarett Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec (patchset #2 id:100001 of https://codereview.chromium.org/2319293003/ )
2016-09-08 msarett Checking for valid colorType, alphaType, colorSpace in SkCodec
2016-09-08 brianosman Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ().
2016-09-08 mtklein GN: add a helper script for running Android builds

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2328543003
Cr-Commit-Position: refs/heads/master@{#417367}

This change:
1) Introduces color_utils::ImplicitAlphaBlend, which does an alpha
   blend using the alpha of the foreground color;
2) Introduces a NativeTheme color ID for the shading of a pressed
   button;
3) Uses ImplicitAlphaBlend to blend that shade, instead of calling
   into PlatformStyle;
4) Deletes PlatformStyle::BackgroundColorForMdButton

BUG=644543

Review-Url: https://codereview.chromium.org/2319313003
Cr-Commit-Position: refs/heads/master@{#417366}

Use of a wall clock to drive an animation is dangerous. We should be using the monotinic time.

BUG=645098

Review-Url: https://codereview.chromium.org/2326643002
Cr-Commit-Position: refs/heads/master@{#417365}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1f827fb3b6b4ce5185228c00ddbbe0fe53a12fa8 Canary seems to be working, bump actual LogDog. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:643243

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2324653004
Cr-Commit-Position: refs/heads/master@{#417364}

BUG=639467

Review-Url: https://codereview.chromium.org/2319533003
Cr-Commit-Position: refs/heads/master@{#417363}

media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back().

This CL is a code refactoring, no new code added.

R=mcasas@chromium.org
BUG=643714
TEST=all content_browsertests passing.

Review-Url: https://codereview.chromium.org/2314403003
Cr-Commit-Position: refs/heads/master@{#417362}

BUG=635948
NOPRESUBMIT=true (for protocol.json)

Review-Url: https://codereview.chromium.org/2295913003
Cr-Commit-Position: refs/heads/master@{#417361}

Review-Url: https://codereview.chromium.org/2317273003
Cr-Commit-Position: refs/heads/master@{#417360}

This object hooks into existing data saver code to track savings based
on host, data used, and original size of the data.

BUG=615565

Review-Url: https://codereview.chromium.org/2257533003
Cr-Commit-Position: refs/heads/master@{#417359}

refactored codebase accordingly. This is the first step towards achieving
the "Don't use so many inner classes for NetLog" cleanup ticket, which
seeks to make the codebase more "Include what you use" clean.

There are many "net/log/net_log.h" includes in the codebase. Since 'net_log.h'
has many includes itself, this leaves the codebase susceptible to the
undesirable scenario where clients of 'net_log.h' could be relying upon
'net_log.h' not for its contents but its inner includes.

Extracting NetLog's inner classes into their own files will help with the
above issue. For instance, once these inner NetLog classes are extracted:
ThreadSafeObserver, Entry, EntryData, NetLog enum types, then
ThreadSafeObserver clients will not need to include "net_log.h".

Here are a couple historical notes:

1) In refactoring "NetLog::TYPE_SSL_PRIVATE_KEY_OPERATION" to
"NetLogEventType::SSL_PRIVATE_KEY_OPERATION", the removal of "TYPE_" from
"TYPE_SSL_PRIVATE_KEY_OPERATION" created a compiler error when compiling
an ssl-based object file because it turns out that SSL_PRIVATE_KEY_OPERATION
is a macro definition in the ssl translation unit; this resulted in
a macro collision. To resolve, "NetLogEventType::SSL_PRIVATE_KEY_OPERATION"
was changed to "NetLogEventType::SSL_PRIVATE_KEY_OP".
    - There aren't any dependencies in the [netlog viewer] code
       that depend on the old naming so this should be fine.

2) The new enum classes, as opposed to enums, made it so that
[NetLogEnumClass]::LABEL needed to be statically cast to int at times.
-e.g.- In NetLog::GetEventTypesAsValue()'s for loop to
       iterate through all enums.
       - Also had to do this in 2 or 3 instances outside of net_log.cc.

BUG=473710
R=eroman@chromium.org,tfarina@chromium.org
TBR=asargent@chromium.org,thestig@chromium.org,bengr@chromium.org,avi@chromium.org,zea@chromium.org,rohitrao@chromium.org,sergeyu@chromium.org,mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2315613002
Cr-Commit-Position: refs/heads/master@{#417358}

It's weird to have a perf test for BSP tree stuff in the same file
as perf tests for CalcDrawProps.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2320883002
Cr-Commit-Position: refs/heads/master@{#417357}