- 30 Mar, 2016 40 commits
-
-
pkasting authored
All: * Add/update/clarify comments. ContentSettingImageView: * This doesn't directly subclass views::View. Move those overrides into the IconLabelBubbleView list and reorder the code to match. * Nuke IsBubbleShowing() and just inline its trivial code into its lone caller. IconLabelBubbleView: * Rename GetBubbleOutPadding() to GetOuterPadding(), the class already has "bubble" in the name. * Factor code into some helpers in preparation for adding more uses/complexity in the future. * Functional change: Make the leading padding match the trailing padding for MD in all cases, not just when there's no image. This looks better to me, is simpler, and will be necessary for an upcoming change. * Add missing const to unittest code. layout_constants.*: * Rename "padding" to "spacing" in a place where we're referring to the distance between objects instead of at the edge of an object. BUG=586423 TEST=none Review URL: https://codereview.chromium.org/1834933002 Cr-Commit-Position: refs/heads/master@{#383917}
-
azurewei authored
This cl implements showing a warning bubble when an IME extension is calling chrome.input.ime.activate() API, according to the API proposal: https://goo.gl/IeN7xE. The input.ime.activate() API will not respond util user finishes interacting with the bubble. Only when user presses the 'OK' button, the extension call be successfully activated and get an input.ime.onActivate() event. If user checks the 'Never show this again.' check box when clicking 'OK' button, the extension could be directly activated next time if the API is called from a user action like clicking buttons. This cl adds the following new classes: ImeWarningBubble: The interface or the IME warning bubble. ImeWarningBubbleView: The implementation for the IME warning bubble. Provides warning information to the user upon the activation of an IME extension. BUG=517773 TEST=BrowserTest.ImeActivatedBubbleBrowserTest Review URL: https://codereview.chromium.org/1724733002 Cr-Commit-Position: refs/heads/master@{#383916}
-
hajimehoshi authored
This CL makes FrameLoaderClientImpl cache user agent string instead of BlinkPlatformImpl to avoid threading issue. BUG=598479 Review URL: https://codereview.chromium.org/1839023002 Cr-Commit-Position: refs/heads/master@{#383915}
-
benwells authored
TBR=jyasskin@chromium.org BUG=176621, 176616, 309477 Review URL: https://codereview.chromium.org/1847473002 Cr-Commit-Position: refs/heads/master@{#383914}
-
kjellander authored
Reland of move libpeerconnection target from third_party/libjingle (patchset #1 id:1 of https://codereview.chromium.org/1834163002/ ) Reason for revert: The config.h problem was addressed in https://codereview.webrtc.org/1820023004/ which was rolled in with https://codereview.chromium.org/1840133002/ Original issue's description: > Revert of Remove libpeerconnection target from third_party/libjingle (patchset #4 id:60001 of https://codereview.chromium.org/1808233002/ ) > > Reason for revert: > Broke clang/win gn build (https://bugs.chromium.org/p/chromium/issues/detail?id=598316), as mentioned in the review thread in comment 24. > > Original issue's description: > > Remove libpeerconnection target from third_party/libjingle > > > > All locations that depended on the target also depended on libjingle_webrtc, > > which is where the sources of libpeerconnection were moved. > > > > BUG=webrtc:4256,481633 > > > > Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f > > Cr-Commit-Position: refs/heads/master@{#383468} > > TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,kjellander@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4256,481633 > > Committed: https://crrev.com/8d484368f9d4013effeee0e078fbe7039254cd45 > Cr-Commit-Position: refs/heads/master@{#383490} TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:4256,481633 Review URL: https://codereview.chromium.org/1839063005 Cr-Commit-Position: refs/heads/master@{#383913}
-
peria authored
Now we keep document in LocalDOMWindow, and do not have to keep it alive in hidden window object. BUG=None Review URL: https://codereview.chromium.org/1836193002 Cr-Commit-Position: refs/heads/master@{#383912}
-
azurewei authored
--testActivateAndListChange: for inputMethodPrivate.onImeMenuListChanged --testSetAndUpdateMenuItems: for inputMethodPrivate.onImeMenuItemsChanged --testNotifyMenuItems: for inputMethodPrivate.notifyImeMenuItemActivated BUG=570761 TEST=ExtensionInputMethodApiTest.ImeMenuAPITest Review URL: https://codereview.chromium.org/1839923002 Cr-Commit-Position: refs/heads/master@{#383911}
-
alokp authored
Review URL: https://codereview.chromium.org/1841273002 Cr-Commit-Position: refs/heads/master@{#383910}
-
thakis authored
I want to use this bot as the default-on win/clang trybot, so that if I need to modify it (change it to release, or make it use LLD, or make it build fewer targets then "all"), I don't have to modify our existing FYI waterfall bots. BUG=588518 Review URL: https://codereview.chromium.org/1838083003 Cr-Commit-Position: refs/heads/master@{#383909}
-
krb authored
And see codereview/1810993003 BUG=565069, 568673 Review URL: https://codereview.chromium.org/1814503003 Cr-Commit-Position: refs/heads/master@{#383908}
-
benwells authored
This test has been disabled for a long time and from local tests seems OK now. TBR=jyasskin@chromium.org BUG=309149 Review URL: https://codereview.chromium.org/1843043002 Cr-Commit-Position: refs/heads/master@{#383907}
-
shinyak authored
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of https://codereview.chromium.org/1814423002/ ) Reason for revert: This might be breaking official build. Original issue's description: > Patch to try dump-on-DCHECK. > > This patch does two things: > > 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process. > > 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds. > > All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds. > > Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period. > > BUG=596231 > > Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077 > Cr-Commit-Position: refs/heads/master@{#383894} TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596231 Review URL: https://codereview.chromium.org/1842563008 Cr-Commit-Position: refs/heads/master@{#383906}
-
benwells authored
The test is failing there after a recent QUIC update. TBR=jyasskin@chromium.org BUG=598953 Review URL: https://codereview.chromium.org/1844733004 Cr-Commit-Position: refs/heads/master@{#383905}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#383904}
-
benwells authored
TBR=jyasskin@chromium.org BUG=598950 Review URL: https://codereview.chromium.org/1840363002 Cr-Commit-Position: refs/heads/master@{#383903}
-
dtapuska authored
Replace two Plugins logging with VLOG(1). This has a slight change in that it uses operator<< on Node.h as opposed to logging the address of the HTML Plugin Element; I do think this is slightly more useful than the previous log info. BUG=596760 Review URL: https://codereview.chromium.org/1845533002 Cr-Commit-Position: refs/heads/master@{#383902}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/9b2ef62d4708..890579051d40 $ git log 9b2ef62d4..890579051 --date=short --no-merges --format='%ad %ae %s' 2016-03-29 djsollen Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/1842793002/ ) 2016-03-29 herb Add repeatSpan and change interface name. 2016-03-29 robertphillips Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=djsollen@google.com Review URL: https://codereview.chromium.org/1847443002 Cr-Commit-Position: refs/heads/master@{#383901}
-
noel authored
Manually recover the images from CL issue 561363002 and submit those images to LayoutTests/fast/images/resources TBR=msarett@chromium.org BUG=598949 NOTRY=true Review URL: https://codereview.chromium.org/1844833002 Cr-Commit-Position: refs/heads/master@{#383900}
-
tzik authored
The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 Review URL: https://codereview.chromium.org/1840053002 Cr-Commit-Position: refs/heads/master@{#383899}
-
newt authored
"BookmarkThumbnailWidget" is no longer an appropriate name since the widget no longer shows thumbnails. This CL updates the name to simply "BookmarkWidget". BUG=593587 Review URL: https://codereview.chromium.org/1840193002 Cr-Commit-Position: refs/heads/master@{#383898}
-
yutak authored
PtrHash<T> is specialized over various smart pointer types, e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary; there's no code requiring the specialized versions, and they are nothing more than individual class declarations. This patch gets rid of that abstraction. Additionally, hash functions for a raw pointer T* are now defined in PtrHash<T>, instead of PtrHash<T*>, in order to align with other XXXPtrHash class templates: for example, hash functions for RefPtr<T> are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup is more idiomatic C++. BUG=581524 Review URL: https://codereview.chromium.org/1839003002 Cr-Commit-Position: refs/heads/master@{#383897}
-
jbudorick authored
This is a reland of https://codereview.chromium.org/1836883002/ BUG=428729 TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/1839083003 Cr-Commit-Position: refs/heads/master@{#383896}
-
estade authored
custom theme. BUG=596136 Review URL: https://codereview.chromium.org/1813393002 Cr-Commit-Position: refs/heads/master@{#383895}
-
wez authored
This patch does two things: 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process. 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds. All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds. Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period. BUG=596231 Review URL: https://codereview.chromium.org/1814423002 Cr-Commit-Position: refs/heads/master@{#383894}
-
skobes authored
ScopedLogger was removed in http://crrev.com/381906. The original review is on http://crrev.com/1379443002. Review URL: https://codereview.chromium.org/1840693002 Cr-Commit-Position: refs/heads/master@{#383893}
-
kozyatinskiy authored
R=pfeldman@chromium.org BUG=598885 Review URL: https://codereview.chromium.org/1837283002 Cr-Commit-Position: refs/heads/master@{#383892}
-
jamescook authored
They eventually get valid pointers assigned, but this makes the code clearer and prevents spurious warnings from editors (like Eclipse) that detect constructors with uninitialized data. BUG=none TEST=existing ash tests Review URL: https://codereview.chromium.org/1838343003 Cr-Commit-Position: refs/heads/master@{#383891}
-
thestig authored
BUG=122457 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1834223007 Cr-Commit-Position: refs/heads/master@{#383890}
-
lushnikov authored
This behavior was regressed back in http://crrev.com/1649533003. BUG=598919 R=pfeldman, dgozman Review URL: https://codereview.chromium.org/1846433002 Cr-Commit-Position: refs/heads/master@{#383889}
-
slan authored
These variables should be declared when target_cpu is "arm", so that cross-compiles may use these arguments to determine how to build host tools. Related change in //v8: https://codereview.chromium.org/1839763003/ BUG=592660 Review URL: https://codereview.chromium.org/1842833003 Cr-Commit-Position: refs/heads/master@{#383888}
-
vmpstr authored
DisplayListRasterSource used to derive from RasterSource and there was another implementation. However, currently there's only one raster source and it doesn't derive from any common interface. Rename it to just be the RasterSource. R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1837263005 Cr-Commit-Position: refs/heads/master@{#383887}
-
wolenetz authored
Reworks the StreamParser InitCB interface, MSE stream parsers, and the handling of CB to sum and record the counts of tracks by type across SourceBuffers for a MediaSource at the time of transitioning ChunkDemuxer to INITIALIZED in ChunkDemuxer::OnSourceInitDone(). Reporting of detected text track counts is included for WebM and ISO BMFF stream types, with minimal support added to the latter's parser in this CL to support their detection only. Note that CEA 608/708 caption data embedded within ISO BMFF video tracks is neither detected nor reported. Further, 'sbtl' handler_type is detected as text tracks in ISO BMFF, going beyond what the spec describes currently, but enabling detection of this subtitle track embedding produced by some ffmpeg encodes. No other new text track presence detection is added; it is still missing from some MSE parsers like mp2ts. Further, at most one each of audio and video tracks are detected by the mp2ts parser. BUG=595128, 336926 Review URL: https://codereview.chromium.org/1826583003 Cr-Commit-Position: refs/heads/master@{#383886}
-
dmazzoni authored
This makes the chrome://chrome-signin page accessible too. BUG=557429,587187,453157 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1815933002 Cr-Commit-Position: refs/heads/master@{#383885}
-
dalecurtis authored
Simple change to the default controls that lets the user continue playback with subsequent play/pause button presses. Useful in cases where the error is transient (e.g., network related). In the event of an error the default controls will now pause playback. It'd be nice if we could restore current time in this case too, but it seems to be cleared in unpredictable ways upon decode error. BUG=none TEST=play after decode / network error restarts from beginning. Review URL: https://codereview.chromium.org/1827573004 Cr-Commit-Position: refs/heads/master@{#383884}
-
benchan authored
This CL removes the unnecessary inclusion of base/metrics/histogram.h (introduced by crrev.com/308221) in base/message_loop/incoming_task_queue.cc. The latter doesn't actually use any of the code provided by histogram.h BUG=None Review URL: https://codereview.chromium.org/1844693003 Cr-Commit-Position: refs/heads/master@{#383883}
-
nick authored
BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1802163002 Cr-Commit-Position: refs/heads/master@{#383882}
-
nainar authored
This patch renames consumeImage to consumeImageOrNone to more accurately represent what the function does. It consumes an ident in the case CSSValueNone is specified and consumes an image otherwise. Review URL: https://codereview.chromium.org/1842523003 Cr-Commit-Position: refs/heads/master@{#383881}
-
wangxianzhu authored
During merging, display items that have been moved to new places have null client. Avoid crash during PaintController::showDebugData() so that we can dump data during merge. Review URL: https://codereview.chromium.org/1843863002 Cr-Commit-Position: refs/heads/master@{#383880}
-
eakuefner authored
BUG=catapult:#2102 Review URL: https://codereview.chromium.org/1845443002 Cr-Commit-Position: refs/heads/master@{#383879}
-
dtapuska authored
Replace one WebAudio logging with a VLOG(1) call. BUG=596760 Review URL: https://codereview.chromium.org/1837113002 Cr-Commit-Position: refs/heads/master@{#383878}
-