- 16 Dec, 2020 40 commits
-
-
Oriol Brufau authored
It has been enabled by default since M86. Bug: 457718 Change-Id: I89f115d310d5e0a3f83ad7cdcbabe4f52d9c2d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593377 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837424}
-
Eugene But authored
Bug: 688063 Change-Id: I23fedc798c5f63f4d5b9199079c0840fc898a2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591721 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#837423}
-
Christopher Cameron authored
CanvasColorParams should have the user-specified canvas parameters. The user specifies color space, alpha, and format. The format can only be things like "unorm8" or "float16". The format doesn't specify things like BGRA vs RGBA vs RGBX. Canvas resource providers, meanwhile, need to be able to specify much finer detail -- the SkColorSpace, SkAlphaType, SkColorType. They also should include a SkFilterQuality (which is passed next to the CanvasColorParams right now). Copy-paste CanvasColorParams into CanvasResourceParams and use CanvasResourceParams instead. The next patches in this sequence will re-specialize CanvasColorParams from what it has drifted to, and make CanvasResourceParams more general. Bug: 1157747 Change-Id: Ia9776d2dea64148fa2e3b2d520428ca9f969cf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586835Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#837422}
-
Brandon Wylie authored
Also drops the requirement that every TabObserver care about activity detachment events by default. Interested clients can still override this method and get custom behavior. Bug: 1157728, 1146320 Change-Id: Icb4ca185fb46075b141aa75d8c0ff57a187f5143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585996Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837421}
-
Brandon Wylie authored
Bug: 1056147 Change-Id: Ib13cb84cc38791afa12b92a3ea4ce12a33a1c434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590653 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#837420}
-
Anne Lim authored
I forgot to set expiry_time_micros_, but it passed the unittest because I also forgot to call RemoveExpiredStrikes() in the unittest. Bug: 1061639 Change-Id: I80570e03202c22cca069cb2084351849a4979484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594313Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#837419}
-
Yaron Friedman authored
Internal repo migrated to new function. BUG=783819 Change-Id: I00a18ede62983068e2e55698015f156a0c3de216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593871Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837418}
-
Andre Vincent authored
Middle slot promo: screenshot/4ZY3YFud3UN6Apn Modules: screenshot/mwLN3C9mnHP54rb Fixed: 1077442 Change-Id: I2201fcd0cfba081d0cdddd6d28639d10756e0728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587617 Commit-Queue: Andre Vincent <andrevincent@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837417}
-
Azeem Arshad authored
This CL adds a progress icon and dashed line showing the share target details and connection token. File preview icon on the right side is TODO. This CL also updates confirmation token in send confirmation page to match the specs. Screenshot: https://screenshot.googleplex.com/5Vmf5iXCNsGDrdR.png Fixed: 1157297 Change-Id: Ic4378966ea2fe972fcb6d66ff1c2fc9371c41123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590591 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837416}
-
Jinsuk Kim authored
Post-launch clean-up of feature flag/constants used for experiments. Bug: 1006111 Change-Id: I11135d67aec98f9c34d6161122f1529a641c20ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578299Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#837415}
-
Hidehiko Abe authored
This CL enables Lacros IME. The condition is slightly complicated, because there was a bug in ash-chrome, and lacros-chrome IME requires the fix to be enabled. With this CL, ash-chrome starts to tell lacros-chrome about its internal IME support status. lacros-chrome respects the info to decide whether or not to enable IME on lacros-chrome. If both lacros-chrome and ash-chrome are newer than this CL, IME on lacros-chrome is automatically enabled. If ash-chrome is older, because the support status is not passed to lacros-chrome, it won't enable IME. If lacros-chrome is older, there's no handling code, so IME won't be enabled, either. Because "enable" by default status is introduce, another command line flag to forcibly disable wayland IME is introduced. BUG=1133732 TEST=Made sure IME on lacros-chrome is enabled with new ash-chrome. Made sure IME is not enabled with old ash-chrome. Change-Id: I9bca95ee300962c6af6add8c1f847cc905154230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589714 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#837414}
-
Austin Tankiang authored
Bug: 1158643 Change-Id: Ia27d46bd3430b7a12567c33eec09f5f50936713e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592272 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837413}
-
Melissa Zhang authored
Bug: 1157713 Change-Id: I9f521bdb9f7cd31881b2359245700b03ff8af4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584629Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837412}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d8fe52139faf..d5b38571d31e 2020-12-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9f21427e00621fa06da7c7004b801965419173ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837411}
-
Theo Johnson-kanu authored
- Removing the CHAR limit because of this issue, https://buganizer.corp.google.com/issues/175316543 Translated label require more CHAR than is allowed by the CHAR_LIMIT Bug: 1154827 Change-Id: I47e93e11067c4a0ba36ab4189f9dce5d454711da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589367Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#837410}
-
Yuta Hijikata authored
This change makes is_chromeos_lacros to be true only when current_os is either linux or chromeos. This ensures that is_chromeos_lacros will evaluate to false when generating ninja files for toolchains such as the toolchain for pnacl. It also ensure that enable_scrambled_message_ids is false for lacros-chrome regardless of toolchain that is in use. BUG: 1052397 Change-Id: Ibbe8d2149937b506c6c86f2422a356c5d2d4d869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581632 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837409}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608054952-4392c501b8d700164ac6acf89580f5ab35749e86.profdata to chrome-mac-master-1608076760-b9ea13a2a007bc956431b47b7a25fe6a939d9e2a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I20c2d06ec94cb1efe0b815f7b934e2ba103668ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594551Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608054952-237303eeff32fc09fadd9f8e86812521d687784d.profdata to chrome-linux-master-1608076760-d4793f464fd5473cef2d681bda9559291286bad5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I662fbc45af4433e2a3914d871e645c13bb5f1407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594550Reviewed-by:
-
Jeroen Dhollander authored
This is used inside the Libassistant mojom service to give all the components access to the Libassistant V1 objects when they are created, and inform the components when the V1 objects are destroyed. Bug: b/171748795 Test: chromeos_unittest --gtest_filter=ServiceControllerTest* Change-Id: I01ad35cb5530ebd005c62b1a463be3c65a001729 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585366 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837406}
-
Yao Xiao authored
Bug: 1152336, 1155057 Change-Id: Ib2d73bfdb0b977f6227d3af0069169cdf85f704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593027 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#837405}
-
Jimmy Gong authored
It was previously possible for users to start a new share sheet instance and select a target while a previous file transfer was in progress. Although harmless, as we already show an error state, it was not ideal for users to think that they would be able to transfer multiple files at once. This change preemptively stops any new nearby discoveries if there is already an existing file transfer and notifies the user via error state message. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/23cb20c1829b7de561eb48cc7069c2434b80a0ac Bug: 1149739 Test: browser_tests, unit_tests Change-Id: I17dfcf6a6db393e60d3ce030adc3d98a527e00be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586844 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#837404}
-
Fabrice de Gans-Riberi authored
https://chromium.googlesource.com/openscreen.git/+log/79c6ea2a0c44..4dbefed1b355 2020-12-15 fdegans@google.com Fix linkage of UdpPacket::kUdpMaxPacketSize 2020-12-12 alexleung@google.com Internal change 2020-12-11 miu@chromium.org Full Cast Standalone Sender (Mirroring) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110490 Tbr: jophba@chromium.org Change-Id: Ief3f4b66129f2347cac35b1466fe296b5bc10f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594215 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#837403}
-
Noel Gordon authored
The page_factory_receiver_ can be re-bound, due to developer activity such as chrome inspector devtools page reloads for example. Reset page_factory_receiver_ if it is bound, prior to re-binding. Bug: 1113981 Change-Id: Idcb665fe8069baa2c6ae72f4a0098072da07c23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592239Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Bug: 1157960 Change-Id: I28497af293fa83e6ed1f4162ae0767a540356343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593890 Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837401}
-
Findit authored
This reverts commit df3e91a1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837373 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RmM2U5MWExMjBkMjY4NDU4ZWYzNWNmNTdkNzhlNDAxODE1ZGZmOGQM Sample Failed Build: https://ci.chromium.org/b/8860797505511259488 Sample Failed Step: gfx_unittests Original change's description: > Prevent making invalid SkImageReps > > Ensure that SkImageRep is always constructed with a valid bitmap. > Instead of constructing an invalid SkImageRep then throwing it away when > initializing an SkImage, we add an SkImage::CreateFromBitmap() that will > just return a null SkImage directly if the bitmap is null/uninitialized. > > ImageSkia was creating a null ImageSkiaRep when searching for a > representation in order to force use of the nearest one, but it also > uses a boolean value to do the same, so stop making a null ImageSkiaRep. > > Then disallow null/empty ImageSkiaRep and also disallow their transport > over mojo. > > Remove a few tests that were creating invalid ImageSkiaReps to test that > they work - as they are no longer valid. > > Have ImageSkia constructed from ImageSkiaOperations check for the > ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as > that can still return a null ImageSkiaRep. In that case, the resulting > ImageSkiaRep must also be null. And we can do that without trying to > perform operations on the (invalid, null) bitmap inside the null > ImageSkiaRep. > > R=sky@chromium.org > > Bug: 1155258 > Change-Id: Id7953743ca31804fa3d987677bb8c4962919fd35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572896 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837373} Change-Id: If565d70cf106083108462ac7372ddaab252a18c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594552 Cr-Commit-Position: refs/heads/master@{#837400}
-
Rune Lillesveen authored
We insert implicit combinators inside compounds to correctly do selector matching across shadow boundaries. Document those and rename the relation for matching across a UA shadow boundary. Also remove kPseudoShadow and related code which were remains from the ::shadow selector in Shadow DOM v0. Bug: 1157927 Change-Id: I5a31caecd689b01a21e06157cb75e5b47725e9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593380 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#837399}
-
Eric Willigers authored
Manifest updating on desktop platforms was enabled Dec 12, 2019 https://chromium-review.googlesource.com/c/chromium/src/+/1961354 Bug: 926083 Change-Id: I5267c33511479a65bcff969aba25012ddc17bfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593790 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#837398}
-
Curt Clemens authored
Expand share target list width to 200px. Simplify the margins/padding by removing some of the unnecessary interstital margins on the preview and list elements and instead putting padding on the main content div. Change the top margin on the #process-row to 24px to match spec. Screenshot: https://screenshot.googleplex.com/6Vs8tWVZypxn3Lk.png Fixed: 1145023 Change-Id: If1cecd192623e5edb638e44190949bf194625108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593922 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
-
Darwin Huang authored
Bump raw-clipboard flag from expiry milestone M88 to M94 so that it continues to exist in the Chrome UI. Bug: 897289 Change-Id: I8603db3a973bba435794ae09ea040405023683e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594286 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837396}
-
Kent Tamura authored
Bug: 1158682 Change-Id: I4473f1b2ae032f57a0a9b7f4205c88d350dde906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592528 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837395}
-
Erik Jensen authored
In Python 2, we had to manually open /dev/null to redirect child processes' stdio to it. Python 3.3+ supports specifying subprocess.DEVNULL to do the redirection, which is much simpler. Change-Id: Ideb8154a55686f046f88b79c1879b3b4f7708a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593177Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837394}
-
Noel Gordon authored
Followup to CL:2585261. Use idiomatic import of print function: import it from the __future__. Bug: 1113981 Change-Id: Ib5f7b87c193c9a9de60d25f9e82a4a6e0ff55bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593848Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837393}
-
Sinan Sahin authored
This CL will be followed up by another one cleaning up the logging statements once the fix is confirmed. Bug: 1153706 Change-Id: I2c7feb4b4d94cfd4051df6e64d4564f5a26be16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594263Reviewed-by:
-
Marijn Kruisselbrink authored
This collapses white space, limits the length of descriptions to 64 characters, and on windows strips out '*' characters to ensure the windows dialog itself will still include the true extension. This last behavior is triggered by the `keep_extension_visible` flag that was added in https://crrev.com/c/2582842 to fix a similar problem on Mac. Tested: Verified that the extension is shown in the pickers shown by https://fsa-tests.glitch.me/accepts.html Bug: 1137247 Change-Id: Ife2344589427dbc1055234026601642113b6a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586958 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
David Stevens authored
This reverts commit 9641413f. Reason for revert: The optimization caused a number of flickering bugs related to overlays. The benefits of the optimization are small compared to the complexity, so it should be removed. This revert leaves SurfaceAggregator::Aggregate's target_damage parameter intact, as it is used by the delegated ink trail. Original change's description: > Reland "viz: Re-enable ignore_undamaged on platforms using GL buffer > queue" > > Previously the CL (crrev.com/c/2179763) got reverted since it enabled > the optimization in cases where it shouldn't have. > In particular, the optimization was enabled for SkiaOutputSurface where > only_invalidates_damage_rect used to be false and overlays are not > supported. > The diff between http://crrev.com/c/2205886/1..2 fixes that, > avoiding removing only_invalidates_damage_rect and fixing the logic > to enable the optimization in display.cc. > > Original CL description: > "SurfaceAggregator has an option to output only the quads that > intersect the damage rect computed by SA itself. > > This optimization was disabled on devices with HW overlays or where > the renderer might expand the damage, since SA would not know the > final damage rect. > > This CL re-enables the optimization on devices where we can estimate > a bounding rect of the renderer expanded damage. > > This is achieved by asking to the renderer for a bounding rect that > represents the maximum area that can be expanded. > SurfaceAggregator will aggregate the boundingrect union the damage. > > The damage on the root render pass will be unchanged, so that HW > overlays damage computation won't be affected." > > > Bug: 1077210, 1082947 > Test: viz_unittest (new test and Display tests) > Change-Id: Ib660320b03c0146c62e208332fa6eaa19632c84d > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/2205886 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769741} BUG=b:175087584,1156536,b:171728387,1143580 TEST=Open Play Movies preview from fullscreen Play Store in ARCVM TEST=Verify shelf doesn't flicker when playing YouTube videos in ARCVM Change-Id: I17beb6ebe9482f90c0f9c32c34cb9c7f280dc785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592271Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#837390}
-
Rakib M. Hasan authored
This tester will run skew tests on an Android Oreo emulator. Bug: 1114563 Change-Id: I2cc2eb6af62fe29cefe857c5191dc7e326c99057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594283Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#837389}
-
Xiyuan Xia authored
Fix AnimationThroughputReporter leaks its AnimationTracker when the underlying layer is released before the reporter. In such case, AnimationTracker holds a ref count of LayerAnimator so that that the animator and the animation sequences are kept around even if the underlying layer is released. And the animations will never run in such case and the tracker is leaked. The CL fixes the issue by observing LayerDestroyed to clean up. Also rename IsTrackingAnimation -> HasAnimationsToTrack to better reflect its meaning that returning a true means there will be animations to be tracked but does not mean it is tracking them right now. Bug: 1158510 Change-Id: I98980522a9b6866b0f635a512d0fbb6987eb2c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590646 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#837388}
-
Sadrul Habib Chowdhury authored
Add the 'benchmark' category to the trace-event that reports the FirstContentfulPaint event, so that the trace gets included for all benchmarks (without all benchmarks having to enable all traces of 'loading' category). BUG=1158862 Change-Id: Id1bd528f735de625002a1210ab75896faaece99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593479 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#837387}
-
Sean Gilhuly authored
Bug: 1159126 Change-Id: Iecc57ca0fa587e2d24f48c2a726e1b12dd5c232c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593937 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#837386}
-
Darren Shen authored
CFI issues were fixed for DecoderEngine in: https://chromium-review.googlesource.com/c/chromium/src/+/2537444 But they were never fixed for SystemEngine. Apply the same fixes there. Unfortunately this makes the tests are bit more complicated because the new 'entry points' structure doesn't directly allow stateful mocks. Use a workaround involving global variables. Bug: b/174442293 Change-Id: I9439dffc7296d1dc60c60c132789346ff52c05e5 Fixed: b/174442293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592527Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#837385}
-
