- 24 May, 2018 40 commits
-
-
Vadym Doroshenko authored
Only origin is needed from observed_form, let's expose only it. It has benefits, that it it wouldn't be needed to implement GetObservedForm in NewPasswordFormManager. Bug: 831123, 845826 Change-Id: I0b9ad0ff8ffeaf37bdef08bf73359cb46267faec Reviewed-on: https://chromium-review.googlesource.com/1070371Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#561456}
-
Marc Treib authored
Nothing here requires thread-affinity, so let's relax the restriction and go with the recommended way. This includes using a SequenceChecker instead of a ThreadChecker, and using SequencedTaskRunnerHandler::Get() instead of ThreadTaskRunnerHandler::Get(). Bug: 846238 Change-Id: I6175c7cff26b4dad1329bd22bef816a0ed33e320 Reviewed-on: https://chromium-review.googlesource.com/1069358 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561455}
-
Pavol Marko authored
As requested by translation process feedback. Bug: b:78220246 Change-Id: I73fbc519ad23e59ea738ec5e11a644de06af4b2d Reviewed-on: https://chromium-review.googlesource.com/1071467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561454}
-
Noel Gordon authored
Test working well in RELEASE/DEBUG/MSAN: now re-enable on ASAN Bug: 845087 Change-Id: I5d7d82c9eca3d0b3fbbfb58bd2d34050d089f8d7 Reviewed-on: https://chromium-review.googlesource.com/1071413Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561453}
-
Hajime Hoshi authored
It looks like the CL https://chromium-review.googlesource.com/c/chromium/src/+/1058990 lost the information. This CL adds the infromation again. Bug: 841172 Change-Id: I9eda1527dedb50c99c742140ad05c1848f37de6b Reviewed-on: https://chromium-review.googlesource.com/1071159Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561452}
-
Felix Ekblom authored
This CL add a callback to sendStandBy() and sendWakeUp() that is run once requests have been been made on D-Bus to put displays to sleep or wake them up. Additionally, an API test is added ensuring that calls to the functions propagate to the D-Bus client. BUG=b:78171027 Change-Id: I7c529ce328bcd8ce67d96d357f71dfbc0da229cf Reviewed-on: https://chromium-review.googlesource.com/1053780Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#561451}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02f8ae585af8..b887ecda57d6 $ git log 02f8ae585..b887ecda5 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 rockot Add ARC++ Mojo support libs to chrome deployment Created with: roll-dep src/third_party/chromite BUG=chromium:822034 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6cde13dee4c436f61fb8a14598575f3e0ad70110 Reviewed-on: https://chromium-review.googlesource.com/1071239Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561450}
-
Colin Blundell authored
Moves this service out of //components/printing/service and into the canonical location for services within //components. As part of this move, explicitly adds the //printing OWNERS as the OWNERS of the service (before, this was inherited via //components/printing). This CL has NOPRESUBMIT=true because the code move triggers a bunch of presubmit warnings that are out of scope to fix in this CL. NOPRESUBMIT=true TBR=jam@chromium.org, dcheng@chromium.org Change-Id: Ibc57c165f01696cded02760e8a11a65f5d9a1e81 Reviewed-on: https://chromium-review.googlesource.com/958468 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561449}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie46d8b73d9cc16f8156d0c07e82811bab46bd933 Reviewed-on: https://chromium-review.googlesource.com/1070974 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561448}
-
Jérôme Lebel authored
Changing -[IdentityView setName:email:] to -[IdentityView setTitle:subbtitle:]. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9c6a3da00bf5f396b38a92a25d1c6318994ca5da Reviewed-on: https://chromium-review.googlesource.com/1068672 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561447}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8517631bf410..e9c81ee2ea3a $ git log 8517631bf..e9c81ee2e --date=short --no-merges --format='%ad %ae %s' 2018-05-24 skia-bookmaker Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Ia29955fec10d8a046fdf88ca2a1cbbcd4844804b Reviewed-on: https://chromium-review.googlesource.com/1071240 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561446}
-
Javier Ernesto Flores Robles authored
Removes duplicated icon package. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib4ed2ab9aeab2fa1cd81ab8804148732657f9ec1 bug: 845472 Reviewed-on: https://chromium-review.googlesource.com/1070968 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561445}
-
Olga Sharonova authored
In audio service. Bug: 845446 Change-Id: Ibcf287d7e4642388b8c4f4a88de57bf0450dc56a Reviewed-on: https://chromium-review.googlesource.com/1068735 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561444}
-
Mattias Nissler authored
Extend the TPM firmware update code to be able to deal with different TPM firmware update flows, represented by a newly introduced Mode enum. In addition to the previously-existing powerwash update flow, add a mode constant for the state preserving update flow. Change the chrome://chrome UI to request state-preserving TPM updates if allowed. BUG=chromium:788719 TEST=New unit tests, manual integration testing against platform functionality. Change-Id: I7b2340b0a470d9f4bb393cde0ca01d91db3d442e Reviewed-on: https://chromium-review.googlesource.com/1016918 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561443}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f156687a201..4e9b50ab86b9 $ git log 1f156687a..4e9b50ab8 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 mmoss Revert recent gclient.py changes to fix Chrome releases. Created with: roll-dep src/third_party/depot_tools BUG=chromium:846194 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibf3ae599c18c25b60f08d954ced9e1b2d91b7c0d Reviewed-on: https://chromium-review.googlesource.com/1071232Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561442}
-
Vaclav Brozek authored
Autocomplete attributes are string properties of DOM elements. For parsing password forms, a few special values are important. This CL adds a few functions to password_form_conversion_utils to compute an enum representation of the autocomplete attributes, and a simple cache to keep those computed values to minimize string comparisons. Bug: 833838 Change-Id: I6c386895be9af54ae1e31c715795a26b29eb0e5c Reviewed-on: https://chromium-review.googlesource.com/1027881Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561441}
-
Friedrich Horschig authored
This reverts commit ec54e1ca. Reason for revert: The newly introduced test failed consistently. Please check either the test or it's implementation. Details in the linked bug. Original change's description: > Adapt scroll-visual-viewport-send-boundary-events.html to run with a compositor > > Since this test uses chrome.gpuBenchmarking.pinchBy, we need to have > it run with a compositor. As part of issue 787924, we will no longer > handle gesture pinch events on the main thread. > > Bug: 787924 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I0127028f246ae72a772ef8c9f163b4403b6c3036 > Reviewed-on: https://chromium-review.googlesource.com/1068625 > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560831} TBR=mcnee@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 787924, 846243 Change-Id: I9e6b2f6e8d0ad6d6a43048659f825d590f218fd8 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1071527Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561440}
-
Michael Lippautz authored
Bug: chromium:841830 Change-Id: I0e00b0eca368d6471996288677eb45ea09a55977 Reviewed-on: https://chromium-review.googlesource.com/1071407Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561439}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c4b384a2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18504 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=kereliuk No-Export: true Change-Id: Ide9eb59a86b89fc35223186643f5637094435ba3 Reviewed-on: https://chromium-review.googlesource.com/1071077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561438}
-
Yuki Shiino authored
Removes unused code in processing arguments of callback functions and callback interfaces. Change-Id: I5a98a011ef5c42c69b9f9016579a19942cbad01f Reviewed-on: https://chromium-review.googlesource.com/1067569Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#561437}
-
Yutaka Hirano authored
They are contained in net::HttpResponseHeaders which is also contained in the struct. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I11b438790fc351ba9097bb44415c5c5c4ca923c3 Reviewed-on: https://chromium-review.googlesource.com/1071327 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#561436}
-
Fergal Daly authored
This adds an understanding of ::part to InvalidationSet. Changes RuleFeatureSet to set invalidates_parts and tree_boundary_crossing for ::part selectors. Bug: 805271 Change-Id: I905b7f5a700acfc08bd9a01d4cda12a0de4eac18 Reviewed-on: https://chromium-review.googlesource.com/1068299 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561435}
-
Tsuyoshi Horo authored
When Chrome fails to load a signed exchange, the error page shows ERR_FAILED. It is difficult to know the failed reason. After this CL, the error page shows ERR_INVALID_SIGNED_EXCHANGE. > This site can’t be reached > The webpage at https://example.com/example.sxg might be temporarily down or it may > have moved permanently to a new web address. > ERR_INVALID_SIGNED_EXCHANGE Bug: 830505 Change-Id: Ifcc60a9a353b4f3c29711bc27fb94322761dbdfb Reviewed-on: https://chromium-review.googlesource.com/1065396 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561434}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfd1ec50..0503463a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5b6d371881e6392b3a6441217a4aacb9990a5d76 Reviewed-on: https://chromium-review.googlesource.com/1070796Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#561433}
-
Yoshifumi Inoue authored
This patch changes "merge-start-list.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977, 707656 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4cb1f79ae6df06a47114550e7af32439d994a186 Reviewed-on: https://chromium-review.googlesource.com/1071155Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561432}
-
Florent Castelli authored
Although not all fields are currently implemented, this should be stable and give users enough to experiment with. Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/VvBUUo7h0L4/gCBrvQMLCAAJ Bug: 803494 Change-Id: I7b3c61a84c1706991603ea539eeaf5f22fb4e918 Reviewed-on: https://chromium-review.googlesource.com/1070277Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561431}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ibb6a087acc07871e2f92fb16823fb9315bdd0098 Reviewed-on: https://chromium-review.googlesource.com/1071241Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561430}
-
Yoichi Osato authored
This patch adds assert_selection tests converted from editing/selection/move-left-right.html. Here is generator: crrev.com/c/1032319 This patch includes #31-#43 tests in original 43 tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic4a9f93f275d8d6466984440564230f9636d729b Reviewed-on: https://chromium-review.googlesource.com/1063511Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#561429}
-
Morten Stenshorne authored
Legacy layout is buggy here, so the expected rendering was wrong. Also wrote a new wpt test for this. When calculating intrinsic size, the legacy engine makes room for whitespace that is to be collapsed. Bug: 845902 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I77087577aad68dc249ca33a8ac8a79ef4f35469e Reviewed-on: https://chromium-review.googlesource.com/1070270Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561428}
-
Sylvain Defresne authored
Pass the current tab as the opener when opening a new tab. This allow selection the previous current tab when the tab is closed via "pull-to-close" action or via the new "close" action in the UI refresh. The current tab is passed when tab is opened via ([*] denotes that this behaviour is added by this CL): - open tab in background - "New Tab" menu action [*] - captive portal detection [*] - search by image [*] Bug: 661988 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79 Reviewed-on: https://chromium-review.googlesource.com/1068680Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561427}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27f5a0df4a28..8517631bf410 $ git log 27f5a0df4..8517631bf --date=short --no-merges --format='%ad %ae %s' 2018-05-24 angle-skia-autoroll Roll third_party/externals/angle2/ 586750168..b001528ff (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Ic59d9bc073c68ce102eeb6f51d74731be60cadc4 Reviewed-on: https://chromium-review.googlesource.com/1071235 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561426}
-
Thomas Tangl authored
The layout and the strings of the sync confirmation dialog and the consent bump are updated to match the mocks under: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr6xZArjQ0C0km5svyrm3ZWaI Main changes: - Add new illustration on top of the dialog. - Add account picture. - Add settings button. - Update/add strings. Screenshot of sync confirmation dialog: https://drive.google.com/file/d/1hLL7JijPMqId63Emst_-Neap5YzksjDU/view?usp=sharing Screenshots of consent bump: https://drive.google.com/file/d/1YIUwtY421r5kCeowUIWXmurHKoO4-J0r/view?usp=sharing https://drive.google.com/file/d/1DbNOb9TJsrnkvZLsRHNiP2xZH-BCGYwi/view?usp=sharing Bug: 823967, 819909, 801342 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3da556e78b9d22ac1eececed599da8743fd2f17 Reviewed-on: https://chromium-review.googlesource.com/1021812Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#561425}
-
Michael Lippautz authored
Split write barrier into fast and slow parts: - The fast part only checks whether any Oilpan heap is currently marking. This check is only approximate as it does not consider the current ThreadState. In general, we expect this check to be enough to allow bailing out of the barrier. - The slow version checks whether the current ThreadState is marking and whether the values actually require a write barrier. This way we emit only a short instruction sequence for the fast cases and avoid poluting the regular instruction sequences. Verified locally on the microbenchmark blink_perf.parser query-selector-deep which showed a 42% regression. Scores (higher is better): - ToT: 8932 - Without barrier: 15188 - With this CL: 13352 Bug: chromium:844576, chromium:757440 Change-Id: Ie8ebbf95fef0ff59ad8f1a111dd5daecfabc4109 Reviewed-on: https://chromium-review.googlesource.com/1071272 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561424}
-
Matt Falkenhagen authored
Similar to frames, the shared worker needs a factory bundle in order to load non-NetworkService URLs like chrome-extension://. This fixes the remaining test failure but we're still missing test coverage. I think the factory bundle needs to be propagated to ServiceWorkerSubresourceLoaderFactory for use with network fallback. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d Reviewed-on: https://chromium-review.googlesource.com/1069956 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561423}
-
Kush Sinha authored
|ChromeOSOAuth2TokenServiceDelegate| loads tokens at startup and calls |FireRefreshTokensLoaded| before some token service observers may have had a chance to register themselves. This causes them to miss the |OnRefreshTokensLoaded| callback. For now, the solution is to respect the temporal coupling between |OAuth2TokenServiceDelegate::LoadCredentials| and |OAuth2TokenService::AddObserver|, i.e. |LoadCredentials| is called only when all observers have been added. Ideally, it should be an observer's responsibility to check whether it has been initialized 'too late' and may have missed the |OnRefreshTokensLoaded| notification. Bug: 820046 Change-Id: I3ac67798d165afe230fa29e03ec7af75a9a093a9 Reviewed-on: https://chromium-review.googlesource.com/1069353 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#561422}
-
Lei Zhang authored
r560826 added chrome/apps/printing_strings.grdp, and the duplicate file name made part of the translation pipeline unhappy. Rename the file in components/, to be consistent with the solution for bookmark_strings.grdp. BUG=846106 Change-Id: Iacfb38c3ea4f9e234e25ddb2163081539af9c1d2 Reviewed-on: https://chromium-review.googlesource.com/1070872Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561421}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b001528ffa00..2a12b3d585a8 $ git log b001528ff..2a12b3d58 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 jiajia.qin ES31: Add struct uniform block support in compute shader for D3D Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I96c49978656f736a511efc4ccb0057cc0fd7196c Reviewed-on: https://chromium-review.googlesource.com/1071236Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561420}
-
Marc Treib authored
Before, OnRefreshTokenRevoked triggered a notification to observers, and OnCredentialsRejectedByClient caused us to invalidate the credentials in the SyncEngine. In both cases, it actually seems better to do both of these things, so this CL merges the two. Bug: 842697 Change-Id: I81fd4578731c282284fa40cbbb0be0e1cd102656 Reviewed-on: https://chromium-review.googlesource.com/1068880 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561419}
-
Keishi Hattori authored
Clear all persistents on thread termination, because when we have a bug and it leaves a Persistent behind, it will not be a stale pointer and just causes null dereference. Since we disabled PersistentHeapCollections on non-main threads we can assume all PersistentNode::Self() can be cast to Persistent<DummyGCBase> Bug: 831117 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib55b280f8e7c5d966ce43d3f60f2af873cd50739 Reviewed-on: https://chromium-review.googlesource.com/1025547 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561418}
-
Greg Thompson authored
I can't repro the failures anywhere outside of the real environment. BUG=818832 R=martiniss@chromium.org Change-Id: I9ccaa3bf5f7e357f879c4d804310d34b0e1abaaa Reviewed-on: https://chromium-review.googlesource.com/1070192Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561417}
-