- 04 Aug, 2017 40 commits
-
-
Matt Falkenhagen authored
The renderer-side ServiceWorkerDispatcher had OnAssociateRegistration, which was either called via IPC for service worker controllees, or directly from ServiceWorkerNetworkProvider for "controllers" (service worker execution contexts). But service worker controllees don't actually need to keep track of the associated registration. I think we needed this in old times when there were things like navigator.serviceWorker.ready had to be populated with a registration immediately <https://codereview.chromium.org/477593007>, now it's an async API that asks the browser for the registration <https://codereview.chromium.org/894973003>. Similarly, we had OnDisassociateRegistration, but once OnAssociateRegistration IPC is removed, all it did was set the controller to nullptr, so it can be replaced with SetController. It's never called for service worker execution contexts. There's more simplificiation possible here, we can possibly remove the whole ProviderContext interface as now there are no common functions between controllees and controllers, but that's for follow-up work. TBR=tsepez for removing messages from service_worker_messages.h Change-Id: I8b24c831e850351b7da955f80006d1cf51039095 Reviewed-on: https://chromium-review.googlesource.com/599092Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#492000}
-
Alexander Shalamov authored
Layout test for orientation sensor is using assert_array_equals for DOMMatrix objects, thus, assert will always pass. This CL fixes this issue by converting DOMMatrix to Float64Array. Bug: 751015 Change-Id: I599f864e631c667ce90b193590bfc4dda534cab6 Reviewed-on: https://chromium-review.googlesource.com/601971Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#491999}
-
Hector Dearman authored
Now that memory-infra has switched to collecting OS metrics separately from the old path we can remove a lot of the old code path. Specifically we can remove: - ProcessMetricsDumpProvider - The content/ stub for ProcessMetricsDumpProvider - The support for OS Metrics in ProcessMemoryDumo - (Including process_memory_maps and process_memory_totals) - The logic for registering of ProcessMetricsDumpProvider - The support in OS metrics for ProcessMetricsDumpProvider - The PrivatePlatformFootprint structtraits We also remove the following memory-infra features: - Peak RSS on recent versions of Android (Little used feature, superseded by general peak detection support in memory-infra). - General peak detection support in Linux (Currently unused, coming back soon) - Some OS stats of little use on MacOS This removes 10 files and ~1000 lines. Bug: 718809 Change-Id: I858ddc91ce342176c25dfda58cb9d3b1ebb39c6f Reviewed-on: https://chromium-review.googlesource.com/586721 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491998}
-
Philip Jägenstedt authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/m4DNZbLMkRo/9fzhqNwqBQAJ Because this is also supported in Edge 15 and exists in WebKit's IDL, add an historical.html test covering this and other non-standard features that existed or still exist in Blink, but are no longer in the spec, annotated here: https://chromium.googlesource.com/chromium/src/+/e70c6e15ba896a2e88d0dc05f1a20fb3d4befabf Bug: 698163 TBR: timvolodine@chromium.org Change-Id: If8eac7005a652c000d34f12c48bd04194e1e215e Reviewed-on: https://chromium-review.googlesource.com/597668 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491997}
-
Ian Kilpatrick authored
This was a mistake when I was initially writing this code. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic67f0dd0364c9a03724c626b61c56632c8fa6605 Reviewed-on: https://chromium-review.googlesource.com/600310Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491996}
-
Vasilii Sukhanov authored
This reverts commit 2c3ec3ce. Reason for revert: still failing (https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/27201) [ RUN ] WebNavigationApiTest.UserAction [5936:1628:0804/040823.764:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebNavigationApiTest.UserAction --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\s\w\iou7dp23\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4492_8435\d4492_12222" --disable-offline-auto-reload --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --allow-legacy-extension-manifests --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank [5936:1628:0804/040824.460:WARNING:render_frame_host_impl.cc(2614)] OnDidStopLoading was called twice. [5936:1628:0804/040824.539:INFO:CONSOLE(0)] "[FAIL] userAction: Received unexpected event 'onCreatedNavigationTarget':{"sourceFrameId":1,"sourceProcessId":1,"sourceTabId":0,"tabId":1,"timeStamp":0,"url":"chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/b.html"} Error at Object.handleRequest (extensions::binding:64:27) at Object.<anonymous> (extensions::binding:374:32) at captureEvent (chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:194:17) at chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:223:5 at EventImpl.dispatchToListener (extensions::event_bindings:403:22) at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:140:26) at EventImpl.dispatch_ (extensions::event_bindings:387:35) at dispatchArgs (extensions::event_bindings:260:26) at dispatchEvent (extensions::event_bindings:269:7)", source: chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/test_userAction.html (0) ../../chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc(537): error: Value of: catcher.GetNextResult() Actual: false Expected: true Failed 1 of 1 tests Original change's description: > Enable WebNavigationApiTest.UserAction > > Bug: 662160 > Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe > Reviewed-on: https://chromium-review.googlesource.com/600768 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491817} TBR=nasko@chromium.org,alexmos@chromium.org Change-Id: Ieeabb0b39759aa8b94916d7c10b3c867d106a142 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 662160 Reviewed-on: https://chromium-review.googlesource.com/602147Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491995}
-
Philip Jägenstedt authored
Enabled in https://chromium-review.googlesource.com/599728 but now failing on WebKit Linux Trusty (dbg) in the waterfall. Put it with the same test in other places. Bug: 689781 Change-Id: I37a8e13ae607a18fffe3b60aa4f8812e9aadd448 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/601911Reviewed-by:
-
Martin Sramek authored
- Local Storage - Indexed DB - Filesystems - Service workers - WebSQL Bug: 607897 Change-Id: I7fd82d08c651fb8f41dbde9c6af1b723679c621c Reviewed-on: https://chromium-review.googlesource.com/596088Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491993}
-
tetsui authored
In new-style notification, the resizing behavior of image notification is different form the non-MD notification. This CL adds LargeImageView, which implements the specific resizing behavior. BUG=737850 TEST=manual Review-Url: https://codereview.chromium.org/2969603003 Cr-Commit-Position: refs/heads/master@{#491992}
-
Ondrej Skopek authored
Change integrity calculation to be able to add another JavaScript file to the Local NTP. To be used when porting Voice Search (go/local-ntp-voice-search). Bug: 583291 Change-Id: I9c0c1c1ede827b7f77b14e744b24a495eca70387 Reviewed-on: https://chromium-review.googlesource.com/600429Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Ondrej Škopek <oskopek@google.com> Cr-Commit-Position: refs/heads/master@{#491991}
-
antrim authored
Let user select license type during enrollment flow if multiple licenses are available. BUG=725124 Review-Url: https://codereview.chromium.org/2977033002 Cr-Commit-Position: refs/heads/master@{#491990}
-
Jan Krcal authored
This is an experimental feature to show also lower-resolution favicons in NTP tiles. This implementation serves for decision-making. Bug: 752130 Change-Id: I4d09ede341fb63c49845f6aac8b5b547b4473db1 Reviewed-on: https://chromium-review.googlesource.com/600236 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#491989}
-
Yoichi Osato authored
We mark and invalidate LayoutObject by - finding first/last LayoutObject by canonicalization and - traverse on layout tree However we can those operation at once by traversing flat tree. For that, this CL changes SelectionState::kInside marking from layout tree to flat tree. I will change kStart/kEnd marking. Core part is L517-L549, which replaces old SetSelectionState and CollectInvalidationSet. LayoutSelectionTest.cpp: It traverses LayoutTree using NextInPreorder() and confirm each SelectionState and ShouldInvalidateSelection bit. This CL introduces InsertLayoutObjectAndAncestorBlocks() from CollectInvalidationSet() to construct PaintInvalidationSet in SetShouldInvalidateSelection(). Test expectations update: Since we traverse on flat tree, we skip pseudo element, or list style marker. Bug: 739062 Change-Id: I0717340fb7eef2c130d1281c2c9f5d8ff9b9b586 Reviewed-on: https://chromium-review.googlesource.com/593529 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491988}
-
Vasilii Sukhanov authored
This reverts commit b1c5af84. Reason for revert: CheckClientDownloadValidateRequestNoSignature and CheckClientDownloadValidateRequest fail more than pass on Linux Tests. [ RUN ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequest ../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1690: Failure Value of: HasClientDownloadRequest() Actual: false Expected: true ../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1693: Failure Value of: fetcher Actual: false Expected: true [ FAILED ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequest (41 ms) [ RUN ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequestNoSignature ../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1777: Failure Value of: HasClientDownloadRequest() Actual: false Expected: true ../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1780: Failure Value of: fetcher Actual: false Expected: true [ FAILED ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequestNoSignature (73 ms) Original change's description: > Move URL whitelist checking b4 content analysis > > Refactor checking of URL whitelist to happen before analyzing the > downloaded file, in order to improve SB check latency for whitelisted > URLs. Certificate whitelist checks still happen towards the end of > processing since they rely on file analysis. > > Bug: 526841 > Change-Id: I59e228dea251ff1a03e319efccf1c2a8aec89bc3 > Reviewed-on: https://chromium-review.googlesource.com/587329 > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491890} TBR=vakh@chromium.org,jialiul@chromium.org,mortonm@google.com Change-Id: I1a026c9956034867d0eae39acea4352443db38bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 526841 Reviewed-on: https://chromium-review.googlesource.com/601949Reviewed-by:
-
Daniel Hausknecht authored
Bug: 752132 Change-Id: Ib7320e6156978e6eabe527dedc013609bffedfe9 Reviewed-on: https://chromium-review.googlesource.com/601791Reviewed-by:
-
Adam Rice authored
ReadableStream.prototype.pipeTo was using the global Boolean function. Use a copy of the original value instead to avoid problems when it is overwritten. This change also adds a test that ReadableStream and WritableStream still work when all global objects have been set to undefined. Bug: 752177 Change-Id: I09c7fb139610c2c9c3bc8780c59615361d8beb55 Reviewed-on: https://chromium-review.googlesource.com/601610Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#491985}
-
Vasilii Sukhanov authored
This reverts commit c59f6260. Reason for revert: Broke compilation on Linux ChromiumOS Builder (dbg) ../../components/exo/data_device_delegate.h:28: error: undefined reference to 'vtable for exo::DataDeviceDelegate' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > Delivers drag and drop methods from Surface to DataDevice. > > The CL lets Surface observe drag and drop events and delegates the events to > DataDevice thorugh DataDeviceManager. > > Bug: b:31988797 > Test: None > Change-Id: I9574cd86137922d7527bd297d182a7b45e632c9e > Reviewed-on: https://chromium-review.googlesource.com/579250 > Commit-Queue: Daichi Hirono <hirono@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491951} TBR=reveman@chromium.org,hirono@chromium.org,hidehiko@chromium.org Change-Id: Ie770510e27a19b94f5e621ef41d24138c219104c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:31988797 Reviewed-on: https://chromium-review.googlesource.com/601989Reviewed-by:
-
Mihai Sardarescu authored
The desktop re-authentication flow does not update the sign-in manager. Here are the explinations why: * SigninManager::StartSigninWithRefreshToken dchecks that the profile is not authenticated (see https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_manager.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=105) * InlineSigninHandler simply updates the refresh tokens in case of a reauth (see https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=246 ) The mobile re-auth flow calls SigninManager::OnExternalSignin which in some cases may lead to a unexpected call to GoogleSigninSucceeded. On iOS this flow does not exists as the iSL always removes invalid accounts. On Android, there is a possibility for the SigninManager::OnExternalSignin to be called in a reauth flow, however the Java code ignores GoogleSigninSucceeded notifications (see https://cs.chromium.org/chromium/src/chrome/browser/android/signin/signin_manager_android.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=347) This CL makes it explicit that: * SigninManager does not send GoogleSigninSucceeded notifications on reauth * Adds a DCHECK when the authenticated account ID is changed. TBR=mpearson@chromium.org Bug: 733226 Change-Id: I85cc4497a0d099447a7d8a46b435e93f39d8d4c7 Reviewed-on: https://chromium-review.googlesource.com/579432 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#491983}
-
Patti authored
Make the Site Details web UI update the default permission strings when they change without needing to reload the Site Details page. Manual test - With #enable-site-details on, open https://permission.site. Open the Page Info bubble, click "Site settings" to open the Site Details page. Make sure the 'Location' setting is set to 'Ask (default)'. In a new window, open chrome://settings/content/location and put the two windows side by side. On chrome://settings/content/location, click the toggle to block location access by default, and verify the Site Details page drop-down value for location changes to 'Block (default)'. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1c03acd9b636ea8463e382ae21cc646161267d9 Reviewed-on: https://chromium-review.googlesource.com/597030 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491982}
-
Georg Neis authored
Bug: v8:6649 Change-Id: I79555121ce72bef536ca99365cc5b12c3a6496df Reviewed-on: https://chromium-review.googlesource.com/590369 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#491981}
-
Vasilii Sukhanov authored
Disable BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1 TBR=chrisha@chromium.org Bug: 749098 Change-Id: Ia814e450c72b65017025bb3eb11db49c31b1498e Reviewed-on: https://chromium-review.googlesource.com/601968Reviewed-by:
-
Philip Jägenstedt authored
Based on the "Expected to timeout, but passed" and "Expected to fail, but passed" sections of a full run of LayoutTests/external/wpt on Linux Debug. Bug: 310004, 679742, 698256 Change-Id: Ifc5966c6e8d611b2deb67c56bf2fb06fe35e71d9 Reviewed-on: https://chromium-review.googlesource.com/599728Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#491979}
-
Dominik Röttsches authored
Allow ranges for font-style in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc and support the oblique <angle> style property of CSS Fonts Level 4. Bug: 749091 Change-Id: I7888f2f01f3cda8ec1b8d5c13b884f75b1790e50 Reviewed-on: https://chromium-review.googlesource.com/600228 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#491978}
-
Julien Brianceau authored
Bug: 750830 Change-Id: I98830d02a56b733dc5e631a8e10d9e55e2a5a6fb Reviewed-on: https://chromium-review.googlesource.com/600327Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#491977}
-
Vasilii Sukhanov authored
This reverts commit e03b42cc. Reason for revert: both tests timeout quite reliably on Win10 Tests x64 (https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/14362) Original change's description: > Enable WebNavigationApiTest.CrossProcess(History|Fragment). > > Bug: 708139 > Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 > Reviewed-on: https://chromium-review.googlesource.com/601027 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491836} TBR=nasko@chromium.org,alexmos@chromium.org Change-Id: Iee6a4124181b0e7761a5c77e1f65ea3cda23d4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 708139 Reviewed-on: https://chromium-review.googlesource.com/601948Reviewed-by:
-
Philip Jägenstedt authored
Bug: 734121 Change-Id: I3393aeda531cde0b4d12644a362a8ba299e0aafe Reviewed-on: https://chromium-review.googlesource.com/597849 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491975}
-
Thiemo Nagel authored
We'll never ship an update to x86-{alex, mario, zgb} again thus there's no use in keeping the special cases around. Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I150a4b50d3347767f94dbc0e01019cef979a134f Reviewed-on: https://chromium-review.googlesource.com/581188Reviewed-by:Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491974}
-
Adam Rice authored
The ReadableStream constructor uses the String function. However, the implementation was failing to take a copy of the function. This meant that the version from the Javascript environment was used. If it had been modified then it could result in incorrect behaviour. Use a copy of the original value of the String function in ReadableStream. This change also includes a regression test. BUG=752177 Change-Id: I52f36244a9d87131219958837e3cee00a8fc5fb4 Reviewed-on: https://chromium-review.googlesource.com/601668Reviewed-by:
-
Shuhei Takahashi authored
This function will be used in Recent. As a bonus, unit tests are added. Bug: 742722 Test: unit_tests Change-Id: I0c5d6271e7845fb0d7f86047414f652e049348f3 Reviewed-on: https://chromium-review.googlesource.com/588811 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491972}
-
Vasilii Sukhanov authored
TBR=dtseng@chromium.org Bug: 719930 Change-Id: I98bb00242238f059b7a43fc26147751fdc3e1168 Reviewed-on: https://chromium-review.googlesource.com/601908Reviewed-by:
-
gambard authored
The privacy setting strings for the suggestions is confusing. This CL disambiguate them. Bug: 751731 Change-Id: I1e91133b085b73d35553337c9341fda15234f7d1 Reviewed-on: https://chromium-review.googlesource.com/599870Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491970}
-
Georg Neis authored
Bug: chromium:748544 Change-Id: I9458ea9c25d65bc31ff34dc8101936468ed2bf81 Reviewed-on: https://chromium-review.googlesource.com/589434Reviewed-by:
-
Shuhei Takahashi authored
This change introduces core concepts of Recent file system: RecentModel: The most important class owning RecentSources. The only API it provides is GetRecentFiles() which queries RecentSources for recently modified files and build a list of recently modified files across file systems, and also caches the result for better file system operation performance. Files are represented as FileSystemURL. RecentSource: Interface class for a source of recent files. This interface will be implemented for several sources such as local storages and cloud storages so that they appear in Recent file system. RecentContext: Holds several "context" objects necessary for operations in RecentModel and RecentSource. Bug: 742722 Test: unit_tests Change-Id: I2a2ff1fa28e8cf5c705ad1ee6bc75a39b49b2f0b Reviewed-on: https://chromium-review.googlesource.com/588950Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#491968}
-
Yusuke Sato authored
This ends up sending two D-Bus messages to session_manager, and it is guaranteed that the message for starting ARC instance is always sent first. This is because Chrome (with crrev.com/488879) sends the D-Bus method directly in StartArc() without any thread hops. BUG=b:64327302 TEST=try, manually went through ARC opt-in Change-Id: I97c4779b2ed5827b46559f9f7571a1090b4ced68 Reviewed-on: https://chromium-review.googlesource.com/601768 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bad5ad7d601b..5910ed347a63 $ git log bad5ad7d6..5910ed347 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 mtklein 15-bit lowp is dead, long live 8-bit lowp 2017-08-04 skia-deps-roller Roll skia/third_party/externals/angle2/ 13c0dd463..53440f39c (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ic2866ec9c147d544e2185748dd9adaced0c5096b Reviewed-on: https://chromium-review.googlesource.com/601371Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491966}
-
tzik authored
Change-Id: Icb8f3be6610108b08ea111f60f59e7f914dfc1fe Reviewed-on: https://chromium-review.googlesource.com/599142Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#491965}
-
Marc Treib authored
Bug: 690467 Change-Id: Icd90a52d66d7d6b8734398de6707f18e762cd06b Reviewed-on: https://chromium-review.googlesource.com/600309Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491964}
-
Kent Tamura authored
The following tests are removed because they are covered by html/dom/reflection-forms.html in WPT. - fast/dom/HTMLInputElement/input-size-attribute.html - fast/dom/HTMLInputElement/size-as-number.html - fast/dom/HTMLInputElement/size-attribute.html TBR=kochi@chromium.org Bug: 685886 Change-Id: I4afaa32bffb9e6ff377a5c734a9bb4c758d27d24 Reviewed-on: https://chromium-review.googlesource.com/601693 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491963}
-
jgruber authored
Coverage information has changed granularity. Bug: v8:6000 Change-Id: Ic18d82e9523145d4323807598e05943ff2d4bfd3 Reviewed-on: https://chromium-review.googlesource.com/596049 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491962}
-
Eddy Mead authored
We don't use files with the extension ".in" any more, as they have been replaced with the more standard ".json5" format. Change-Id: I54b8acf9d93b0711d54baf9685baaeeeeea8715c Reviewed-on: https://chromium-review.googlesource.com/601769Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#491961}
-
