- 23 Sep, 2020 40 commits
-
-
My Nguyen authored
Proposed new name found in http://go/cros-input-methods Rationale: http://go/cros-input-methods-naming Current view for US International: http://screen/3sankWPvq6xQW2R New view for US International: http://screen/BrfNpMZn7GYzS5h Current view for Belgium: http://screen/B9USEaX8iX2JuTp New view for Belgium: http://screen/4A4hVAMrK62JP2z Remove adding language before input name logic as there are no longer duplicate names for IME tray. It's fine not to update string for OOBE for now because it's clear what language the keyboard is referring to. OOBE view: http://go/cros-oobe-2019#slide=24 Bug: 1113439, 889763 Change-Id: Ia7dadd44874937872c1f10fa51ca81e344378ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423068Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809639}
-
Raphael Kubo da Costa authored
The Mac bots are occasionally timing out. Clean up the iframe tests a bit more hoping it helps: * Remove redundant call to 'reset_sensor_backend' that is already performed by the test's cleanup function. * Move the message handler to a separate function, so that we can then call it from a catch-all try/catch statement and ensure we will always send a reply. This also allows us to remove several try/catch blocks from the handler itself. Bug: 1073865 Change-Id: I9756c85ee401a78dabe5f283250ab68110decabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424248 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809638}
-
Melissa Zhang authored
Bug: 1130409 Change-Id: Iaa4c0c624dd238d1fe26c42f6dfe606fe5c20fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421987Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809637}
-
Matt Falkenhagen authored
Change-Id: I30dd3f55cc8832512f52062d9b5bff085887f392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415918Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809636}
-
Ryan Keane authored
This CL adds a new MediaPipelineBackend to allow audio data to be proxied across an IPC through the MultizoneAudioDecoderProxy. Video data decoding will not be changed, and should be passed through to the environment-specific CmaBackend. This change is accomplished through the use of an environment variable orthogonal to that used for platform type. After this change, all audio data processed by the AudioPipelineImpl should be diverted across the IPC, as described in go/cast-media-chromium-runtime Bug: b/167425332 Change-Id: Iaefd150bac0b6edf9708c79d4c6d50f2a5eb27ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412558Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#809635}
-
Fabrice de Gans-Riberi authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe..83b2ac66 83b2ac66 [fuchsia] Bring more changes from the Fuchsia copy 368b1cb1 Upstream Fuchsia changes in build file fb520a53 Add CPEPrefix. Bug: 1124037, fuchsia:56362 Change-Id: Ia77c08b48668de4315b44d3b72a3a3e23d722494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412548 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809634}
-
Raphael Kubo da Costa authored
This does not directly fix the timeouts on the ARM64 Mac bots reported in the bug below, but it simplifies the test and hopefully eliminates some of the sources of flakiness. Bug: 1128439 Change-Id: I4b1840a8db6e8d2541003b5b1ecb860f4bc04c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418378 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Target counter currently has an off by 1 error. Bug: 1131108 Change-Id: Ib180c0fd4c165be6708adc9b008fcee209b41595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423752Reviewed-by:
-
My Nguyen authored
Experiment with new maps. Related CL: http://cl/332964764 Bug: b/166523259 Change-Id: I9ba8f3d637fb8b68cb3e776d3f5156156d4b53ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423063Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809631}
-
Bo Majewski authored
Moves all main files to main.* Creates a separate directory for images and moves the icon there Renames resources ID to match file names. Bug: 1111229 Change-Id: Idbf49a3fb273bf7a4a64cb1431087db1199a9ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409657 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809630}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/c1d5cef..71413e9 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I9ad35d0700b17584cad73f851c603c591636b7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422320 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Auto-Submit: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#809629}
-
Asanka Herath authored
Bug: 973801 Change-Id: I4567b856ab55097edddf8939cb5c1c3cff6f5768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422618 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809628}
-
Darwin Huang authored
TBR=takumif@chromium.org Bug: 1124982 Change-Id: I5464b1abdf11c13fea7d0819abc809d2a6abf184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424521Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809627}
-
Trevor Perrier authored
Bug: 1127531 Change-Id: I42538f522e6ce49483d6070566bc9f06c15c77d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422711 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809626}
-
David Black authored
Holding space needs to support selection of multiple holding space items to perform bulk context menu and drag/drop operations on them at a time. This CL refactors HoldingSpaceItemContextMenu into a shared HoldingSpaceItemViewDelegate to facilitate these requirements. Note that this CL does not change any existing behavior, just lays the groundwork for supporting multiple selection. Bug: 1129981 Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809625}
-
Becca Hughes authored
Adds Shaka Player to //third_party to be used by Chrome Kaleidoscope. Eng-Review: https://groups.google.com/a/google.com/g/chrome-eng-review/c/TWyhpLrpc-8 BUG=1117052 Change-Id: I5e682287951962c06fb32060100e26d7d5097551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359572Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#809624}
-
James Vecore authored
This CL adds a pref to track if onboarding was run by this user before. If it has not, when enabling for the first time, onboarding is run first by navigating to the subpage and showing in a dialog. Once onboarding has been done once, the user can freely toggle on/off without triggering onboarding. However, onboarding will still run if the user triggers the pod button and the feature is disabled. This matches the Android behavior. Additionally, this CL fixes a bug with the premature closing of the shared receiveManager which needs to stay alive and connected after the dialog closes otherwise getReceiveManager returns a remote with a closed pipe. Bug: b/154866951 Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809623}
-
Robbie McElrath authored
This CL prevents the top view from being force shown unless the renderer crashes or us unresponsive. Bug: 1127076 Change-Id: I0092a473726376c11181863d3041aa60de15eb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419384 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809622}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id975e82ce1fd43dfb7bf3ce9debffe9efd848581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420535 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809621}
-
Robert Ogden authored
This CL adds an enum, SiteInstanceProcessAssignment, which describes all the ways a SiteInstance may be assigned a render process. This is exposed in the content API to allow embedders to record this usage. See design doc in bug and/or chained CL for more info. Bug: 1129505 Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809620}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_GetDefaultPrintSettings message to GetDefaultPrintSettings() in mojom::PrintManagerHost. It introduces several helper functions to access PrinterQuery which runs on IO thread. GetDefaultPrintSettings is called on UI thread and posted to IO thread for PrintViewManagerBase to get the settings. It also updates PrintRenderFrameHelperTestBase with implementing GetDefaultPrintSettings in TestPrintManagerHost and managing it based on the frame. Bug: 1008939 Change-Id: I873a7a4a3b3e46ca39880946724bcf8b3a2818b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409467Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#809619}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/efa0f60c03cb..9bcb0cadf78f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com,huangdarwin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com,huangdarwin@google.com Change-Id: I0aba1c4bb0e30d775f365a6cb6d4e36cc18aaa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425264Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809618}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I1f3d4a7c29fb1bac0f5d4fd2b5ebd42217d79f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420775 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Updates COMPONENT for platform/json since Blink>Internals is getting deprecated. https://docs.google.com/document/d/1aIyRShgMPy1TmuaMK-hI7j6bewbjqc4Nyxp0N0PTvGE/edit Bug: None Change-Id: I420d8143ec483f7366efa0fb5ff2197916e62949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416152Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809616}
-
Keishi Hattori authored
Updates COMPONENT for platform/weborigins since Blink>Internals is getting deprecated. https://docs.google.com/document/d/1aIyRShgMPy1TmuaMK-hI7j6bewbjqc4Nyxp0N0PTvGE/edit Bug: None Change-Id: I76c76601539153cbf086531762b70983399064df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417777Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809615}
-
James Vecore authored
Converts disocvery and confirmation pages to use the page template for consistent behaviour and reduced css. There should be no change in behavior. Change-Id: I8382befed448e6bb1b94e020717cb127950eeaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423350 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Rachel Carpenter authored
Also move all the logic for when to show Release Notes notifications to one place so that it is easier to parse. Bug: b/167914389 Change-Id: I7712b410b635fd7d2c2d84abfa5a4b5124d1bdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413368Reviewed-by:
-
Maggie Cai authored
deactivated. This CL increments the auto display service counter when dialog deactivated on CommonAppsNavigationThrottle. The dialog should stop auto pop up after 2+ dismissals. BUG=853604 Change-Id: I3ec88d4d767dbf41c08258f1b055fc6467736a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424363Reviewed-by:
-
Christoph Schwering authored
The feature is disabled by default and is not subject to an active experiment. Bug: 1007974 Change-Id: I304f6a1c64ff3370fff91c63bb50ce1441d9bf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410020 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#809611}
-
Dale Curtis authored
R=tguilbert Bug: 1128458 Change-Id: I339bc8eab6770da2db79b89800f6022a6680707d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424651 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#809610}
-
Richard Townsend authored
Layout can occur earlier under the foreground HTML parser, but this broke some layout tests (which depend on document.fonts.ready firing after onload). To fix, make sure that FontFaceSetDocument::DidLayout checks for Document::LoadEventFinished, and call it after every layout operation (not just after LocalFrameView::UpdateLayout) to make sure that it fires (LocalFrameView::UpdateLayout is skipped if the the frame doesn't think it needs layout, which it _does_ if fonts are ready.) Bug: 901056 Change-Id: Iadb04fecfc01c1f1e1b7d74016cca5166923ded5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273140Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#809609}
-
Erik Chen authored
This reverts commit 47ef029b. Reason for revert: Broke codesearch Original change's description: > [lacros] Support also_build_ash_chrome in lacros build > > This CL supports also_build_ash_chrome arg to allow building ash-chrome > in an alternate toolchain. > > A few other fixes are required to work, but they will be landed in > separate CLs because they could affect existing builds, so landing them > separately will make it easier to reason and detect potential breakages. > > Bug: 1129223 > Change-Id: I94dc3dc1ca2bc96f029fea3c4f4d6e41d018e2ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416999 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#808611} TBR=dpranke@google.com,liaoyuke@chromium.org NOTRY=true Bug: 1129223 Change-Id: If057512f5d495989bc339ab2ff10440cbba729b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422599 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#809608}
-
minch authored
Themed system tray background was added at crrev.com/c/2006370 and removed at crrev.com/c/2398988, since themed background is controlled inside AshColorProvider after crrev.com/c/2242223. - Remove the unnecessary logic inside GetBackgroundColor that was added to theme the system tray background color. - Always add blur for system tray. Then the background color of the system tray will always be kTransparent80 with 30 blur sigma, based on the latest spec at https://www.figma.com/file/rQFGy3iAMfNdDnydTGkvHr/Style-%7C-Semantic-color-system-surface-theming?node-id=372%3A0 Bug: 1130618 Change-Id: Ib38a30f6f287baa63a3f2544374224e526859e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424646Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#809607}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c7133e86f13..4f973a50bbbc 2020-09-22 oysteine@google.com Merge "New/Updated typed arg types for Chrome" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04e1ab30cfa69c02b6df7ceb1c4cee9dfd2f346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809606}
-
Xing Liu authored
Only call DownloadManager.addCompletedDownload on Android version below Q, since it's deprecated. On R it will cause a crash. Bug: 1120233 Change-Id: I19951e2fcdd71b9de9facbc551c95fd275f46170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425168Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809605}
-
Christoph Schwering authored
The feature is enabled by default and is not subject to an active experiment. Bug: 1007974 Change-Id: I96bae8f4a0ad8493e1c32bfecfe9814e4190fef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409907 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
Alan Cutter authored
This CL updates the comment in tools/metrics/histograms/OWNERS to mention chromium-metrics-reviews@google.com when git cl upload suggests a reviewer when touching histograms.xml. Before CL: Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) owner@chromium.org is commented as: Use the following owners only if: - You work in the same area as them. - They are already a good reviewer for the non-metrics part of the CL. After CL: Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) owner@chromium.org is commented as: Prefer chromium-metrics-reviews@google.com instead. Use the following owners only if: - You work in the same area as them. - They are already a good reviewer for the non-metrics part of the CL. Change-Id: I9162a55caac98f7481f8d2517acc509faee969b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418501 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by: -
Mohammad Refaat authored
Attach a WKWebView to the view so cookies can be set correctly. Also adding clearing cookies between tests. Bug: 1121425 Change-Id: Ib2fabd80040963e7c8a9a76a9a5eb3fe66def589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423052Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#809602}
-
Min Qin authored
This is recorded for regular suggestions, but missing for Query tiles. BUG=1130176 Change-Id: I05a33d57b57442deb58dc9972726e01fbdf8b422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419921 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#809601}
-
Eugene But authored
This is a follow up for the following comment: https://chromium-review.googlesource.com/c/chromium/src/+/2410302/1/ios/chrome/browser/crash_report/synthetic_crash_report_util_unittest.mm#86 Bug: 1103752 Change-Id: If5e0d97dadbb07705d59e3814b0b10f38f92d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425114 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809600}
-
