- 07 Apr, 2020 40 commits
-
-
Hans Wennborg authored
This is in preparation for moving these macros out of logging.h Bug: 1031540 Change-Id: I29aa4ce07dcb7b165b72a6fa4b8dda4f8371e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139152 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757001}
-
Dominik Röttsches authored
Bug: 1063867 Tbr: kojii Change-Id: I7cc1a1e075078c6e2d82b45321463056ae217759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139711Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#757000}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e95fbfb1f509..4af38c49bfee git log e95fbfb1f509..4af38c49bfee --date=short --first-parent --format='%ad %ae %s' 2020-04-06 afdx@google.com spirv-fuzz: Improve support for compute shaders in donation (#3277) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4af38c49bfee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ia7afaf8b1f59bed26226e5ab87a81dcbda61174a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756999}
-
Simon Zünd authored
This CL prevents Debug.evaluateOnCallFrame to interrupt V8 execution. This is necessary as V8 is not able to handle nested Debug.evaluateOnCallFrame messages in a safe and correct manner. Bug: chromium:1062448 Change-Id: I59f62c3c16a3052fe09043e06ced6b59c8364fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139391 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756998}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bdb6807825ac..b4a27407e2be git log bdb6807825ac..b4a27407e2be --date=short --first-parent --format='%ad %ae %s' 2020-04-07 bclayton@google.com Coverage: Improve uncovered visualizations Created with: gclient setdep -r src/third_party/swiftshader@b4a27407e2be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0e9786a27a931cb38c21cb85593cbd5715013348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139252Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibfc14dbbc3cab9a131352d9c724483f53c47a16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139379Reviewed-by:
-
Alice Wang authored
This CL adds the param eligible_for_consistency in X-Chrome-Connected header and sends true to Gaia when user is signed out. It also parses the param show_consistency_promo from the response of Gaia. Bug: 1063362 Change-Id: Ia6329304db8928a5e309fa7f2424f66a55a04751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132252 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756995}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates OfflinePage classes. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781, 1067314 Change-Id: I73fa1791aa8c862ee0c9833eeb13db1c92ac411d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126989 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#756994}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1065314 Change-Id: Ib716159c67e84ac6e09511c45dc42cedc45d23dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123991 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756993}
-
Dominic Battre authored
This adds more log data to understand why the charset converter fails on some Chrome OS bots. R=mkwst@chromium.org Bug: 1068489 Change-Id: I4abca82cdffdd60ffd7c15f186c79768c2a1c8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139651 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#756992}
-
Wez authored
This test made assumptions regarding the timely processing of network- change notifications, resulting in flakiness. Fix the test to explicitly wait on each expected OnNetworkChanged() notification before continuing. Bug: 1064673, b/142796913 Change-Id: I9da235476415274ebcd254d8f6d08a62176b31c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124669 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756991}
-
Koji Ishii authored
This member needs to be set in |LayoutBox::AddLayoutResult|, after |NGFragmentItems| was built and set to the cached list. Since this member is used as a cached index, allow changing by marking it as |mutable|. This change is needed to properly mark |NGFragmentItem| as |const|. This patch has no behavior changes. Bug: 982194 Change-Id: I83131b744cd73994b861be9eb374e5e5e47fd5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138998Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756990}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/lSCFQ.....PanIU... Created with: gclient setdep -r src/third_party/aemu-linux-x64@PanIU... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ie5c8ea92d8145654e845ae9d9b93b80783c10ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139351Reviewed-by:
-
Rainhard Findling authored
* Rename metrics to appropriate naming scheme. * For safety check start, record both action and hist on JS side to have metrics for all user actions in one place. Bug: 1015841 Change-Id: I2160be6721bad09d6f7c2978e1a459b8916615ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132140Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756988}
-
David Jean authored
Bug: 1052143 Change-Id: I1838e127921240e6052c4f2370ea4e0e46ae3d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137389 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#756987}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/275e665173c6..852ebea2d55d git log 275e665173c6..852ebea2d55d --date=short --first-parent --format='%ad %ae %s' 2020-04-07 csmartdalton@google.com Reland "Reland "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"""" 2020-04-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@852ebea2d55d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5a46266b0c5075299b8b2ead185e0cde6997b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139251Reviewed-by:
-
Sean Harrison authored
Bug: 1032584 Change-Id: Ic18e3947f11d756f8e6d28b53d380f7cde59d7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133970 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756985}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f526d777e0b3..c3c6694d8f0f git log f526d777e0b3..c3c6694d8f0f --date=short --first-parent --format='%ad %ae %s' 2020-04-07 cwallez@chromium.org Rename BG[L]Binding to BG[L]Entry Created with: gclient setdep -r src/third_party/dawn@c3c6694d8f0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifbbbbab40bba512b6ced6672cd09c6b7fdebefe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139129Reviewed-by:
-
Noel Gordon authored
<cr-action-menu> is Polymer3 and so won't be active during a files app unittest framework. Add window.UNIT_TEST guards to prevent the breadcrumb.js unittest from trying to access undefined (in unittest) <cr-action-menu> api. Define window.UNIT_TEST and window.IN_TEST for closure compilation. It seems window.IN_TEST is only closure defined in gallery externs so add these new closure defines to a files app common externs file. Bug: 1061388 Change-Id: Id5c11649f32969d5b1b11cbf30236c80edbc69c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138939Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756983}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e8697a423557..e29095b1961e git log e8697a423557..e29095b1961e --date=short --first-parent --format='%ad %ae %s' 2020-04-07 mathias@chromium.org Add more countWtf8Bytes unit tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@e29095b1961e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iece6bbc6104073d7b1ba65fcb25a6e4aa4274cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139123Reviewed-by:
-
Dominic Battré authored
This reverts commit 66559848. Reason for revert: broke Cast Linux builder, see https://crbug.com/1066880#c11 Original change's description: > Fix issue with accessibility events on hidden nodes > > This is an issue with AXObjects that are ignored and not > included in the accessibility tree. When we fire an event > on such a node, the serializer owned by > RenderAccessibilityImpl first walks up to find a common > ancestor that is in the tree, and then serializes that > node, even if it was already serialized. It breaks the > mechanism that avoids re-serializing nodes that were > already just serialized. > > In extreme circumstances, this led to a bug where the > size of the AXTreeUpdate for a large table grew to 200MB > for one particular website, even though the resulting > AXTree had only around 2MB worth of data. > > The fix is simple: when a node changes, only fire a > notification on the nearest ancestor that's in the tree. > That way the serializer can avoid redundantly processing > the same node more than once. > > Covered by a new test and a DCHECK that asserts that we > should never get an AXTreeUpdate with more nodes than the > size of the resulting tree. Without the new fix, the test > fails with an AXTreeUpdate containing 1000 nodes with a > tree of size 10. > > Bug: 1066880 > > Change-Id: I247ad6aecaaf45b02371d2dad430b50489a86fa2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134848 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756970} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com Change-Id: I8c28e60d58d4270dd2942de2b1e067c3f390c40e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138415Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#756981}
-
Matthias Körber authored
Bug: 1065001 Change-Id: If942491a835311080ef5f64f4cce76e3ba64ca67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121267Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#756980}
-
Rune Lillesveen authored
Bug: 1067277 Change-Id: I255b78ea9edece09ceb2c74848dc7a48d2166ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137343Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756979}
-
Hiroshige Hayashizaki authored
The test is no longer flaky. TBR=battre@chromium.org Bug: 960623 Change-Id: I0a6d3ac4ddd64faf7c4f2b36654e570a0955abcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138995Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#756978}
-
Anastasiia Nikolaienko authored
Bug: 1068231, b/141108534 Change-Id: I263857af7a4e1e0e13eba367b66bbe12bbe6f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135758Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#756977}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c048306eaf01..bc1001ace1ff git log c048306eaf01..bc1001ace1ff --date=short --first-parent --format='%ad %ae %s' 2020-04-07 dberris@chromium.org Dashboard: Terminate on Permutation Test Convergence Created with: gclient setdep -r src/third_party/catapult@bc1001ace1ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067589 Tbr: nuskos@google.com Change-Id: If853adf72219b794462d28d2829aa8b8c857333c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139115Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5846ff3c7ae0..275e665173c6 git log 5846ff3c7ae0..275e665173c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c0b367bf..ebd295df (366 commits) Created with: gclient setdep -r src/third_party/skia@275e665173c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I521d612e267d16387d238d952ef8276105b9c494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139111Reviewed-by:
-
Alex Danilo authored
Changes the setting of 'transparent' background color to only apply for the non files-ng case - allowing the files-ng background color to inherit. This also has the side-effect of allowing all the files-ng background color rules to work as well (e.g. no hover color when pointer is active). Bug: 1068079 Change-Id: Icb4611d9138404b8ba9854e518619adf02c44246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138936Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756974}
-
Melissa Zhang authored
This reverts commit 4c027362. Reason for revert: Potentially breaking https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4672 Original change's description: > [CrOS settings] Fix printing new route in settings page > > https://chromium-review.googlesource.com/c/chromium/src/+/2126332 > Changes the routes to printing pages in settings. os_printing_page has a > route that was missed. This CL updates the route in > os_printing_page.html to match the new route, from /printing to > osPrinting. > > Fix: 1068322 > Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: jimmy gong <jimmyxgong@chromium.org> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Cr-Commit-Position: refs/heads/master@{#756949} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I50d29f93d85233a198f62baec0e65b4c5eda9b4f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139172Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756973}
-
Dominic Mazzoni authored
Completely mechanical/automated. Doing it in small chunks and landing with TBR to minimize collisions. Bug: 1063155 Tbr: aleventhal@chromium.org Relnotes: N/A Change-Id: I5fbd94675e32b998f3817923f6c5c619e5d59629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131528 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#756972}
-
Alex Danilo authored
Adds a blue focus ring around the cancel selection button only when it's being focused from keyboard interaction. Sets width of the cancel selection button to match the width of buttons on the action bar. Bug: 1068079, 1065837 Change-Id: I2adad00e74dbf1a8515b4dabbdcc704c51aa8e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139054Reviewed-by:
-
Dominic Mazzoni authored
This is an issue with AXObjects that are ignored and not included in the accessibility tree. When we fire an event on such a node, the serializer owned by RenderAccessibilityImpl first walks up to find a common ancestor that is in the tree, and then serializes that node, even if it was already serialized. It breaks the mechanism that avoids re-serializing nodes that were already just serialized. In extreme circumstances, this led to a bug where the size of the AXTreeUpdate for a large table grew to 200MB for one particular website, even though the resulting AXTree had only around 2MB worth of data. The fix is simple: when a node changes, only fire a notification on the nearest ancestor that's in the tree. That way the serializer can avoid redundantly processing the same node more than once. Covered by a new test and a DCHECK that asserts that we should never get an AXTreeUpdate with more nodes than the size of the resulting tree. Without the new fix, the test fails with an AXTreeUpdate containing 1000 nodes with a tree of size 10. Bug: 1066880 Change-Id: I247ad6aecaaf45b02371d2dad430b50489a86fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134848 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5540fdbe7451..55cc5f2199b1 git log 5540fdbe7451..55cc5f2199b1 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 tsepez@chromium.org Move uint8_t vectors to data partition in xfa/ 2020-04-06 tsepez@chromium.org Move uint8_t vectors to data partition in fxjs/ 2020-04-06 tsepez@chromium.org Put uint8_t vectors into data partition in fpdfsdk/ 2020-04-06 tsepez@chromium.org Put uint8_t vectors into the Data partition in fpdfapi/ 2020-04-06 thestig@chromium.org Fix regression in FPDF_CountNamedDests(). 2020-04-06 thestig@chromium.org Add more tests for FPDF_CountNamedDests(). 2020-04-06 thestig@chromium.org Fix typos in some .in files and regenerate the .pdf files. Created with: gclient setdep -r src/third_party/pdfium@55cc5f2199b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I85b9bb34d3abe405ae35d672c27ac0b2343a2131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138968Reviewed-by:
-
Peter Kasting authored
The bulk of this is simply moving the contents of toolbar_button_interactive_uitest.cc into toolbar_button_unittest.cc. Originally, the tests in this file were split out due to fears that showing a context menu in a unittest would lead to flakiness (due to e.g. setting mouse capture) (see https://codereview.chromium.org/1864423002/#msg7 ). However, we run menus in plenty of other unittests (e.g. ui/views/controls/menu/menu_runner_unittest.cc), and it doesn't cause problems. I also tested this locally and could not detect any problems either running in a debugger and allowing the menu to set capture, or trying to do mouse input while the tests ran. I suspect this is not going to cause an issue; certainly it's worth a shot. This also moves these tests from ViewEventTestBase, which was being misused to not actually run event tests, to ChromeViewsTestBase, which does the desired frameworky bits without the unnecessary ones. Finally, this makes use of ViewsTestBase::CreateTestWidget(), SimpleMenuModel, and a few other classes to dramatically reduce the amount of boilerplate code necessary. Bug: none Change-Id: I6658760610e963d44e557e4985bb936bacd1a118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139112 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756968}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/029854ebc997..e8697a423557 git log 029854ebc997..e8697a423557 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 kimanh@chromium.org Wait for line to be loaded before setting breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@e8697a423557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id6d5d22331712fe47008d1a119a7add4e752b380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138967Reviewed-by:
-
Minyue Li authored
Bug: 1056230 Change-Id: I7cc0529eaa2e476192d62637fb70e6542920021a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126291Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Minyue Li <minyue@chromium.org> Cr-Commit-Position: refs/heads/master@{#756966}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ic5b4050f5e9c4e2a7f09e79510537fba9e7995dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138655 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756965}
-
Roman Sorokin authored
* Removed webui_login option. * Simplified ctor. * Migrated tests to LoginManagerMixin where possible * Changed base class to OobeBaseTest where makes sense Change-Id: I011ec80a5c9ef97d500b9cb396fe90de3409b87d Bug: 987587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122927 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#756964}
-
David Bokan authored
This feature has been enabled for close to a year so it's safe to remove the flag. Bug: 772130 Change-Id: I3e52f442de3d9aec4a55eeed5c9c8bd4c771bf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136103Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756963}
-
Charles William Dick authored
It is not possible to directly reclaim memory from ARCVM based Android apps, so don't kill them. In ARCVM, the virtio balloon is sized to balance available memory between host and guest, so if there is critical memory pressure in Chrome, there will also be limited memory in the Android guest. ARCVM relies on the Android Low Memory Killer running in the guest to kill apps, increasing the memory available to the guest, which will be returned to the host with the virtio balloon. BUG=b:147336074 TEST=launch ARCVM, run 'grep 'WARNING debugd' /var/log/messages'. verify there's no warning from debugd. tast run <DUT> arc.MemoryChromeOSPerf.vm, also see no warnings in /var/log/messages. (this will force critical memory pressure) Change-Id: I7d610ea44eaf45494f6b4143b053779f6f3df6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135094Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Charles Dueck <cwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756962}
-
