- 28 Nov, 2017 40 commits
-
-
Justin Donnelly authored
It no longer has any effect since the feature was rolled out server-side. Bug: 787621 Change-Id: If993da36b87d3a43adfc6377c3f66a73b2b6415d Reviewed-on: https://chromium-review.googlesource.com/794154 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#519901}
-
chrome://net-exportEric Roman authored
Bug: 788668 Change-Id: I9aeb429e91854eecef19cb29dacb65d05465a28f Reviewed-on: https://chromium-review.googlesource.com/794716Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519900}
-
Xiyuan Xia authored
ExtendedAuthenticator(Impl) could out-live AuthStatusConsumer. Hence AuthStatusConsumer should clean up its reference in the ExtendedAuthenticator before it is released. Bug: 788987 Change-Id: Ie489da7b0c085cbfa7723b01692855c3457cf90a Reviewed-on: https://chromium-review.googlesource.com/794842Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519899}
-
Qiang Xu authored
changes: - Move Is{Toggle}SpokenFeedbackEnabled code to ash, which used to be AccessibilityDelegate and called into chrome. This won't work in mustash world. This change breaks the delegate way, by having prefs in ash, the Is{Set} could be done in ash. - Change ToggleSpokenFeedbackEnabled to SetSpokenFeedbackEnabled to align with other method names. feedback enabled update the tray icon visibility. This is one step forward. Bug: 594887 Test: tested on emulator with --mash. Could see toggling spoken Change-Id: I3a9c4277f6d1e8bfb2b03777011f6f2f9055d296 Reviewed-on: https://chromium-review.googlesource.com/777780 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#519898}
-
Sammie Quon authored
Bug introduced when I was trying to show focus rectangle around user card view by removing the background. Draw the background instead on the parent, button_from_view, which the focus painter is on so that the background does not cover the focus rectangle. Also fix the separator between the user card view and the drop down, before it only reached halfway (see bug for snapshot). Test: manual Bug: 786184 Change-Id: I54481c414a373a9f761d4b2f6b8097160633fbdc Reviewed-on: https://chromium-review.googlesource.com/794853Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#519897}
-
Devlin Cronin authored
We have a UseStrictIPCMessageSender() method in NativeExtensionBindingsSystemUnittest, but it wasn't being checked when we instantiated the IPCMessageSender. Correctly check it so that tests that want strict mocking get it. Bug: 653596 Change-Id: Ib18945a14e0a88788bcfe9e56c530ff0ae2b36ca Reviewed-on: https://chromium-review.googlesource.com/786900Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519896}
-
Xiaohui Chen authored
Bug: 761426 Test: Build and run locally, used browser, settings, voice search Test: on new tab and no feature seems broken. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I647a19ec174442ddab5c4c322bfd34c8fc9a75bf Reviewed-on: https://chromium-review.googlesource.com/740909 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519895}
-
Sergei Datsenko authored
Check handling of different types of redirects and their combinations. Bug: chromium:787197 Change-Id: I6548c2802e000a2dd7913bbf1154797312b15361 Reviewed-on: https://chromium-review.googlesource.com/790051Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#519894}
-
Vlad Tsyrklevich authored
This cfi-icall failure manifests with new versions of libgtk, discovered after an upgrade. Change-Id: I9f5d90c55599d4b935b0ddd3184df203bc674767 Reviewed-on: https://chromium-review.googlesource.com/794872Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519893}
-
Scott Little authored
This test has a data race; see bug for more info. TBR=chrisha@chromium.org Bug: 787842 Change-Id: I299403b8c4f2c2744b4c7d7a0173759bd7a65925 Reviewed-on: https://chromium-review.googlesource.com/794841Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#519892}
-
Raymond Toy authored
When reading the output of the waveshaper tests, it's kind of hard to tell exactly what's being tested. Add a few more test messages and/or labels to make it a bit clearer. Bug: 789197 Test: WaveShaper/waveshaper-{copy-curve,simple}.html Change-Id: Ic90ebe94282d4b416321766bc16daa3cbc53299c Reviewed-on: https://chromium-review.googlesource.com/794018 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519891}
-
Yafei Duan authored
Most tasks are taking raw pointers and they needs to be checked against nullptr. This CL fixed the potential issue. Bug: 772206 Change-Id: Ifab61fd75ed88c9d03fd0af8088454148c88144a Reviewed-on: https://chromium-review.googlesource.com/792261Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#519890}
-
Abhishek Arya authored
R=ochang@chromium.org,mmoroz@chromium.org Bug: Change-Id: Ie4a1446726e84b2cb3826515f06a9a9d74f3b0fb Reviewed-on: https://chromium-review.googlesource.com/794593 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519889}
-
Mustafa Emre Acer authored
These seem to be remnants of Google Toolbar. Bug: 789302 Change-Id: I21432ee75ee428d422c5f7ff6846e6d9333c89ed Reviewed-on: https://chromium-review.googlesource.com/792343 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#519888}
-
kapishnikov authored
Since BUG 787148 that caused Cronet test flakiness on iOS has been fixed, we can reduce the timeout. 15 seconds should be enough time for all current tests. BUG=781012 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieaa65d6a6e65112be4dfea821f1142a51acdc7ce Reviewed-on: https://chromium-review.googlesource.com/794038Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519887}
-
Jared Saul authored
Previous CL affected both Chrome Downstream card unmasking *and* PaymentRequest: https://chromium-review.googlesource.com/c/chromium/src/+/780361 Bug: Change-Id: I60fb111109f2c1ee0406158d0558cad4d3a17a95 Reviewed-on: https://chromium-review.googlesource.com/785793Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519886}
-
Scott Violet authored
Also some other insignificant changes I came across when looking into this. BUG=none TEST=none Change-Id: Ia0b831db631c7663d41ddb828d78338b40d7f228 Reviewed-on: https://chromium-review.googlesource.com/794632Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519885}
-
Scott Violet authored
The current pattern for test suites that *may* use aura has the test suite create aura::Env. In order to enable mus more broadly we need to make it so that the test suite configures Env appropriate for mus. This patch adds AuraTestSuiteSetup that is meant to setup the necessary state at the test suite level for tests that may use aura. It looks at the command line and potentially enables mus as appropriate. In order to setup env for mus WindowTreeClient needs to be configured, which required moving around some stubs. I had to update AuraTestHelper for mus being configured at the global level. This is mildly complicated by the fact that AuraTestHelper wants to create its own WindowTreeClient in this case. BUG=776514 TEST=covered by tests Change-Id: Ie433e4f6afe58b2aa15bdfb08fe462c6c1a30fad Reviewed-on: https://chromium-review.googlesource.com/792455 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519884}
-
Erik Luo authored
Screenshot: https://imgur.com/a/d5iLM Bug: 771931 Change-Id: I8b3abd912cedfcc74f9deff87c9e5885cfc26678 Reviewed-on: https://chromium-review.googlesource.com/777841Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#519883}
-
Matt Falkenhagen authored
* Remove content::ServiceWorkerProviderType and typemapping. * Move content::mojom::ServiceWorkerProviderType to Blink. * Give modern names and comments to the type. Bug: 629701 Change-Id: Iab93d2392fdcb45b41cfbfcdd41513131f0109b8 Reviewed-on: https://chromium-review.googlesource.com/792552Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519882}
-
Jialiu Lin authored
This is a regression introduced by a refactoring CL. SupportUserData key should be unique, but due to this refactoring, one of the data key losts its sameness. This make SetUserData() and GetUserData() consume different keys. This CL fix this problem. Also move the logging of "SafeBrowsing.ReferrerURLChainSize. DownloadAttribution" UMA metric right before report sending to help catch this kind of regression in the future. Bug: 789217 Change-Id: I778926b2d2ede69ad2b7c8327ce835104faa7852 Reviewed-on: https://chromium-review.googlesource.com/794512 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#519881}
-
Jose Dapena Paz authored
There were several typos in AXPlatformNodeAuraLinux implementation of AtkValue interface. Change-Id: Ifdcee50d0425f71f30b651d35197c663723adf8c Reviewed-on: https://chromium-review.googlesource.com/794137Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#519880}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cde6fc4afe73..11d7efb857ae $ git log cde6fc4af..11d7efb85 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 simonhatch Dashboard - Add webcomponents-lite.js for html imports polyfill. 2017-11-28 simonhatch Pinpoint - Always run ReadValue quest Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1b3ddb70ec2e3d646a64035481acff18d4930a0e Reviewed-on: https://chromium-review.googlesource.com/794594 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519879}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/99acb1c816dc..1ff9b7ffa653 $ git log 99acb1c81..1ff9b7ffa --date=short --no-merges --format='%ad %ae %s' 2017-11-28 dsinclair Remove CollectionSize from fpdfppo. 2017-11-28 dsinclair Remove CollectionSize from fpdf_flatten. 2017-11-28 dsinclair Remove CollectionSize from string_view_template 2017-11-28 dsinclair Remove CollectionSize from JBig2_Context 2017-11-28 rharrison Convert from character stream to visible text indices in GetText Created with: roll-dep src/third_party/pdfium BUG=788103,788220 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iefdff68f09558ee706d0702bf47b8241a7141f4c Reviewed-on: https://chromium-review.googlesource.com/794026 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519878}
-
rbpotter authored
- Change model to be a Polymer UI element - Leverage existing classes to store data - Add behavior for setting/getting settings values Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I30b5aa71363c0bc2820670e8a9f3fb77b5975477 Reviewed-on: https://chromium-review.googlesource.com/783692Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#519877}
-
Fady Samuel authored
This CL adds UMA to track how often the CompositorResizeLock and Surface synchronization fail to synchronize clients within a given timeframe. This CL also tracks the number of times a fallback surface is used within a call to SurfaceAggregator::Aggregate. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia6a5e0a102372b7bc87160ebc611a66dee0b58c1 Reviewed-on: https://chromium-review.googlesource.com/794210Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#519876}
-
Ovidio Henriquez authored
This change updates the optional-services-present.html test to not use setBluetoothFakeAdapter. This will help us migrate the tests to the wpt/ directory, since testRunner is not used anymore. This change also updates the files in https://chromium-review.googlesource.com/c/chromium/src/+/769346 to resolve the comments that were made after the CL was submitted. To address the comments, assert_equals is used in request-from-iframe.html instead of assert_unreached, and callWithTrustedClick is placed before the onmessage listener. BUG=509038 Change-Id: I95b846790f7f5b69cf3c76d16638b4d130d77bf8 Reviewed-on: https://chromium-review.googlesource.com/779700Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@google.com> Cr-Commit-Position: refs/heads/master@{#519875}
-
David Dorwin authored
Removing the default entry will cause a compiler error if a value is missing. This also makes it clearer how each value is handled. This CL also makes the values absolute to further enforce consistency with enums.xml and disables obsolete values. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9cdf9b1dffdcb3f4b365676c5ca71cb46fe44f85 Reviewed-on: https://chromium-review.googlesource.com/792262Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519874}
-
Jose Dapena Paz authored
Move AXPlatformNodeWinTest utility methods that are platform independent to a parent class that can be used for other platforms unit tests. This is a preparation change to land later AXPlatformNodeAuraLinux unit tests. Bug: 789099 Change-Id: Ib0592dd96414ee3ad222c04e17d12537fc629fd8 Reviewed-on: https://chromium-review.googlesource.com/793034Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#519873}
-
Raymond Toy authored
Test that insertion of events at the same time as existing events are handled correctly. Bug: 788932 Test: AudioParam/event-insertion.html Change-Id: I0b27ac6f17730f35e552b456e52fa997615e6060 Reviewed-on: https://chromium-review.googlesource.com/791913 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519872}
-
Kim Paulhamus authored
Correctly return TypeErrors instead of DomExceptions for missing Rp & User Entity elements. Bug: 664630 Change-Id: I464a3d2555f2599299238768a8ef59e8b32cb7f6 Reviewed-on: https://chromium-review.googlesource.com/741863 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519871}
-
Andrey Lushnikov authored
This patch starts treating *.mjs files as javascript files. BUG=781088 R=dgozman Change-Id: I58222d6b7ad3d1c3c3442048da9cf46692b23172 Reviewed-on: https://chromium-review.googlesource.com/794349Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519870}
-
Bo Liu authored
Relying on browser compositor for the reset is problematic because reset stops if app is in the background, which also happen to be the time the GPU is most likely to be killed by Android. Move the reset signal to any context creation success directly from the GPU process. ContextProviderCommandBuffer::BindToCurrentThread does more things like registering transfer buffers. But hopefully those don't cause GPU crashes. Bug: 777601 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I360c29c97c7a3222a84cb797c8be2f3fb65200db Reviewed-on: https://chromium-review.googlesource.com/786271Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#519869}
-
Shanfeng Zhang authored
Bug: 734265 Change-Id: Id9690f81213561c1808532c85b41e61ecda81adc Reviewed-on: https://chromium-review.googlesource.com/794412Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Cr-Commit-Position: refs/heads/master@{#519868}
-
Shenghua Zhang authored
Since we are beginning to run external URL test again, and labs now has wifi. We need to re-enable the wifi checker test for swarming_cron use. Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab Reviewed-on: https://chromium-review.googlesource.com/794341Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519867}
-
Devlin Cronin authored
All messaging events (runtime.onMessage, runtime.onMessageExternal, extension.onRequest, extension.onRequestExternal) are handled directly by custom messaging bindings, rather than by the EventRouter. However, runtime.onMessageExternal wasn't marked as unmanaged in the schema. Fix this. Bug: None Change-Id: I438b273c4046f91367fd44e9fcfd8a537ae7f13e Reviewed-on: https://chromium-review.googlesource.com/786899Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519866}
-
Samuel Huang authored
When Supersize assigns tool-prefix by default, but fails to find the tools needed, previously it quietly falls back to using other tools. This CL changes makes this a hard failure instead. For LLVM, also prints instruction on how to download the required tools, now that download_objdump.py is ready. Bug: 723798 Change-Id: Icc7e02deca9800dc7fbf30fbe6314a98c019be25 Reviewed-on: https://chromium-review.googlesource.com/794104 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#519865}
-
Jia authored
This cl adds ui::UserActivityObserver and viz::mojom::VideoDetectorObserver to listen to relevant events when generating idle events. See https://docs.google.com/document/d/123eFd0rUTu0140V6hJKkkWmpqibdIfM-zTtUR5a2qaQ/edit# for more detail. Bug: 784232 Change-Id: I64bae608ea7500406197c3219f26599962256adc Reviewed-on: https://chromium-review.googlesource.com/780480Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Renjie Liu <renjieliu@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519864}
-
Owen Min authored
Bug: 760296 Change-Id: Icd7907d70667feea0f5398c5c87c6f84e441f472 Reviewed-on: https://chromium-review.googlesource.com/792175Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519863}
-
Dan Sanders authored
Before this change, the testing path invoked RenderWrapper::Stop() by posting a task, which would execute after PipelineImpl::Stop(). The production path also posts a task, but to a different thread, and PipelineImpl::Stop() waits for that task to execute before returning. This change makes the testing path more similar to the production path, by ensuring that RendererWrapper::Stop() executes before PipelineImpl::Stop() returns. The PipelineTeardownTest is also updated so that expectations on the Demuxer that Stop() the Pipeline are posted rather than directly called. This better matches the production behavior where they would be on separate threads and therefore cannot be re-entrant. Bug: 788508 Change-Id: I894ee6c2febb3b739aaa809c6aa0d9388b76b64a Reviewed-on: https://chromium-review.googlesource.com/791860 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519862}
-