- 14 Aug, 2018 40 commits
-
-
Fredrik Söderquist authored
The property: paint-order: stroke markers is equivalent to: paint-order: stroke markers fill (Spec: "If any of the three keywords are omitted, they are painted last, in the order they would be painted with paint-order: normal." @ https://svgwg.org/svg2-draft/painting.html#PaintOrder ) So the fill should be painted last. Add 'marker:none' to the appropriate element in the ref. Disable stroke and marker in a few cases to avoid "overdraw" and thus "incorrect" edge rendering in some cases. BUG=872972 Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c Reviewed-on: https://chromium-review.googlesource.com/1172778Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582914}
-
Miguel Casas authored
lowLatency 2D contexts would crash the tab when sent to the background; this is because of the callstack HTMLCanvasElement::PageVisibilityChanged() CanvasRenderingContext2D::SetIsHidden() canvas()->GetCanvas2DLayerBridge()->SetIsHidden(hidden) ... Canvas2DLayerBridge::Hibernate() and that tries to destroy its Layer, which has not been created (because in lowLatency mode we don't use it). This CL fixes the issue by cutting at SetIsHidden() if there is no |layer_|. Test: open https://codepen.io/miguelao/full/ZjJNNw (or any other trivial sample canvas lowLatency demo), draw something , then open a new tab. The former tab crashes on ToT, doesn't with this CL. Bug: 839970, 870873 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6657a72009438cb31fac2b2d874c807b1719d16a Reviewed-on: https://chromium-review.googlesource.com/1173344Reviewed-by:Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#582913}
-
Dominic Battre authored
Chrome used to fetch password requirements specifications once the Autofill server responded. This means that two network round trips were necessary until the data was available. With this change, the requirements are fetched every time the renderer reports that password forms were found, which moves the lookup to an earlier point. As this reporting can happen multiple times through the life-cycle of a site, the CL also introduces an extra in-memory cache lookup that prevents further processing if the requirements have been fetched already. Bug: 873653, 846694 Change-Id: Id1bdd575fa659fcf05b40a937cb6aa00206e8965 Reviewed-on: https://chromium-review.googlesource.com/1172972Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#582912}
-
Xu Xing authored
Main changes: 1), move flag enable viz inside DelegatedFrameHost. 2), cache host_frame_sink_manager_, so this matches DelegatedFrameHostAndroid and saves several lines of code. 3), if enable_viz_ is true, support_ is nullptr. Otherwise, support_ is valid. So (enable_viz_ || support_ ) is always true. Bug: 859977 Change-Id: If13d08dc7dc1ba04de507d181bf2a940d8010466 Reviewed-on: https://chromium-review.googlesource.com/1168740Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#582911}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8f60c708bfd1..193e9338017c git log 8f60c708bfd1..193e9338017c --date=short --no-merges --format='%ad %ae %s' 2018-08-14 anthonyalridge@google.com Create ability to zoom on dot plots. Created with: gclient setdep -r src/third_party/catapult@193e9338017c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I4315739c22c6f86fcecdc1a2ce2eaf5914837840 Reviewed-on: https://chromium-review.googlesource.com/1174451Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582910}
-
Mugdha Lakhani authored
1. backgroundfetchclick and backgroundfetchabort are of type BackgroundFetchEvent now. 2. BackgroundFetchEvent includes a BackgroundFetchRegistration object. 3. Temporarily (until match() and matchAll() have been implemented on BackgroundFetchRegistration), BackgroundFetchUpdateUIEvent also includes a BackgroundFetchSettledFetches object. 4. BackgroundFetchUpdateEvent --> BackgroundFetchUpdateUIEvent, and inherits from BackgroundFetchEvent. 5. backgroundfetched --> backgroundfetchsuccess. 6. backgroundfetchsuccess and backgroundfetchfail are of type BackgroundFetchUpdateUIEvent. 7. Update WPT tests accordingly. Bug: 869918 Change-Id: Ibb05087e692b39c2dd34c990baeff642627b6520 Reviewed-on: https://chromium-review.googlesource.com/1158835 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582909}
-
Kevin Schoedel authored
Plumbs the CastSystemGestureDispatcher through to touch exploration, and invokes tap actions when touch exploration calls for a tap at a location outside lift activation bounds (currently always the case). This allows waking from the ambient screen in screen reading mode. Bug: internal b/112073530 Test: manual Change-Id: Iab086ee76c0aa254c23e2635a4b283ff6156434d Reviewed-on: https://chromium-review.googlesource.com/1168117 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582908}
-
Luke Halliwell authored
Generalize MediaLoadDeferrer interface to handle other media playback options; add IPC to send background suspend enabled state from browser to renderer, and replace switch with content client implementation. Not using a switch will allow this to be robust against redirects and prewarmed render processes. Bug: b/73820381 Change-Id: Ib6b5adb7aa477dae06a1bb911bf6adb896023abe Reviewed-on: https://chromium-review.googlesource.com/1154138 Commit-Queue: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582907}
-
James Cook authored
The existing aura::Env::GetInstance() doesn't create anything. Most callers were using GetInstanceDontCreate() to mean HasInstance(), so rename the method. This makes it easier to write presubmits for aura::Env::GetInstance(). Bug: none Test: bots Change-Id: I0c606df7c8e439579d4ae39fa11dd119b610cb77 Reviewed-on: https://chromium-review.googlesource.com/1173473Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582906}
-
Javier Ernesto Flores Robles authored
Marking ContextMenuJsTest.FindLinkImageAtPointOutsideElement, ContextMenuJsTest.GetImageTitleAtPoint and ContextMenuJsFindElementAtPointTest.LinkOfTextWithoutCalloutProperty as flaky on devices. Bug: 796418 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1639c935a5f33cccd58a809f63f8bbeac32dcd45 TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174536Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582905}
-
Kevin McNee authored
The associated bug which required this extra tab is fixed. Bug: 147644 Change-Id: Ic256c30eda064134d670f3ce49ca7483a0ed5ff7 Reviewed-on: https://chromium-review.googlesource.com/1173400Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582904}
-
Elly Fong-Jones authored
Without any stored images, TabCloseButton falls back to the default sizing for ImageButton, which is 16x14. This change makes it always a square, which makes the focus ring and ink drop circles instead of ovals. Bug: 873063 Change-Id: I5c2deec54f768d64be14ee0f9c0adcb52a8d754e Reviewed-on: https://chromium-review.googlesource.com/1172506Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582903}
-
Gauthier Ambard authored
The bottom insets of the popup menus were wrong because of a rounding error. This CL adjusts it by rounding at the end of the additions instead of doing everytime a new element is computed. Bug: 850516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic99c3d71e1f7d8a0b47a3e6453242d4a36007e66 Reviewed-on: https://chromium-review.googlesource.com/1174253 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582902}
-
Fernando Serboncini authored
TBR=kbr@chromium.org Change-Id: I9a732afd2670bca16f6cbcde309e1397093f42a1 Reviewed-on: https://chromium-review.googlesource.com/1173364 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582901}
-
Rohit Rao authored
This reverts commit 4e0162d3. Reason for revert: Logic in the conditional was wrong. Reverting and relanding to make cherrypicking easier. Original change's description: > [ios] Fixes an issue where BVC is overdismissed by a bug in WebKit. > > The WKFileUploadPanel has a bug in iOS 11 and earlier which causes view > controllers to be overdismissed when the HTML file picker is > used. WebKit attempts to dismiss the file picker view controller, but > due to a bug inadvertently dismisses its presenting view controller > instead. > > We previously attempted to work around this bug in > BrowserViewController, but now the file picker is presented on top of > BrowserContainerViewController instead. This CL copies the BVC fix into > BrowserContainerViewController as well. > > BUG=852367 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I8c3ef4b55cc052f832aa3e9e995c20880a96db00 > Reviewed-on: https://chromium-review.googlesource.com/1172505 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582899} TBR=rohitrao@chromium.org,marq@chromium.org Change-Id: Id199b64138930f430e5b753d00e78cc1ecab54a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1174551Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582900}
-
Rohit Rao authored
The WKFileUploadPanel has a bug in iOS 11 and earlier which causes view controllers to be overdismissed when the HTML file picker is used. WebKit attempts to dismiss the file picker view controller, but due to a bug inadvertently dismisses its presenting view controller instead. We previously attempted to work around this bug in BrowserViewController, but now the file picker is presented on top of BrowserContainerViewController instead. This CL copies the BVC fix into BrowserContainerViewController as well. BUG=852367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c3ef4b55cc052f832aa3e9e995c20880a96db00 Reviewed-on: https://chromium-review.googlesource.com/1172505Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582899}
-
Amirhossein Simjour authored
I also made some changes on Build files to make sure that there is no circular dependencies. More tests to come in follow up CLs. BUG=810847 Change-Id: I04fe2d848ebd76a076a09d1c0aab7cdaba9e205a Reviewed-on: https://chromium-review.googlesource.com/1099563 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582898}
-
Ian Clelland authored
The flag has been removed from RuntimeEnabledFeatures, so this change eliminates a warning message on startup. Change-Id: I8f6f8027f7f0446a5cf3c03f0740cd90277a7ecf Reviewed-on: https://chromium-review.googlesource.com/1173255Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#582897}
-
Pavol Marko authored
Temporarily add ChromeOS-only logging to diagnose certificates disappearing from the system token: (*) Log info about all all User certificates on chrome start up (*) Log a message when a certificate is being deleted. Bug: 844537 Test: Examine output of net_unittests --gtest_filter=*LogUserCerts* Change-Id: Ie9f173573ba7e0704bc8e21462183390fac0c640 Reviewed-on: https://chromium-review.googlesource.com/1169478 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582896}
-
Oriol Brufau authored
Spec: https://drafts.csswg.org/css-logical/#box BUG=873101 TEST=external/wpt/css/css-logical/animation-004.html Change-Id: I104a8ecc746f4516e567b16a75c5d32a31d4dab8 Reviewed-on: https://chromium-review.googlesource.com/1170769Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#582895}
-
Jun Choi authored
Add observer function to notify embedder when Bluetooth adapter power has changed. Bug: 866601 Change-Id: I711b752c75b96a6428b7d1f28f425a5f17cf3bb9 Reviewed-on: https://chromium-review.googlesource.com/1170230 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582894}
-
Rayan Kanso authored
Record the duration of web exposed methods in BackgroundFetchManager using UMA. Bug: 780025 Change-Id: Ide4f4ce2f416f450475d4a75862b2a20ebee41fb Reviewed-on: https://chromium-review.googlesource.com/1170902 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582893}
-
Pavol Marko authored
* Add function GetEndOfCurrent interval to obtain the last end of the interval which contains the current time. * Add function MaterializeIntervalsToLocalTimezone, which materializes the given intervals to the current local timezone. * Add function TimeIsInsideCrosSettingsIntervals, which checks if the current time is inside the intervals set in cros settings. It then returns the localized string of the end of the interval that contains the current time. This is a reland of CL:1132676 which fixes memory leaks that lead to a revert (revert was CL:1172003). BUG=chromium:852860 TEST=added unittests Change-Id: I8ad01d4ab90d4e699e4b7377c24e4932513ebe1b Reviewed-on: https://chromium-review.googlesource.com/1172128Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582892}
-
Javier Ernesto Flores Robles authored
FindImageElementAtPointOutsideElement is flaky on devices. Bug: 796418 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36781de8c1127f74196457c0a0ec7ebf0bd6c5d5 TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174437Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582891}
-
Jérôme Lebel authored
Plugging in the non-personalized section: + "Autocomplete searches and URLs" with prefs::kSearchSuggestEnabled + "Make searches and browsing better" with unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id48c7fbfd9d713a9a2445735797d57d4c7211f05 Reviewed-on: https://chromium-review.googlesource.com/1173236 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582890}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5fb1284. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22701 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I69c6827487746ef2f93c3a68901c55f8e046f14f Reviewed-on: https://chromium-review.googlesource.com/1174104 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582889}
-
Martin Kreichgauer authored
Touch ID previously used a non-zero AAGUID chosen by us. But WebAuthn requires self-attestation to use an all-zero AAGUID value. Also delete the unused |TouchIdAaguid| function. Bug: 678128 Change-Id: I27bc82f7248d2c22ede773c0e6b010f56022d255 Reviewed-on: https://chromium-review.googlesource.com/1172911Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582888}
-
Balazs Engedy authored
Change each sheet show during the WebAuthn UX flow to include a pretty illustration in the top of half of the dialog. Bug: 849323 Change-Id: Ieff9ceea06f63f5b6892e4401b43b922a13d28a8 Reviewed-on: https://chromium-review.googlesource.com/1172323 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582887}
-
Jun Choi authored
Add logic to cancel ongoing WebAuthN request when user clicks "cancel" button from any UI modal or "back" button from the initial welcome screen. Bug: 847985 TBR: jam@chromium.org Change-Id: Ia9a014cf78583c2512ceaebf822758aa0dc65d99 Reviewed-on: https://chromium-review.googlesource.com/1173489 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582886}
-
Gauthier Ambard authored
This CL rename the openURL: method to indicate that it is loading the URL in a new tab. Bug: 861729 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bea43c3589070c1b32b8d7bf08330edab9f59e2 Reviewed-on: https://chromium-review.googlesource.com/1174255Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582885}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fe19ddfb2910..8f60c708bfd1 git log fe19ddfb2910..8f60c708bfd1 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 raphael.kubo.da.costa@intel.com telemetry: Prefer reading Linux version information from os-release(5) Created with: gclient setdep -r src/third_party/catapult@8f60c708bfd1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8c3870f6cbe893b98ac983c3887a0590f621cb0a Reviewed-on: https://chromium-review.googlesource.com/1174212Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582884}
-
Yuta Kitamura authored
This patch adds a new test utility for Blink platform. It's called TestingPlatformSupportWithCustomScheduler, and is a natural extension of TestingPlatformSupport. The new utility removes the need of writing custom Platform and WebThread in tests. Essentially, the objective of this CL is to shift the responsibility of writing custom WebThread from each test to platform/testing. Two affected tests are rewritten to use it. Bug: 826203 Change-Id: I41160fe50286adc3acb09dbd128d654c356d4355 Reviewed-on: https://chromium-review.googlesource.com/1170702 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582883}
-
Javier Ernesto Flores Robles authored
This reverts commit 5afd5ef8. MDC roll broke feedback for iOS 10. Bug: 873293 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9e181f4bbbec7726d0370b95bd17d4fadca89377 TBR: pkl@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174256Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582882}
-
Friedrich Horschig authored
Before this CL, the accessory bar wouldn't add impressions to delayed appearing actions. This CL ensures this is done once (per new set of actions) while keeping the constraint that every bar impression happens exactly once. Bug: 873143 Change-Id: I4de6c8f8e95321176d9bca19459d6e9d2cdae746 Reviewed-on: https://chromium-review.googlesource.com/1171227 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#582881}
-
Alex Loiko authored
This CL adds flags and Finch features for a new WebRTC feature. It also applies the flag settings to WebRTC Audio Processing. Bug: chromium:873650 webrtc:7494 Change-Id: If2062aaf4f8bf48e26742b2841187f02221141ff Reviewed-on: https://chromium-review.googlesource.com/1172438 Commit-Queue: Alex Loiko <aleloi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582880}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 04226262. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22700 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibc1fdb53ea79ae7f8809f0b21c26ab4e49e97ad6 Reviewed-on: https://chromium-review.googlesource.com/1174099 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582879}
-
Uladzimir Miniailau authored
This CL isolates code for parsing LookupAffiliationResponse into lookup_affiliation_response_parser.*, and adds a fuzzer for it. Bug: 834707 Change-Id: If269a3603a0b84891491955ec0a99ad8506e0fc7 Reviewed-on: https://chromium-review.googlesource.com/1131185 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582878}
-
Daniel Cheng authored
- Use the helpers in histogram_functions.h instead of using custom versions. - Use kMaxValue version of UMA_HISTOGRAM_ENUM in one more place - Return const char* for enum stringification helpers to reduce number of temporary strings. - Use StrCat() to build dynamic histogram names to reduce number of temporary strings. Bug: none Change-Id: I720d11ad16c245f3ea59d55c2b75af8914eea7e8 Reviewed-on: https://chromium-review.googlesource.com/1174014 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582877}
-
Hayato Ito authored
Add links to some useful pictures to understand how DOM works. This CL doesn't add pictures in the repository. At this point, pictures are served from a web site which hayato@chromium.org ownes. TBR=rakina Bug: 742715 Change-Id: Ic48854b4cc37fe4aca55bd2142ff4cbc26af823f Reviewed-on: https://chromium-review.googlesource.com/1174293Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582876}
-
Maksim Sisov authored
$ git log --oneline 3cb5bbacc5c8a79105c868875222696f6b9d8296...ff1ecaf1014df4cb9ca36c5a270647a9934aaa99 ff1ecaf minigbm: fixup! align minigbm functions names with upstream libgbm 79205a5 minigbm: align minigbm functions names with upstream libgbm faeb009 minigbm: Opening new fd for dri backend a047d41 minigbm: increment ref count in drv_bo_import dc8554f minigbm: amdgpu: align the stride to 256 1805a9b msm: allow allocation of NV12 dumb buffers dea0ccb minigbm: Add BO_USE_HW_VIDEO_DECODER to supported flags a8a3895 minigbm: close bo handle in bo destroy 293d9e3 minigbm: DRM_FORMAT_BGR888 for amdgpu 9924776 minigbm: Build fix for arm64 abe44f6 minigbm: add support for BG24 6bd7885 minigbm: run clang-format Bug: 820047, 869206 Change-Id: I512b35c7821fd3221a97592006de5279b414dd01 Reviewed-on: https://chromium-review.googlesource.com/1169821 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582875}
-