- 07 Jan, 2021 40 commits
-
-
Stepan Khapugin authored
This flag will guard a new implementation of OmniboxTextFieldIOS Bug: None Change-Id: I305e0d980287950595fd591e8dc71be34f141b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611244 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#841020}
-
Jasmine Chen authored
This addresses a subtle race condition in CameraModuleCallbacks::SetCallbacks(). The key sequence of events, 1. CameraHalClient receives a pending remote of CameraModule 2. CameraHalClient calls CameraModule::GetNumberOfCameras() 3. CameraHalClient calls CameraModule::SetCallbacks() to pass a pending remote of CameraModuleCallbacks. 4. CameraModule receiver would fire CameraModuleCallbacks::CameraDeviceStatusChange() 5. CameraModule receiver then fires CameraModule::SetCallbacksCallback The expectation was that 4 would be received before 5. However, since CameraModule and CameraModuleCallbacks run on different message pipes, 4 can actually be received after 5, not meeting the expectation. So here we make CameraModuleCallbacks an associated interface of CameraModule. Please see crrev.com/c/2434712 for the implementation on CameraModule. Bug: b/169324225 Test: With the following, 1. Open Chrome Camera App (CCA) 2. restart cros-camera 3. Verify CameraDeviceStatusChange is received before SetCallbacksCallback 4. Repeat and passes 20/20 times. Additionally, 1. Build capture_unittests and scp to DUT 2. tast run dut 'camera.CaptureUnittests' Change-Id: I79f6006b7827d2e556b01e7d57df43916ca7913e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470898Reviewed-by:Wei Lee <wtlee@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841019}
-
Eugene Zemtsov authored
1. Readback for textured frames in blink::VideoEncoder 2. Media foundation encoder can now handle NV12 frames Test: https://kstreeter.github.io/wctranscode/ Bug: 1158665 Change-Id: Ie5865736eeee22f91bcf161f82a687c03679f912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598058 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841018}
-
Alex Ilin authored
This reverts commit 387260f4. Reason for revert: StartSurfaceTest#testShow_SingleAsHomepage_BackButton__Instant_Return is failing on builder "test-o-phone", see https://crbug.com/1163874 Original change's description: > [Start] Don't auto delete a tab selected from the tab switcher. > > In this CL, we introduce a new flag "keepTab" for a Tab with launch type > FROM_START_SURFACE. When this kind of Tab is selected from the carousel > Tab switcher on the Start surface, or from grid tab switcher, the > "keepTab" is set to be true. This guarantees the tab won't be auto > deleted from the TabModel when the back button is tapped. > > More details see doc: > https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit# > > Bug: 1155139 > Change-Id: Ib1e2ce917b0396bbd147ada2ebfc470cffd4718a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585822 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840737} TBR=dtrainor@chromium.org,hanxi@chromium.org,wychen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id3a59cff24aa7568b8d6866877731e8979ffeaae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155139, 1163874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612897Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841017}
-
Mattias Nissler authored
Chrome OS stores feature flags (in the chrome://flags sense) in signed device settings so they can be applied to the login screen environment. With this change, the code that writes to device settings no longer stores raw switch values but feature flag names. BUG=chromium:1073940 TEST=New unit tests Change-Id: I97033aa72941ba31ee950948ff1e235ccc9692e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287290 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841016}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4379.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4380.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icb366ab4a1c674dfa25ba555085bb20e8aaf7f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841015}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/24a9cfc3d443..468417610753 2021-01-07 changhaohan@chromium.org Fix angle popover early hiding and shift-click behavior If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2613e51d5ff66359c2635b291104b480280d4368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614465Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of e8136dba with updating the initial value for |cancel| in PrintRenderFrameHelper::CheckForCancel() to false as it could be called after |preview_ui_| is closed. This change also includes cleaning up printing_message_filter.{cc,h} since all messages in PrintingMessageFilter has been converted to mojo interfaces. Original change's description: > [printing] Mojofy PrintHostMsg_CheckForCancel > > This CL replaces the PrintHostMsg_CheckForCancel IPC message > with a new CheckForCancel Mojo method in the PrintPreviewUI > interface. > > Bug: 1008939 > Change-Id: Ic694b892744387bfc0c4c1232ed4b6a9cb1b6388 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212181 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771581}> Change-Id: Ie8a9e8c7ae6e5c74616964a485fc2ec0496160a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596667 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841013}
-
Tsuyoshi Horo authored
Bug: 1150458 Change-Id: Id2720551fcfab68ea9ef9be8f97210fef89ed7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612869Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841012}
-
Olivier Robin authored
If the result is a valid URL with a not HTTP(s) scheme, add quotes so it triggers a search instead of a load. Bug: 1153445 Change-Id: I5d9d79feafc6d2df756da5a9d35c434ce22393f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611735 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841011}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4379.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4380.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ieb721438cf50fc972d0f48b5b9de996477ee149f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614567Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccaf6dbd5c6e..5ff758df67da 2021-01-07 primiano@google.com Win port: Build {Thread,Test}TaskRunner on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: I55439b842c72eaf615702c0105004571d8e5364a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614185Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a clang tool to rewrite deprecated base::StringPiece APIs. To do so, it makes use Clang Transformer [1], significantly reducing the required boilerplate. For now, it only removes usages of the `as_string()` API, replacing it with explicit std::string constructions or omitting it entirely, if possible. The edits generated by the tool compile cleanly, except when used in complicated macro expressions. In these cases commas might not be enclosed in parentheses correctly. While it'd be possible to modify the tool to handle these cases properly, the required effort likely outweighs a small manual pass over the result to fix these issues. [1] http://lists.llvm.org/pipermail/cfe-dev/2018-November/060184.html Bug: 1049498 Change-Id: I77a0945d6cb59bde6f2ad65f079a399f67bbd054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601742 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#841008}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..ccaf6dbd5c6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idd3f9add0888eb646b61ef4419fea11a8e46572f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613651Reviewed-by:
-
Mirko Bonadei authored
This reverts commit 7c0169de. Reason for revert: Temporary revert to let https://chromium-review.googlesource.com/c/chromium/src/+/2612384 land before the -Wsometimes-uninitialized is addressed upstream. Original change's description: > Enable usrsctp runtime checks. > > The usrsctp library has a mechanism to enforce invariants (similar to > CHECK or RTC_CHECK). In order to enable these checks, the macro > INVARIANTS needs to be defined on all the usrsctp translation units. > > Maybe, this macro should be renamed into USRSCTP_ENABLE_CHECKS or at > least into something with USRSCTP_ as prefix. > > This CL enables these runtime checks in debug builds and when the > build is explicitly asking for them (dcheck_always_on=true). > > Bug: None > Change-Id: Id63d78200ae2a762b86a4dc0c70d1a04e7d94350 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600903 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840138} TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: Ifd63fad568cfdad45fe5330948e1fb616ba1c5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614406Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841006}
-
Kuo Jen Wei authored
Fixed by waiting for |requestVideoFrameCallback()| returned before draw video onto canvas. Bug: b/172214187 Test: tast run "camera.CCAUI*" Change-Id: I7352a58f08d36cc2c2459af06883ae124ad7ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611148 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#841005}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/5f87855f34ce..c493c6112021 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 7b7a21c4058c to 234c65c0f32c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I759411c63f039524403d40f36e23fb318027759b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613313Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609988385-4b9eeae9cba8aed26e55c5712ae60d144fa0441b.profdata to chrome-win32-master-1609999114-48d6c013bfb0cf3d871ee24efc89ddcdc4d51629.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib5d9852a90e59aa2d33b38f0e057adae5f496c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613311Reviewed-by:
-
Ulan Degenbaev authored
The result of a memory measurement now: - includes an empty breakdown entry. - has random order of breakdown entryies. Bug: chromium:1085129 Change-Id: Ie3f338d8274a0276d09f732560ed9797f5c376af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607339 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#841002}
-
Oleg Davydov authored
This commit moves expire date of the following histogram: * Extensions.ExtensionCacheCount * Extensions.ExtensionCacheSize The expire date is now in sync with other histograms owned by our team (Extensions.Force*). Bug: 1160813 Change-Id: I172aecec7dc32a0b651ccc99c54e212e386145dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607311Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#841001}
-
Andre Le authored
The regression bug below was caused by crrev/c/2108573, where we mistakenly setting border twice in message view (one in OnThemeChanged() and one in SetIsNested()). We don't need to set border in OnThemeChanged() if we have done so in SetIsNested(), so this CL remove that function call. Fixed: 1073561 Change-Id: Iaa74b630e0b4d9d2bac7ac9f0c5edf182b1eb89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606266Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#841000}
-
Ewann authored
This CL replaces the existing system colours by Google material colours. Bug: 1155472 Change-Id: Ia9c9e8f31d65fe1db70fd29ad94ca370d0aede07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595050Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#840999}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. This change is split into multiple CLs. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. Bug: b:168097163 Change-Id: I73c4bc11c1a18bcbadf73bcc611a28cf880517bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593266 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840998}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2ab1a92dbfba32901c74e56a62a3dd591a773e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614033Reviewed-by:
-
Jan Krcal authored
This CL updates the name of the feature that gates signed-in profile creation. Previously, it included multiple features but now it only gates this one so the new name makes better sense. Bug: 1126913 Change-Id: Ib2dba73093560378026b9eba9539f15b0cce5c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604920 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
David Roger authored
This CL changes the way DiceInterceptedSessionStartupHelper adds the account on the web. Previously it was mostly waiting for the reconcilor to trigger, and making sure that the process is not stuck (by forcing calls to list accounts). The new behavior is more proactive: when the profile is new, it blocks the reconcilor and forces a call to multilogin directly. The advantages are: - it is easier to control and hopefully it should be less brittle. - it should be faster: * the previous flow was doing an extra /ListAccounts call after the reconciliation, which is now removed * the previous flow was using MergeSession while the new flow uses multilogin, which should be faster on desktop (no need to fetch an access token) When the profile is not new, it's not possible to simply use multilogin, as there may already be accounts in the profile. The reconcilor is still used in this case, as it has the logic to handle this. Note: it would be possible to use MergeSession instead of Multilogin, as this would work for all profiles (including existing profiles). However MergeSession is now discouraged and thus we avoid adding a new usage here. This CL also improves histograms. Bug: 1151313 Change-Id: I9e0f6034abd845047226a3b592ce9a1dabf0c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600909 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by: -
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. This change is split into multiple CLs. Most of usages of update URL are handled here, others will be handled in follow-ups. Bug: b:175766994 Change-Id: I978347906907dfe864fd70649c41cb1c1c5c5322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593260 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Egor Pasko authored
Restrict Linker functionality to be "package private", do not expose the whole Linker API to clients. Reduce verbosity in code comments about the Linker, and reformulate them in terms of RELRO producer/consumer, rather than process type. This way the App Zygote can become the RELRO producer without contradicting all these explanations. Remove ChromiumLinkerParams. Previously I thought that in the new protocol it would expand, but now I realized that it is better to extend the messages that happen later in Linker lifetime. Extract the bundle exchange between linkers in different processes into LibraryLoader's inner class. This looks cleaner because it makes the communication protocol handled in one compact place. Before this change it was nontrivial to verify that communication is not racy. The plan is to add functionality to the MultiProcessMessageHandler to make it possible to sometimes move the RELRO FD from isolated processes into the browser process, without leaking a lot of knowledge about it outside of the package o.c.b.library_loader. With this change the MultiProcessMessageHandler will make sense to move to another file. Bug: 1154224 Change-Id: I2c027961530947a93bca44ce70b8b9dcd25e1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607931 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#840993}
-
Fergal Daly authored
This replaces render_frame_created_ and was_render_frame_ever_created_. We should also be able to get rid of must_be_replaced in a follow-up. Bug: 1163815 Change-Id: Ib8f20e4b98b1ceeb268149e219e247691859da66 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599784 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840992}
-
Francois Beaufort authored
This CL removes services/device code of the Web NFC API to reduce binary size of the Desktop build. Bug: 520391 Change-Id: I63cd742e8a185acd755354664d27348fd5bf17c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595421Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#840991}
-
Alice Wang authored
This CL moves ccountPickerDialogFragment to signin.ui target. Bug: 1159804 Change-Id: I887a245b7eca166de19c76a7c87c709de3239a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608833 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#840990}
-
Stephen Chenney authored
Bug: 916825 Change-Id: I2235cc1331deb857a69bc15938c16551727f4ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610685 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#840989}
-
Taylor Brandstetter authored
Commit log: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2c26785bed47 Bug: chromium:1163228 Change-Id: Ic5f5783afd359036e154e1f08da60a75afebb5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613956Reviewed-by:
-
Anastasiia N authored
Extend OAuth2Login.SessionRestoreTimeTo* and OAuth2Login.PostMergeVerification/PreMergeVerification histograms. Bug: 1144817, 1138295 Change-Id: Id22d47526780d7d7afeea1cc57e782d8358c9b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601359Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#840987}
-
Ramin Halavati authored
Create and use an ephemeral Guest profile if user has chosen Guest option in signin intercept. Bug: 1157764 Change-Id: I9d00b7c06897bcb0ebfd35c36289502acab6ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611955Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I53681c35b7c7cb37ddc924cb5e9e2b51844f60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614405Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840985}
-
Sami Kyostila authored
If the last delayed task in a queue is cancelled and swept away, we ended up comparing an invalid iterator with the end of the queue. Depending on where the new end of the queue ends up being, this can cause us to try to cancel an invalid task, potentially triggering a crash. Bug: 1155905 Change-Id: I9df4a2802dbaf3da733f8bde72f394b8fe0b7fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612970 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#840984}
-
Daniel Cheng authored
When a window proxy is initialized for a child frame, it must be reinitialized on every subsequent navigation to correctly hook up the window proxy (which may have cached JS references). Previously, this was only happening for the main world window proxy. One visible side effect is that if an extension cached a window proxy reference to a frame that was then navigated, the cached reference would not work until something else forced the window proxy to be reinitialized. Fixing this has an unintended side effect in an inspector protocol test which logs context creation: since isolated world window proxies are reinitialized in an arbitrary order (specifically, HashMap iteration order), the expected results become arbitrary as well. Instead of hoping that iteration order remains consistent, update the test to only log the context creation events it actually cares about. Change-Id: I11d7e13f7c2810d1c662ccf40f37c880e5026db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607680 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840983}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..ccaf6dbd5c6e 2021-01-06 primiano@google.com Win port: add base::getopt_compat If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Test: Test: perfetto_unittests --gtest_filter=GetOpt* Change-Id: I1d31283c15d4a1670648e89f2dee3e78d06db3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614275Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_ScriptedPrint message to ScriptedPrint() in mojom::PrintManagerHost. While this sync message is handled, PrinterQuery::GetSettings() triggers the print setting dialog box. If users don't have any action on the dialog it could cause the unresponsive dialog. So, it uses SetBlocked() to ignore the unresponsive dialog. Bug: 1008939 Change-Id: I9aa91e55479befc6917fb3006871ed89e5209ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569167Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
