GitLab

This CL adds the equivalent to element-timing/multiple-redirects for
LargestContentfulPaint. Since we use get-host-info instead of the .sub
commands, the .sub in the name is unneeded. This CL also updates the
expectations for disabled-OOR-CORS: the recent TAO tests will fail
without this flag enabled.

Bug: 1003943, 1042580
Change-Id: Ibc0b79d4c548fdbe9dc3eab6bd810f5a92425b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010176Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733408}

https://android.googlesource.com/platform/external/perfetto.git/+log/5d3c6c53932a..b6cc6e6bb8d3

git log 5d3c6c53932a..b6cc6e6bb8d3 --date=short --first-parent --format='%ad %ae %s'
2020-01-20 buss@google.com Fix compilation on Windows/VSC.

Created with:
  gclient setdep -r src/third_party/perfetto@b6cc6e6bb8d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I02906d529a2e57da2cd6f6865e0b3ad8461803f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008266Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733407}

Bug: none
Change-Id: I17614a11b718a226bf00591596f378a4a3d44575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007638
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733406}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfd2711e575d..24def43af03b


Created with:
  gclient setdep -r src-internal@24def43af03b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I29863f350c033be18903ccd8c3c03b65053f0502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008262Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733405}

The issue in this crash is that we compute the viewport registration and
the scrolls_inner_viewport|scrolls_outer_viewport bits separately, even
though they mean the same thing. However, in some cases they end up
not matching which leads to violating invariants in the compositor.

In some (I believe transient) cases, [1] will not have a
GlobalRootScroller so we don't have an outer viewport. Because of that,
we also avoid registering an inner viewport. This both-or-neither
viewport registration was added in https://crrev.com/c/1955860 to
simplify viewport existence.

However, setting the |scrolls_inner_viewport| bit on the ScrollNode
happens earlier, during pre-paint[2] at which point we don't yet know
whether the outer viewport will be registered. This means we end up in a
situation in the compositor where InnerViewportScrollNode() returns
nullptr (because it comes from the ViewportPropertyIds) but there exists
a node in the ScrollTree where |scrolls_inner_viewport| is true. The
crash happens because we assume that if we're looking at a node that
has this bit set to true, we must also have an outer viewport and so we
crash dereferencing OuterViewportScrollNode.

Ideally, we wouldn't need to duplicate this information but we don't
want to do a ScrollTree walk each time we want to get one of the
viewport nodes. So we need the ViewportPropertyIds registration. I've
considered removing the |scrolls_x_viewport| bits altogether,
compositor code can always do something like:

  scroll_node == InnerViewportScrollNode()

But there's a handful of cases inside property_trees.cc that check these
bits and they don't have access to the ViewportPropertyIds. We could
pass those down but that seems awkward.

This CL changes it so that we set these bits based on the nodes we
register to the ViewportPropertyIds. The information is duplicated but
at least it comes from the same source. This also means we don't need
the bit on the blink-side paint property node so the bit is removed
there.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/frame/local_frame_view.cc;l=2813;drc=e085cd7f91fd90b436565329510b738afb436b19
[2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/frame/visual_viewport.cc;l=218;drc=4045478f9a1db6872c1527a8e725bb79ae90f5ce

Bug: 1037759
Change-Id: I1dc06d9c6541b4afcd351841e8e7544ec11e3eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006610
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733404}

Register them in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I3dcf06de160044cc0abd423ede2738ef212b21de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005368
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733403}

sheriff: disable http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html

Test is flaky.

TBR=kenrb@chromium.org

Bug: 1043357
Change-Id: I646f8f1a1391bac4e323462f8729a255244c5fa9
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010182Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733402}

For non surface control case. SkiaOutputDeviceGL is used. Without
CommitOverlayPlanes support, we will always redraw the whole frame even
if chrome is playing video fullscreen. This CL add CommitOverlayPlanes
for SkiaOutputDeviceGL. It should save power for fullscreen video
playback case.

Bug: 1043667
Change-Id: I4924f039b935ed61ff20535c6652993582bffdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010173Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733401}

As per comments in:
https://chromium-review.googlesource.com/c/chromium/src/+/2001359/5/components/signin/core/browser/account_reconcilor.cc#452

There is a scenario where the reconcilor can be broken:
if EnableReconcile is called as the reconcilor is already running, the
state will be set to SCHEDULED, but is_reconcile_started_ remains true.
From there the reconcilor is in inconsistent state, and triggers a
DCHECK in FinishReconcileWithMultiloginEndpoint:
DCHECK_EQ(AccountReconcilorState::ACCOUNT_RECONCILOR_RUNNING, state_);

Change-Id: I4f7436f94b87b5e34b11b856d0b55bd880813877
Fixed: 1043651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010795
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733400}

This will allow disabling event dispatching altogether in cases where we
can reliably do that (SVGImage). It may also help with not sending
events when seeking the timeline.

Bug: 1021630, 1039886
Change-Id: I82e7b453b3b6abb1d71d064c33c89db7657c8b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007572Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#733399}

The corresponding feature flag was already removed from the application
a while back. This CL removes it from flag-metadata.json as well.

Bug: NONE
Change-Id: I6929e19c4c61445b03458b80c3e44ff2e18da068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010772
Auto-Submit: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733398}

GpuProcessHostDisableGLBrowserTest.CreateAndDestroy wants to use software
compositing, not the hardware path. The vulkan_content_browsertests were
enforcing that software fallback not be allowed. Causing this test to crash.

However BrowserTestBase::UseSoftwareCompositing already is in use by tests which
wish to explicitly be software compositing only. I'm adding this to the setup
of the test to allow it to run in the vulkan_content_browsertests suite.

TEST=vulkan_content_browsertests
GpuProcessHostDisableGLBrowserTest.CreateAndDestroy

Bug: 1009664
Change-Id: I85f00e2e3a4bf710d946ac69d46bd3e0e0879233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003251Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733397}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1042208
Change-Id: If065e4216e783e5356f4014696d2ebc853208f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007726
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733396}

In the User Timing spec, it is an error to make a PerformanceMark with
the same name as a read-only attribute from the PerformanceTiming
interface[1]. E.g. it is an error to call
`performance.mark("navigationStart")` as this would lead to ambiguity
when trying to resolve calls like
`performance.measure("m", "navigationStart")`.

Since the read-only attributes are defined on the PerformanceTiming
interface[2], it makes more sense to declare a name/attribute mapping
locally instead of in the PerformanceUserTiming class.

[1]: https://w3c.github.io/user-timing/#the-performancemark-constructor
[2]: https://www.w3.org/TR/navigation-timing/#sec-navigation-timing-interface

Bug: 805566
Change-Id: I2466d123a0d93965555c06d2434cb839fafabb72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967567
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733395}

Currently, we are sorting animations by creation order. This update the
animation compositing order to first sort by animation class
priority, as per spec
(https://drafts.csswg.org/web-animations/#dom-document-getanimations).

This inter-element composition order is used and tested by
getAnimations.

Bug: 993365
Change-Id: I30dd1c504165baa1120b73ab7e18f0b775df8bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993677
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733394}

The function signature is no longer different so just use SwapBuffers().

Bug: none
Change-Id: I7f244b3dddafd95eb3e534df3cf9e639b3aff5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008055Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733393}

Test is failing on the Mac10.13 Tests builder

See
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16844
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16843
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16842

TBR=dbeam@chromium.org

Bug: 1043665
Change-Id: If938bea126e7607e9c74787bac567cac04658c0b
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010178Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733392}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=olivierrobin@chromium.org

Bug: 1042208
Change-Id: I15d44cfb7e142a9c7fc41373d454ee997c7ed6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010784
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733391}

MainController observes WSL to know when the last {normal|incognito}
tab is closed. Conceptually, this seems like a Scene-level concern.
However, clearing browsing data might be an App-level concept, so I
keep the logic in MainController for now.

Bug: none
Change-Id: I0b3453518f4f0390a34f77ce27817f4af1f4d650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003135
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733390}

Change-Id: I6a91ea0021077507e968ce2be0adde5588118d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010169Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733389}

This reverts commit 53513b6a.

Reason for revert: Use the wrong path.

Original change's description:
> [ios] Allow use of chrome_browser_provider_forward.h from provider
> 
> The provider are not permitted to have dependency on //ios/chrome,
> however they were able to forward-declare ChromeBrowserProvider so
> they ended up with indirect dependency.
> 
> To allow moving the class to the global namespace, allow them to
> include the forwarding header since this does not increase the
> amount of "bad" dependency.
> 
> Bug: 1042208, 1043657
> Change-Id: I838167daa14f16ab65983fd3ebf61267f1a9eedd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010796
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733375}

TBR=marq@chromium.org,sdefresne@chromium.org

Change-Id: Iaa7ff98d55ac57fefb448ff0b9ed246cb2495069
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042208, 1043657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010864Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733388}

https://skia.googlesource.com/skia.git/+log/3322aafc36d4..ef05567733eb

git log 3322aafc36d4..ef05567733eb --date=short --first-parent --format='%ad %ae %s'
2020-01-20 bsalomon@google.com Don't pass final W/H to convolve_gaussian() in SkGpuBlurUtils.

Created with:
  gclient setdep -r src/third_party/skia@ef05567733eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: Ib1da9b3954a6d2a8ccd84096ca3f80a5b71c6de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008260Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733387}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c33c078292af..53ad544d73bc

git log c33c078292af..53ad544d73bc --date=short --first-parent --format='%ad %ae %s'
2020-01-18 cjmcdonald@chromium.org Add SDK/Unmount endpoint
2020-01-18 bpastene@chromium.org Revert "chrome_chromeos_lkgm: Skip betty & betty-pi-arc when updating the LKGM."
2020-01-17 yueherngl@google.com servo: remove 11011.B firmware branch builder
2020-01-17 lamontjones@chromium.org toolchain_util: allow editing unquoted strings
2020-01-17 cjmcdonald@chromium.org Build API: Add logic to handle toolchain changes
2020-01-17 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-17 yueherngl@google.com servo: tie the build to nautlius instead of octopus

Created with:
  gclient setdep -r src/third_party/chromite@53ad544d73bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: Ia8b1dafc2da5d89657d3752d26b82e699dd0d9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008259Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733386}

When running the GPU process, we use dependency injection to customize
its behaviour through the ExternalDependencies struct. VizMainImpl's
constructor takes an ExternalDependencies parameter and std::moves it to
a member field. Some of the code, however, continued to reference the
parameter instead of the field. This lead to the code assuming that some
dependencies were stubbed out.

This CL updates VizMainImpl's constructor to consistently check the
member field for the injected values and adds tests to check that some
injected values end up in use.

Bug: 1040583
Change-Id: If1c7922f4c7286c2a73afd33572b287ad29f64ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992701Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733385}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=marq@chromium.org

Bug: 1042208
Change-Id: I0c71b5c3173df9e89d8f616f2d02a844c99880c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007760
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733384}

Test is failing with timeout.

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33950
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33949

Bug: 1043661
TBR=achuith

TBR'ing achuith since he seems to have context.

Change-Id: I8a40f54f62398b1e08544b00b5c57888d28b36db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010171Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733383}

https://webrtc.googlesource.com/src.git/+log/f5c1f79a282d..9fbe9ae1c109

git log f5c1f79a282d..9fbe9ae1c109 --date=short --first-parent --format='%ad %ae %s'
2020-01-20 titovartem@google.com Add support of negotiating multiple codecs in PC framework
2020-01-20 danilchap@webrtc.org Rewrite RTC_CHECK macros to work in constexpr expression in gcc
2020-01-20 danilchap@webrtc.org Merge RtpPacket HasExtension and IsExtensionReserved functions

Created with:
  gclient setdep -r src/third_party/webrtc@9fbe9ae1c109

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: If89edc197fc679efe85a50f95a5079434b1c6dff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008256Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733382}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/07344a40..b56d35e2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia499a637a920d32b7846ca0bbbf896bb3201c22f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010923Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733381}

This patch eventually cancels the change in
https://crrev.com/c/1989232 because the web_idl/ and bind_gen/
directories have already been following PEP8.

Bug: 839389
Change-Id: I6730f41e632f786e1bba6adc20ddc105d43860b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010752Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733380}

Bug: 1043148
Change-Id: I0789a40948bf74123ce50685726034d11ceedbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007764Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733379}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug: 1042208
Change-Id: I5fbed15d8a69cf472a24dcf0f855f617b0b9f62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007814
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733378}

We recently re-enabled a set of tests we believed were fixed:
https://chromium-review.googlesource.com/c/chromium/src/+/2006132

However the media/ tests we enabled apparently still flake, but only
on Windows. This patch re-adds them to the flag expectations.

TBR=backer@chromium.org
TEST=skia_renderer_gl_blink_web_tests
Bug: 1026375

Change-Id: I141b6c75a7515f178d8c092c29705d99eb79697a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008255Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733377}

posixpath.abspath("d:\\a\\b") doesn't work because posixpath
doesn't recognize a drive letter.  This patch fixes the issue.

Bug: 839389
Change-Id: Ifef644dd1e9b26e6a4e572f485e7cbabf7148871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010751
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733376}

The provider are not permitted to have dependency on //ios/chrome,
however they were able to forward-declare ChromeBrowserProvider so
they ended up with indirect dependency.

To allow moving the class to the global namespace, allow them to
include the forwarding header since this does not increase the
amount of "bad" dependency.

Bug: 1042208, 1043657
Change-Id: I838167daa14f16ab65983fd3ebf61267f1a9eedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010796
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733375}

Using wpt-import in Chromium e2347e02.
With Chromium commits locally applied on WPT:
8a985066 "[Trusted Types] Implement require-trusted-types-for"
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"
2012a39c "Update timeout and split slow COOP WPTs"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I4b19d6c728fffde0ce696b8b011104f009c6f547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010922Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733374}

- Adds V8DOMConfiguration::InstallMethods
- Fixes/adds bindings::V8SetReturnValue
- Adds ToImpl/ToImplWithTypeCheck and DomTemplate for backward
  compatibility
- Adds check of argument length
- Adds member variable definitions of trampoline functions

Bug: 839389
Change-Id: Id15984167f876279fe498631fc83aadf4cdd3040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010593Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733373}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=marq@chromium.org

Bug: 1042208
Change-Id: I1349bdd47e3b14b023bf292539822cb22a37a0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007287
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733372}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=noyau@chromium.org

Bug: 1042208
Change-Id: Iebe7231c7edbd4508ea1b9bd34c08c5f9c1a89eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007583
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733371}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ec654fdcab5..85de0bc72ef7

git log 7ec654fdcab5..85de0bc72ef7 --date=short --first-parent --format='%ad %ae %s'
2020-01-20 tvanderlippe@chromium.org Fix typescript compilation with ts_library
2020-01-20 aerotwist@chromium.org Adds Puppeteer types
2020-01-20 bmeurer@chromium.org Roll upstream changes.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@85de0bc72ef7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iad3451ad495ca0f936aff89111ff80083e0f1008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008257Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733370}

This change removes the Password Leak Detection base::Feature and
feature flag. The feature has been launched in M79 and is completely
rolled out, which is why it is safe to remove this code now.

Bug: 986298
Change-Id: If1f07423e7ef3a55415c6849340b178bc6affdca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007757Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733369}