- 19 Jul, 2017 40 commits
-
-
Vladislav Kaznacheev authored
The new FastInkView class contains everything required for low-latency rendering of pointer-like objects. Bug: 743083 Change-Id: I0d31451899078875acd906396dda945bb45f2189 Reviewed-on: https://chromium-review.googlesource.com/576389 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488020}
-
Mark Pearson authored
Bug: Change-Id: Icfe1de44e197f16ba90b7e81d09036ad97a56dd8 Reviewed-on: https://chromium-review.googlesource.com/578427 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#488019}
-
David Bokan authored
This patch removes the --enable-inert-visual-viewport flag from Chrome. This does *not* remove the inertVisualViewport setting from Blink. This feature is currently on by default but it was accidentally forced to the off state by the existence of the command line flag. By removing the flag, the Blink setting controls the status of this switch - which is currently set to on. Note: we're not losing anything as the feature is intended to be on by default and we didn't have a matching --disable-inert-visual-viewport flag so this flag would have been useless as of M61. This patch fixes some tests that were expecting the flag to be off and removes others that were explicitly testing behavior of the flag when disabled. I also added a new test to test the new flag-on behavior. This also exposed a bug in document.rootScroller, window's scrollX and scrollY properties reverted to returning the FrameView's rather than the rootScroller's scroll offset. This was caught by the set-root-scroller.html test, I've commented out the checks (rootScroller isn't yet shipped), and I'll fix the behavior in a followup patch. Bug: 740956 Change-Id: I249a34b4ee67dfbe8230e6bc3048871a6325e43d Reviewed-on: https://chromium-review.googlesource.com/575768Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488018}
-
Dale Curtis authored
While src= track change still suffer from http://crbug.com/709302, MSE based track changes work fine. This change enables both pausing and disable track for MSE content with a keyframe distance < 5s. The experiment data suggests that in the 95th percentile we might end up waiting ~980ms when disabling a track before the next video frame is shown. The 25th percentile is ~66ms, 50th is ~155ms, and 75th is ~325ms. For pausing, the percentiles results are ~10ms, ~32ms, ~116ms, and ~255ms. These compare favorably with control values. A later CL will cleanup chrome://flags and switches entries once we are confident in this release. Notably this has been launch approved since M58 and experiments have been running since then at 75% of dev, canary, beta. The discovery of issue 70302 blocked launch for all playbacks, so this pieces out the MSE portion which works properly. BUG=663999,703411 TEST=experiment data looks good. Change-Id: I07dfebb96d4a2c9147909bb7cdf96fa02469f801 Reviewed-on: https://chromium-review.googlesource.com/576488Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488017}
-
Marijn Kruisselbrink authored
In https://codereview.chromium.org/6231550869897216 the setter for these range attributes was removed. This finishes that cleanup and also removes the actual attributes and their use. Change-Id: I4b474be89358d2b3364016fd842933b39a557f94 Reviewed-on: https://chromium-review.googlesource.com/578129Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#488016}
-
Patrick Monette authored
Since https://chromium-review.googlesource.com/c/544717, it is not allowed to bind to an interface on a different thread than where it is used. To fix that, the binding is now only done on the IO thread. Bug: 662084 Change-Id: I4e361ae4853f2d0ace3d910e12bc32e0c9a80d5c Reviewed-on: https://chromium-review.googlesource.com/576618Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#488015}
-
jiajia.qin authored
The CL https://codereview.chromium.org/2791813003/ introduced two bugs 710673 and 710874. So currently, for format=GL_RED/GL_RED_INTEGER or type=GL_FLOAT, it will not go GPU-GPU path. But by investigating that CL, we still can go GPU-GPU path using CopySubTextureCHROMIUM instead of CopyTextureCHROMIUM like the earlier code did. Using copySubTextureCHROMIUM can bypass the potential bug in CopyTextureCHROMIUM in MacOS. But still need to figure out the reason. BUG=710673 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2896553003 Cr-Commit-Position: refs/heads/master@{#488014}
-
Tove Petersson authored
Bug: 743024 Change-Id: I50d581ed2e4c20ab9d222d897e407f0ef6606fb6 Reviewed-on: https://chromium-review.googlesource.com/570165Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#488013}
-
Kyle Horimoto authored
(1) The user would click "connect", then the dialog would close temporarily before reopening. The issue was as follows: When currentRouteChanged() was called, we would store whether the dialog should be shown and wait for the network to be updated with Tether properties (e.g., signal strength) before showing the dialog in networkPropertiesChanged_(). However, once a connection attempt started, we would receive an additional update on that network, resulting in networkPropertiesChanged_() being called again and the dialog being shown again by mistake. (2) The user would attempt a connection attempt, which would bring up the dialog. If the user clicked "not now" (closing the dialog), then clicked "connect" again (opening the dialog), then "not now" again (closing the dialog), the dialog would open again. The issue was that if the user opened the dialog from the network detail page, we create a new location on the back stack, then when we close the dialog, we would remove that item from the stack by navigating backward; the handling for this route change would cause the dialog to be opened again. (3) The connection dialog called private function onDialogCanceled_() when it was closed, but this function does not actually exist on the TetherConnectionDialog Polymer element (I believe that this function was part of an earlier version of this element that was eventually deleted). Since this handler function was unused, I removed it. Bug: 672263, 738501 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I396109a589956e616322ba8bc8b7e7867bf5ea66 Reviewed-on: https://chromium-review.googlesource.com/576116Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488012}
-
Yuwei Huang authored
This CL introduces an AppInitializer class for initializing the app differently in different builds before launching the app. Previously we had two different main.mm for the Chromium and internal build. It's a pain to keep them in sync and introduce some unnecessary dependencies (e.g. base:i18n and ui/base) to the internal build target. This is especially painful when I try to add initialization code for i18n stuff. This refactoring should help reducing redundant code and simplify the dependency map of the internal build a bit. This should be landed after internal CL: https://chromereviews.googleplex.com/595547013/ Bug: 746105 Change-Id: I4e80ef92cb3f9f68a0f811a6e9d749c36b06b145 Reviewed-on: https://chromium-review.googlesource.com/575260 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#488011}
-
Yuly Novikov authored
gtest started to shard in a different way when we switched from 7 Android devices to 1, so one of the 256 test batches started to intermittenly time out. BUG=670879 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b5594dac3f4269a8f8d03e6be715af968aa81ea Reviewed-on: https://chromium-review.googlesource.com/577918 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#488010}
-
Eric Roman authored
Change-Id: Ibb031940c31618f1ea15b6fd5c3e1269eec83b05 Reviewed-on: https://chromium-review.googlesource.com/576788 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488009}
-
sclittle authored
Revert of Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (patchset #13 id:240001 of https://codereview.chromium.org/2957043002/ ) Reason for revert: Broke compile on Linux ChromiumOS Builder (dbg), see https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29 Original issue's description: > Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. > > Renamed TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks. > > BUG=672263,735642 > > Review-Url: https://codereview.chromium.org/2957043002 > Cr-Commit-Position: refs/heads/master@{#487975} > Committed: https://chromium.googlesource.com/chromium/src/+/2257878a0dfb81bbbc37613752865983568580af TBR=khorimoto@chromium.org,jamescook@chromium.org,lesliewatkins@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672263,735642 Review-Url: https://codereview.chromium.org/2978363002 Cr-Commit-Position: refs/heads/master@{#488008}
-
Ryan Landay authored
Based on MultiWindowUtils#isInMultiWindowMode() (which is in org.chromium.chrome code, and therefore can't be used in the content layer), but with simpler implementation. We should probably update callers of MultiWindowUtils#isInMultiWindowMode() at some point to use this method instead and then remove that method. Bug: Change-Id: Ibb20fccf706368dd054541ce769855e1e24266ba Reviewed-on: https://chromium-review.googlesource.com/578390Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#488007}
-
Shimi Zhang authored
Use symbol.ARCH after we properly set it in stack_core.py. Bug: 746521 Change-Id: Ie3c44ea6b315b5a7ec3977655f135bfb2c0b0d6d Reviewed-on: https://chromium-review.googlesource.com/578238Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#488006}
-
Sergey Ulanov authored
Some low-hanging fruit in ui/base: 1. Updated BUILD.gn to add pak files to data_pack, so these files are accessible in the test VM. 2. Implemented ResourceBundle methods that were missing. Now all tests in ui_base_unittests pass except those that write test resource and /tmp (these fails because mmap() is broken on tmpfs). Bug: 740608 Change-Id: I7534c40eba38ffcf1e12673360863034f3a89864 Reviewed-on: https://chromium-review.googlesource.com/575123Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488005}
-
Tatsuhisa Yamaguchi authored
This change also includes a change to hide the context menu button added by https://chromium-review.googlesource.com/c/566768/ when the flag is set. Bug: 745879 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f1a75f55eab76e9ec3300a73820937357a37679 Reviewed-on: https://chromium-review.googlesource.com/574902 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488004}
-
Tim Song authored
Mocks can be found here: https://docs.google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI BUG=746046 Change-Id: If33b43a2352bfc22fcbd12d1702c674239d922b0 Reviewed-on: https://chromium-review.googlesource.com/576728 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488003}
-
Theresa Wellington authored
Splits #testNTPOverTabSwitcher_Incognito_FromTab into two different tests and re-enables. BUG=744710 Change-Id: I7c5a527fe3077219f285ac8521629d175c959c96 Reviewed-on: https://chromium-review.googlesource.com/578208Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#488002}
-
Anton Vayvod authored
HTMLMediaElement may destroy WebMediaPlayerImpl when handling disconnect from a remote device so WMPI shouldn't do anything after calls to |client_|. BUG=738677 TEST=follow the steps from the bug with the link from #c18 Change-Id: I59b299acc9740644bb046737419066734a870dc4 Reviewed-on: https://chromium-review.googlesource.com/576473Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#488001}
-
Donn Denman authored
Adds a new set of Ranker features to log via UKM for Contextual Search. The doc for these UKM CS V2 features is at go/ukm-cs-2. Also adds some simple tests that the expected features have actually been logged. BUG=740714 Change-Id: I23542702737e4d9de30e0bed6ba433663e8dac02 Reviewed-on: https://chromium-review.googlesource.com/572235 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#488000}
-
Fady Samuel authored
Now that FrameSinkManager and FrameSinkManagerImpl live in the same place and have the same namespace, it no longer makes sense for these two to be two separate classes. This CL merges the two and updates all call sites. This CL also simplifies SurfaceHittestTest a bit by moving FrameSinkManager into a custom test fixture that creates a FrameSinkManager on SetUp. Bug: 722935 Change-Id: I910c08d63320adca372063b579395e6d0f195d8e Reviewed-on: https://chromium-review.googlesource.com/576397 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487999}
-
Collin Baker authored
This feature flag will be used to enable and disable use of renovations. Design doc: https://docs.google.com/a/google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU Bug: 736933 Change-Id: I2808e734a8a60e7b7eb45efc85b51299500018f4 Reviewed-on: https://chromium-review.googlesource.com/572664 Commit-Queue: Collin Baker <collinbaker@google.com> Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#487998}
-
Eric Karl authored
We avoid stencil buffers on certain Intel GPUs with a known leak. From looking at UMA, it appears that this leak may apply even when the GPU isn't the active one (on a multi-GPU system). Expanding the workaround to handle this case as well. Bug: 713854 Change-Id: I880c83fcf78b617506b3f8816dedf13fe133b2c1 Reviewed-on: https://chromium-review.googlesource.com/578376Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#487997}
-
Matt Mueller authored
The variable is unused since https://chromium.googlesource.com/chromium/src/+/efe5baba2d156238707d6d8303b2055ddb246fe2 Bug: none Change-Id: I11901f5def30d0058f3c1cf10e1ba4e5be9f84d3 Reviewed-on: https://chromium-review.googlesource.com/576993Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#487996}
-
Fadi Meawad authored
Based on the discussion in the spec: https://github.com/WICG/device-ram/issues/6 there was a decision to rename the header to Device-Memory instead of Device-Ram, hence this CL Bug: chromium:718622 Change-Id: I5420af3aa5aa96ef913e88f1fee361c6a39eeace Reviewed-on: https://chromium-review.googlesource.com/578128Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487995}
-
Catherine Chung authored
This method deletes the instance and resets it to nullptr to avoid memory leaks in tests. Bug: 743049 Change-Id: Ib14253155c2282dd8c4cedcc9bc25f7389ae7a28 Reviewed-on: https://chromium-review.googlesource.com/571504Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Catherine Chung <catherinechung@google.com> Cr-Commit-Position: refs/heads/master@{#487994}
-
Lukasz Anforowicz authored
There are 4 subclasses of ChildThreadImpl: - RenderThreadImpl - PpapiThread - GpuChildThread - UtilityThreadImpl Before this CL, RenderThreadImpl and PpapiThread would have a |field_trial_syncer_| field. GpuChildThread would construct a ChildProcessFieldTrialSyncer via ChromeContentGpuClient::Initialize, but only if the GPU didn't share the browser process. UtilityThreadImpl did not have a |field_trial_syncer_| field. Before this CL, RenderThreadImpl and GpuChildThread would notify the browser process about trial activations by calling FieldTrialActivated method of mojom::FieldTrialRecorder. PpapiThread would notify via PpapiHostMsg_FieldTrialActivated legacy IPC. UtilityThreadImpl wouldn't do anything. After this CL, ChildProcessFieldTrialSyncer and base::FieldTrialList::Observer are encapsulated and hidden by ChildThreadImpl. Also - after this CL, the //content -> //components/variations dependency is sighly more restricted. Bug: 740726 Change-Id: I2fdf4e16f52a7339476e337f695b44e621d0b295 Reviewed-on: https://chromium-review.googlesource.com/567034 Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#487993}
-
Quinten Yearsley authored
Change-Id: I4c54ce01d990dc8b2d6a6ffdb46f0774157faa71 Reviewed-on: https://chromium-review.googlesource.com/577722Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#487992}
-
rdevlin.cronin authored
Right now, we determine whether to store the record of a lazy listener in the extension prefs based only on the type of context - if the context registering the listener is a lazy context (like an event page), then we store a lazy listener in extension prefs. This is incorrect for webview events. Webview events are exposed on a <webview> DOM object, but are implemented behind-the-scenes as extension events (including the listener bookkeeping). However, having a lazy listener for a webview event doesn't make sense: - the only time a listener would be considered lazy is when the listener was added in a lazy context - a lazy listener will only be used to wake up an inactive context - webview events are tied to a specific webview Thus, a lazy listener would only be used for a webview which has since been torn down. With this in mind, we can avoid registering any lazy listeners for webview-related events. Introduce the key supportsLazyListeners into the JSON schema and add it for webview events. When this key is present, events don't register lazy listeners. Wire this up for both native and JS-based bindings, and add unit tests for the bindings and an end-to-end test to ensure that webview event listeners will never be registered as lazy listeners. A followup will add logic to clean up current prefs to remove traces of the listeners. BUG=736381 Review-Url: https://codereview.chromium.org/2973903002 Cr-Commit-Position: refs/heads/master@{#487991}
-
Yixin Wang authored
Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"" This is a reland of 9c083706 Original change's description: > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" > > This is a reland of a66ebc8a > Original change's description: > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > BUG=705029 > > > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > > Reviewed-on: https://chromium-review.googlesource.com/562604 > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#486519} > > Bug: 705029 > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/571044 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487342} Bug: 705029 Change-Id: Iefb798a8c4d54263e5e8f47bc5d1c63c04d72f77 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/576349Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#487990}
-
Steve Kobes authored
For the first time, the flag expectations file now includes expectations for all platforms the CQ runs layout tests on (Linux, Mac, Win). This process was used: 1. Triggered CQ dry run with empty flag expectations file and RLS forced on in test runner (see patch set 1). 2. Saved {linux,mac,win}_chromium_rel_ng layout_test_results from new viewer in TestExpectations format, to local files named "Linux", "Mac", and "Win". 3. Ran this hacky Python script, piping stdout to the flag expectations file: https://pastebin.com/ikHTt5zf Bug: 711468 Change-Id: Iebe35ae4a637aaaae85bc9adba1d278bde80d381 Reviewed-on: https://chromium-review.googlesource.com/576353 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#487989}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d97f36..010a464 BUG=737384 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib297a22f55426153c816bf59fe6701a41ccef6a2 Reviewed-on: https://chromium-review.googlesource.com/578246Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Cr-Commit-Position: refs/heads/master@{#487988}
-
Steven Holte authored
Bug: 745939 Change-Id: Ic6c91f0409410256533c84e75c2b92c9390de2bf Reviewed-on: https://chromium-review.googlesource.com/576790 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#487987}
-
mbjorge authored
Revert of Add libc++ __tree to ubsan blacklist. (patchset #2 id:20001 of https://codereview.chromium.org/2109663003/ ) Reason for revert: Issued fixed upstream Original issue's description: > Add libc++ __tree to ubsan blacklist. > > libc++ __tree is not ubsan clean. It floods compile and run steps > with "runtime error: downcast" and "runtime error: upcast" errors, > making ubsan much less usable. > This is a KI with libc++: https://llvm.org/bugs/show_bug.cgi?id=19302 > > Committed: https://crrev.com/e2abe2366d707ac6ad308e2643f41423971f81fc > Cr-Commit-Position: refs/heads/master@{#402902} TBR=dpranke@chromium.org,ochang@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2983093003 Cr-Commit-Position: refs/heads/master@{#487986}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67c78739..b55b2e87 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ieb9dcea8393b4dc4c37c0f37722f8d8575567868 Reviewed-on: https://chromium-review.googlesource.com/577915Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487985}
-
dougt authored
BUG=703369 Review-Url: https://codereview.chromium.org/2981073002 Cr-Commit-Position: refs/heads/master@{#487984}
-
Tien-Ren Chen authored
This reverts commit a207e0dd. Reason for revert: Lint error in downstream code. Original change's description: > Android: Re-enable lint > > Android lint has been failing due to API level mismatch between lint and > platform-tools (26 vs 25). This is causing new lint errors to be > introduced. Ignore the API mismatch for now and re-enable lint so it at > least catches all other issues. > > API warning will be re-enabled after platform-tools is rolled. > > Bug: 739746,746409 > Change-Id: I339560498544462732300c5030381a0c67f25f1b > Reviewed-on: https://chromium-review.googlesource.com/577593 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487918} TBR=mthiesse@chromium.org,wnwen@chromium.org,agrieve@chromium.org Change-Id: I4857cf1ba5f10b009155693a803df922036f1878 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739746, 746409 Reviewed-on: https://chromium-review.googlesource.com/578059Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487983}
-
Mike Reed authored
In preparation for https://skia-review.googlesource.com/c/24644/8 NOTRY=True Bug: 746578 Change-Id: Ia5a59056598e6db62ca2417eaddc2a783d4625b4 Reviewed-on: https://chromium-review.googlesource.com/578487 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#487982}
-
Steven Bennetts authored
Bug: Change-Id: I5f05a943778b6a56abf5535cd0d2b43389ef733f Reviewed-on: https://chromium-review.googlesource.com/577723 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#487981}
-