- 11 Oct, 2019 40 commits
-
-
Jenny Wong authored
This reverts commit 776645cc. This CL was reverted because it caused on-device crash loops: base::CreateSequencedTaskRunner() would fail on a DCHECK because of lack of access to |g_thread_pool|. Now that the libcast_media_1.0_audio target is statically linked when possible, this is no longer an issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/1846314 Bug: internal b/135280530 Change-Id: Ib84ff58f17dec31abe3ba438a1a87a53763942af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848576Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Jenny Wong <jyw@google.com> Cr-Commit-Position: refs/heads/master@{#705213}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/af9c6ce85491..4d4275fc6a5d git log af9c6ce85491..4d4275fc6a5d --date=short --no-merges --format='%ad %ae %s' 2019-10-11 achuith@chromium.org flash: Prefer full_payload download. Created with: gclient setdep -r src/third_party/chromite@4d4275fc6a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic27275d31bd1c1e63b92441e56b5c96cc61ac33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705212}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within Chrome Notificatios, Push messaging, Sharing, and Autofill browser tests. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: I81ab8aa383c385c90980377842656c402d8dd2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850734Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705211}
-
Andrey Kosyakov authored
Bug: 1013000 Change-Id: I225064e4cdbeab4ed23588df8ec0154f00d6dd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851225 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#705210}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I556dc4abd7e9688782bdbaced5198d06561b8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705209}
-
Kristi Park authored
It's possible for width to be non-zero while the icon is hidden. In this case, we do want to grow the label starting from 0 width. Change-Id: I80d6d216aef5f5ec8d849fd844ce21e38079f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850966Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#705208}
-
Mathieu Binette authored
I updated the chromium bot configs to exclude Chrome-only tests in https://crrev.com/c/1838375, but the new category filter flags are not available in the CELab package we use in chromium/src, so this broke our bots. Oops. Updating the package will fix this. Notable changes since the last version: - Implement @category & filter arguments for EnterpriseTestCase: https://crrev.com/c/1823607 Bug: 1013507 Change-Id: I0aeee6021d25b2a3dd0f514f35821dd66069c4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856398Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#705207}
-
Piotr Bialecki authored
This CL brings in changes in mojo and browser needed to surface the subscription-based variant of the API to JavaScript. The explainer can be currently found in the following URL: https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md Changes related to floor height estimation are due to the fact that in order to implement hit test for local-floor reference spaces, the current height estimation needs to be known to ArCoreImpl. Additionally, if we ever decide to estimate the floor height more intelligently, it would have to be done in ArCoreImpl so it's one more reason to move floor height information there. Bug: 928481 Change-Id: I2d21bfa021c3a238455dd3489353233c5c848a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829942Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#705206}
-
Toby Huang authored
Site Settings page currently shows the enterprise "office" icon instead of the "kite" icon for supervised users. This CL fixes this and ensures that the kite icon and "This setting is managed by a parent." tooltip is shown in Site Settings when a supervised user is logged in. Bug: 1005547 Change-Id: I91d81337b3f1b5cd070163ecc032a1695592dc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838652 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705205}
-
Collin Baker authored
This moves Browser away from listening to for INVALIDATE_TYPE_AUDIO for audibility state changes. This is part of a refactor detailed in the attached bug. Bug: 846374 Change-Id: I09cd8395c16bba812e9417f2ca6364d43864d39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854214 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705204}
-
chrome://webapksdpapad authored
Use JS modules instead, since HTML Imports are being removed. Replace CallJavascriptFunction() with FireWebUIListener(), since within a JS module context, all variables/functions are private (unlike previous behavior of being global), and can't be called from the outside Bug: 937747 Test: Visit chrome://webapks, should no longer see HTML import warnings in DevTools. Change-Id: I4319d6b78a9a4c370a2f9152e7448e7c3325adf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850271 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705203}
-
Oystein Eftevaag authored
Tracing_controller_impl.cc/.h now uses the Consumer Mojo interface rather than the old Agent/Coordinator interface, allowing the latter to be deleted in the next CL. As part of this, the option to anonymize the data has to be moved from the TraceConfig struct to be an explicit argument to StopTracing instead, as the filtering/whitelisting done at JSON export time needs the full unfiltered proto data available. BUG=839086 Change-Id: Id73b73a1cdbc6c7a6c8d343c391136abc5914743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817207Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#705202}
-
Jacques Newman authored
Bug: 1012831 Change-Id: I40adeaa1c625ee45f21cd3cc1f1ada50d8760c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854719 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#705201}
-
Alex Clarke authored
I noticed telemetry hadn't changed after submitting the StartupTabPreloader and this is because we where not accepting intents with a component. This patch adds support for intents with a component name compatible with ChromeTabbedActivity.MAIN_LAUNCHER_ACTIVITY_NAME. BUG: 1013535 Change-Id: I4bc48ffc70676638358fcb58a38719d7198499c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852788 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#705200}
-
Dominic Mazzoni authored
First, re-lands the fix to bug 836554, which ensures TalkBack announces when a slider changes. This time, adds a check to only fire the TYPE_VIEW_SELECTED event if the slider has accessibility focus, hoping that will address the problems with fullscreen video by suppressing announcements when an unfocused slider changes. Also, doesn't expose the "can scroll forwards / backwards" actions on a slider that isn't an HTML INPUT control, because a pure ARIA slider won't respond to those. That addresses bug 917845. Finally, added code to ensure that a slider updates the accessibility tree when its value changes - I found this was necessary in order to get announcements after changing a slider with the volume keys. Bug: 836554, 917845, 953652 Change-Id: I3f1f88321a4644bc5729c16c14e0bd9037a641ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853857Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#705199}
-
Kristi Park authored
Enable by default in preparation for 100% rollout. Bug: 851335 Change-Id: I46cee16a1b803c7b2d55362baa1c56d630a2b83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854031Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#705198}
-
Thomas Tangl authored
This reverts commit fbb09263. Reason for revert: Test is flaky Original change's description: > [profile-menu] Re-enable browser test _WithUnconsentedPrimaryAccount > > ... and wait for SyncTransportActive during the setup. > > Bug: 995720, 1012167 > Change-Id: Ib0523c68738f226a29171fabc64264cf36c03f37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856061 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705126} TBR=droger@chromium.org,tangltom@chromium.org Change-Id: I44760e6374571726196153bf32022c9735fb7984 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995720, 1012167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856958Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705197}
-
Evan Stade authored
No behavioral change intended. Change-Id: I6905ee8f089812ee46eb454de7062a35b10db26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849266Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705196}
-
Boris Sazonov authored
This CL changes how credential entries are bound to the corresponding views in the ListView - now PropertyModel is used to provide Credential instances. The same PropertyModel contains FAVICON property for the favicon. Bug: 1012646 Change-Id: I1943220e6b716224d3e7ae5fb7ec226edc70e299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852430 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705195}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9b33e3602340..27c4369651a8 git log 9b33e3602340..27c4369651a8 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-11 herb@google.com Introduce SkGlyphDrawableBuffer Created with: gclient setdep -r src/third_party/skia@27c4369651a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ib2a9806f52e52d9bd56986206f6fa897c743c158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856678Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705194}
-
Jan Wilken Dörrie authored
This change performs minor clean-ups of base::AutoReset such as making use of std::exchange in its move operations, taking the constructor argument by forwarding reference and getting rid of the branch to protect against self-move assignment. Bug: None Change-Id: I7cac40c037dc1e18367b42d3057bc984f14cb472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855838Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#705193}
-
Roman Aleksandrov authored
Scroll view to show auto-selected toggle. Fix layout issue with zero height divs. Bug: 1010166 Change-Id: I56399b4a43da16797b3b25a818b8d39f3a4c89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848380Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#705192}
-
Gang Wu authored
Problem: In third_party/blink/renderer/core/input/gesture_manager.cc, the function GestureManager::HandleGestureLongTap did not process kGestureLongTap for Android, but it is not enough. In web_view_impl.cc, function WebViewImpl::HandleGestureEvent processes kGestureLongTap, it clears the context menu, but does not generate new data for the context menu since GestureManager ignores kGestureLongTap. Then in some conditions, it will make the context menu in Android totally useless, click anything on the context menu won't do anything. Fix: In this CL, we check if we should process long_tap action before clear ContextMenuController. Bug:1012068 Change-Id: I2d490d5bde19f016d117437bcb793459b92a0cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849171Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705191}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: Icd6c09563e577153829c8243758b8c98aff1b6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837872 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#705190}
-
Sergey Ulanov authored
Protected memory and HW decoders are not supported on x64 devices, so WebEngine wasn't working properly when WIDEVINE_CDM feature was enabled. This CL adds IsFuchsiaCdmSupported() that indicates that that FuchsiaCdm is supported on the device. For now it's just a stub that returns true only in arm64 builds. With this change WebEngine will not try to use protected memory on x64 devices where it's not supported. Bug: 1013412 Change-Id: Ib9c323c725886ea7397bc7f2633a44fad56ee13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854547 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705189}
-
siyua authored
Remove this for now since it is not launched anywhere but breaks newly added browser-tests. Bug: 932818 Change-Id: Ic28350544eab1afb03862b650b09bb60cb829e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855205Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#705188}
-
Tommy Steimel authored
This CL moves SlideOutController out of ui/message_center and into ui/views/animation. This will allow the SlideOutController to be used for swiping to dismiss notifications from the GMC dialog in crrev.com/c/1829671 Bug: 1008905 Change-Id: I3ba95fe85ba18763324529d6e4fa450d7f78c143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853855 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705187}
-
Austin Eng authored
This reverts commit fc5ad208. Reason for revert: Use of the GPUProgrammablePassEncoder and GPURenderEncoderBase interfaces aren't installing the function templates properly. Original change's description: > WebGPU: Add GPUProgrammablePassEncoder interface > > This is a spec match-up with[1] > > [1] https://github.com/gpuweb/gpuweb/pull/459 > > Bug: 877147 > Change-Id: I080324cbb083160ae84aa109623e311f24a875cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#704061} TBR=jinho.bang@samsung.com,haraken@chromium.org,cwallez@chromium.org Bug: 1013649 Change-Id: I0d401cece6c5dcfb94d17c3cc32965512d4ec2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856618Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#705186}
-
Livvie Lin authored
Renames https_invalid.icon since the triangle icon will be used for HTTP pages as well as part of crbug.com/997972. Bug: 1008218 Change-Id: I031ab884361c5085f7ef0f7b93935e235540005a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846567Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705185}
-
Tom Tan authored
RtlCaptureStackBackTrace on Windows ARM64 relies on frame pointer chain to walk the stack which is guaranteed by "/Oy-" option for clang-cl.exe/cl.exe. This option is enabled in optimized build but not in debug build which could cause missing Chromium modules in stack trace. Bug: 893460 Change-Id: I60c3196aa8917209cfcf059eecc1660c291f5c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854825Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705184}
-
Jeremy Roman authored
I intend to reuse them to test a navigation throttle, but it's a little crowded to put them in the same .cc file. Bug: 1013389 Change-Id: Ie67cbff281ee7ca753b01d06743036a74764fa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854219 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705183}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 530939ea. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I01cb61e3c28497ca0b10c4b45636b0b915caea2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856418Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705182}
-
James Cook authored
This feature was added to support the mustash project, which was using the mojo pref service to support Chrome OS UI code running outside the browser process. The mustash project was cancelled, none of the remaining users of the mojo pref service need synced prefs, and the mojo pref service will be removed soon. This CL is partially a manual revert of these changes: "Reland "Support late registration of syncable preferences."" https://chromium-review.googlesource.com/c/chromium/src/+/1074688/ "Properly distinguish between regular and priority preferences in sync." https://chromium-review.googlesource.com/c/chromium/src/+/1099381/ This CL keeps the code to reset prefs on type mismatches between server and client. One of the histograms added in the CLs above is marked obsolete. Bug: 1012462, 840332 Change-Id: I702bfbfbb2c9e6e5c84496391efb6f48a4c07c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848267 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#705181}
-
Evan Stade authored
Bug: 268984 Change-Id: I3e31bd137be5df84c1fcad094813965d23b2cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848502Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705180}
-
Gavin Williams authored
-Currently when a user has ChromeVox turned on and a printer is successfully added, a success toast pops up but ChromeVox does not announce it. This change forces ChromeVox to read out the contents of the toast. Bug: 987343 Change-Id: I9ffa73d8765ddfbdaad421bf13d3ab4efaaadfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850250Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#705179}
-
danakj authored
RenderWidget used to start closing and then post a task to self-delete. But now it deletes synchronously inside Close(). So when closing_ becomes true, the RenderWidget will be deleted in the same stack. Thus we do not need to guard against closing_ since blink will not be using the RenderWidget afterward - it would be a UAF. The LayerTreeViewDelegate methods used to check for a null WebWidget which would be the case once closing_ became true, before RenderWidget was destroyed. Now the RenderWidget disconnects itself from the LayerTreeView and deletes immediately, so these methods are never called with a null WebWidget unless they were used while the RenderWidget is undead. But the compositor does not run while the RenderWidget is undead, and the LayerTreeViewDelegate will not be used unless the compositor posted the task and then runs it after the RenderWidget becomes undead. The methods in this CL are all part of the BeginMainFrame step which only runs when the compositor is visible and the RenderWidget is not undead. R=avi@chromium.org Bug: 419087 Change-Id: If0158f2ffeaf0c5d334a80aed3cdb9e686002fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854878Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705178}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8f41e5d14063..dbcebd185da3 git log 8f41e5d14063..dbcebd185da3 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 treehugger-gerrit@google.com Merge "processor: Fix some potential crashes in json exporter" 2019-10-11 fmayer@google.com Merge "Add roots to heap_graph proto." Created with: gclient setdep -r src/third_party/perfetto@dbcebd185da3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2cdbf3923d1a9439fadd131e6c5bdfdbe96e79ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705177}
-
Matt Giuca authored
This is a reland of 825856a2 Original CL was reverted because the new API wasn't ready for M78. Now the API is changing (https://crrev.com/1816002) so we re-land the new origin trial name. Original change's description: > Migrate Badging origin trial name to BadgingV2. > > This invalidates all existing Badging origin trial tokens, as we are > moving to a new (slightly incompatible) Badging API. New origin trial > tokens will become available. > > Bug: 1000960 > Change-Id: Ic9ca1b56a390a601b2591a27352d205650df2c33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787018 > Commit-Queue: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693555} Bug: 1000960 Change-Id: Ic7a7e87f58ec4bc060a68f2adfcd7e5021b20909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855078 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705176}
-
Lucas Gadani authored
Bug: 984550 Change-Id: Ib2705c3e1121a24bffa147e24ed8b3ecc9241f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853845Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705175}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddd5171b..4e284d62 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I615d6e5567999acccbc67e344b436a48a3a86835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855419Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705174}
-