1. 13 Nov, 2018 40 commits
    • chromium-autoroll's avatar
      Roll src/third_party/webrtc e769ed90c359..44ca9a392ac6 (75 commits) · 04725414
      chromium-autoroll authored
      https://webrtc.googlesource.com/src.git/+log/e769ed90c359..44ca9a392ac6
      
      
      git log e769ed90c359..44ca9a392ac6 --date=short --no-merges --format='%ad %ae %s'
      2018-11-13 mbonadei@webrtc.org Allow usage of stringstream under examples/.
      2018-11-13 kwiberg@webrtc.org Remove some unused RentACodec static methods
      2018-11-13 peah@webrtc.org AEC3: Corrected erroneous if-statement that always returned true
      2018-11-13 nisse@webrtc.org Add missing include of unistd.h
      2018-11-13 nisse@webrtc.org Delete deprecated class WrappedI420Buffer
      2018-11-13 mbonadei@webrtc.org Configs to run slow_tests.
      2018-11-13 nisse@webrtc.org Delete obsolete interface class RtpData
      2018-11-13 srte@webrtc.org Adds setup of RTP Extensions in Scenario tests.
      2018-11-13 asapersson@webrtc.org Add tests for cpu overuse scaling.
      2018-11-12 ouj@fb.com Adding rtcp report interval into RTCConfiguration.
      2018-11-12 ouj@fb.com Explicitly retain self in objc blocks to avoid compiler warning.
      2018-11-12 srte@webrtc.org Allows change of fake encoder max rate in scenarios tests.
      2018-11-12 srte@webrtc.org Add support for screenshare content type in scenario tests.
      2018-11-12 srte@webrtc.org Simplifies audio priority rate config in scenario tests.
      2018-11-12 eladalon@webrtc.org Remove obsolete comment (WebRtcSessionDescriptionFactory ctor)
      2018-11-12 srte@webrtc.org Using early acknowledged rate for safe reset in GoogCC.
      2018-11-12 ilnik@webrtc.org In RTP to NTP estimator use linear regression instead of ad hoc filter
      2018-11-12 eladalon@webrtc.org Event log - Use ToUnsigned() and ToSigned() on timestamp_ms
      2018-11-12 eladalon@webrtc.org Event logs - encode N channels as N-1
      2018-11-12 kwiberg@webrtc.org AudioCodingModule: Remove support for creating encoders
      2018-11-12 nisse@webrtc.org Tweak ChannelReceive interface, to make it closer to ChannelReceiveProxy
      2018-11-12 nisse@webrtc.org Eliminate use of EventWrapper from android audio device tests
      2018-11-12 eladalon@webrtc.org Add RtcEvent::timestamp_ms()
      2018-11-12 kron@webrtc.org Add offer_extmap_allow_mixed to RTCConfiguration
      2018-11-12 danilchap@webrtc.org Revert "Run robolectric tests for Android on several Android API versions"
      2018-11-12 aleloi@webrtc.org Fuzzer crash in AGC2.
      2018-11-12 jonasolsson@webrtc.org Remove most of api/ortc/.
      2018-11-12 kron@webrtc.org Fix overflow for high bitrates in BitrateProber
      2018-11-12 yvesg@google.com Revert "Roll "Enable SSE, SSE2, and run-time detected SSE4.1 for libopus.""
      2018-11-10 eladalon@webrtc.org Hide RtcEvent members behind accessors
      2018-11-10 eladalon@webrtc.org Event logs - separate audio_level and voice_activity
      2018-11-09 yvesg@webrtc.org Roll "Enable SSE, SSE2, and run-time detected SSE4.1 for libopus."
      2018-11-09 eladalon@webrtc.org Rename fields in rtc_event_log2.proto
      2018-11-09 mellem@webrtc.org Fix up an outdated comment in peerconnection_integrationtest.cc.
      2018-11-09 Peter) Slatala Signal Network route change in fake ice.
      2018-11-09 eladalon@webrtc.org Use delta-encoding in new WebRTC event logs
      2018-11-09 phoglund@webrtc.org Clean up root OWNERS.
      2018-11-09 artit@webrtc.org Run robolectric tests for Android on several Android API versions
      2018-11-09 kron@webrtc.org Pass HdrMetadata between VideoFrame and EncodedImage for VP9
      2018-11-09 terelius@webrtc.org Add support for audio in latency visualization.
      2018-11-09 jonasolsson@webrtc.org Fix flaky JsepTransportControllerTests.
      2018-11-09 kron@webrtc.org Add RTP header extension for HDR metadata
      2018-11-09 ilnik@webrtc.org In RTP to NTP estimator do not allow huge jumps in NTP timestamps
      2018-11-09 yvesg@webrtc.org Reintroduce missing dependencies in libwebrtc.a library.
      2018-11-09 mellem@webrtc.org Implement data channels over media transport.
      2018-11-08 ouj@fb.com Reland "Use the factory instead of using the builtin code path in `VideoCodecInitializer`"
      2018-11-08 yvesg@webrtc.org [Win/boringSSL] Add nasm as part of required dependencies.
      2018-11-08 Peter) Slatala Callback changes to media transport interface:
      2018-11-08 Peter) Slatala Add owners for media_transport_interface
      2018-11-08 sprang@webrtc.org Add ability to specify if rate controller of video encoder is trusted.
      2018-11-08 sprang@webrtc.org In Android encoders, cache EncoderInfo in InitEncode.
      2018-11-08 nisse@webrtc.org Delete rtc::Filesystem. Move needed functions to filerotatingstream.cc.
      2018-11-08 nisse@webrtc.org Eliminate use of EventWrapper from mac audio device
      2018-11-08 sprang@webrtc.org Add magjed/nisse/sprang/brandtr as api/video_codecs owners
      2018-11-08 danilchap@webrtc.org Introduce RtpPacket::GetExtension accessor that return result
      2018-11-08 yujo@chromium.org Split a separate codecs target off of :video_jni
      2018-11-08 nisse@webrtc.org Eliminate use of EventWrapper from ios audio device tests
      2018-11-08 alessiob@webrtc.org Tolerate optional chunks in WAV files
      2018-11-08 saza@webrtc.org Add flag for fast jitter buffer playout in neteq simulation
      2018-11-08 alessiob@webrtc.org MsanUninitialized: restric type check to msan case.
      2018-11-08 nisse@webrtc.org Delete classes EventFactory and EventFactoryImpl.
      2018-11-08 oprypin@webrtc.org Make the bitrate_allocator param optional to prepare for its removal
      2018-11-08 nisse@webrtc.org Reenable test RampUpTest.AudioTransportSequenceNumber
      2018-11-08 kwiberg@webrtc.org Add a style rule about not using const optional<T>& arguments
      2018-11-08 saza@webrtc.org Add missing conditional defines to neteq test and tools targets
      2018-11-08 nisse@webrtc.org Deprecate EventFactory and delete all usage.
      2018-11-07 sprang@webrtc.org Update H264 encoder to use GetEncoderInfo
      2018-11-07 sprang@webrtc.org Update LibVpxVp8Encoder to use GetEncoderInfo
      2018-11-07 sprang@webrtc.org Update VP9 encoder to use GetEncoderInfo
      2018-11-07 orphis@webrtc.org Remove multiple RTX codec entries in GetRtpReceiver/SenderCapabilities
      2018-11-07 sprang@webrtc.org Update SimulcastEncoderAdapter merging of EncoderInfo
      2018-11-07 ilnik@webrtc.org Clear FrameBuffer if there were no frames received for 10 minutes
      2018-11-07 alessiob@webrtc.org Reland "Isolating APM API build target: making :api an actual target."
      2018-11-07 brandtr@webrtc.org Add field trial for target bitrate RTCP XR message.
      2018-11-07 nisse@webrtc.org Delete NullEventFactory
      
      
      Created with:
        gclient setdep -r src/third_party/webrtc@44ca9a392ac6
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff, who should
      be CC'd on the roll, and stop the roller if necessary.
      
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
      
      BUG=chromium:None,chromium:none,chromium:None,chromium:901661,chromium:None,chromium:None,chromium:None,chromium:766721,chromium:None,chromium:None,chromium:None,chromium:none,chromium:None
      TBR=webrtc-chromium-sheriffs-robots@google.com
      
      Change-Id: I80b2d4e7908e09e4b4b99e592eca5879ce252ca2
      Reviewed-on: https://chromium-review.googlesource.com/c/1333849Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#607647}
      04725414
    • Vincent Boisselle's avatar
      Added new Autofil API v1 protos. · 2d754c7e
      Vincent Boisselle authored
      These protos will be used to interface with the new Autofill API. We don't make any use of the protos in this CL.
      
      Change-Id: I2353c0f183501748556cd3702f6fc625c43adb50
      Reviewed-on: https://chromium-review.googlesource.com/c/1324197Reviewed-by: default avatarMathieu Perreault <mathp@chromium.org>
      Reviewed-by: default avatarRoger McFarlane <rogerm@chromium.org>
      Commit-Queue: Vincent Boisselle <vincb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607646}
      2d754c7e
    • Mario Sanchez Prada's avatar
      Migrate SyncedBookmarksObserverBridge to the IdentityManager · dfa24463
      Mario Sanchez Prada authored
      Replace usage of SigninManagerBase::IsAuthenticated with
      IdentityManager::HasPrimaryAccount().
      
      Bug: 903840
      Change-Id: I907301ebe26df1a1b7c718a30ec0051b26a5ad55
      Reviewed-on: https://chromium-review.googlesource.com/c/1332300Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
      Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
      Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#607645}
      dfa24463
    • Kevin Bailey's avatar
      [omnibox] Update owners · cfeacb30
      Kevin Bailey authored
      ...to reflect current team.
      
      The other relevant OWNER files refer to this one.
      
      Change-Id: Ifdbe2da5c6f1ac93e53e8f464ce2472d0ebef04e
      Reviewed-on: https://chromium-review.googlesource.com/c/1333889Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
      Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
      Commit-Queue: Peter Kasting <pkasting@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607644}
      cfeacb30
    • Wan-Teh Chang's avatar
      Roll src/third_party/libaom/source/libaom/ 351711076..716f2896c (34 commits) · 9f71aed4
      Wan-Teh Chang authored
      https://aomedia.googlesource.com/aom.git/+log/35171107616f..716f2896c6ba
      
      $ git log 351711076..716f2896c --date=short --no-merges --format='%ad %ae %s'
      2018-11-06 remy.foray Fix overflow in clamp_mv_to_umv_border_sb
      2018-11-02 johann.koenig cfl: replace null functions with NULL
      2018-11-07 yaowu Port simplified rdmult computation from libvpx
      2018-11-07 urvang Change MV_REFERENCE_FRAME type back to int8_t.
      2018-11-06 urvang Remove LAST_REF_FRAMES enum value.
      2018-11-05 urvang Cleanup regarding buffer pool ref counts.
      2018-11-06 yunqingwang Fix optimization config flag
      2018-11-05 urvang Reference related code: Better naming and comments
      2018-11-06 urvang Doc for refresh_*_frame and new_bwdref_update_rule
      2018-11-05 urvang Introduce an enum for reference types.
      2018-11-06 david.turner Remove uses of _mm_set_epi64x
      2018-10-30 elliottk Add warning when writing colocated chroma in Y4M
      2018-11-01 elliottk Add high bit-depth edge detection
      2018-11-05 chiyotsai Remove av1_set_mv_cost
      2018-11-05 debargha Deprecate redundant get_horver_correlation() fn
      2018-11-02 sarahparker Clean up naming in horver_correlation_test
      2018-11-02 johann.koenig cdef: remove AOM_UNUSED
      2018-11-02 sarahparker Check pointers in test/* functions
      2018-11-02 sarahparker Namespace global motion functions
      2018-11-02 ravi.chaudhary Fix issues for palette content in enc row-mt
      (...)
      
      Created with:
        roll-dep src/third_party/libaom/source/libaom
      R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org
      
      Change-Id: I6b0f6c1c736dc894fb4c77e0915b4e748157d6a5
      Reviewed-on: https://chromium-review.googlesource.com/c/1331909Reviewed-by: default avatarJohann Koenig <johannkoenig@google.com>
      Commit-Queue: Wan-Teh Chang <wtc@google.com>
      Cr-Commit-Position: refs/heads/master@{#607643}
      9f71aed4
    • Tom Tan's avatar
      Get correct program counter in browser_watcher for Windows ARM64. · ab224ffa
      Tom Tan authored
      Bug: 893460
      Change-Id: I1beadfbd939b8998a9d64f14260b106180ce3aae
      Reviewed-on: https://chromium-review.googlesource.com/c/1333131
      Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
      Reviewed-by: default avatarSigurður Ásgeirsson <siggi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607642}
      ab224ffa
    • Denis Kuznetsov's avatar
      Add configuration option to trigger restore robot accounts flow. · f96c6f6c
      Denis Kuznetsov authored
      After version rollback it is possible to have device with
      TPM state / InstallAttributes /policy preserved, but with
      robot account information lost. We need to trigger a path that would
      perform only this step upon version rollback.
      
      TBR: alemate@chromium.org
      Bug: 854101
      Change-Id: Ib1f4bb7f571661d8db3f9a46702ad09ad6fa275e
      Reviewed-on: https://chromium-review.googlesource.com/c/1296604
      Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
      Reviewed-by: default avatarSergey Poromov <poromov@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607641}
      f96c6f6c
    • Dmitry Gozman's avatar
      Replace NavigationPolicyInfo with WebNavigationInfo · 7b10a538
      Dmitry Gozman authored
      - Introduce a top-level struct for navigaiton info.
      - Avoid passing the struct by non-const reference.
      - Add comments describing the fields.
      
      We can follow up with WebNavigationParams constructor
      taking WebNavigationInfo which will make it easy for all
      the clients to commit.
      
      TBR=tommycli@chromium.org, thestig@chromium.org
      
      Bug: 855189
      Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
      Change-Id: I84aeb2771d83b4e0f1e713a259d7889d0956782f
      Reviewed-on: https://chromium-review.googlesource.com/c/1279226
      Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607640}
      7b10a538
    • Mitsuru Oshima's avatar
      Make shelf blur quality same as launcher's · 894145b9
      Mitsuru Oshima authored
      Bug: None
      Test: None
      Change-Id: I697dcf3af1c6736e572d67ad254d815fd797402f
      Reviewed-on: https://chromium-review.googlesource.com/c/1333897Reviewed-by: default avatarDaniele Castagna <dcastagna@chromium.org>
      Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607639}
      894145b9
    • Jan Krcal's avatar
      Reland: [AF] Add integration tests for wallet metadata · 46c534fb
      Jan Krcal authored
      This CL creates the first integration tests for the autofill wallet
      metadata model type.
      
      Bug: 894001
      Change-Id: I55ab6517d03d7ccb199d24ccbbc9ff13927017f0
      Reviewed-on: https://chromium-review.googlesource.com/c/1332934Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
      Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607638}
      46c534fb
    • Jeffrey Cohen's avatar
      match comment changes from CL on server side · 8d37adb9
      Jeffrey Cohen authored
      Bug: 901429
      Change-Id: I888c28fb2900e2c780c654ebb2a92450ec9a6c59
      Reviewed-on: https://chromium-review.googlesource.com/c/1331578Reviewed-by: default avatarMarc Treib <treib@chromium.org>
      Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607637}
      8d37adb9
    • Max Moroz's avatar
      [libFuzzer] Switch back to -fsanitize=fuzzer-no-link instrumentation on Mac. · a6986c17
      Max Moroz authored
      This reverts the speculative fix landed in https://crrev.com/c/1262077.
      
      Bug: 892167
      Change-Id: I1eb3c8c9cb2615cfd33681554fad7e4234a4a497
      Reviewed-on: https://chromium-review.googlesource.com/c/1332428Reviewed-by: default avatarJonathan Metzman <metzman@chromium.org>
      Commit-Queue: Max Moroz <mmoroz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607636}
      a6986c17
    • chromium-internal-autoroll's avatar
      Roll src-internal a20b35ec2dc1..52c961afab61 (3 commits) · 0e86ce8f
      chromium-internal-autoroll authored
      https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a20b35ec2dc1..52c961afab61
      
      
      Created with:
        gclient setdep -r src-internal@52c961afab61
      
      The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff, who should
      be CC'd on the roll, and stop the roller if necessary.
      
      
      
      BUG=chromium:904763,chromium:904715,chromium:904768
      TBR=mmoss@chromium.org
      
      Change-Id: I7bcd8c7d8e992d8a105053cf1bbb5f86c24af384
      Reviewed-on: https://chromium-review.googlesource.com/c/1333855Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#607635}
      0e86ce8f
    • Carlos IL's avatar
      Disable MessagingInterstitial test for committed interstitials · ad7cb8bd
      Carlos IL authored
      This test was added as part of a fix for a crash that occurred due to
      interstitials not having an associated web contents.
      With committed interstitials enabled, interstitials are no longer a
      special case, and do have a web contents, so the special conditions
      that are checked in this test no longer apply.
      
      Bug: 752372
      Change-Id: Id06e38674dd17f97a467f98b5759433aad8cd6ec
      Reviewed-on: https://chromium-review.googlesource.com/c/1313675Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
      Commit-Queue: Carlos IL <carlosil@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607634}
      ad7cb8bd
    • Danyao Wang's avatar
      [Nav Experiment] Use restore completion callback to clear browsing data. · 169e31d0
      Danyao Wang authored
      This CL adds a new AddRestoreCompletionCallback APIs to
      NavigationManager. Since session restore is asynchronous in slim nav,
      this allows callers to registers a completion callback that
      NavigationManager will execute when session restore completes.
      LegacyNavigationManager always runs the completion handler synchronously.
      
      [MainController -removeBrowsingDataForBrowserState:] is refactored to
      wait for session restore completion.
      
      This fixes SigninInteractionControllerTestCase/
      testSignInSwitchManagedAccount.
      
      Bug: 890381
      Change-Id: Iae660ab054514a9db8d75804a7a8d9599b234d7e
      Reviewed-on: https://chromium-review.googlesource.com/c/1331568
      Commit-Queue: Danyao Wang <danyao@chromium.org>
      Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607633}
      169e31d0
    • Mario Sanchez Prada's avatar
      Convert chrome/browser/ui/autofill/chrome_autofill_client.cc to Identity service · 1d8fb732
      Mario Sanchez Prada authored
      Migrated away from SigninManagerBase::GetAuthenticatedAccountId() and
      AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager.
      
      Bug: 903886
      Change-Id: I4bd70c490760a9d22687545f7d22851f9cdb9a5a
      Reviewed-on: https://chromium-review.googlesource.com/c/1331473Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#607632}
      1d8fb732
    • Nektarios Paisios's avatar
      AXSelection: Added declarative test for aria-hidden and strengthened tests for... · 0272e9b9
      Nektarios Paisios authored
      AXSelection: Added declarative test for aria-hidden and strengthened tests for aria-hidden and list bullets
      
      Tests now check the results of both shrinking a selection as well as extending a selection.
      In the case of aria-hidden, we want to check whether a DOM selection on aria-hidden endpoints would be correctly extended or shrunk when converted to an equivalent AX selection, since aria-hidden objects are an example of an object that is ignored in the accessibility tree.
      In the case of a list bullet, we want to check whether an AXSelection that has an endpoint on a list bullet, would be correctly extended or shrunk when converted to a DOM selection, since list bullets are an example of an object not present in the DOM tree.
      R=dmazzoni@chromium.org
      
      Bug: 639340
      Change-Id: Ia9e7dee6efe5c0059faae101a1a07b5d7d35ef5c
      Reviewed-on: https://chromium-review.googlesource.com/c/1327221
      Commit-Queue: Nektarios Paisios <nektar@chromium.org>
      Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607631}
      0272e9b9
    • Stephane Zermatten's avatar
      [Autofill Assistant] Fix transition from overlay to TouchEventFilter. · b684e07c
      Stephane Zermatten authored
      https://chromium-review.googlesource.com/c/1331401 introduced a bug that
      made the page visible temporarily between the time the overlay is
      switched off and the time a touchable element appears.
      
      This was due to an over-eager early abort in updateTouchableArea, which
      would not update anything unless the touchable area changed - regardless
      of whether enabled changed.
      
      This patch fixes the problem by decoupling the update of "enabled" from
      the update of the touchable area.
      
      Bug: 806868
      Change-Id: I3ee78489cb538d6fd06e24d15fcb47a456b1f079
      Reviewed-on: https://chromium-review.googlesource.com/c/1333754Reviewed-by: default avatarMathias Carlen <mcarlen@chromium.org>
      Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607630}
      b684e07c
    • Lukasz Suder's avatar
      [Autofill Assistant] Checks the details coming from Parameters. · 9aacd9fc
      Lukasz Suder authored
      The details and statusMessage were moved to controller.
      
      If the details from parameters differ from details coming from Action, Autofill Assistant is closed.
      
      Bug: 806868
      Change-Id: Icb7da81fa7eca0bf4894632f4ca0c3a68b16ae1c
      Reviewed-on: https://chromium-review.googlesource.com/c/1332192
      Commit-Queue: Lukasz Suder <lsuder@chromium.org>
      Reviewed-by: default avatarStephane Zermatten <szermatt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607629}
      9aacd9fc
    • Fredrik Söderquist's avatar
      Fixes and tweaks to wpt/css/filter-effects/ · 23bcf533
      Fredrik Söderquist authored
      filter-contrast-003.html
      
        Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just
        over 0.25 and can after filtering and rounding end up above 0.
        (0x3f / 255) on the other hand is just below 0.25 and the result will
        be clamped to zero.
      
      filter-external-001-test.html
      filter-external-002-test.html
      
        Change the hue-rotate parameter in the external file from 120 to 150.
        Move the file to support/ and remove lint entry.
        Make both filters operate in sRGB to make computing the reference
        easier. Use rgb(...) notation with percentage values in reference.
      
      fecolormatrix-type.html
      
        Add color-interpolation-filters=sRGB to the filter to make it easier
        to reason about what the result should be. Use rgba(...) notation in
        the ref using percentage notation.
      
      filters-test-brightness-003.html
      
        Add 'filter: brightness(0)' before 'filter: brightness()' to properly
        test if the "no argument" notation is considered valid by the parser.
      
      filter-grayscale-001.html
      filter-grayscale-002.html
      filter-grayscale-003.html
      filter-grayscale-004.html
      filter-grayscale-005.html
      
        Remove the " (and not blue)" text from the reference and update the
        001,004 and 005 tests accordingly.
      
      css-filters-animation-saturate.html
      
        Interpolate the argument from 4900% rather than 5000% to end at the
        ref's 2500% (25).
      
      css-filters-animation-hue-rotate.html
      
        Sample the animation at .5 to match the expectation.
      
      css-filters-animation-drop-shadow.html
      
        Use explicit rgba(...) in the ref rather than the keyword 'gray'.
        We're interpolating the color of the drop-shadow from 'black'
        (rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's
        better and more accurate to describe the color as "semi-transparent
        black" (rgba(0, 0, 0, 0.5)).
      
      css-filters-animation-combined-001.html
      
        Initial value for animation for 'opacity(...)' is '1' - not zero.
        Change test to interpolate from 0 -> 1 (rather than 1 -> 1)
      
      Bug: 903383
      Change-Id: I4d0113989414616494b98c22fbac817f007cd762
      Reviewed-on: https://chromium-review.googlesource.com/c/1333816Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
      Commit-Queue: Fredrik Söderquist <fs@opera.com>
      Cr-Commit-Position: refs/heads/master@{#607628}
      23bcf533
    • Steve Anton's avatar
      Add a ByteBufferQueue data structure · 68c381e3
      Steve Anton authored
      A ByteBufferQueue is internally a queue of byte buffers. Clients
      can append entire byte buffers then copy data out across buffer
      boundaries.
      
      Bug: 874296
      Change-Id: I64e8a7e9f080aa73e818a81c1a42241ac9ac4e26
      Reviewed-on: https://chromium-review.googlesource.com/c/1289152
      Commit-Queue: Steve Anton <steveanton@chromium.org>
      Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
      Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607627}
      68c381e3
    • Corentin Wallez's avatar
      Add back some WebGL test expectations · 539ef7dd
      Corentin Wallez authored
      A lot of expectations were removed but some of them were still
      necessary, this adds them back.
      
      TBR=kbr@chromium.org
      BUG=chromium:693135
      BUG=chromium:772651
      BUG=chromium:798117
      BUG=chromium:874620
      BUG=chromium:887241
      
      Change-Id: Ib3bccdf2ff48a28a8f0a3ce428239980a58c5266
      Reviewed-on: https://chromium-review.googlesource.com/c/1333650Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
      Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
      Commit-Queue: Corentin Wallez <cwallez@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607626}
      539ef7dd
    • Dan Harrington's avatar
      Remove function definition order rule · f710e804
      Dan Harrington authored
      The Google c++ style guide removed this rule in 2014. There was support on cxx
      for removing this rule from the Chromium style guide.
      
      Change-Id: I6434b2c2112638cfe96e8c42b59e20889d19aa9f
      Reviewed-on: https://chromium-review.googlesource.com/c/1330935Reviewed-by: default avatardanakj <danakj@chromium.org>
      Commit-Queue: Dan H <harringtond@google.com>
      Cr-Commit-Position: refs/heads/master@{#607625}
      f710e804
    • Fabio Tirelo's avatar
      [Mfill Android] Rename UserInfo::Field::is_password to is_obfuscated · 7c346a90
      Fabio Tirelo authored
      This is another step to generalize the data sent to the front end for
      the accessory sheet, to enable sending data for profiles and credit
      cards.
      
      Please check the linked bug for the desired final state as well as
      the steps of this refactoring to be sent in follow-up CLs.
      
      Bug: 902425
      Change-Id: I240da77100748a337b889bff7b4be0a7c82404f4
      Reviewed-on: https://chromium-review.googlesource.com/c/1330694
      Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
      Reviewed-by: default avatarFriedrich Horschig [CET] <fhorschig@chromium.org>
      Reviewed-by: default avatarTommy Martino <tmartino@chromium.org>
      Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607624}
      7c346a90
    • Moe Ahmadi's avatar
      [AF][IOS] Fixes SaveCardInfoBarView's broken constraints · b3415984
      Moe Ahmadi authored
      SaveCardInfoBarView's constraints break while the parent view animates.
      This CL fixes that problem by lowering the priority of the constraints on
      the SaveCardInfoBarView's bottom anchor while setting up subviews and
      restoring it once SaveCardInfoBarView has moved to its superview.
      
      This CL also:
      -adds a11y identifiers to subviews for easier debugging.
      -sets translatesAutoresizingMaskIntoConstraints to NO where missing.
      -removes unnecessary constraints.
      
      Bug: 904521
      Change-Id: I99dabdbc83614b881c6af4eaad22c29cc4fd8c08
      Reviewed-on: https://chromium-review.googlesource.com/c/1331910
      Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
      Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607623}
      b3415984
    • Christopher Thompson's avatar
      Add custom malloc with max limit to prevent OOM · e9f1c43d
      Christopher Thompson authored
      This adds the custom malloc/free functions from the old
      libpng_read_fuzzer to the upstream fuzzer to prevent clusterfuzz running
      into OOM.
      
      Bug: 904054
      Change-Id: Ibb824beb191cb5657687c55ee2db8c7783547bad
      Reviewed-on: https://chromium-review.googlesource.com/c/1330936
      Commit-Queue: Christopher Thompson <cthomp@chromium.org>
      Reviewed-by: default avatarLeon Scroggins <scroggo@chromium.org>
      Reviewed-by: default avatarMax Moroz <mmoroz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607622}
      e9f1c43d
    • chromium-autoroll's avatar
      Roll src/third_party/angle cd47a379f960..0864a7ac638c (1 commits) · 373e9b99
      chromium-autoroll authored
      https://chromium.googlesource.com/angle/angle.git/+log/cd47a379f960..0864a7ac638c
      
      
      git log cd47a379f960..0864a7ac638c --date=short --no-merges --format='%ad %ae %s'
      2018-11-13 syoussefi@chromium.org Vulkan: Enable end2end tests for ES2_VULKAN everywhere
      
      
      Created with:
        gclient setdep -r src/third_party/angle@0864a7ac638c
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff, who should
      be CC'd on the roll, and stop the roller if necessary.
      
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      TBR=cwallez@chromium.org
      
      Change-Id: I15f68178f76b7927f5f059c7124c23256173dde2
      Reviewed-on: https://chromium-review.googlesource.com/c/1333853Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#607621}
      373e9b99
    • Fredrik Söderquist's avatar
      Slimmer SVG enumeration tables · cbae617c
      Fredrik Söderquist authored
      This replaces a Vector<std::pair<..., ...>> with a new SVGEnumerationMap
      class that wraps a list of entries (also "pairs".) The setup of the map
      is however not done runtime but rather compile time, saving a bunch of
      code footprint in the process.
      
      Change-Id: If2c77f1ebcf15dcf8fc75d6a25cacebf42401287
      Reviewed-on: https://chromium-review.googlesource.com/c/1329974Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Commit-Queue: Fredrik Söderquist <fs@opera.com>
      Cr-Commit-Position: refs/heads/master@{#607620}
      cbae617c
    • Marc Treib's avatar
      Migrate sync_ui_util to SyncUserSettings · 8f5d676f
      Marc Treib authored
      SyncUserSettings is a new class that encapsulates all the
      user-configurable knobs for Sync. It replaces a bunch of setters
      and getters directly on the SyncService.
      
      Bug: 884159
      Change-Id: Iae8ac063b497ba4a74244d73927bc093cb42b57e
      Reviewed-on: https://chromium-review.googlesource.com/c/1333387Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
      Commit-Queue: Marc Treib <treib@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607619}
      8f5d676f
    • Marc Treib's avatar
      Move fake GetUserSettings() impl from SyncService to [Fake|Test]SyncService · 0ef1b0d3
      Marc Treib authored
      Bug: 884159
      Change-Id: Idb63eef4c7e6786ac589fc39bd637478c8b7ff8b
      Reviewed-on: https://chromium-review.googlesource.com/c/1333370Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
      Commit-Queue: Marc Treib <treib@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607618}
      0ef1b0d3
    • Marc Treib's avatar
      Cleanup: remove unnecessary includes from profile_sync_service.h/cc · 06d8cd62
      Marc Treib authored
      Bug: none
      Change-Id: I41edddb7fd8555c8ef513a714cb4540b0b2d2718
      Reviewed-on: https://chromium-review.googlesource.com/c/1333749Reviewed-by: default avatarJan Krcal <jkrcal@chromium.org>
      Commit-Queue: Marc Treib <treib@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607617}
      06d8cd62
    • Nicolas Ouellet-payeur's avatar
      Mark BrowserSwitcherUseIeSitelist policy Windows-only · 41c7aeca
      Nicolas Ouellet-payeur authored
      Bug: 904840
      Change-Id: I49876ee13a190b0b257197d31cd93230778a0e08
      Reviewed-on: https://chromium-review.googlesource.com/c/1311079
      Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
      Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607616}
      41c7aeca
    • Aaron Leventhal's avatar
      Expose a11y default state on default buttons in views · 6aa60fe2
      Aaron Leventhal authored
      Bug: 904433
      Change-Id: Ida5f3e93ede1f26cbf98a8e0b786a7f9ef2334f1
      Reviewed-on: https://chromium-review.googlesource.com/c/1331727
      Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
      Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
      Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607615}
      6aa60fe2
    • Mario Sanchez Prada's avatar
      Migrate ChromeBrowserStateManagerImpl to the IdentityManager · e99023e1
      Mario Sanchez Prada authored
      Move away from SigninManagerBase::GetAuthenticatedAccountId() and
      AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager.
      
      Bug: 903835
      Change-Id: Ia9b3f6251ad93b9cd6e042b54283b56fb0610bc8
      Reviewed-on: https://chromium-review.googlesource.com/c/1333447Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
      Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#607614}
      e99023e1
    • Sylvain Defresne's avatar
      Revert "Integrate Lite Page Server Previews with the Previews Stack" · 1e3e82ce
      Sylvain Defresne authored
      This reverts commit 8bd3e513.
      
      Reason for revert: identified as likely cause for flakyness of PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation by FindIt
      
      Original change's description:
      > Integrate Lite Page Server Previews with the Previews Stack
      > 
      > Adds Lite Page Server Previews to DetermineAllowedPreviews and
      > DetermineCommitted. For now, the preview is always allowed if the
      > feature is enabled and is committed if the URL matches.
      > 
      > This intentionally leaves an open question about whether more logic
      > in the NavigationThrottle can/should be moved into the DeciderImpl.
      > 
      > The biggest part of this change is moving the URL checking logic to
      > the previews component and adding additional helper functions there.
      > 
      > Bug: 898557
      > Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9
      > Reviewed-on: https://chromium-review.googlesource.com/c/1323800
      > Commit-Queue: Robert Ogden <robertogden@chromium.org>
      > Reviewed-by: Doug Arnett <dougarnett@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#607427}
      
      TBR=dougarnett@chromium.org,robertogden@chromium.org
      
      Change-Id: Iaa200e39f10086d95654bc7fb7485c66d3f53ed0
      No-Presubmit: true
      No-Tree-Checks: true
      Bug: 898557,904830
      Reviewed-on: https://chromium-review.googlesource.com/c/1333814Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
      Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607613}
      1e3e82ce
    • Alexander Timin's avatar
      [message_loop] Remove MessageLoopTypedTest.RecursiveDenial3. · f3f15d41
      Alexander Timin authored
      It assumes a specific ordering between immediate and delayed tasks that is
      not guaranteed by the SequencedTaskRunner API which only states that :
      
      //   - Given two tasks T2 and T1, T2 will start after T1 starts if:
      //
      //       * T2 is posted after T1; and
      //       * T2 has equal or higher delay than T1; and
      //       * T2 is non-nestable or T1 is nestable.
      
      This property is already verified by
      MessageLoopTypedTest.PostDelayedTask_InPostOrder_3 and recursive post task
      ordering is verified by MessageLoopTypedTest.RecursiveDenial1.
      
      R=gab@chromium.org
      BUG=891670
      
      Change-Id: Ic340df17dcd3529565564dff3c18c64f48bd1d2d
      Reviewed-on: https://chromium-review.googlesource.com/c/1333772Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
      Commit-Queue: Alexander Timin <altimin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607612}
      f3f15d41
    • Scott Violet's avatar
      chromeos: disables WizardControllerOobeConfigurationTest.ConfigurationIsLoaded · 4681e0fe
      Scott Violet authored
      as it is flaky
      
      BUG=904841
      TEST=test only change
      TBR=antrim@chromium.org
      
      Change-Id: If14a89ef3e6488867860601b9191e55381245547
      Reviewed-on: https://chromium-review.googlesource.com/c/1333757Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Scott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607611}
      4681e0fe
    • Scott Violet's avatar
      Revert "Disable Android IMEs according to given ImeInfo." · cb4796d8
      Scott Violet authored
      This reverts commit 2687587b.
      
      Reason for revert: This triggers a use of initialized value on the msan bots. I believe you forgot to initialize is_removing_imm_entry_
      
      https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929963931985091872/+/steps/unit_tests/0/logs/ArcInputMethodManagerServiceTest.EnableIme/0
      
      ==14387==WARNING: MemorySanitizer: use-of-uninitialized-value
          #0 0x5638655272d9 in arc::ArcInputMethodManagerService::ImeMenuListChanged() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc:394:7
          #1 0x56385b307d20 in arc::ArcInputMethodManagerServiceTest_EnableIme_Test::TestBody() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc:313:14
          #2 0x56385dbb3cb2 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
          #3 0x56385dbb3cb2 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2522:0
          #4 0x56385dbb7a6b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2698:11
          #5 0x56385dbb9559 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28
          #6 0x56385dbf2614 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5182:43
          #7 0x56385dbf0ee7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
          #8 0x56385dbf0ee7 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4791:0
          #9 0x56386b81af20 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2333:46
          #10 0x56386b81af20 in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0
          #11 0x56386b822e8a in Run ./../../base/callback.h:99:12
          #12 0x56386b822e8a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
          #13 0x56386b822607 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10
          #14 0x56386b7e9154 in main ./../../chrome/test/base/run_all_unittests.cc:30:10
          #15 0x7fd6f88f4f44 in __libc_start_main ??:0:0
          #16 0x5638521e2b09 in _start ??:0:0
      
      Original change's description:
      > Disable Android IMEs according to given ImeInfo.
      > 
      > Android IMEs can be disabled in Android side by using 'ime' command.
      > This CL ensures that disabled IMEs are also disabled in Chrome OS's
      > InputMethodManager.
      > 
      > Bug: b/119274469
      > Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1331294
      > Reviewed-by: Yusuke Sato <yusukes@chromium.org>
      > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#607473}
      
      TBR=yusukes@chromium.org,yhanada@chromium.org
      
      Change-Id: I5fd93607e711cd90edc4eb0ccf656b4c82ad5555
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: b/119274469
      Reviewed-on: https://chromium-review.googlesource.com/c/1333892Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Scott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607610}
      cb4796d8
    • Jun Choi's avatar
      Plumb FidoAuthenticator::IsPaired() to embedder · 4d10954f
      Jun Choi authored
      WebAuthN UI modal should only show Bluetooth security keys in device
      selection modal if the security key is in pairing mode and not already
      paired. As so, plumb FidoAuthenticator::IsPaired() to WebAuthN Chrome
      embedder layer.
      
      Bug: 877344
      Change-Id: I214ef45b833cbf3c9258be10b4a83b43f4b51167
      Reviewed-on: https://chromium-review.googlesource.com/c/1319631
      Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
      Reviewed-by: default avatarKim Paulhamus <kpaulhamus@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607609}
      4d10954f
    • Elly Fong-Jones's avatar
      views: fix IconLabelBubbleView accessibility properties · c5c2f0c0
      Elly Fong-Jones authored
      IconLabelBubbleView is a Button and should use Button::GetAccessibleNodeData,
      not Label::GetAccessibleNodeData. Setting its button text causes the right
      behavior here.
      
      Before: "This site is using your location."
      After: "This site is using your location. Button."
      
      Maybe ideally: "This site is using your location. Manage location access.
                     Button."
      
      ... but that requires new strings.
      
      Bug: 879014
      Change-Id: I7b4840e17ea70eede41ee0b3095a8a2de288c6ea
      Reviewed-on: https://chromium-review.googlesource.com/c/1331668
      Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
      Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
      Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#607608}
      c5c2f0c0