GitLab

This is a reland of 9f1eb0ba

The only change from the original cl is in cc/test/layer_tree_test.cc,
so TBRing reviewers who approved other parts of this cl.
TBR=dcastagna@chromium.org,piman@chromium.org,ericrk@chromium.org

Original change's description:
> Switching all ui/gl dependent tests to SwiftShader
>
> This cl's switches cc_unittests and viz_unittests from OSMesa
> to SwiftShader and fixes other issues related to that change.
>
> Bug chromium:848035
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ib1b58e02d4df4a687ef7be57284c06097bdeca94
> Reviewed-on: https://chromium-review.googlesource.com/1070490
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572442}

Change-Id: I85f723ed8a8f7d981a9652cd7979c54d0f1248ae
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1125899
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572623}

Prior to this CL, an impl-side child allocated LocalSurfaceId would cause
a spurious commit on the main thread as the new LocalSurfaceId propagates its
way back to the main thread from the parent renderer.

LayerTreeHost::SetLocalSurfaceIdFromParent really only cares about changes
to the parent_sequence_number and embed_token to propagate to the impl thread.
Other changes are irrelevant and should not cause commits.

This CL fixes the issue by early exiting in
LayerTreeHost::SetLocalSurfaceIdFromParent. This problem was cause by looking
at SurfaceId flows. This will likely improve scrolling performance a bit on
Android.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide4f9df9d89c70216e9a54dfc6ccd298cf046821
Reviewed-on: https://chromium-review.googlesource.com/1126325Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572622}

Change-Id: I99db5b6c8845502d0d68079fe44e5d31dc805e0f
Reviewed-on: https://chromium-review.googlesource.com/1126204Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572621}

Code coverage showed that we were missing a test case for the
document.policy object where the state of a feature which is
on-by-default but not mentioned in any policies is queried.

Change-Id: Icd77f4763e80ea0746692f6bc660a11b4d444263
Reviewed-on: https://chromium-review.googlesource.com/1126203Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572620}

It should never be necessary to force a commit when a content_source_id changes.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I58bd6d840feca9df58bd674e2a42cf987bba2ed5
Bug: 847383, 672962
Reviewed-on: https://chromium-review.googlesource.com/1124760Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572619}

SurfaceView(s) used by the CompositorSurfaceManagerImpl are normally
attached during the inflation of the CompositorView. Normally that is
before the first draw of the application window happens (in
Activity#OnCreate). However, if the inflation is delayed (if it happens
on a background thread), this means that the SurfaceView is attached
after a draw event has occurred.

At the time of the first attach of a SurfaceView to the view hierarchy
(regardless of the SurfaceView's actual opacity), the window
transparency hint changes (because the window creates a transparent hole
and attaches the SurfaceView to that hole). This may cause older android
versions to destroy the window and redraw it causing a flicker. This one
line CL sets the window transparency hint early so that when the
SurfaceView gets attached later, the transparency hint need not change
and no flickering occurs.

Also removes misleading comments added earlier when this bug was not understood
well enough.

Bug: 855888,704866
Change-Id: If213b238a708fe1da5fce7808b0ec2e8cec4998a
Reviewed-on: https://chromium-review.googlesource.com/1125288Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572618}

This will allow us to move it to blink platform.

IsUseZoomForDSFEnabled() is moved to CompositorDependencies,
and all callsites in content/renderer/ are changed to use
the CompositorDependencies. RenderViewImpl tests are set up
to override CompositorDependencies instead of injecting
command lines into their process.

R=piman@chromium.org

Bug: 838693
Change-Id: Ibccc88af3460d33a092228b95c230ef0236ff408
Reviewed-on: https://chromium-review.googlesource.com/1125172
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572617}

This is a reland of CL:1069411 (which has been reverted in CL:1094734)
Original Author is dgozman@chromium.org.

Added a helper to ChromeDevToolsManagerDelegate and DevToolsWindow
to check whether inspection is allowed. This helper is used to:
- not open DevToolsWindow;
- not show "Inspect Element" context menu item;
- disable DevTools-related browser commands;
- not show inspectable views on chrome://extensions;
- not show extensions on chrome://inspect.

RenderFrameDevToolsAgentHost also disallows attaching a debugging session
when embedder says so to prevent exposure over protocol or remote debugging.

TBR=avi@chromium.org,rdevlin.cronin@chromium.org
(TBR-ed due to no changes in OWNER-ed files this reland CL since the original
 CL:1069411)

Bug: 838146
Test: browser_tests --gtest_filter=DevToolsSanity*Policy*
Change-Id: I2c26bce4f0be57e8b526b7fff73442712d46d5da
Reviewed-on: https://chromium-review.googlesource.com/1125855
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572616}

https://webrtc.googlesource.com/src.git/+log/57900cb93360..f4aeb891b7aa


git log 57900cb93360..f4aeb891b7aa --date=short --no-merges --format='%ad %ae %s'
2018-07-04 magjed@webrtc.org Android: Handle StartRecording() failure gracefully
2018-07-04 eladalon@webrtc.org Make rtc_event_log2text work on stdin if no input file specified
2018-07-04 saza@webrtc.org Fuzz key presses in APM
2018-07-04 mbonadei@webrtc.org Removing warning suppression flags in common_audio/.
2018-07-04 mbonadei@webrtc.org Removing warning suppression flags from pc/.
2018-07-04 henrik.lundin@webrtc.org NetEq fuzzers: Set max length in BUILD config rather than in the code
2018-07-04 devicentepena@webrtc.org AEC3: Reverberation model: Changes on the decay estimation.
2018-07-04 philipel@webrtc.org Add ParsedPayload::video_header() accessor.
2018-07-04 sprang@webrtc.org Add experimental shortened 2-temporal-layer setting
2018-07-04 henrik.lundin@webrtc.org Limit fuzzer input size for comfort noise decoder fuzzer
2018-07-04 philipel@webrtc.org Remove non-implemented function signatures from RtpFrameReferenceFinder.
2018-07-04 mbonadei@webrtc.org Adding CheckNoWarningSuppressionFlagsAreAdded.
2018-07-04 gustaf@webrtc.org AEC3: Simplified suppression gain calculation
2018-07-04 asapersson@webrtc.org webrtcvideoengine_unittest: Use RtpHeaderParser class for parsing rtp header.
2018-07-04 buildbot@webrtc.org Roll chromium_revision 79cbcdf6..1a589010 (572378:572487)


Created with:
  gclient setdep -r src/third_party/webrtc@f4aeb891b7aa

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:none,chromium:857404,chromium:none,chromium:none,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I12c95d6fada56c5ceff5060115663d69af0d1a2d
Reviewed-on: https://chromium-review.googlesource.com/1126286Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572615}

If user left button down then move cursor out of scrollbar then middle
button down, we would not clear the last_scrollbar_under_mouse_.

Bug: 852943
Change-Id: I1546fa201f0ab8cda77d8444f51b97966d3d68f8
Reviewed-on: https://chromium-review.googlesource.com/1114181
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572614}

The SimCompositor was mocking out all compositing with its own
implementation of WebLayerTreeView that only overrode a few
setter/getters and provided methods for tests to query state of the
"compositor" as well as a way to do a synchronous BeginMainFrame.

This makes SimCompositor own a RenderWidgetCompositor instead of
implementing WebLayerTreeView, making SimTests run a real composite
step instead of faking it out, and querying state from a real
compositor.

This uncovered that scrollbars are painting on throttled child frames
even though layout has not been done, which is pointless work and/or
problematic.

Platform::IsThreadedAnimationEnabled() was returning true in unit
tests with a synchronous compositor, and thus where threaded animations
do not in fact run. The RenderWidgetCompositor and SimCompositor used
to work around this by returning a null AnimationHost in this scenario.
Instead of production code having to deal with a null AnimationHost,
which is not clear about intent at all, we should make
IsThreadedAnimationEnabled() accurate.

A few changes were needed to make this happen:
1. An accessor on the compositor to tell if a main frame has been
requested.
2. An accessor on the compositor to tell if commits are deferred.
3. Scrollbars stop painting when their frame is throttled.
4. SimCompositor becomes a RenderWidgetCompositorDelegate, to make
a LayerTreeFrameSink and respond to BeginMainFrame.
5. SimCompositor::MainFrame() now asks the actual compositor to do
a synchronous Composite. It does so to the LayerTreeHost directly
in order to specify the "now" TickTicks.
6. Platform::IsThreadedCompositingEnabled() is dead, so goodbye.
7. Platform::IsThreadedAnimationEnabled() returns true, but is
overriden when appropriate in tests to be false (when synchronous
compositing is being used).
8. RenderWidgetCompositorFactory allows a test to specify a
delegate so that SimCompositor can be the delegate.

R=bokan@chromium.org, dcheng@chromium.org
TBR=piman

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3486abd740874cb2403b5b54e596ddffd8a00bd0
Reviewed-on: https://chromium-review.googlesource.com/1125149
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572613}

Mostly s/double/TimeDelta/ and Method() to MethodDelta(). The
kNextFireIntervalInvalid constant is changed to TimeDelta::Min().

Bug: 763980
Change-Id: I878a4136edcfe815184e7021a19eefffbc02fd31
Reviewed-on: https://chromium-review.googlesource.com/1125919Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#572612}

Per design recommendation, this CL adjusts the color and alpha of the
tab grid page control.

Bug: 849646
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2fe6c4709994f8c763e76c1960afe096305b460
Reviewed-on: https://chromium-review.googlesource.com/1122117Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572611}

https://android.googlesource.com/platform/external/perfetto.git/+log/24b373394918..d91316e9576a


git log 24b373394918..d91316e9576a --date=short --no-merges --format='%ad %ae %s'
2018-07-04 dproy@google.com Merge "Clang-format typescript"
2018-07-04 dproy@google.com Clang-format typescript


Created with:
  gclient setdep -r src/third_party/perfetto@d91316e9576a

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:111101465
TBR=perfetto-bugs@google.com

Change-Id: I010c16c18bca2f12ada5f51d4f76c35433a38cff
Reviewed-on: https://chromium-review.googlesource.com/1126284
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572610}

Also adds:
-fuzzing support for protos at components/autofill/core/browser/proto
-ProcessQueryResponse method to FormStructure class.

Bug: 834707
Change-Id: I831e012c0a5569f663d6bd435c7c24d7a6f6a524
Reviewed-on: https://chromium-review.googlesource.com/1125847
Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572609}

https://chromium.googlesource.com/angle/angle.git/+log/2b06054dd41f..a72ebeba2127


git log 2b06054dd41f..a72ebeba2127 --date=short --no-merges --format='%ad %ae %s'
2018-07-04 lucferron@chromium.org Vulkan: Fix issue in DynamicBuffer


Created with:
  gclient setdep -r src/third_party/angle@a72ebeba2127

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I027796c6757d1700121d62b7fce04660991b33a4
Reviewed-on: https://chromium-review.googlesource.com/1126282Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572608}

It DCHECKs that it is the graph owner already.

Bug: 856641
Change-Id: I7bad00ac4955f502826d5a0cdafbf0f24cd87a2e
Reviewed-on: https://chromium-review.googlesource.com/1118973
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572607}

When a stale resource is detected a subsequent request will be queued
via a StaleRevalidateResourceClient. When the subsequent resource
fetch completes it will be removed from the MemoryCache.

Design: https://docs.google.com/document/d/1wqbhCdf3eCv-VuUoV34xD2KfMinOCxH4fRe5EDCtXIo/edit

BUG=348877

Change-Id: I27ba8f295fe070e7a34eed7a362921ab4ce544cf
Reviewed-on: https://chromium-review.googlesource.com/1103064
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572606}

Change-Id: I8a14e62e8502dd813f1bed8a447dbb53945d827e
Reviewed-on: https://chromium-review.googlesource.com/1126254
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572605}

ScopedFeatureList must be initialized before testing any feature.
https://cs.chromium.org/chromium/src/base/test/scoped_feature_list.h?l=26

If it is not initialized, any feature is tested in the global
FeatureList, which could lead to bad interaction between tests.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic2bfba36312cbebb5c0abadaf1074f7eaff37d9a
Reviewed-on: https://chromium-review.googlesource.com/1126102Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572604}

This reverts commit ce5f0c23.

Reason for revert: presumably caused crashes on internal tests
(see https://crbug.com/860250 and https://crbug.com/860268 for
builder links).

Original change's description:
> Roll HarfBuzz to 1.8.2 plus build fix
> 
> https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/957e7756634..2cb075fe26
> 
> Contains a fix for Khmer shaping.
> 
> Bug: 847034
> Change-Id: I0ac1fdf4df69e5c5dd3cc8a877809db99ce40fda
> Reviewed-on: https://chromium-review.googlesource.com/1123826
> Reviewed-by: Ben Wagner <bungeman@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572188}

TBR=bungeman@chromium.org,kojii@chromium.org,drott@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 847034, 860250, 860268
Change-Id: Icd36bffb962ca04e99eda0c56779ce1a21b4ce26
Reviewed-on: https://chromium-review.googlesource.com/1126339Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572603}

Effectively remove all dependencies to blink in VR browsing code.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I18214e1009be86bc665b6679c0e5b50224746e1a
Reviewed-on: https://chromium-review.googlesource.com/1114692Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572602}

Use the correct color scheme instead of always using incognito color
scheme when setting the placeholder color.

Bug: 859553
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If6146f5b9f0c0c16833d058e9a5b12534314a09b
Reviewed-on: https://chromium-review.googlesource.com/1126100Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572601}

This will hopefully catch issues where RasterDecoder instructs the
driver to make bad memory accesses (e.g. glTexImage2D with data =
nullptr and GL_PIXEL_UNPACK_BUFFER set inappropriately). The current
gpu_raster_fuzzer target uses a stub GL implementation and won't catch
these errors.

Bug: 856208
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iea7dac66ef051a82af38ca2dde3e8374187f21ba
Reviewed-on: https://chromium-review.googlesource.com/1125141
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572600}

CursorBreakIterator is now used on shaping, but the ICU
RuleBasedBreakIterator isn't thread-safe. This CL makes it thread-local.

Bug: 473476
Change-Id: Ibb55f0a8301efc8281d1f968d5467171941b0d5d
Reviewed-on: https://chromium-review.googlesource.com/1125151Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572599}

Bug: 851318
Change-Id: I314fea352b79d012f9b8d8453ceb8a46783dc66e
Reviewed-on: https://chromium-review.googlesource.com/1121322Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572598}

The old sign-in page requres component extensions. The unittest needs
to create the ExtensionService before loading the page.

Bug: 859438
Change-Id: I22296316346ee0f7e780babd6125cf388e920d03
Reviewed-on: https://chromium-review.googlesource.com/1125210Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572597}

It was incorrectly set to the view rect of the containing LayoutView.
Also fixed a similar accessibility bug along the way.

Bug: 859461

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I443bb56b2e8fac06a6af2efe4e9d3ec3ff6a9556
Reviewed-on: https://chromium-review.googlesource.com/1125510
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#572596}

Video of updated animations:
  https://drive.google.com/file/d/1ihIjMdIJaYjke9l8nb-2dHL_e4iMc8vk/view?usp=sharing

This CL updates the transition animations to and from the tab grid as described
in the referenced bug. Instead of the entire grid zooming in and out, the
updated transition only zooms the active tab/cell, keeping other animations in
the grid more subtle.

To support the updated animations, the GridTransitionLayout and
GridTransitionItem classes have some new properties (and GridCell has some
additions to support them):

 - GridTransitioLayout now has an expandedRect property which defines the rect
that the selected tab should occupy when expanded.
 - GridTransitioLayout now has a selectionItem property to define an item that
show the selection state of the selected tab/cell while being separate from the
selectedItem itself. This allows the selection ring to be animated (or not)
independently of the selected item.
 - GridSelectionItem defines an auxillaryView (a subview of the item's |cell|)
that may be animated; GridCell esposes its top bar for this purpose.

The animations performed by GridTransitionAnimation are changed to use
UIViewPropertyAnimators. This requires significant changes inside that class,
but it  also simplifies some parts of its API:
 - The property animator(s) used by GridTransitionAnimation are exposed as a
single |animator| property; internally it's a PropertyAnimatorGroup, but it's
exposed as an id<UIViewImplicitlyAnimating>, which is sufficient for animations
to be run.
 - There is no longer a GridTransitionAnimationDelegate. Completion handlers may
be added to the animator property by interested party.
 - Duration is set on the GridTransitionAnimation when it's initialized, not
when it's animated.
 - Partial animations (that is, property animations that are either delayed
relative to the whole animation, or which run for a shorter duration than the
whole animation) are build using keyframe animations, as recommended by Apple.
Since this involves triple-nesting blocks, a helper method is added to
GridTransitionAnimation for this; it may be cleaner in the long term to add this
to PropertyAnimatorGroup.
 - The TabGridViewController no longer applies a translation to its toolbars as
it appears/disappears; instead it fades the toolbars in and out.
 - The GridToVisibleTab and TabToGrid animators use the BVC's named content area
guide to determine the expandedRect of the animation; assuming the snapshots are
all up to date, this will be a pixel-perfect match.
 - The GridToVisibleTab and TabToGrid animators (for now) don't animate the BVC
in/out at all; it simply appears (or disappears) at the end (or beginning) of
the animation. See the follow-up steps section, below, for more information.

Other small changes:

- Makes the grid cell contents background the same as the cell header background
so it looks correct when the cell header is faded out in animations.
- Removes all reference to the "regular" and "expanded" tab grids, since that's
no longer a meaningful distinction.
- Tightens up and clarifies (hopefully) the comments describing all of the parts
of the animations.

Follow-Up Steps:

The major piece of follow-up for this CL is to have the BVC's contents animate
alongside this transition so that the toolbars can be faded out and there can be
a cross-fade to the web contents (which makes it cleaner when the snapshot
doesn't match the final web content).

Bug: 850507
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I14dd4aa97bec4e42ddff4ae903d6c4ce0931650b
Reviewed-on: https://chromium-review.googlesource.com/1118547
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572595}

https://chromium.googlesource.com/catapult.git/+log/5abd99f5f768..82213060d5ce


git log 5abd99f5f768..82213060d5ce --date=short --no-merges --format='%ad %ae %s'
2018-07-04 perezju@chromium.org [Telemetry] Add flush-tracing and sync markers on first tab only
2018-07-04 perezju@chromium.org [dashboard] Skip flaky ListTestSuitesTest.testPartialTestSuites


Created with:
  gclient setdep -r src/third_party/catapult@82213060d5ce

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:854212,chromium:860103
TBR=sullivan@chromium.org

Change-Id: I964cb29eb623c77634a2b66357acdf4d71f852e2
Reviewed-on: https://chromium-review.googlesource.com/1126281Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572594}

V3 of the supersize UI design adds alternate groupings using component.
The tree treats each component as a folder seperated by ">" signs. For example,
if a symbol belongs to Internal>Android, the tree view would include an Internal
node containing an Android node, which would contain the symbol.

To reduce noise, symbols are still grouped by directory within the component
groups.

https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-04/?group_by=component

Bug: 847599
Change-Id: Ifc9cb2c58f3937fe849f8004360021d5f9143512
Reviewed-on: https://chromium-review.googlesource.com/1125264
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572593}

I'm about to duplicate that line in
https://chromium-review.googlesource.com/c/chromium/src/+/1106434
and it feels silly to clobber |recent_time_| since TimeTicks is
monotically increasing regardless of nested loops (cloberring it is at
best irrelevant and at worse forces an unecessary recomputation of
Now()).

R=danakj@chromium.org, kylechar@chromium.org

Bug: None
Change-Id: Ia11ca15fcde850fba5cc33bc1cbac68386495719
Reviewed-on: https://chromium-review.googlesource.com/1125168Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572592}

MessageLoop::AddTaskOserver now has a thread-affine DCHECK

Caught while running base_perftests.exe locally, too bad waterfall
doesn't run these (even if not analyzing actual perf results).

R=danakj@chromium.org, kylechar@chromium.org

Bug: 860252
Change-Id: I6d09f29bea7e56e1b315c1d5789b4c1cd65b9abb
Reviewed-on: https://chromium-review.googlesource.com/1126320Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572591}

Also remove cwallez from gpu_passthrough_cmd_decoder.

BUG=chromium:852089
TBR=kainino@chromium.org

Change-Id: I621140d8986af6380325a6ce841a7929ae1c63b8
Reviewed-on: https://chromium-review.googlesource.com/1126308Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572590}

This CL fixes a potential race when the user starts navigation at the
same time as the bloated renderer is being reloaded. The race may
cause the infobar to be shown on user navigation, which is misleading.

Now the navigation id is saved for the bloated renderer reload and
later on it is matched with the navigation id provided to the
DidFinishNavigation event. The infobar is shown only if the ids match.

Bug: 808143
Change-Id: I1e3c37e565e1434b6ab5557df44281fb418c6e12
Reviewed-on: https://chromium-review.googlesource.com/1106619
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572589}

Change-Id: Iae40af3d5ab3ecb3a9f41443359a069424ddacb6
Reviewed-on: https://chromium-review.googlesource.com/1126253
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572588}

Change-Id: I522d8ef23a39e78c687dfcff6f8e69dd1c5cf662
Reviewed-on: https://chromium-review.googlesource.com/1125067Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#572587}

We are shortly going to change the semantics of
GaiaCookieManagerService::ListAccounts() to populate its out-params even
in the case where it returns false to indicate that the accounts are
stale. A search through the codebase shows a minimal number of
production callsites that call ListAccounts() outside of an if
condition:

blundell:src(change_signin_ui_util) $  git grep "\<ListAccounts(" | grep -v "if (" | grep -v unittest
(standard input):1:(standard input):3:chrome/browser/signin/signin_ui_util.cc:    bool cookie_accounts_valid = cookie_manager_service->ListAccounts(
(standard input):2:(standard input):6:components/browser_sync/profile_sync_service.cc:      gaia_cookie_manager_service_->ListAccounts(
(standard input):7:(standard input):13:components/signin/core/browser/gaia_cookie_manager_service.cc:bool GaiaCookieManagerService::ListAccounts(
(standard input):8:(standard input):14:components/signin/core/browser/gaia_cookie_manager_service.h:    // to ListAccounts(). The GCMS will delay calling ListAccounts if other
(standard input):9:(standard input):15:components/signin/core/browser/gaia_cookie_manager_service.h:  bool ListAccounts(std::vector<gaia::ListedAccount>* accounts,

An examination of the two production callsites listed above shows that
ProfileSyncService actually does guard its usage in an if-condition, just
spread over multiple lines. SigninUiUtil, however, does not. This CL
changes SigninUiUtil to explicitly depend on the current behavior of
GaiaCookieManagerService::ListAccounts() so that its behavior won't
change when we change the semantics of
GaiaCookieManagerService::ListAccounts().

Bug: 859882
Change-Id: I8ee63b980edc9f6a2980d3a46702a72f93307ee4
Reviewed-on: https://chromium-review.googlesource.com/1126257
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572586}

Chrome sign-in passwords shouldn't be saved, so Chrome sign-in form
sholdn't be skipped. On CL
https://chromium-review.googlesource.com/c/chromium/src/+/979932 it was
implemented skipping this form in the renderer process. As result
password hash can't be saved. This CL implements skipping such form
in the browser process. As positive side effects, it adds checking
whether to save a password in ShowManualFallbackForSaving, that
avoids to show manual fallback for sync credentials for any form.

Bug:852205

Change-Id: I4d749aecdb57dab03b7928f551f41c015490da56
Reviewed-on: https://chromium-review.googlesource.com/1120342
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572585}

https://skia.googlesource.com/skia.git/+log/233c65202e69..cdefa23a23cf


git log 233c65202e69..cdefa23a23cf --date=short --no-merges --format='%ad %ae %s'
2018-07-04 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 539468cef869..517a57f4ba88 (3 commits)


Created with:
  gclient setdep -r src/third_party/skia@cdefa23a23cf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: Ia5ece05b68cf6b5806efe2b74f4348e163d3c9c2
Reviewed-on: https://chromium-review.googlesource.com/1126280Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572584}