GitLab

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the completion of loading
the Link Doctor error page would be at race with that of subsequent navigations
initiated in the test, leading to flakiness.

BUG=637415,700514

Review-Url: https://codereview.chromium.org/2754173003
Cr-Commit-Position: refs/heads/master@{#457796}

Review-Url: https://codereview.chromium.org/2761493002
Cr-Commit-Position: refs/heads/master@{#457795}

https://skia-review.googlesource.com/c/9835/

BUG=skia:6366
NOTRY=True

Review-Url: https://codereview.chromium.org/2750403005
Cr-Commit-Position: refs/heads/master@{#457794}

CreateGaiaAuthFetcher interface expects the caller to take ownership of the
returned pointer. This CL makes this fact obvious and self-documented by
changing return type to unique_ptr<GaiaAuthFetcher>.

BUG=702574

Review-Url: https://codereview.chromium.org/2757873002
Cr-Commit-Position: refs/heads/master@{#457793}

crrev.com/2749873002 moved Ozone GPU initialization away from gl init and
it now need to be explcitly called before initializing GL.

This CL explicitly initialize Ozone platform in exo wayland clients.

TBR=reveman@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2750173006
Cr-Commit-Position: refs/heads/master@{#457792}

Without this fix, if the mojom target containing mojom::Foo is linked into a
component, mojom::Foo::Deserialize() doesn't work outside of that component.

The reason is that the method calls mojom::Foo_Data::Valiate() which is not
exported.

BUG=702397

Review-Url: https://codereview.chromium.org/2754003005
Cr-Commit-Position: refs/heads/master@{#457791}

BUG=702641
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2757893002 .
Cr-Commit-Position: refs/heads/master@{#457790}

R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2756163002
Cr-Commit-Position: refs/heads/master@{#457789}

https://pdfium.googlesource.com/pdfium.git/+log/ce88e77e62d8..adee4859cdb4

$ git log ce88e77e6..adee4859c --date=short --no-merges --format='%ad %ae %s'
2017-03-17 npm Cleanup in fx_agg_driver part 2

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2753163003
Cr-Commit-Position: refs/heads/master@{#457788}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f8189977..d92eee0f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2754273002
Cr-Commit-Position: refs/heads/master@{#457787}

On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame
count variables |total_frame_count_| and |dropped_frame_count_|. In this CL
We make those two variables atomic.

BUG=701712

Review-Url: https://codereview.chromium.org/2751353003
Cr-Commit-Position: refs/heads/master@{#457786}

The Categories can have an additional action, fetch or view all.
For now they are represented as two different bool. It is unclear if they can
be set at the same time or not. They are also display on the UI with the same
text "More".
This CL creates a new API to expose them.

BUG=none

Review-Url: https://codereview.chromium.org/2751093003
Cr-Commit-Position: refs/heads/master@{#457785}

This refactoring prepares for wakeup-based throttling and introduction of the WakeupBudgetPool.

R=skyostil@chromium.org,alexclarke@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2754853003
Cr-Commit-Position: refs/heads/master@{#457784}

This CL makes visual improvements to the toolbar inside the tab grid.
- The toolbar is overlaid the tab grid, with a dark blur effect view.
- The toolbar properly responds to status bar height changes
  (such as in-call status, or horizontal no status bar).
- The tab grid contents properly inset according to status bar height changes.

Screenshots:
https://drive.google.com/open?id=0BwS6YyQeisH5MHM4czh6akxwWDQ

BUG=686770

Review-Url: https://codereview.chromium.org/2723453003
Cr-Commit-Position: refs/heads/master@{#457783}

We're close to replace FullLTO and CFI with FullLTO with
their ThinLTO counterparts. This should reduce linking time
by 2x-3x, and open a road for even better gains.

This particular change sets up a bot that tests for CFI+ThinLTO.
Eventually, when we switch the desktop build to ThinLTO, we'll
retire all ThinLTO bots and make CFI/LTO bots to imply ThinLTO.

BUG=660216

Review-Url: https://codereview.chromium.org/2759443002
Cr-Commit-Position: refs/heads/master@{#457782}

When the NativeAppsCollectionViewController's parent controller is dismissed,
|isMovingFromParentViewController| is false.
The consequence is that the NativeAppsCollectionViewController was not unregistering itself from the InstallationNotifier. This led to crashes.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541

Review-Url: https://codereview.chromium.org/2760643002
Cr-Commit-Position: refs/heads/master@{#457781}

BUG=None
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2758663004
Cr-Commit-Position: refs/heads/master@{#457780}

Revert of PlzNavigate: Enforce 'frame-src' CSP on the browser. (patchset #23 id:790001 of https://codereview.chromium.org/2655463006/ )

Reason for revert:
Possibly broke browser_side_navigation_content_browsertests.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin10_Tests_x64%2F9276%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_content_browsertests_on_Windows-10-10586%2F0%2Flogs%2FSitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromHeaders%2F0

Original issue's description:
> PlzNavigate: Enforce frame-src CSP on the browser.
>
> Use a NavigationThrottle to check infringement of the 'frame-src' on the
> browser-side. Before this patch, a redirect during the navigation could
> led to a child frame to be displayed inside its parent, even if it was
> disallowed by its parent.
>
> BUG=685074
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel
>
> Review-Url: https://codereview.chromium.org/2655463006
> Cr-Commit-Position: refs/heads/master@{#457757}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e3b610bfff1acd060ed8b3f595344402b833bad

TBR=nasko@chromium.org,alexmos@chromium.org,clamy@chromium.org,creis@chromium.org,nick@chromium.org,dcheng@chromium.org,arthursonzogni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=685074

Review-Url: https://codereview.chromium.org/2754303002
Cr-Commit-Position: refs/heads/master@{#457779}

Also, allow configuring the interstitial via URL query parameters
instead of reading them from the profile.

Review-Url: https://codereview.chromium.org/2755733002
Cr-Commit-Position: refs/heads/master@{#457778}

BUG=671420

Review-Url: https://codereview.chromium.org/2753143002
Cr-Commit-Position: refs/heads/master@{#457777}

This CL renames PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_
and, more importantly, changes its type from (a unique_ptr to) FormFetcherImpl
to just FormFetcher. The PasswordFormManager does not use the "Impl" part
anyway, and the more general type is necessary for coming changes.

BUG=621355

Review-Url: https://codereview.chromium.org/2750363004
Cr-Commit-Position: refs/heads/master@{#457776}

Generating benchmark name with code makes it hard to code search for a benchmark.

Review-Url: https://codereview.chromium.org/2752273002
Cr-Commit-Position: refs/heads/master@{#457775}

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019

Review-Url: https://codereview.chromium.org/2746223002
Cr-Commit-Position: refs/heads/master@{#457774}

BUG=166704

Review-Url: https://codereview.chromium.org/2748393002
Cr-Commit-Position: refs/heads/master@{#457773}

Using wpt-import in Chromium 6f8c23bd.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/8014

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/html
jsbell@chromium.org:
  external/wpt/common
suzyh@chromium.org:
  external/wpt/web-animations

TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: I8294ca176bd28212fadcf0c49a42e991036b9fa7
Reviewed-on: https://chromium-review.googlesource.com/456677Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457772}

This CL adds MediaStreamTrack.applyConstraints()
method behind a flag (that is implied if ImageCapture
is on).  The method essentially derives to
ImageCapture::setMediaTrackConstraints(); this one
prepares a mojo::PhotoSettings and applies it via
mojo interface.

Only simple Constrains are supported now, i.e.,
{zoom : 3.14} is supported, but {zoom : { ideal : 100}}
or {zoom : { exact : 27}} are not (TBD later).

LayoutTests are added where appropriate.

Also a cleanup: methods that return Promises are not
supposed to throw exceptions; so I removed an unused
ExceptionState from some ImageCapture methods.

applyConstraints() when called without the optional
argument |constraints|, and is supposed to do... nothing?
Filed Spec bug:
https://github.com/w3c/mediacapture-main/issues/438

BUG=700607

Review-Url: https://codereview.chromium.org/2757673005
Cr-Commit-Position: refs/heads/master@{#457771}

Absolutify the links, per https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md
documenting support, fix a mailto link (which auto-linking broke), and
fix a '/` typo

BUG=700973
TBR=eranm@chromium.org

Review-Url: https://codereview.chromium.org/2758763002
Cr-Commit-Position: refs/heads/master@{#457770}

Hidden behind a flag, so no user-visible changes yet.

BUG=690467

Review-Url: https://codereview.chromium.org/2749813002
Cr-Commit-Position: refs/heads/master@{#457769}

BUG=701451
TBR=fukino@chromium.org

Review-Url: https://codereview.chromium.org/2748383006 .
Cr-Commit-Position: refs/heads/master@{#457768}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7b2dc0f0d467..689eddc13b0f

$ git log 7b2dc0f0d..689eddc13 --date=short --no-merges --format='%ad %ae %s'
2017-03-17 nednguyen Remove oomkiller_profiler

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2749383004
Cr-Commit-Position: refs/heads/master@{#457767}

BUG=700973

Review-Url: https://codereview.chromium.org/2756633002
Cr-Commit-Position: refs/heads/master@{#457766}

Also removed PendingIndexNavigationDisabled experimental setting.

BUG=692331,701717
TEST=Back forward navigation works correctly.

Original Review-Url: https://codereview.chromium.org/2751793002

Review-Url: https://codereview.chromium.org/2756753002
Cr-Commit-Position: refs/heads/master@{#457765}

Replaced with WebStateObserver::DidSuppressDialog callback.

In content dialogs suppression is implemented via a single callback:
WebContentsDelegate::ShouldSuppressDialogs. This callback is called
before showing a dialog.

On iOS implementing the same API would require a roundtrip
(JS->Native->JS). This is because WKWebView does not provide any
callbacks for showing geolocation dialogs. So on iOS dialogs blocking is
implemented in JS as a boolean flag which is set by
WebState::SetShouldSuppressDialogs. Embedder still needs a callback to
know if the dialog was suppressed which is implemented as
WebStateObserver::DidSuppressDialog and require only one JS->Native
message.

BUG=674991

Review-Url: https://codereview.chromium.org/2755013002
Cr-Commit-Position: refs/heads/master@{#457764}

https://skia.googlesource.com/skia.git/+log/73e21af21390..a392dbaa998e

$ git log 73e21af21..a392dbaa9 --date=short --no-merges --format='%ad %ae %s'
2017-03-16 bsalomon Revert "Revert "Revert "Revert "Detect Chrome either by renderer or version strings.""""
2017-03-17 reed Revert "More SkVertices implementation work"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: I14dd58faedbdeecdfe87319012a5750fd46de375
Reviewed-on: https://chromium-review.googlesource.com/456620Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457763}

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
However, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786

Review-Url: https://codereview.chromium.org/2757563006
Cr-Commit-Position: refs/heads/master@{#457762}

BUG=none

Review-Url: https://codereview.chromium.org/2756733003
Cr-Commit-Position: refs/heads/master@{#457761}

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the active and inactive state (shadow_controller.cc) instead of just the inactive state.
- make the contents of the info bubble a single, multi-line, selectable label. To be selectable, the bubble must be activatable. This is somewhat trickier because the system menu bubble wants to close itself whenever activation changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system bubble closes, when the user presses the back arrow, or when the user presses the (i) again.

BUG=676395,341706

Review-Url: https://codereview.chromium.org/2754963002
Cr-Commit-Position: refs/heads/master@{#457760}

This migrates the variables in chromeos.gyp to BUILD.gn, making the
source easier to read. This also lets us remove a use of exec_script, so
chromeos/BUILD.gn no longer has to be whitelisted to use it.

BUG=701617

Review-Url: https://codereview.chromium.org/2753883002
Cr-Commit-Position: refs/heads/master@{#457759}

This CL relaxes the precision of a floating-point comparison made in the
zoom browsertest to avoid spurious test failures.

BUG=702269

Review-Url: https://codereview.chromium.org/2761473002
Cr-Commit-Position: refs/heads/master@{#457758}

Use a NavigationThrottle to check infringement of the 'frame-src' on the
browser-side. Before this patch, a redirect during the navigation could
led to a child frame to be displayed inside its parent, even if it was
disallowed by its parent.

BUG=685074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2655463006
Cr-Commit-Position: refs/heads/master@{#457757}