- 17 Mar, 2020 40 commits
-
-
Antonio Gomes authored
This CL is the final effort in order to unify both media_devices.typemap and media_devices_for_blink.typemap definitions. BUG=704136 R=guidou@chromium.org Change-Id: I4a004f08eb863984c82d63e23c84dd4884fa7f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105795 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#750952}
-
Brian Liu Xu authored
Implements support for |kIgnored| in |AXVirtualView| so that elements with role or state |kIgnored| are hidden from the accessibility tree without affecting their contents. When an element has |kIgnored| set, that means that its accessible node should not be exposed to the platform. Thus, the accessibility tree shows its descendants instead of the ignored node. |kIgnored| should not be confused with |kInvisible|. Invisible nodes can still appear in the accessibility tree, and the invisible state is inherited by descendant nodes; they are hidden in the sense that a special state is reported to screen readers that understand it. In contrast, ignored nodes do not appear in the accessibility tree, and the state is not inherited; they are hidden in the sense that they are not exposed at all to the platform. This change is a prerequisite to eliminating the hidden root node of |TreeView| so that screen reader users can access descendant nodes using the review cursor. |TreeView| currently uses |kInvisible| to hide the root node, but that results in the entire subtree becoming invisible to screen reader users. We plan to make a subsequent change to move the root node from |kInvisible| to |kIgnored|. Bug: 811277 Change-Id: I9f30c6cc479c64919d1a3c4397a9455d4f1f1988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103714 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750951}
-
W. James MacLean authored
EnrollmentRecoveryTest.DifferentDomain and EnrollmentRecoveryTest.Success are very flakey on linux-chromeos-dbg. Disabling for now. TBR=rsorokin@chromium.org Bug: 1062248 Change-Id: I0af356e279721ff964116d1d9bc8ecbd549df51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107301Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750950}
-
Anders Hartvoll Ruud authored
There was a bug in CascadePriority, when creating priorities with a 'generation'. This constructor was supposed to _set_ the generation, not bitwise-or with the previous generation. Bug: 947004 Change-Id: Ie3471f6a3052c0f3ca8454151a8f46839558d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106064Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#750949}
-
Maxim Kolosovskiy authored
This CL introduces intent verification of a password change flow in order to be sure that a password change flow is triggered by the password manager. The CL does not introduce a triggering itself. Once the proper intent signing is implemented, the verification should be changed (b/151391231). Bug: 1057608 Change-Id: I3f403589e40b729ac2fd3b514d8b7a1d1a5362ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102731Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750948}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23283eb96876..24de19ebe70e git log 23283eb96876..24de19ebe70e --date=short --first-parent --format='%ad %ae %s' 2020-03-17 tvanderlippe@chromium.org Disable NodeURL unittest 2020-03-17 tvanderlippe@chromium.org Disable BezierUI test 2020-03-17 tvanderlippe@chromium.org Disable persistence unit test Created with: gclient setdep -r src/third_party/devtools-frontend/src@24de19ebe70e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8ae89d1877a240269ca989b0d2af4ac9aad45201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750947}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ba9e1b8b75f3..620bed1c71a4 git log ba9e1b8b75f3..620bed1c71a4 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 phoglund@webrtc.org Remove allbins and story hacks, fix -Infinity. Created with: gclient setdep -r src/third_party/webrtc@620bed1c71a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I85e1104db3e3486f42433223c70ca1bb8c292cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107319Reviewed-by:
-
Andreas Haas authored
With this CL the ArrayBuffer class gets finally removed and completely merged into DOMArrayBufferBase. This required the following changes: * Move the internal fields of ArrayBuffer to DOMArrayBufferBase: array_buffer_contents_ and is_detached_. * Change DOMArrayBufferBase to be based on ArrayBufferContents instead of ArrayBuffer now. * Change the constructors of DOMArrayBuffer and SharedDOMArrayBuffer. * Move the implementation of ArrayBuffer::Transfer to DOMArrayBuffer. * Make ArrayBufferContents copyable. As ArrayBufferContents is just a wrapper around an std::shared_ptr, this is fine. * Add a Detach function to DOMArrayBufferBase which allows to set the is_detached_ flag. R=haraken@chromium.org, ulan@chromium.org Bug: chromium:1008840 Change-Id: I2355ce0a38cf0453af2960b03e7a984dc002d1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106058Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#750945}
-
ckitagawa authored
This is a reland of 88733983 Switching the triggering to onPageLoadFinished() from onHidden() as onHidden() was flaky due to renders going away. We will want to revist this triggering behavior in a follow up. > Previously reverted due to: crbug/1061952 > The onHidden() trigger appears to be flaky due to Renders going away > too soon. Going to have to re-land with either a different test or > alternative triggering option... Original change's description: > [Paint Preview] Tab Service Java side > > This CL implements the Java side integration for the TabService. > > Bug: 1058093 > Change-Id: Iaa8f007a2a16ac10f87466eb7d5d49f05e112576 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090298 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750542} Bug: 1058093 Change-Id: I269ff0ebb8372255d5c0c69a2d9f9bfa886e5838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106258Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#750944}
-
ckitagawa authored
Paint Previews were getting clipped if a scroll occurred before capture. This CL fixes this by applying a transform to fix this behavior. Bug: 1061918 Change-Id: Iff3f461b57cdc95ddcc864cbb006cc20657325b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105397Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#750943}
-
Yifan Luo authored
Bug: 1053540 Change-Id: Ie6e009915c90669719bbdecb803a5d1065be1836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082381 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#750942}
-
Viktor Semeniuk authored
This change adds confirmation dialog when user clicks on remove password button inside menu. Bug: 1047726, 1061088 Change-Id: I0e090c47dddb896cf1a8d6e847ef11f738cfeb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096685 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#750941}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2550e967241f..971a6233c2a4 git log 2550e967241f..971a6233c2a4 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 jiawei.shao@intel.com Validate the declaration of storage texture format in shader Created with: gclient setdep -r src/third_party/dawn@971a6233c2a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I66ec3d8ca2f64d25231b30c976ae9e8a1ef65e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107316Reviewed-by:
-
Elly Fong-Jones authored
This change fixes some markdown syntax issues, variable naming, etc. It also adds mentions of some iOS-specific classes. Bug: None Change-Id: I308088245f8579f59757b03af4d1a6143b808cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105957 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#750939}
-
Michael Ershov authored
This CL splits TpmChallengeKey::BuildResponse method into separate steps: PrepareKey, SignChallenge, RegisterKey. This allows to observe public key that will be used for creating challenge and to register a key without signing challenge. RestoreState allowes to continue attestation flow with a new TpmChallengeKey object. This will be used to observe public key that will be used for serialization. Bug: 1045895 Test: TpmChallenge* Change-Id: I031072027cfd883eff0f69483f73799d970f1cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062130 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750938}
-
Alice Wang authored
This CL makes the pre-native setup and get account number safe inside RequestGenerator. This is a revert of the try-catch part of the CL https://crrev.com/c/2080231. Bug: 1061951 Change-Id: I6944a7e2acf1d295285b153ee2572d8bde9ad26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106053 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#750937}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: I2b0eba4a992c992064f52554012d8913bb2706fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106160 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#750936}
-
Fabian Sommer authored
ChallengeResponseAuthKeysLoader now waits until force-installed login screen extensions are installed before requesting a certificate from these extensions, avoiding an incorrect error message. In order to know which extensions to wait for, stored ChallengeResponseKeys now contain the id of the extension that signed them. ChallengeResponseAuthKeysLoader will only wait for 5 seconds, then the error is displayed anyway (e.g. if the extensions failed to load). This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2078584 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2101749 since a test added in this CL was crashing in debug mode: A ExtensionLoadObserver object which waits on the loading of extensions would, when all extensions had already loaded, indirectly destroy itself in the middle of the function StartWaiting(). This was fixed by ensuring that the function returns after any call that might cause immediate destruction of the object. Test: Compile with is_debug=true and run the browser_tests in this CL. Bug: 1052404 Change-Id: I5b564d05c5da0a075d94772e4698673dcd418cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102651Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#750935}
-
Alex Ilin authored
This CL fixes LiveSignInTest.CancelSync and LiveSignInTest.TurnOffSync. This CL makes IdentityManager update the list of accounts in cookie after an account is logged out and the account reconcilor updates its state. Fixed: 1054167 Change-Id: I7b0b205e00b2a81eedb4e5519ac681aca4d8c9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106174 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#750934}
-
Tanmoy Mollik authored
It doesn't make much sense to abort sign-in if some other account was updated. Moreover, SigninManager doesn't expect sign-in to be aborted at random moments, so it might be left in an unconsistent state. This cl removes onSystemAccountsChanged() method altogether as it just calls the abortSignIn() method inside it. Bug: 1059422 Change-Id: I1320ca10e93879665493473f2eb74148f30c580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094298Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a58084c626ce..c1e52741a15b git log a58084c626ce..c1e52741a15b --date=short --first-parent --format='%ad %ae %s' 2020-03-17 phoglund@google.com Use the same logic for JSON parsing in uncompressed mode. Created with: gclient setdep -r src/third_party/catapult@c1e52741a15b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: crouleau@google.com Change-Id: I442879ae48e39d4f6eec985d8a962f5e99ceeafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107317Reviewed-by:
-
Alex Ilin authored
While working on live tests I discovered that there is no reliable way to observe account deletion from cookies during the log out. AccountReconcilor changes its state to DONE as soon as Gaia log out is started without waiting for the log out request completion. This CL adds missing log out observers to GaiaCookieManagerService and makes AccountReconcilor wait until the log out is done. NOTE: This CL doesn't block AccountReconcilor on log out completion if multilogin endpoint is used. This is left as a TODO in code. Bug: 1054167 Change-Id: If10aede8c5ed10791f4554e91c39526772e075ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832263 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae2152e9..26596343 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1de4176011186a71522726bcf05ae8f6dfafdf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750930}
-
Hwanseung Lee authored
This reverts commit 4143ca0e. Reason for revert: complication error at chrome internal Original change's description: > Clean up the AndroidSetupSearchEngine feature flag > > The AndroidSetupSearchEngine feature is enabled by default > and the config has no effect anymore. > Therefore, remove the config and every reference to > AndroidSetupSearchEngine. > > Bug: 1057939 > Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> > Cr-Commit-Position: refs/heads/master@{#750834} TBR=sky@chromium.org,hs1217.lee@samsung.com,fhorschig@chromium.org Change-Id: I564011f94406cd750d9156b348fc04208e4530cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107336Reviewed-by:
Hwanseung Lee <hs1217.lee@samsung.com> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#750929}
-
Hiroshige Hayashizaki authored
Manual changes: - mixed-content/generic/test-case.sub.js: to accept an array of scenarios. - TestExpectations: to reflect test renames. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: If0b32bdc7796e7df2b9de80e7a33cf3413a69959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103589 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#750928}
-
Hiroshige Hayashizaki authored
Manual changes: - referrer-policy/generic/test-case.sub.js - referrer-policy/4K-1/generic/test-case.sub.js - referrer-policy/4K/generic/test-case.sub.js - referrer-policy/4K+1/generic/test-case.sub.js to accept an array of scenarios. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: I66bcf412557016d985f5bf8ee461cd46f1b46485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102931 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Manual changes: - upgrade-insecure-requests/generic/test-case.sub.js: to accept an array of scenarios. - TestExpectations: to reflect test renames. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: I0dde51e0520a803635493fae549befd1f6f72a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102932 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: -
Andrey Zaytsev authored
This is part of the Friendly Settings Privacy settings redesign. The network prediction toggle is being moved to the new cookies page. See http://slides/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo#slide=id.g64328a826f_0_1 for more context. Implementation review: http://slides/13mIMXvISMXz_I_rRuDeN_qe4RsW49LYhudbSj23owVw#slide=id.p Bug: 1032584, 1061479 Change-Id: I7d418242100ec6c3562fa3841caf1ec0e613bcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105313 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL removed a use of the deprecated ArrayBuffer class. In the |OutgoingStream| class, ArrayBuffer was used to own a byte array and its length. This Cl replaces ArrayBuffer with a small inner class that does exactly that, it stores a byte array and its length. The constructor uses the wtf::Vector allocator to allocate the byte array. R=ricea@chromium.org CC=haraken@chromium.org Bug: chromium:1008840 Change-Id: I21286265eeaabe359ea7709b8d05042c854b7c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102585Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
The OWNERS file can only include Committers. Bug: none Change-Id: I7507cba5c56e6d5ada2eb5ef4bef62736035d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106077Reviewed-by:
-
Antonio Gomes authored
This is the first step to unify media_devices.typemap and media_devices_for_blink.typemap. Basically, the former will be used as-is from Blink when the work done. Note that, the approach could have been backwards, ie use blink.mojom.MediaDeviceTypes throughout the code and remove blink::MediaDeviceTypes, however that would result in a way bigger CL (see [1] for reference), since today blink::MediaDeviceTypes enum item are used mainly for indexing vectors, and blink::mojom::MediaDeviceTypes class enum items can be implicitly converted to int, for similar purposes. [1] https://crrev.com/c/2106015 Since 'blink::mojom::MediaDeviceTypes type' parameter is actually unused in blink::MediaDevices::OnDevicesChange(), it is possible to consider removing the parameter and the blink.mojom.MediaDeviceTypes definition altogether from media_devices.mojom. BUG=704136 R=guidou@chromium.org Change-Id: Id3d42c3bbde30a7dd02b92439b867764e4211073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105794Reviewed-by:
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::InsertBefore| and added test for it. Change-Id: I653902201706e107403308e594356b6bb899db91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106702 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#750921}
-
Rushan Suleymanov authored
Make entity tracker's lifetime same as initial sync done. The tracker won't exist if we still have no data from the server. In this patch also authentication_account_id is not set explicitly for metadata coming from ModelReadyToSync. The behavior for this field becomes similar to cache_guid. If authentication_account_id differs from activation request then the metadata will be reset. Generally it should not affect anything. In the next patch unittests will be added. Bug: 947044 Change-Id: I34a75006d1f31888f8ca485a94538b6dd98923c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038733 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750920}
-
Maksim Ivanov authored
Having the component specified in the OWNERS file allows to route the bug directly to the responsible team during bug triage process. Bug: none Change-Id: I0c9d019ec7e653375f297a27b4578440ed9d631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106573Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#750919}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Ibc2a0eaefdfe20ea1484a464024c184b15306548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105219 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#750918}
-
Maria Petrisor authored
The LoginShelfButtons (Shut down, Browse as Guest and Add Person) are not updated on a locale change issued through a policy change. Both the text language and the alignment of the buttons (in case of RTL) are not updated. LoginShelfView does have an OnLocaleChanged function and adds an observer that are meant to update the buttons, but the function is not triggered when the locale policy changes. This CL adds a function, NotifyLocaleChange, which is called after the language switch (OnLanguageSwitchedCallback) handled in login_display_host_webui.cc. NotifyLocaleChange uses LocaleUpdateController to notify all OnLocaleChanged observers. Both the text and the alignment issues are resolved after adding the proposed changes. Browser tests are also added for checking the Shut down button text, alignment, and the text of an UnifiedSystemTray element. Bug: 1051945, 1054417 Change-Id: Ida6ea782622dacdf118666c64bb908929b4cdb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081820 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#750917}
-
Sylvain Defresne authored
WebStateList is not re-entrant (already asserted by locked_) so there is no point nesting batched operations. Add a bool to ensure this is not the case. Add a method to check whether a batched operation is in progress (could be used internally to also omit sending notification during a batched operation). Bug: 1014526 Change-Id: I6b6dc3278312895a32898d898245f538f9a5264d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089675 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750916}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8bc88340292b..ba9e1b8b75f3 git log 8bc88340292b..ba9e1b8b75f3 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 kthelgason@webrtc.org Fix issue with decoding in certain cases. Created with: gclient setdep -r src/third_party/webrtc@ba9e1b8b75f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2247c7d799550d9eeccd56565a6df16a37a7e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107314Reviewed-by:
-
Camillo Bruni authored
The newly introduced will make the return type of ModuleRecord::Evaluation explicit. Currently an empty v8::Local return value corresponds to a successful evaluation and any returned value is treated as an exception. This is different when top-level await is enabled. In this case ModuleRecord::Evaluation always returns a Promise on success. Thus simply checking for an empty or non-empty v8::Local is no longer sufficient and we need a dedicated flag to detect Exceptions. Bug: 1022182, v8:9344 Change-Id: Ida7684bff79d68624548c99aee6e7b6f2e334afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105315 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#750914}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/281b5c16d2cc..23283eb96876 git log 281b5c16d2cc..23283eb96876 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 liviurau@chromium.org Doc update Created with: gclient setdep -r src/third_party/devtools-frontend/src@23283eb96876 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb9345412e4df7398443d531be7202d1e1cc8a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107313Reviewed-by:
-
