- 12 Jun, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fc3341632fc0..ffaa47e0fe5f $ git log fc3341632..ffaa47e0f --date=short --no-merges --format='%ad %ae %s' 2017-06-12 robertphillips Roll ANGLE 2017-06-12 robertphillips Re-enable deferred proxies in Chrome 2017-06-12 robertphillips Remove GrTGpuResourceRef specializations 2017-06-12 mtklein append(from_srgb) -> append_from_srgb(kUnpremul) 2017-06-12 bsalomon Modify Adreno 3xx workaround to toggle face culling rather than call glFlush. 2017-06-11 reed remove unneeded proc fields Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: If06f8578dc07b69a86917ae2d349a91609aed03a Reviewed-on: https://chromium-review.googlesource.com/531484Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478692}
-
Ian Vollick authored
Bug: None Change-Id: Iaffa31a55019b3bf25cac048eb81cc9bb05cc950 Reviewed-on: https://chromium-review.googlesource.com/530105 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#478691}
-
Jeremy Roman authored
8-bit WTF::String and LChar are expected to be used for Latin-1 data, rather than UTF-8. Using CString and char is more idiomatic, and as a bonus, avoids a copy (since String::Utf8 returns a CString already). Change-Id: I5a4f726d4980a143793cd88cc80f79fb7375ea72 Reviewed-on: https://chromium-review.googlesource.com/521965 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#478690}
-
kylechar authored
If any of the failure conditions are reached it's a serious problem which crashes ash. Switch DVLOG(1) to LOG(ERROR). Bug: 732436 Change-Id: Ibac4991a6b5f7bae8763e191eb73de9684318e75 Reviewed-on: https://chromium-review.googlesource.com/531564Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#478689}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5ece949fa04..7ba431f75da5 $ git log a5ece949f..7ba431f75 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 nednguyen Remove generate_telemetry_harness script Created with: roll-dep src/third_party/catapult BUG=728177 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibf94dfa26bace6a6e9f8fd3fae0237cc08e74ebe Reviewed-on: https://chromium-review.googlesource.com/531445 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478688}
-
baxley authored
Matchers should not wait, so this is a replacement. This replaces most uses of chrome_test_util::WebViewContainingText. There are a few left over that are dependent upon having a method that waits for the absence of a test. BUG=707009 Review-Url: https://codereview.chromium.org/2798773002 Cr-Commit-Position: refs/heads/master@{#478687}
-
Quinten Yearsley authored
Before this CL, the unit test method test_build_check was still passing even though the check_build behavior wasn't quite as intended, I think -- run_webkit_tests.main was still exiting with an error code, but not because the build check failed. This CL fixes the test and Port.check_build, and simplifies the logic in Port.check_build. Bug: 726781 Change-Id: I03ff816245e244ea05e75e34fe8fabc649f41865 Reviewed-on: https://chromium-review.googlesource.com/528394 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#478686}
-
Rouslan Solomakhin authored
Before this patch, hitting the software keyboard's "submit" button in the CVC unmask dialog would hide the software keyboard and recenter the dialog vertically. This would cause the user to hunt for the "Confirm" button on the dialog at a new location. The user would be even more frustrated if they instead accidentally tapped outside of the CVC dialog, which cancels the CVC unmask. This patch adds an editor action listener for the CVC number field in the CVC unmask dialog. Whenever the user hits "submit" button on their software keyboard in the CVC dialog, the listener checks if the dialog's "confirm" button is enabled and, if so, clicks it. This patch also changes the default software keyboard action on expiration date from "submit" to "next field". After this patch, hitting the software keyboard's "submit" button in the CVC unmask dialog will perform the CVC unmask. Bug: 730771, 687438 Change-Id: Ie8d93e1df214c7fd5494dd0da64a3b94fb1861b9 Reviewed-on: https://chromium-review.googlesource.com/527500Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#478685}
-
Varun Khaneja authored
The main change is to move most of the v4_* unit_test targets out of the runners for mobile since v4_* is specifically targeting desktop platforms. Bug: 621647 Change-Id: I8a8b1c28231b424c116b87c23659f18b1e5873c6 Reviewed-on: https://chromium-review.googlesource.com/524988 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#478684}
-
japhet authored
There's no need to go to LocalFrameClientImpl to determine how to load a plugin element, that was a purely pre-blink necessity. Simplify a bunch of logic around HTMLPlugInElement to assume that url_ and service_type_ are always set and correct by the time the ObjectContentType is being determined. BUG= Review-Url: https://codereview.chromium.org/2927703003 Cr-Commit-Position: refs/heads/master@{#478683}
-
magjed authored
Revert of Fix timestamp issue in RTCVideoEncoder for native frames (patchset #1 id:20001 of https://codereview.chromium.org/2934793002/ ) Reason for revert: The CL did not fix the problem. Original issue's description: > Fix timestamp issue in RTCVideoEncoder for native frames > > Speculative fix for WebRTC test failures. See issue for more information. > > BUG=732345 > TBR=emircan > > Review-Url: https://codereview.chromium.org/2934793002 > Cr-Commit-Position: refs/heads/master@{#478627} > Committed: https://chromium.googlesource.com/chromium/src/+/25b7a7a6350e64c24953b43594ed2b73afe33246 TBR=emircan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=732345 Review-Url: https://codereview.chromium.org/2936583003 Cr-Commit-Position: refs/heads/master@{#478682}
-
Philip Hanson authored
Exclusively for extension app windows spawned using showInShelf = true, make the tooltip text for the shelf item (icon) match the current value of document.title from the corresponding window. BUG=chromium:687359 TEST=Verify that the shelf item tooltip for extension app windows matches the document.title once the content is loaded. TEST=From an extension app window with showInShelf=true, change the document.title dynamically and confirm that the shelf item tooltip changes to match. Change-Id: I4620052821c19d91ea803151dc2cd4e538be121d Reviewed-on: https://chromium-review.googlesource.com/526276 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#478681}
-
James Cook authored
This is part 2 of the conversion of ash system tray IME support to mojo. The next CL will introduce a mojo interface that needs this type. The struct is simple, so use it natively everywhere. Rename IMEProperty to ImeMenuItem because it's a menu item, not a generic property. Bug: 724305 Test: ash_unittests, unit_tests Change-Id: I8a8bb21ce99158ce45d4a6d889254ab311eef877 Reviewed-on: https://chromium-review.googlesource.com/528345 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Hadi Moshayedi <moshayedi@chromium.org> Cr-Commit-Position: refs/heads/master@{#478680}
-
sigbjornf authored
Following r478084, the main thread may contend with the audio thread on accessing AudioBufferSourceNodeHandler's mutable state. Coordinate such access by introducing a Mutex over |min_playback_rate_|. Using atomic ops would be the natural choice for handling this, but steering clear of those over doubles (cf. https://crrev.com/1256053006) until std::atomic<> is allowed. R=haraken,hongchan BUG=731568 Review-Url: https://codereview.chromium.org/2929283002 Cr-Commit-Position: refs/heads/master@{#478679}
-
chrome://tracingsullivan authored
Compiling locally, resources.pak goes from 16744913 bytes to 14952341 (nearly 1.8MiB savings). Review-Url: https://codereview.chromium.org/2933483005 Cr-Commit-Position: refs/heads/master@{#478678}
-
yusufo authored
- Disable contextual search before we go through the search engine promo check - On a WebSearch from selection, first show the search engine promo and only after that send the search intent. BUG=728891 Review-Url: https://codereview.chromium.org/2926413002 Cr-Commit-Position: refs/heads/master@{#478677}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935713002 Cr-Commit-Position: refs/heads/master@{#478676}
-
nednguyen authored
Revert of Remove find_dependencies script (patchset #1 id:1 of https://codereview.chromium.org/2932213002/ ) Reason for revert: find_dependencies is still used. Original issue's description: > Remove find_dependencies script > > BUG=chromium:728177 > > Review-Url: https://codereview.chromium.org/2932213002 > Cr-Commit-Position: refs/heads/master@{#478658} > Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa TBR=charliea@chromium.org,stevenjb@chromium.org,achuith@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2933163002 Cr-Commit-Position: refs/heads/master@{#478675}
-
Eugene Ostroukhov authored
These tests were never ran as they were stashed to a folder named resources. Bug: Change-Id: I8b8c7bd426ce3b25b3a4a623ad5a1fed4800e1c9 Reviewed-on: https://chromium-review.googlesource.com/529904 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#478674}
-
chaopeng authored
SetViewportStyle(kMobile) gives tests default Android viewport style setting. This makes Blink fallback to the 980px layout width in the absence of a viewport meta tag. BUG= Review-Url: https://codereview.chromium.org/2934853002 Cr-Commit-Position: refs/heads/master@{#478673}
-
Marc Treib authored
Semi-related cleanup: Merge the DefaultSearchProviderIsGoogle implementations between search.cc and local_ntp_source.cc. Bug: 583292 Change-Id: I47f0a2b1eeb2dfd6e117e81b332a44f09b7e8ee8 Reviewed-on: https://chromium-review.googlesource.com/527437Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#478672}
-
Theresa Wellington authored
If BottomSheet#setSheetState() is called with SHEET_STATE_HALF on a small screen, change the target state to SHEET_STATE_FULL since half state is not valid. BUG=726012 Change-Id: Ie14738718954e4ac77273708ae5c2f3a610a2603 Reviewed-on: https://chromium-review.googlesource.com/531345 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#478671}
-
Theresa Wellington authored
When toggling accessibility mode, if the overview mode is showing we hide it and then open a new tab (see ChromeTabbedActivity#onAccessibilityModeChanged()). In Chrome Home, if the NTP UI is showing then the overview mode is technically showing. Prior to this patch, when ChromeTabbedActivity tried to open a new tab, we would "show" the bottom sheet new tab UI but since the bottom sheet was already opened we never finished showing the new UI (which currently consists of showing the regular toolbar). This patch updates the logic in BottomSheetNewTabController to finishing showing the NTP UI immediately if the bottom sheet is already open when BottomSheetNewTabController#displayNewTabUi() is called. BUG=731147 Change-Id: Ief2d8c738f2c96f34f293ea29e41d8a0ab69b275 Reviewed-on: https://chromium-review.googlesource.com/530077 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#478670}
-
nrpeter authored
Origional CL (2495353003) was rolled back by sheriff due to flaky test. This initial patchet is a direct patch of 2495353003. Second patchset contains the fix. chrome.webRequest support for ExtensionSettings -If URL or Origin matches an ExtensionSettings protected host, the event will not be dispatched to that extension / app. BUG=731269 patch from issue 2495353003 at patchset 400001 (http://crrev.com/2495353003#ps400001) Review-Url: https://codereview.chromium.org/2934583002 Cr-Commit-Position: refs/heads/master@{#478669}
-
Jeremy Roman authored
It is already in use in base, and is the standard replacement for our similar atomic operations in base and wtf. Because the C++ memory order is subtle, I'd suggest that classes should seldom use it directly, but it seems like it's no worse than base/atomicops.h and wtf/Atomics.h in this regard. Change-Id: I09f4b7448d4724c42a4813acd88f2f00e467bed5 Reviewed-on: https://chromium-review.googlesource.com/523122Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478668}
-
Evan Stade authored
Bug: 731688 Change-Id: I4c42adc0e5a11dae0486824fc7c0754413f601c8 Reviewed-on: https://chromium-review.googlesource.com/530066Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#478667}
-
shivanisha authored
Screenshot attached in the bug. BUG=689992 Review-Url: https://codereview.chromium.org/2930753002 Cr-Commit-Position: refs/heads/master@{#478666}
-
newcomer authored
UI tests are not yet implemented, waiting on final behavior from UX. Enable the new launcher with --enable-features=EnableFullscreenAppList BUG=721781 Review-Url: https://codereview.chromium.org/2898743002 Cr-Original-Commit-Position: refs/heads/master@{#478372} Committed: https://chromium.googlesource.com/chromium/src/+/01b3ff8dd7b21723108b7802164f3a8fa64dabce Review-Url: https://codereview.chromium.org/2898743002 Cr-Commit-Position: refs/heads/master@{#478665}
-
droger authored
This is a refactoring/cleanup, to prepare for DICE response handling. BUG=730589 Review-Url: https://codereview.chromium.org/2925083002 Cr-Commit-Position: refs/heads/master@{#478664}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1c02d65fcbf3..a5ece949fa04 $ git log 1c02d65fc..a5ece949f --date=short --no-merges --format='%ad %ae %s' 2017-06-12 nednguyen Move Annie to emeritus OWNER Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6eecc5acf7f6b0e02f6b379a9caf845a02d1661f Reviewed-on: https://chromium-review.googlesource.com/531107 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478663}
-
floppymaster authored
Update instructions to generate ICU header lists Update header list for unbundling ICU 59 Bug: https://bugs.gentoo.org/619796#c2 Review-Url: https://codereview.chromium.org/2935603002 Cr-Commit-Position: refs/heads/master@{#478662}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5143f2f3763b..fc3341632fc0 $ git log 5143f2f37..fc3341632 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 mtklein port encode_bitmap_for_png() to SkRasterPipeline 2017-05-15 halcanary SkPDF: consolodate glyph runs on BUILD_FOR_WIN 2017-06-09 ethannicholas added SPIR-V RelaxedPrecision 2017-06-09 ethannicholas fixed issue with SkSL dead code elimination 2017-06-12 mtklein only SkHalfToFloat_finite_ftz(uint64_t hs) is called Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ic832bc9bbf5c0ca20b9b6cd57a3b34d4a07a368c Reviewed-on: https://chromium-review.googlesource.com/531264Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478661}
-
domlaskowski authored
The cursor scale and rotation must be updated on pointer enter, even though neither the surface nor the hotspot changed. BUG=730843 TEST=caroline: Cursor is not stale on pointer enter. Review-Url: https://codereview.chromium.org/2935753002 Cr-Commit-Position: refs/heads/master@{#478660}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2932333002 Cr-Commit-Position: refs/heads/master@{#478659}
-
nednguyen authored
BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2932213002 Cr-Commit-Position: refs/heads/master@{#478658}
-
khushalsagar authored
We already skip these layers during UpdateDrawProperties to prevent crashes. Mark these layers as non-drawing so they are skipped by the rest of the system. BUG=730020 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2925213002 Cr-Commit-Position: refs/heads/master@{#478657}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/982f6e0..0492d44 BUG= TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie238aa7b0f34193e94a5c86da50bcb9b9764d971 Reviewed-on: https://chromium-review.googlesource.com/531106Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478656}
-
Mike Baxley authored
A lot of underlying helpers have been updated. I ran this 150 times locally with no failures. Setting to FLAKY_ to confirm on the bots. Bug: 631078 Change-Id: I12667d8dd2751c7fe2e8472b94c5f8386f259a1d Reviewed-on: https://chromium-review.googlesource.com/530097Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#478655}
-
horo authored
BUG= Review-Url: https://codereview.chromium.org/2936543002 Cr-Commit-Position: refs/heads/master@{#478654}
-
Dave Tapuska authored
Ensure implementations that cast InputRouter to InputRouterImpl are only doing it where necessary. Add an additional virtual interface to InputRouter so the touch action can be accessed without a cast to the implementation class. The LegacyInputRouterImpl is largely tied to Chrome IPC. With moving Input messages to be based on mojo messages this class needs to be rewritten. BUG=722928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I97496956bb1547bff5abb145a1a015fec8d0fcb1 Reviewed-on: https://chromium-review.googlesource.com/529408 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#478653}
-