- 09 Jan, 2020 40 commits
-
-
Michael Thiessen authored
Uses the JNI generator to generate test methods for native java unittests that simply call java test methods. Bug: 783819 Change-Id: I2ff4d87a1aa053847077bd3f418123be49174375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992247 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729913}
-
Brian Sheedy authored
Re-enables auto swarming containment on Win 10 x64 Debug (NVIDIA). Disabling it did not have any impact on flakiness. TBR=ynovikov@chromium.org Bug: 1030849 Change-Id: If13321ff6c21e5cc8162d7244b0ce43137aa08e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993118Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729912}
-
Aran Gilman authored
Change-Id: Idcc65495d9c8fe635114f2958ec875919352a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992588Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#729911}
-
Scott Violet authored
-webkit-box always starts horizontal layout from an x position of 0. rtl is handled by starting at 0 and iterating in reverse. https://chromium-review.googlesource.com/c/chromium/src/+/1876073 got close to this by making the width_for_rtl come from the hypothetical size. Unfortunately that doesn't deal with flex. This patch changes how coordinates are calculated when flipped to better give behavior expected of -webkit-box, and it also changes when start/end are flipped. I've add more test cases with a bunch of variations to ensure all cases are handled. This also changes the expectations of paint/invalidation/overflow/float-overflow-right.html. The expectations now match that before the patch at https://chromium-review.googlesource.com/c/chromium/src/+/1876073 BUG=1034461 1037764 TEST=external/wpt/compat/webkit-box-rtl-flex.html external/wpt/compat/webkit-box-horizontal-rtl-variants.html external/wpt/compat/webkit-box-horizontal-reverse-variants.html Change-Id: Ib32dcfef7c147d2e90b754d35f974ebe9c6092b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989930 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#729910}
-
John Lee authored
This CL simply sets up a TabGroupElement that takes in slotted content of TabElements. This is just the first CL to setup the base of the front-end work for tab groups. Bug: 1027373 Change-Id: Ic7248505c6ee7cfeaac92810e9e054f83c840c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992803 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729909}
-
Theresa Wellington authored
When opening the ExploreSitesPage from the Start surface, ChromeActivity#getActiveTab returns null if there are no tabs open, causing an NPE. Update the ExploreSitesPage constructor to take a TabImpl rather than retrieving from ChromeActivity. BUG=1040377 Change-Id: I4d46df53dd2881fb3754a5eeb5fbadfcc6ac367e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993489 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729908}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CustomTabToolbarColorController - Teaches CustomTabToolbarColorController about webapp minimal UI - Adds logic to use default status bar color when the web page is a preview and the CCT is NOT in TWA mode. - Shares logic between CustomTabStatusBarColorProvider and CustomTabToolbarColorController. BUG=997796 TEST=WebappNavigationTest Change-Id: I34172a0167a3cea340b2a17641daa33af0b09295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989137 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
NOTRY=true TBR=crouleau@chromium.org Bug: 1039801 Change-Id: I1d69246f996f9582fde794d4aec53d7f1590ed82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993668Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#729906}
-
Steve Anton authored
We need to monitor these histograms to determine an appropriate time to deprecate Plan B. It's unlikely that Plan B will be deprecated in 2020 so we'll need to continue collecting these metrics. Bug: 1037402, 1037401 Change-Id: Icb4a83d85355cea94bcf4fcc666e04711895ade8 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981836 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#729905}
-
Thomas Lukaszewicz authored
Fixed CustomTabBarView to set and update its colors only once attached to a widget, preventing the fallback to the default NativeTheme. Updated CustomTabBarView to respond to theme changes. Removed the dependency on GetThemeProviderForProfile from CustomTabBarView and from LocationBarView. Bug: None Change-Id: If505b0bede8f112329dcef5f2a7aab9e67dcfd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989085 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729904}
-
danakj authored
Currently the main frame RenderWidget is never deleted but instead marked undead when the main frame is detached and replaced with a remote proxy. Then it is revived when a local main frame is created again. This changes the code to instead delete the main frame's RenderWidget instead of marking it undead. In order to do this there are a couple of fixes to go with it: 1) The browser needs to tell RenderWidgetHostImpl that the RenderWidget associated with it is gone, so that it can reset state to match the new RenderWidget later. 2) The WebViewFrameWidget needs to delete the animation timeline along with the RenderWidget. If the WebViewImpl isn't closing then it would end up being responsible for this task but the RenderWidget is already gone. Bug: 419087 Change-Id: Ibd08e7b03dd884821b38dc5d0efb5d016fb1d6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988781 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#729903}
-
Mohamed Amir Yosef authored
Change-Id: I021cd952d7a2917a8fb7203cabdac612251193df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963804 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#729902}
-
Avi Drissman authored
The “new updater” project was half-completed when it was abandoned in favor of a different approach. The different approach has been serving us well, so remove all the code for the “new updater” project. This effectively reverts: 21f3fb21 4a634b73 c0ec38a1 ce903eec 22f97baf 35b27074 1f478d5a 4a324668 f316ef44 8bcf1fdb bc95a5bb 753cb9df Bug: 960814, 1025805 Change-Id: I9f3e2b2d75d42f2ad49666dce4e0316f8a934e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991705Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729901}
-
sebsg authored
Revert "Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled" This reverts commit 2dd4658f. Reason for revert: Causing the TaskEnvironmentTest.DefaultCOMEnvironment base_unittests to fail on Win7 starting at this build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/98745 Original change's description: > Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled > > R=fdoray > > Bug: 947576 > Change-Id: I1f901367e6fcc5243f34f50e5704b68727a40731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990135 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729802} TBR=fdoray@chromium.org,joenotcharles@chromium.org Change-Id: Ie19f651e25680bc523ca8c8e37e39d11937fedc1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993841Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729900}
-
Peter Boström authored
Moves duplicated logic into views::test::WaitForAnimatingLayoutManager. Also adds a views::test::GetAnimatingLayoutManager convenience method. Bug: chromium:1039852 Change-Id: I285b4a717c556fc1b329259c0ce6142b271dcb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993565 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#729899}
-
Dan Beam authored
Discussion: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/RqOdTlxuGVg/M7I0CTryDQAJ Bug: None Change-Id: I43cb19e50bf9addc530d728f4f002afa16bd6f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993388 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
sebsg authored
This reverts commit f3a7d44e. Reason for revert: Failing again after this landed https://ci.chromium.org/p/chromium/builders/ci/Mac%20Retina%20Debug%20%28AMD%29/59027 more details at crbug.com/1040202 Bug: 1040202 Original change's description: > Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > This reverts commit b4099b2c. > > Reason for revert: new image has been triaged in Skia Gold. > > Original change's description: > > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > > > This reverts commit 7076daa4. > > > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 > > > > Original change's description: > > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > > > > > Test was producing a minor image diff, has been triaged. > > > > > > Bug: 1040202 > > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#729597} > > > > TBR=kbr@chromium.org,bajones@chromium.org > > > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040202 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367 > > Reviewed-by: sebsg <sebsg@chromium.org> > > Commit-Queue: sebsg <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729736} > > TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org > > Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729838} TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org Change-Id: Ibc4b81aa09eccbe93f04573dbbef675b173dfc32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994002Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf8bd8052673..27db24581e9e git log bf8bd8052673..27db24581e9e --date=short --first-parent --format='%ad %ae %s' 2020-01-09 jdarpinian@chromium.org Optimize disabling ARB_texture_rectangle Created with: gclient setdep -r src/third_party/angle@27db24581e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ia9bf57138feb33c677141374c90b404f329cb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729896}
-
Michael Spang authored
This is equivalent to the upstream "-s" option. It just prepends a string to path lookups in case paths are from a remote device for which we have a local symbols tree. Bug: 1040148 Change-Id: Icfa3232b9aa8fefa7274f26fdb0c123ceeb3f96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992008Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729895}
-
Tommy Steimel authored
This CL switches the kaleidoscope browsertest to JavaScript Bug: 1026732 Change-Id: I35463113733460f24ebd1025420c94e9d8443825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993629Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#729894}
-
Fernando Serboncini authored
Change-Id: Ie841d2cf24be16f9a744b0a76bd35130a9d8ef10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993401 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=1037237 R=proberge@chromium.org Change-Id: I1af2a700fe4d3922f9a16e3068b8b73f09980a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986075 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#729892}
-
Yao Xiao authored
Bug: 1037382 Change-Id: I3ce638552ab44050af8bdd3083a42a5879c0c537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991748 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
-
Matt Reynolds authored
This CL modifies the return value from navigator.hid.requestDevice to return an array of HIDDevice objects instead of a single HIDDevice. If the device chooser is canceled without making a selection, the promise is resolved with an empty array instead of rejecting with a DOM exception. The HID device chooser has also been modified such that each item in the chooser represents a single physical device. If multiple logical HID interfaces are exposed by the same physical device, granting permission to access the single physical device grants permission to access any logical HID interfaces hosted by the device that satisfy the chooser filters. BUG=1036439 Change-Id: Ib67b71bcee32e261d3c9425cfc8bd7173f4ebb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966496Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#729890}
-
Oystein Eftevaag authored
This reverts commit c6d81bfc. Reason for revert: Broken again. Original change's description: > Revert "Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5" > > This reverts commit 5be23f11. > > Reason for revert: The CL that caused problems has been reverted. > > Original change's description: > > Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5 > > > > NOTRY=true > > TBR=crouleau@chromium.org > > CC=mythria@chromium.org,ulan@chromium.org > > BUG=1039295 > > > > Change-Id: I418cf1c1be64257871972520008cf61749fa6032 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988546 > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728565} > > TBR=crouleau@chromium.org,nuskos@chromium.org > > Change-Id: Iaee18d7609fd7a54b480ab59b3dd1a3313be9be5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1039295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985956 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728875} TBR=rmcilroy@chromium.org,crouleau@chromium.org,nuskos@chromium.org NOTRY=true Bug: 1039295 Change-Id: Iaf40d9ec4acef0aeb9ec0e809c707c8e070766aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994020Reviewed-by:
-
Patrick Monette authored
This CL adds an overload to WebContentsImpl::FromRenderFrameHostID() and to RenderFrameHost::FromID() that takes in a GlobalFrameRoutingId instead of taking in a pair of ints. This makes those functions easier to use when the caller already has a GlobalFrameRoutingId instance. Change-Id: I1fd7acf816d5f48b792f69d21007a302317f5cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988729 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729888}
-
Haiyang Pan authored
This reverts commit 4276efd8. Reason for revert: The CL https://crrev.com/c/1988925 offers the same result in a better way Original change's description: > android: Add logging for local instrumentation test run to help debugging > > Currently the builder test-n-tablet has flaky test failure due to timeout in > apk installation. > Adding logging to see which apk spent the most time. > > This CL can be reverted after the issue 1004322 is resolved > > Bug: 1004322 > Change-Id: Ic51694add3666aa0e0442cb6f8c11131e04ae13d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859904 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#706212} TBR=bpastene@chromium.org,jbudorick@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004322 Change-Id: I4157e86800050f8ac051678e22224a4618118484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993444Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#729887}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/368d39c30c42..f6a6a4162f28 git log 368d39c30c42..f6a6a4162f28 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 bclayton@google.com SpirvShader: Move extension list out of for loop. Created with: gclient setdep -r src/third_party/swiftshader@f6a6a4162f28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id02f1b5bf63bf0c6d72a8616406146f8f149719a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993583Reviewed-by:
-
Jack Lynch authored
This CL fixes tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267 Bug: 963183 Change-Id: I009b29a449d76d2a147fd32bb72bf8b2d4e5ebc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636716Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729885}
-
sebsg authored
This reverts commit de763ddc. Reason for revert: Causing consistent build failures on https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel See crbug.com/1040636 for more info. Original change's description: > Implement DWARF Fission support in Chrome Android. > > - Modify some compiler build definitions to allow symbol_level=2 with > Chrome Android 32bit, and to make the build respect use_debug_fission in > those cases. > - Modify "link" and "solink" tools in Android toolchain so that DWP > files can be generated for builds with use_debug_fission. > - Modify partitioned_shared_library template/script so that DWP files > can be generated for partitioned libs when use_debug_fission is set. > > Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081 > Commit-Queue: Nelson Billing <nbilling@google.com> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729858} TBR=thakis@chromium.org,agrieve@chromium.org,scottmg@chromium.org,nbilling@google.com Change-Id: I3f3e446ba7ce07034301663af4d2cf0b5cd95982 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993901Reviewed-by:
-
Gabriel Charette authored
Bug: 1039833 Change-Id: Ib37fd30a9fb47c3e85787e8d249ec2491c40030e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989996 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Chase Phillips authored
As part of addressing a problem with corrupt cache entries, this test verifies that the initial cause of the issue is fixed: cached HttpResponseInfo instances should have a valid request and response time. The original problem resulted in these values being set to their default values (year 1601 on Linux). I verified directly that commenting out the fix in appcache_update_url_loader_request.cc caused this new test to fail. Bug: 989611 Change-Id: I338446b18007ac3cda3e1cd2b5e2cc7a1da6efb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992350 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729882}
-
Koji Ishii authored
Change-Id: Ic51da64e6dbfb30de6cb4f47ea7fbeb1fbbdd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993063Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729881}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu::num_readbacks_pending_ isn't decremented when readback is complete. CheckReadbackCompletion() will continue to run periodically even when there are no pending readbacks as a result. Bug: 1022495 Change-Id: I636d83db87bcad0debbf3098d25023d88e5947b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993392 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#729880}
-
Koji Ishii authored
This patch changes |NGInlineBoxFragmentPainterBase:: ComputeFragmentOffsetOnLine| to support |NGFragmentItem|. It used |NGPaintFragment|, but did not crash when it was null. Fixes e.g., fast/inline/inline-box-background.html Bug: 982194 Change-Id: I99abff4e4a2319151870d1283681d1d957c6d3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993363Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729879}
-
Jack Lynch authored
This CL fixes tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891546 Bug: 963183 Change-Id: If58c767086ea176c430cf764fe9245312ebc6ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721843Reviewed-by:
-
Stephen Martinis authored
They don't need to be in the test_suite_exceptions file Change-Id: I727e160cb66775ef3e368166cc13ae7aa9eb41a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984706Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#729877}
-
chrome://extensions-frameDemetrios Papadopoulos authored
Bug: None Change-Id: Ibf3299e2487b3796e12569b21362c751426e2ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992695 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729876}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ae4bbcda1a91..ce9e11f02436 git log ae4bbcda1a91..ce9e11f02436 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 hypan@google.com Use --no-streaming option when installing app on certain devices Created with: gclient setdep -r src/third_party/catapult@ce9e11f02436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1004322 Tbr: oysteine@google.com Change-Id: I651c74aeaa20daf3e35ea8da0d252d573cf2185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993394Reviewed-by:
-
Erik Jensen authored
On Windows, ToUnicodeEx returns ASCII control characters for certain functional keys. E.g., escape returns 0x1B. This change translates such control characters to the corresponding key function instead of reporting the keys as (unprintable) chacter-generating keys in the layout. In addition, this change checks for known, possibly redundant keys and removes them for a cleaner layout. E.g., if Backslash and IntlBackslash happen to generate the exact same characters for the current layout, only Backslash will be included in the layout sent to the client. Bug: 1026029 Change-Id: Ia261e5ca3baa86b16bba7a4bc6926b5d81c33c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975296 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#729874}
-
