- 18 Sep, 2019 40 commits
-
-
Jit Yao Yap authored
When starting a managed guest session (with no Terms of Service), a blank Ash dialog is shown for a brief moment before the session starts. This is caused by the Ash dialog for Oobe being shown even when all the Oobe screens are skipped. This CL changes the behavior of the Ash dialog to only show when required by using a OobeUI::Observer. The dialog is not shown by default, and will be shown when a Oobe screen is shown. OobeScreenWaiter now checks that the native window is visible by default. A small number of tests had to be changed to either show the native window or ignore the visibility check. The reasoning for the changes are in the comments for their respective tests. The WebUI behavior is unchanged. Bug: 1000164 Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#697539}
-
arthursonzogni authored
(This is a pure refactor. Changes in behavior aren't expected) - Use early returns, it avoid using too many nested if/then/else. There was up to 4 level of indentation in this function. - Remove unnecessary DCHECK. Checking a pointer to be non-null before dereferencing it is useless, because it would have immediately crash anyway. Bug: 1001982 Change-Id: Id54de8441bb0b19b91a70d22435dff5fcd6c5260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806674Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697538}
-
Thomas Tangl authored
Sync promos are added to the identity box of the profile menu. Screenshots: https://drive.google.com/file/d/16Hrj0jMyRW9V0Lujnht__dq9FwDbDqgZ/view?usp=sharing https://drive.google.com/file/d/11pITu_EY6jwocAbDwpE14dRQEbWXsMev/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: I54848b8688cb9e7417a8b9274f85b6093148e568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807502 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#697537}
-
Ken Rockot authored
ResetIPC() is called by both Cleanup() and ProcessDied(), where the latter may be called immediately before the RPHI is reused for a new render process. Some IPC-related cleanup tasks were only being done in Cleanup(). This means it was possible for some tasks scheduled on behalf of the previous process to run after a new process was started by the host. Namely UI-thread interface binding tasks -- limited in lifetime by instance_weak_factory_ WeakPtrs -- could run despite ProcessDied() being invoked after their scheduling. This CL resets instance_weak_factory_ in ResetIPC() rather than only in Cleanup(). It also moves |io_thread_host_| cleanup to ResetIPC() for good measure, since this should prevent some inevitably-cancelled UI thread tasks from being posted on a dead process's behalf. Bug: 1000327 Change-Id: Ib2701e2d99a922c991d57745ad63a6d9b8c294ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810036Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697536}
-
Anton Bikineev authored
This fixes EventsDispatchingInDeeplyNestedV1ShadowTrees regressions in blink_perf.events. Bug: 1003112 Change-Id: I7e5feed395cf9232d576940594a2432e14d5d55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809304 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697535}
-
Hirokazu Honda authored
This CL enables V4L2VideoEncodeAccelerator to encode GpuMemoryBuffer based VideoFrame. GpuMemoryBuffer is preferred to DMABUF on encoding because GpumemoryBuffer interface support Map() and multiplatform support (e.g. Android and Windows). V4L2VideoEncodeAccelerator still can encode DMABUF based VideoFrame. Bug: 1001413 Test: video_encode_accelerator_unittest on kevin with crrev.com/c/1808939 Change-Id: I1bc19d47bea88077cb778cb2c7c70618d22731a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808946 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#697534}
-
Mikel Astiz authored
Besides Windows, flakes have also been observed on: Mac: http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/46978 Linux: http://build.chromium.org/p/chromium.linux/builders/linux-trusty-rel/builds/2754 ChromeOS: http://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/29284 TBR=dtrainor@chromium.org Bug: 810982 Change-Id: I30a1e0a9394b5fd34406e618fe51abafd7ddf899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810519Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697533}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b12fdd2a7ac..a4c8d52b7313 git log 5b12fdd2a7ac..a4c8d52b7313 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 hjd@google.com Merge "perfetto-ui: Checkerboard on no data" Created with: gclient setdep -r src/third_party/perfetto@a4c8d52b7313 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1d468a21de5413fadb722ddd09211f03019d2923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697532}
-
Maks Orlovich authored
Bug: 911299 Change-Id: Icb13317ebaf558753d828754148009cff9ad9ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#697531}
-
Niels Möller authored
Overlooked in previous cl https://chromium-review.googlesource.com/c/chromium/src/+/1808841 Bug: webrtc:8733 Change-Id: I82a85241288069913a7e63bbcdb7fb67cc9c8cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810518Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#697530}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/199cfeb385a2..e3254b433188 Created with: gclient setdep -r src-internal@e3254b433188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I59a84ef82182e832ebc2948c26d2c706d4162774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810386Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697529}
-
chrome://password-manager-internalsDominic Battre authored
This CL migrates the webui implementation of chrome://password-manager-internals to web::WebUIIOSMessageHandler which makes it trivial to add chrome://autofill-internals on iOS as well. The structure is closely aligned to chrome/browser/ui/webui/autofill_and_password_manager_internals/. Bug: 928595 Change-Id: I57eb74057e1bf108edd88bbfe3c08638626a620c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807327 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#697528}
-
Hirokazu Honda authored
media/gpu/test: Use SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE to create a native graphic buffer in CloneVideoFrame() CloneVideoFrame() creates a native graphic buffer. The buffer is a destination in copy of yuv frame file in the test. The use case is image_processor_test and video_encode_accelerator_unittest because ImageProcessor and VideoEncodeAccelerator takes a video frame as input. The buffer is created with GPU_READ_CPU_READ_WRITE. It is because there was no proper gfx::BufferUsage for an encoder input. This CL changes the buffer usage to SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE. The usage is introduced specifically for an encoder input. Bug: 1001413 Test: video_encode_accelerator_unittest on kevin and eve Change-Id: I5e20de356c915335aa0ea9cc9e0d9a302d890346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810445Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 991520 Change-Id: Ibc8f641bff2dde0d675be237a2f3aa6fced81c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808839Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697526}
-
nancy authored
For Crostini, Extension, built-in apps, the AppService is used to valid the app id. For ARC apps, ArcAppListPrefs is used, as ARC apps have some very special cases, e.g. PlayStore. ARC tests also assume synchronous behaviour, and will need more refactoring so the AppService can be used. Related unit tests has been fixed. Extension apps in test cases use OnExtensionLoaded to add extension apps, so set the extension name so that we can use AppService to dump the apps name. BUG=1002351 Change-Id: Ia7f589de82ca226eb05dd1706ab95229699d6fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803015 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697525}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37cb2b2a47f0..fd1414608ba1 git log 37cb2b2a47f0..fd1414608ba1 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Reorder msaa and mipmap resolves to happen all at once 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d32dae1bb37c..a7003d5fc306 (11 commits) 2019-09-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@fd1414608ba1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None Change-Id: I926bded2ba35894422ba429b94e321440ed56c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809982Reviewed-by:
-
Arthur Hemery authored
We were trying to run webkit layout tests on android, but that is not actually a thing. Also added chrome_junit_tests and content_junit_tests to the bot. Bug: 976218 Change-Id: If507c3d8d92506a784bcea79980bc5ec58dc72e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803434 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697523}
-
Sylvain Defresne authored
Some base testing classes want to register multiple profiles and already have a TestingProfile::Builder::TestingFactories, so add a method to avoid having all the caller inline the implementation. Bug: none Change-Id: I6bc0fd8bf7954395d8f11016703b4c4807cfbb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808858 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697522}
-
Fergus Dall authored
Also improve usage of base::RunLoop in several tests Bug: 1003775 Change-Id: Id826b9761b0fe98967688b58f4c77ad794b04eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803934Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697521}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7003d5fc306..d5521094f779 git log a7003d5fc306..d5521094f779 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 99793fa67d78..36c1c0e22fab (1 commits) Created with: gclient setdep -r src/third_party/angle@d5521094f779 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I208d523513aecbacfd4327fb8acdc464631b3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809983Reviewed-by:
-
Hitoshi Yoshida authored
Now we don't use keywords "creator" nor "legacycaller". This CL drops these legacy keywords and reconstruct the parsing patterns. This change does not change output ASTs, as a result. The new pattern ignores OperationNameKeyword to allow "includes" as an operation's name, because the case is cought by the leading "_" rule. cf. https://github.com/heycam/webidl/issues/767 Bug: 839389 Change-Id: Idccb1853a82d629504464f0dad5fbe82702c083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809134Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84da790b..16144e1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee83758aa006691e617e571a459dc2318d473bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807163Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a467e264db50..83d2cae04c5f git log a467e264db50..83d2cae04c5f --date=short --no-merges --format='%ad %ae %s' 2019-09-18 dburger@chromium.org Remove EOL nyan_big, nyan_blaze from legacy CQ. 2019-09-18 lamontjones@chromium.org lib: minor cleanup in image_lib and caller. Created with: gclient setdep -r src/third_party/chromite@83d2cae04c5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia794217e1a176998f6461b2b6310b36fb71e90b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810010Reviewed-by:
-
Keishi Hattori authored
Implements SetPreemptedForCooperativeScheduling which stops all task queues associated with the FrameSchedulerImpl including the unpausable ones. Bug: 804661 Change-Id: Icd7288d85c6411c3e379908d14ed9c6eb7203ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742264 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Noel Gordon authored
Viewing PDF files in a renderer (via chrome PDFium) is controlled by a system pref PluginsAlwaysOpenPdfExternally, which is read once-only at FileApp startup. Dynamic pref changes are ignored (see bug). Remove loadTimeData setters for PDF and SWF file viewing actions: file private_api_strings.cc ShouldBeOpenedWithPlugin calls begone, and same for the file_task.js loadTimeData code in FilesApp. Instead, call ShouldBeOpenedWithPlugin in file_tasks.cc. When the list of file tasks is requested by FilesApp, this new code enables/disables FilesApp PDF/SWF viewing actions ... dynamically based on prefs. Add an integration test: tests that QuickView does not show a PDF when the system PluginsAlwaysOpenPdfExternally pref is enabled. Test: browser_tests --gtest_filter="*QuickViewPdfPreviewsDisabled* Bug: 999103 Change-Id: I455fdbd794247a0a57105a2abd6ed929c752a8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808943 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#697515}
-
Anastasiia Nikolaienko authored
ARC uprev http://ag/9399668 Change-Id: I6479b9977dcb6a3c2d6448714bf8aed23725aad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807320Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#697514}
-
Darren Shen authored
Currently we queue composition operations as "pending" if we are currently handling a PK event. However, the pending composition is not cleared after we handle the pending composition, so IMF thinks that there's still some pending composition to be run in the next operation. Bug: 1004149 Change-Id: Ibe7d6d49cd2d532f2a3300d63df15cd54eda98e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806154Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#697513}
-
Alex Clarke authored
We'd like to prioritize loading and compositing tasks till FCP and this appears to expose a problem with the test. The timing of the script on line 6 with respect to the second promise test is a bit fragile. If the iframe script runs before the promise then document.querySelector('iframe') returns null and the test fails. This timing issue seems unrelated to the test itself, so I propose splitting the test into two as the simplest fix. Bug: 971191 Change-Id: I65384093ac8f4616d64fc21ee692d145be1655a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807323Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697512}
-
Yi Su authored
Currently we assume that if a NavigationContext can be found when "decidePolicyForNavigationAction" is invoked, the navigation should be either user-initiated or JS back-forward. However this can be wrong if the web page uses JS to load the same URL during the navigation. The root cause here is that we are matching URL to find the NavigationContext for WKNavigationAction, which is not reliable. Bug: 1000309,1003467 Change-Id: I7163474df5ffde9cf784ef348f48e652ca878df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807832Reviewed-by:
-
Jan Scheffler authored
This patch adds the emacsy shortcuts to the editor again. Bug: chromium:983874 Change-Id: I8423fad0b0fde6ac83487189092edc8f9c66c095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806737Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#697510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b4e53c4a9938..cbc960899a68 git log b4e53c4a9938..cbc960899a68 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 abennetts@google.com Minimal markdown conversion of Pinpoint Errors doc (https://docs.google.com/document/d/1cuhfQ1peSpz2ts3OMC-O4ALoblamYBaCWWOES8bP8ms/view#) Created with: gclient setdep -r src/third_party/catapult@cbc960899a68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: I32ea130e1c00c8abba9e9d1d87aa781bb6e193ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809853Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca254aeeec6..199cfeb385a2 Created with: gclient setdep -r src-internal@199cfeb385a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3cd8d82fa7aec1ab88cd69551982384d185dd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810179Reviewed-by:
-
Jan Scheffler authored
This patch adds the navigationId to LCP events to allow reporting of LCP for every navigation. Bug: chromium:1001010 Change-Id: If813f679d75c45bbb16a270576f5c9be0f47c772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790445 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This fixes the color popover when the contrast details are show and also has a color picker for the background. Bug: chromium:959012 Change-Id: Iddbd397b9417a331397c3e07fd3690ea5e306710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789225Reviewed-by:
-
Gauthier Ambard authored
This CL removes the default VoiceOver action which is reading the title of the item then the content of the badge. Now the accessibility label is the title and a new property, |additionalAccessibilityLabel|, if it is set. Bug: 985764 Change-Id: Ic2c1f0a590f020de0dae1a37cc01f081663c2e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789397Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697505}
-
Fergus Dall authored
TBR=cmumford@google.com TBR=kinuko@chromium.org Bug: 1005084 Change-Id: I1d22b527d7d5bdaa3f4e7c0b8726258ac43f30db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810442Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697504}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a37ea9246e1e..37cb2b2a47f0 git log a37ea9246e1e..37cb2b2a47f0 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c6edebc2..b1c1d284 (382 commits) 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30847688f059..61a2765940a7 (7 commits) 2019-09-18 herb@google.com Revert "SkZip - synchronized indexing of several pointers" Created with: gclient setdep -r src/third_party/skia@37cb2b2a47f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None Change-Id: Ie5408a899495ee583d742a659b2fbb2139ce7f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810457Reviewed-by:
-
Fergus Dall authored
TBR=sky@chromium.org Bug: 1005095 Change-Id: I9ab1fe467bc0c8d927f7ba4154674c0a3ca5fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810498Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da39c6d82324..a467e264db50 git log da39c6d82324..a467e264db50 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 vapier@chromium.org image_lib: add fsync when updating filesystem superblocks 2019-09-18 vapier@chromium.org image_lib/osutils: improve debug output for image mounting Created with: gclient setdep -r src/third_party/chromite@a467e264db50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia2c39da1ce13f72b7b3b39632bbd1841cf781706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810178Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts MultiroomManagerPtr to new Mojo types. It uses Remote and Receiver instead of MultiroomManagerPtr and Binding. Bug: 955171 Change-Id: I6615aff8b7ca9c58748bbd08ee08f38b57b4c202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804947Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
