GitLab

AudioRendererHost was calling AudioMirroringManager::RemoveDiverter()
just before AudioOutputController::Close().  This caused AOC to re-start
the default audio output stream (to the user's speakers) for 0-50+
milliseconds before closing and shutting down.  This change fixes the
problem by moving the RemoveDiverter() call to a point after AOC has
completed its close operation, which results in no new streams starting
up during this shutdown process.

BUG=474432

Review URL: https://codereview.chromium.org/1172883003

Cr-Commit-Position: refs/heads/master@{#333684}

Revert of Gallery: Add toolbar at the top of window. (patchset #1 id:1 of https://codereview.chromium.org/1145893010/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: Add toolbar at the top of window.
>
> BUG=488227
> TEST=Manually tested.
>
> Committed: https://crrev.com/abd18063e7b78bc50db62c1914aa729cb0daa40f
> Cr-Commit-Position: refs/heads/master@{#332346}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1170403005

Cr-Commit-Position: refs/heads/master@{#333683}

BUG=Bisect bot no longer works.

TBR=prasadv@chromium.org, aiolos@chromium.org

TEST=https://codereview.chromium.org/1177623004

Review URL: https://codereview.chromium.org/1169413003

Cr-Commit-Position: refs/heads/master@{#333682}

Revert of Move overwrite original checkbox and saved label to bottom toolbar. (patchset #2 id:20001 of https://codereview.chromium.org/1167533004/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Move overwrite original checkbox and saved label to bottom toolbar.
>
> BUG=488227
> TEST=none
>
> Committed: https://crrev.com/689d5020bb670e8c63feb20b47fedb2112eee05f
> Cr-Commit-Position: refs/heads/master@{#332545}

TBR=mtomasz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1173863004

Cr-Commit-Position: refs/heads/master@{#333681}

This reverts commit 6a31c05f.

TBR=fukino@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1173863003.

Cr-Commit-Position: refs/heads/master@{#333680}

Picks up https://codereview.chromium.org/1171203002
to add |isReferenceCounted| to the converter data structure.

BUG=465175
TEST=see the bug
TBR=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/1171283003

Cr-Commit-Position: refs/heads/master@{#333679}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9237715..75eb674

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1171353002

Cr-Commit-Position: refs/heads/master@{#333678}

This reverts commit 76ab89d6.

TBR=fukino@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1172883005.

Cr-Commit-Position: refs/heads/master@{#333677}

Review URL: https://codereview.chromium.org/1176583003

Cr-Commit-Position: refs/heads/master@{#333676}

This reverts commit d1e34310.

TBR=mtomasz@chromium.org
BUG=488227

Review URL: https://codereview.chromium.org/1174853002.

Cr-Commit-Position: refs/heads/master@{#333675}

Another platform will have image processor. Change the device
name of image processor to more generic.

BUG=chrome-os-partner:38980
TEST=Test apprtc loopback on peach pit.

Review URL: https://codereview.chromium.org/1156803004

Cr-Commit-Position: refs/heads/master@{#333674}

Revert of Gallery: capture escape key in full screen by adding a permission. (patchset #2 id:20001 of https://codereview.chromium.org/1149323006/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: capture escape key in full screen by adding a permission.
>
> BUG=497011
> TEST=manually tested; Maximize Gallery and press slideshow button. Confirm that it goes to slideshow mode. After it, press escape key and confirm that it goes back to the original mode.
>
> Committed: https://crrev.com/7d1560ccb3dfee3c9f1510b035f67261b0b88d8f
> Cr-Commit-Position: refs/heads/master@{#333246}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497011

Review URL: https://codereview.chromium.org/1174733005

Cr-Commit-Position: refs/heads/master@{#333673}

The current approach doesn't account for expired frames when resuming
after underflow, which means we may resume and then immediately fail
again; these frames are also out of sync with the audio playing out.
Fixing this requires several changes to the pipeline:

- TimeSource::ConvertMediaTimestamps() will now always convert timestamps,
even when time is stopped.  When time is stopped the converted values are
based on the last known media wall clock time.

- TimeSource::ConvertMediaTimestamps() will now return the current media
wall clock time when an empty timestamps vector is given; this value is
used to figure out which video frames have been played out already.

- Introduce AudioClock::CompensateForSuspendedWrites() to ensure the audio
delay value is correctly used when return the current wall clock time.

- Introduce |was_time_moving_| to VideoRendererAlgorithm to ensure the
|last_deadline_max_| value, used by RemoveExpiredFrames, is only changed
when time is ticking; otherwise the value given to RemoveExpiredFrames is
overwritten by Render() calls and EffectiveFramesQueued() will vary.

- Modifies VideoRendererImpl::FrameReady() to remove expired frames based
on the last known media wall clock time during underflow states.

Combined these changes lead to a noticeable improvement in audio/video sync
during underflow as well as a greatly reduced number of underflow events.

BUG=498525
TEST=lots of new tests.

Review URL: https://codereview.chromium.org/1160853006

Cr-Commit-Position: refs/heads/master@{#333672}

This cl implements ServiceWorkerHandler::ActivateTarget() to focus the tab which is controlled by ServiceWorker.

Screenshot: https://code.google.com/p/chromium/issues/detail?id=466871#c65

1/5 chromium: This cl.
2/5 blink: https://codereview.chromium.org/1151993003/
3/5 chromium: https://codereview.chromium.org/1149383004/
4/5 blink: https://codereview.chromium.org/1164583002/
5/5 chromium: https://codereview.chromium.org/1143363009/

BUG=466871

Review URL: https://codereview.chromium.org/1160133002

Cr-Commit-Position: refs/heads/master@{#333671}

This measures time spent in ExecuteJavaScript() in DomDistiller. It
includes JavaScript code transmission through IPC, parsing, compilation,
execution, and returning the JSON back through IPC.

We already have DomDistiller.Time.DistillationTotal, but it is measured
within JavaScript.

In DomDistiller.Time.*, DistillationTotal < RunJavaScript < DistillPage.

BUG=497430

Review URL: https://codereview.chromium.org/1143173009

Cr-Commit-Position: refs/heads/master@{#333670}

I had hoped to bump the deployment target to 10.7 instead, but the nacl bots
still build on 10.6 :-(

Also, pass commands as a single string to subprocess when
shell=True (else, 2nd cmd entry and onward are treated as
shell parameters, not as part of the command).

BUG=494442

Review URL: https://codereview.chromium.org/1169353002

Cr-Commit-Position: refs/heads/master@{#333669}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b23e6aa..5195805

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1175823003

Cr-Commit-Position: refs/heads/master@{#333668}

This is for debugging purposes only and will be reverted
soon.

BUG=495650
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1175703004

Cr-Commit-Position: refs/heads/master@{#333667}

Cr-Commit-Position: refs/heads/master@{#333666}

Added 'blob' scheme in Navigation.MainFrameScheme and Navigation.MainFrameSchemeDifferentPage histograms.
Added it in the end, before the scheme_max so that scheme_max contains the number of schemes.

BUG=492773

Review URL: https://codereview.chromium.org/1167403002

Cr-Commit-Position: refs/heads/master@{#333665}

Move perf_tests_helper.py to
telemetry/util/perf_tests_helper.py

BUG=497905

Review URL: https://codereview.chromium.org/1171803003

Cr-Commit-Position: refs/heads/master@{#333664}

After clicking the "Allow" button in the infobars, Chrome will request
the permission if required from Android.

BUG=496447

Review URL: https://codereview.chromium.org/1164973003

Cr-Commit-Position: refs/heads/master@{#333663}

BUG=498040

Review URL: https://codereview.chromium.org/1174743002

Cr-Commit-Position: refs/heads/master@{#333662}

BUG=498149

Review URL: https://codereview.chromium.org/1176723002

Cr-Commit-Position: refs/heads/master@{#333661}

We're left with the following:
. Embed(ViewManagerClientPtr client)
. EmbedAllowingReembed(mojo::URLRequestPtr request): this variant
  walks the frame tree for the first ancestor marked as an embed root
  and asks it for the ViewManagerclient to embed.

BUG=497855
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1166123005

Cr-Commit-Position: refs/heads/master@{#333660}

Revert of Gallery: use shadow dom with Polymer. (patchset #1 id:1 of https://codereview.chromium.org/1168333002/)

Reason for revert:
All of Gallery Material Redesign will happen in M46.

Original issue's description:
> Gallery: use shadow dom with Polymer.
>
> BUG=488227
> TEST=none
>
> Committed: https://crrev.com/f17dc18bc3dd133d2be1c92d2f4e3c0b05d4d9b1
> Cr-Commit-Position: refs/heads/master@{#333449}

TBR=fukino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488227

Review URL: https://codereview.chromium.org/1172533003

Cr-Commit-Position: refs/heads/master@{#333659}

TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesRecordInAllTaskSwitchHistogram

BUG=487745

Review URL: https://codereview.chromium.org/1148723006

Cr-Commit-Position: refs/heads/master@{#333658}

Mostly turns on char16_t and char32_t to not error out immediately.

R=thakis@chromium.org
BUG=82385,440500,498544

Review URL: https://codereview.chromium.org/1172903002

Cr-Commit-Position: refs/heads/master@{#333657}

Turn on Impl Side Painting on Aura browser compositor by default
and add a disable compositor switch.

(Last attempt to re-land is at https://codereview.chromium.org/1160093005/, the try bot failure seem to be fixed with https://codereview.chromium.org/1166983007/ which is committed)

R=danakj
BUG=314185

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/962833003

Cr-Commit-Position: refs/heads/master@{#333656}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b91fed..9237715

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1166383003

Cr-Commit-Position: refs/heads/master@{#333655}

This patch fixes more size_t to int truncations that I missed on
the initial runs.

R=danakj
BUG=167187
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1170403002

Cr-Commit-Position: refs/heads/master@{#333654}

This scale is currently 0, but if a PaintedScrollbarLayerImpl ends up
in the RenderSurfaceLayerList, we'll try to get the layer's rect in
target space. Since the scale is 0 we end up dividing by 0 and get a
NaN which is bad times.

If we init this to 1 things work until the PaintedScrollbarLayer has
a chance to Update().

R=enne
BUG=497947
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1172873002

Cr-Commit-Position: refs/heads/master@{#333653}

BUG=chromium:489795
TEST=None
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/1168813003

Cr-Commit-Position: refs/heads/master@{#333652}

the same data more than once.

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1160823007

Cr-Commit-Position: refs/heads/master@{#333651}

DecryptingDemuxerStream should report proper video_rotation
of the underlying DemuxerStream.

BUG=none

Review URL: https://codereview.chromium.org/1175563005

Cr-Commit-Position: refs/heads/master@{#333650}

When creating a bookmark file by draging and droping the URL to the desktop
chromium uses the page title for the filename. In cases where the title starts
with a dot the webloc file will also start with a dot. Since files starting
with a dot are considered hidden and not shown by e.g. the Finder users won't
see the expected resulting file. To circumvent this a dot as the first
character is handled like any other character not allowed in a filename and
gets replaced by a hyphen.

BUG=138917
TEST=Paste "data:text/html,<title>. . . hey!</title>" into the Omnibox and drag
  and drop the URL to the desktop.

Review URL: https://codereview.chromium.org/1118813005

Cr-Commit-Position: refs/heads/master@{#333649}

This was made stable in https://codereview.chromium.org/866893003 but
that CL missed this is-dev-channel check.

BUG=495039,384644

Review URL: https://codereview.chromium.org/1170843005

Cr-Commit-Position: refs/heads/master@{#333648}

BUG=439512, 472215

TEST=./tools/perf/run_benchmark --browser=system smoothness.maps

Review URL: https://codereview.chromium.org/1171113002

Cr-Commit-Position: refs/heads/master@{#333647}

BUG=480025

Review URL: https://codereview.chromium.org/1172183003

Cr-Commit-Position: refs/heads/master@{#333646}

This CL defines the LicenseManager interface and implements a dummy
GaiaLicenseManager that returns the user's Gaia token.

BUG=b/19799333

Review URL: https://codereview.chromium.org/1163023002

Cr-Commit-Position: refs/heads/master@{#333645}