- 13 Jul, 2018 40 commits
-
-
Oystein Eftevaag authored
This is needed to avoid ODR violations due to both the generated protozero sourcesets as well as libperfetto having dependencies on third_party/perfetto/src/protozero (the protozero base library) which causes ODR violations in component builds. Requires https://android-review.googlesource.com/c/platform/external/perfetto/+/711693 to land. R=hjd@chromium.org BUG=853872 Change-Id: I805092df1a3e62662f478a7bac015686322d00db Reviewed-on: https://chromium-review.googlesource.com/1120694Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#575024}
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4f6bd4f1e90efc1f6b986dcda2decf88246c80f7 Reviewed-on: https://chromium-review.googlesource.com/1136211 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#575023}
-
Nico Weber authored
- Remove support for 'key_removals', which is unused after https://chromium-review.googlesource.com/c/1136516/ -- As a knock-on effect, update_and_cleanup_test() can now no longer throw, so remove several try:/except: blocks to keep the coverage script happy. - Remove support for having "$bot_name $waterfall_name" in 'modifications' since that's no longer needed and there was a TODO about removing it already. Bug: 843511 Change-Id: I2d9d89e60ad404f78c97f448db017091b4d18b57 Reviewed-on: https://chromium-review.googlesource.com/1136893 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575022}
-
Francois Doray authored
Previously, this scenario could cause the same session to end twice: - Chrome becomes visible. - User event -> Session starts. - Chrome becomes hidden -> Session ends. - Inactivity timeout expires -> Session ends again. This CL fixes the issue by stopping the inactivity timer when a session ends. Bug: 863243 Change-Id: I3d903844ab07775ebc5d653f34fa6b91a3623021 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1136725Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#575021}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6518574ca0b1be4ce469090f8a95848a7d29cdcf Reviewed-on: https://chromium-review.googlesource.com/1136891Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#575020}
-
Tiger Oakes authored
Removing the old UI now that we've reached feature parity. Bug: 847599 Change-Id: I2163241f53a4e5eb2b14e14f7fab12ecb1639f24 Reviewed-on: https://chromium-review.googlesource.com/1136844Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#575019}
-
Devlin Cronin authored
Currently, we have a single generated class that registers all the extension features in the constructor. For instance, ChromeAPIFeatureProvider registers both features from both //chrome and //extensions. Refactor this to generate a method that takes a FeatureProvider and adds features to it, rather than generating a FeatureProvider subclass. This allows us to have multiple feature registration methods called for a single provider, rather than needing a single class per build. This is necessary in order to split out app and extension feature registration. Bug: 862310 Change-Id: I9fba5ea57d8b14ca9f893a2694661163c8bc4140 Reviewed-on: https://chromium-review.googlesource.com/1132124Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575018}
-
Kurt Horimoto authored
This will allow the icon insertion logic to be shared across different implementations of the Reading List empty state. Bug: 851962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibd4abe71be34ae019786620ba88ba6f226b75456 Reviewed-on: https://chromium-review.googlesource.com/1135983 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575017}
-
kylechar authored
Register a context loss callback with the GLES2Implementation to find out about lost context. Implement AddObserver() and RemoveObserver() for VizProcessContextProvider to notify the observers on context loss. viz::Display is already registered as the context loss observer for the ContextProvider. It gets notified and calls out to DisplayClient. Implement a handler for DisplayOutputSurfaceLost() so the root CompositorFrameSink shuts down the display on context loss. The client will see a connection error and reinitialize the display. Also make VizProcessContextProvider log UMA on context loss. This requires moving ContextLossReason enum somewhere visible to VizProcessContextProvider and adding a new histogram for GPU.ContextLost.DisplayCompositor. Bug: 859068 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4c1fb6f00a893003e9b65dde1a7c5802a8f27692 Reviewed-on: https://chromium-review.googlesource.com/1126482Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Reilly Grant authored
Having these API wrapper objects be globals is dangerous because each BluetoothTaskManagerWin creates a new task runner on which to run Bluetooth tasks. Since this is the only class that uses these objects it can just own them instead. To simplify things the weak HANDLE reference in BluetoothTaskManagerWin has also been removed. Bug: 820864 Change-Id: I2abaca53c1b7388503e0f18ac6a004426f0e95ac Reviewed-on: https://chromium-review.googlesource.com/1117445 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#575015}
-
Xiaocheng Hu authored
This patch changes ColdModeSpellCheckRequester to store a Range instead of Position to memorize the checking progress, so that the state is less vulnerable to DOM changes. It also adds more data validity check to make sure that the class is in a valid state when calling RequestCheckingForNextChunk(). Bug: 862932 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I15b71545fad68b1061c2d075f56d849f1ef8e009 Reviewed-on: https://chromium-review.googlesource.com/1135899 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575014}
-
Lei Zhang authored
Help make sure ShutdownSDK() gets called when needed. Change-Id: I9be9e521892c3dd9f49e4141e93a4dbe46c7f5ce Reviewed-on: https://chromium-review.googlesource.com/1135914Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575013}
-
Nico Weber authored
If we always want the output, we should add the flag in testing/buildbot/gn_isolate_map.pyl or waterfalls.pyl for all bots, and not set this for a small arbitrary subset. Bug: 843511 Change-Id: I8a1e1f32ec22da2b02bc05ac56ecee659b4448ee Reviewed-on: https://chromium-review.googlesource.com/1136517Reviewed-by:
-
Tarun Bansal authored
Make the test wait for resource loading hints to be available. Change-Id: I4b0cd3d3f03c53efcd386f16c6e70d05d9ef2ed4 Bug: 863250 Reviewed-on: https://chromium-review.googlesource.com/1136838Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#575011}
-
Nico Weber authored
It's a fairly simple test, it already runs on most Android bots, and it's not clear why it doesn't run on those too. Worst case, we'll find out and re-disable. Bug: 843511 Change-Id: Id1fc932cb3b1599285524e1701602077bbc3d65a Reviewed-on: https://chromium-review.googlesource.com/1136643Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575010}
-
Aldo Culquicondor authored
The VR keyboard doesn't take content space, so we don't need to wait for a window resize to do the auto-scroll to the focused view. We add a new parameter to the result receiver to indicate this. Bug: 831368 Change-Id: I3d965ef9ffec8288ca2f6acc91c5f4fda8fc23f6 Reviewed-on: https://chromium-review.googlesource.com/1127928Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575009}
-
rbpotter authored
If the preset options contain a zero width or height page size, computing the fit to page width or height will result in a division by zero and these values will be undefined. Use 0.0f, indicating an unknown/unavailable fit to page scaling, in this case. Bug: 859230 Change-Id: Ib5b36786da9ba82b1ba1642a5d9ff9c086342fee Reviewed-on: https://chromium-review.googlesource.com/1135785Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575008}
-
Roger McFarlane authored
This CL removes the AutofillRestrictUnownedFieldsToFormlessCheckout (shich has now gone to Stable-Exp) and adds the AutofillSmallFormSupport field trial config (which is going to Beta-Exp). These field trials cannot co-exist (in either fieldtrial_testing_config.json or on a single given channel) because they both control the AutofillRestrictUnownedFieldsToFormlessCheckout feature flag. Bug: 824834 Change-Id: I955db8113da9d15f176c2a8e8aae5bfc72eba1bd Reviewed-on: https://chromium-review.googlesource.com/1076310Reviewed-by:
-
Peter K. Lee authored
Finally, the last step of removing from UserFeedback Provider API. Submit this after all other downstream CLs have been submitted. Bug: 847329 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1c8fb9fdf5e9b3f65e959577a563e9f7311d93e6 Reviewed-on: https://chromium-review.googlesource.com/1132542Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#575006}
-
Michael Thiessen authored
De-duplicates usage of mDonSucceeded and mEnterVrOnStartup. Removes a bunch of dead code and unused variables. Change-Id: I85f9c38dbb1e9c9cd6bbdf404bd9f51c418f8e70 Reviewed-on: https://chromium-review.googlesource.com/1136580Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575005}
-
Andrey Kosyakov authored
We don't want stray web contents being present. Change-Id: I29f243e83c7379add99b75e6c7baa7bfbf530c6e Reviewed-on: https://chromium-review.googlesource.com/1135991 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575004}
-
mark a. foltz authored
This change removes the typemap from media_router::mojom::RouteMessage to content::PresentationConnectionMessage, in preparation for removing content::PresentationConnectionMessage entirely in a subsequent change [*]. The Media Router now uses media_router::mojom::RouteMessagePtr to pass around media route messages, which is move-only and required updating the API for MediaRouterMojoImpl. This in turn required updating many unit tests. Eventually, RouteMessage, RouteMessageObserver, and BrowserPresentationConnectionProxy will be removed when a PresentationConnection can be passed directly through the Media Router. * https://chromium-review.googlesource.com/c/chromium/src/+/1123175 Bug: 817903 Change-Id: I1f33a86fa3ed2cd1c00e370ce432a095bf21d3bd Reviewed-on: https://chromium-review.googlesource.com/1123649Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575003}
-
Chris Harrelson authored
This is unnecessary, because once these frames become unthrottled they will update their layout, including frame rects. Change-Id: I9f58575b58d5e6e7ced6d11391a3d3f628365feb Reviewed-on: https://chromium-review.googlesource.com/1134505 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#575002}
-
Chris Sharp authored
Change-Id: I4442f2e2a9136409831793a396c05150e7607684 Reviewed-on: https://chromium-review.googlesource.com/1136387 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Tessa Nijssen authored
WebContents::Replace() replaces the current text selection with a given string. Currently, SuggestedTextTouchBarController replaces the current user selection when a suggestion is chosen from the touch bar. SuggestedTextTouchBarController now calculates a range that encompasses the word in which the cursor resides. If the cursor is not in or at the end of a word, the range representing the editing word starts at the cursor position and has length 0. When a suggestion is chosen from the touch bar, the selection within the textfield is modified to encompass the word currently being edited (which may be only a cursor position) and then WebContents::Replace() is called to replace the selection. A unit test was written to test that editingWordFromText:cursorPosition: properly calculates the range encompassing the current editing word for various combinations of word and non-word characters. Some parameter types were changed to reduce the number of conversions from base::string16 to NSString and vice versa. Previously, WebContentsTextObserver::DidChangeTextSelection() took a base::string16 as a parameter. It would then convert that input to NSString and pass it to webContentsTextSelectionChanged:range: which would then call editingWordRangeFromText:cursorPosition: which would then convert the NSString back to a base::string16. The call to BreakIterator::Init() was moved out of a DCHECK because DCHECKs are stripped for release builds and the call to Init() should not be removed. Bug: 717553 Change-Id: I367093e13129609c7238bdb9125bbd69a3910f0c Reviewed-on: https://chromium-review.googlesource.com/1130232Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#575000}
-
Amirhossein Simjour authored
Fix typo in calculation of AnchoredPopupWindow's width. Bug: 862594 Change-Id: I0f79ca75c1d3c003d24dcba835fb6925b8d1dab5 Reviewed-on: https://chromium-review.googlesource.com/1136723Reviewed-by:
-
Bret Sepulveda authored
Their size is now consistent with buttons. Bug: 822803, 822074 Change-Id: I26742d82262efb0c2329fdcb313126ad681965ea Reviewed-on: https://chromium-review.googlesource.com/1136061Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574998}
-
Kurt Horimoto authored
When attempting to update the read status of a section, exit editing mode before early returning if that section does not exist. Bug: 863006 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32a0d80a3d16d7bdb0606cedbaf20401df67a640 Reviewed-on: https://chromium-review.googlesource.com/1136022Reviewed-by:
-
Doug Turner authored
TBR=jam@chromium.org Bug: 844973 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2fa684a39ddb01c582173d6955fa264792c779ea Reviewed-on: https://chromium-review.googlesource.com/1136718 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#574996}
-
Nico Weber authored
It no longer does anything that remove_from can't do. No behavior change. Bug: 843511 Change-Id: I74d3e52d7a9d00271baad9203d72ba7efc777a64 Reviewed-on: https://chromium-review.googlesource.com/1136646Reviewed-by:
-
Michael Thiessen authored
No functional changes - we haven't hit the deleted code path in many months and it's no longer relevant now that we don't exit VR when paused. Change-Id: I1131de9f43675d000c366e7174dacae6e300c7d8 Reviewed-on: https://chromium-review.googlesource.com/1135824Reviewed-by:
-
Chris Harrelson authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2c8e14fae22b1fe5d8aec77cf7e203f839972100 Reviewed-on: https://chromium-review.googlesource.com/1135705Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574993}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/589fda45ed12..0b17b7db7523 git log 589fda45ed12..0b17b7db7523 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 treehugger-gerrit@google.com Merge "trace_processor: Fixed small issues from http://aosp/706904" 2018-07-13 lalitm@google.com Merge "perfetto: add trace processor library to expose to external clients" 2018-07-12 lalitm@google.com perfetto: add trace processor library to expose to external clients 2018-07-11 taylori@google.com trace_processor: Fixed small issues from http://aosp/706904 Created with: gclient setdep -r src/third_party/perfetto@0b17b7db7523 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: Idcd7423a61d4580113e6776d9545be537f318a41 Reviewed-on: https://chromium-review.googlesource.com/1136731 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574992}
-
apacible authored
Change-Id: Id3aef7827d87ab415ccb83b85f678dbe2ea28e99 Reviewed-on: https://chromium-review.googlesource.com/1135356Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#574991}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab13ebac. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21203 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I1289268cce80499b7c9ca3bd34730d7d03b01a7e Reviewed-on: https://chromium-review.googlesource.com/1136590 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574990}
-
Nico Weber authored
These sections have been around since the json files started being autogenerated. Not all _apk targets have key_removal sections, and the ones that do have different bots listed there. Omitting args probably isn't important, so don't do it. Bug: 843511 Change-Id: I42c2e0bb03d28d850bb447c62e21df62ed33eafd Reviewed-on: https://chromium-review.googlesource.com/1136516Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cc291365934..210610261006 git log 0cc291365934..210610261006 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Use angle::Result error handling. 2018-07-13 jmadill@chromium.org Add gl::ErrorSet and angle::Result. Created with: gclient setdep -r src/third_party/angle@210610261006 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie5622320e955bea3a724e263dfd212f32db36dcf Reviewed-on: https://chromium-review.googlesource.com/1136732Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574988}
-
Ian Kilpatrick authored
The UseCounter at parse time is relatively high (0.09% of page loads): https://www.chromestatus.com/metrics/feature/timeline/popularity/924 However the parser typically over-estimates these things so added a layout time UseCounter. This should have no side-effects. Change-Id: Icaa5f0603cf6b6b21494df10a88463ecaf4c6b0f Reviewed-on: https://chromium-review.googlesource.com/1136713Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#574987}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7651c1611e6c..ed1205ae20b2 git log 7651c1611e6c..ed1205ae20b2 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 robertphillips@google.com Make GrRenderTargetOpList::purgeOpsWithUninstantiatedProxies match the GrTextureOpList version 2018-07-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 523c5e3122ed..0cc291365934 (1 commits) 2018-07-13 bungeman@google.com Improve SkTestFontMgr. 2018-07-13 robertphillips@google.com Add bullet proofing to image_subset GM for TSAN failures Created with: gclient setdep -r src/third_party/skia@ed1205ae20b2 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I4b4796ce9c67e6946ee80731b5c30560c96b3a13 Reviewed-on: https://chromium-review.googlesource.com/1136733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574986}
-
Charlie Harrison authored
content_settings::Observers are not robust enough for metrics capture. A few problems: 1. It is impossible to tell if a setting change is meaningful (e.g. BLOCK -> BLOCK vs BLOCK -> ALLOW) 2. Some WebUIs trigger duplicate calls into observers If crbug.com/706061 is fixed, we can probably re-add some of this code. In the meantime, I will add a metric or two to the Android Preference UI, where we really need it and can log what we care about directly. This CL also cleans up and versions the SubresourceFilter.Actions histogram, which has a bunch of deprecated / not useful buckets. TBR=msw@chromium.org Bug: 823415 Change-Id: If2d42520b226b21b6a8e875876d733ea32656b11 Reviewed-on: https://chromium-review.googlesource.com/1081370 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574985}
-
