GitLab

There exist two interface through which a views::View is stitched to
a content::WebContentsView
- the ui::Layer is attached via a cr_setParentUiLayer method
- accessibility is attached via the accesibilityHostable protocol

Lifetimes of the embedding are slightly unclear because the attached
WebContentsView may be destroyed the NativeViewHost detaches it.

Replace the AccessibilityHostable protocol with a ViewsHostable
protocol, and add a C++ interface, ui::ViewsHostableView, which provides
a single place through which a views::View and a content::WebContentsView
are stitched together
- have content::WebContentsViewMac implement ui::ViewsHostableView
- have views::NativeWidgetHost implement ui::ViewsHostableView::Host

Use this explicit interface to ensure that the views::NativeWidgetHost
detaches from the content::WebContentsViewMac before it is destroyed.

Additional parameters and method will be added to the
ui::ViewsHostableView interface to enable stitching together
out-of-process NSViews.

R=lgrey
TBR=avi (content/ OWNERship)

Bug: 821561
Change-Id: Iddc46278cd06b9e27d3f12aa5a9e830273f3b562
Reviewed-on: https://chromium-review.googlesource.com/1252641
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595521}

Only DetachTimeFg16x is added because it is the most
different variation from control, while other variations
test values in between.


Bug: 847501
Change-Id: I12da837873f86345e36cfb9577a7a803015baa40
Reviewed-on: https://chromium-review.googlesource.com/1249805Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595520}

There were two possible users of this logic:

1. RenderFrameImpl::LoadDataURL. This one is done during a commit time,
and it seems strange to reuse previous request for data urls, while
not reusing it for all other requests.

2. NetErrorHelper::LoadErrorPage. This one is called from
NetErrorHelper::DidFinishLoad through a chain of callbacks, so
there should not be a provisional document loader at the time of
commit and the logic is wasted.

Note that error page loads did switch to CommitDataNavigationWithRequest
recently, so are not using this logic anymore.

Bug: none
Change-Id: I3b00921c2c6441a007e8391ba3a4a8119d08c5bb
Reviewed-on: https://chromium-review.googlesource.com/1246599Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595519}

Also document GetCatalogTask and update the version checking logic to
be more accurate and clearer.

Bug: 889104
Change-Id: I2467dd767c7a19e5454d4b31412061ea884b2b7e
Reviewed-on: https://chromium-review.googlesource.com/1254741Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595518}

Bug: 878390
Change-Id: I163448cb47ebd21e0c078a6b372466d163336186
Reviewed-on: https://chromium-review.googlesource.com/1228113Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595517}

We are not ready for flatten in frames - the TargetRegistry is null.

Bug: 890760
Change-Id: I8bbffad4f74ffa12f371ce7feef32cae3d6f6304
Reviewed-on: https://chromium-review.googlesource.com/1255122Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595516}

Adding myself there to be able to track things easier.

Change-Id: Ia1228e69de4da77630208d12016754086f28b1be
Reviewed-on: https://chromium-review.googlesource.com/1253622Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595515}

This patch fixes a few issues found while trying to hook up image
decoding end-to-end:
* The images are improperly inserted into the database, since binding as
  string uses the text type, which tries to use UTF8 encoding (which
  doesn't work for binary blobs.)
* Decode failures used to cause a DCHECK, now just bail out with an
  error value
* A callback was called one too many times, even after std::move.
* A crash would happen if a category had no images.

Bug: 867488
Change-Id: Ie28c01e28bd746b9a90563c228775ff3b5a8f83f
Reviewed-on: https://chromium-review.googlesource.com/1248041Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595514}

This CL adds logic to automatically grant notification permissions for
Android Messages for Web immeadiately after the PWA installation.

Bug: 875511
Change-Id: I3ff64ad1439ecaf1ea57e11609a8bcf2cf4b34bf
Reviewed-on: https://chromium-review.googlesource.com/1252903Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595513}

This adds HostFrameSinkManager::FindRootFrameSinkId() to find the root
frame sink id. This is necessary as
window->GetHost()->compositor()->frame_sink_id() is not the root frame sink in
mash.

BUG=879791
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5a1520b2ba144cb231d254059810ff153add3a49
Reviewed-on: https://chromium-review.googlesource.com/1249152
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595512}

Part of ongoing effort to eliminate duplicate code
introduced when automation API was added to Chromecast.

Making Chromecast's copy of AXTreeSourceAura derive from
AXTreeSourceViews.  The two now nearly identical copies of
ax_tree_source_aura.cc will be merged and moved up to
ui/views in a subsequent CL.

Bug: 837773
Test: Manual verification on chromecast and chromeos (tidus)
Change-Id: I1b083280ce280ec0bd25324778f5d84ec3a7e9cf
Reviewed-on: https://chromium-review.googlesource.com/1249682
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595511}

https://android.googlesource.com/platform/external/perfetto.git/+log/5cfa93810a40..7f61afaa6ec3


git log 5cfa93810a40..7f61afaa6ec3 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 fmayer@google.com Disable ubsan on Travis.


Created with:
  gclient setdep -r src/third_party/perfetto@7f61afaa6ec3

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I2db8442bb7cf4d197282e11e5a5e7e1562b2d255
Reviewed-on: https://chromium-review.googlesource.com/1254842Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595510}

Bug: 872688
Change-Id: Ia54b127e61d0eb16d673e2b2ae13c4e3aa220b96
Reviewed-on: https://chromium-review.googlesource.com/1208360Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595509}

When the test was added in https://codereview.chromium.org/26678004/
it only passed on macOS. Since macviews it no longer passes anywhere,
so just delete it.

Bug: 832676
Change-Id: Ie5b3f476f96d7f750612f58ac0c4f9016166ab11
Reviewed-on: https://chromium-review.googlesource.com/1255205Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595508}

This does the same edit to SVGImageElement::InsertedInto as
https://chromium-review.googlesource.com/1141121 did to HTMLImageElement.

Bug: 864306
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74696c16c27eba363e4965d996f3ae688ef27c91
Reviewed-on: https://chromium-review.googlesource.com/1254265Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#595507}

BUG=737995,881371
R=pkasting

Change-Id: I4dc5b47f91c4330497bd26f3ae7ff4affe7ff193
Reviewed-on: https://chromium-review.googlesource.com/1250166
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595506}

This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes
forces the user scrollable bit to be false. It excluded layout object is not LayoutFrameset
but it is of type of Frameset.

In this patch, we changed the Frameset check to body->GetLayoutObject()->IsFrameSet().

Bug: 875287
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icefcc3801dc79b39576f1248a07e43f905279e13
Reviewed-on: https://chromium-review.googlesource.com/1254470Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595505}

Bug: 807714
Change-Id: Ib6a6b2fce7ddb494741364976c73569ce87756f8
Reviewed-on: https://chromium-review.googlesource.com/1228881
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595504}

UMA logging added here:
https://chromium-review.googlesource.com/1232615

Bug: 877671
Change-Id: Icf550ec0dd047462fcf385a7fbf830099c487407
Reviewed-on: https://chromium-review.googlesource.com/1238470
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595503}

Bug: chromedriver:2543
Change-Id: I929e5a37607b596d169534dff87c2e5cbb817538
Reviewed-on: https://chromium-review.googlesource.com/1252983Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595502}

This adds a bit of padding after the checkboxes and makes entire
rows clickable.

Bug: 887678
Change-Id: I89d6d7f1901170d6178b3b5e0fce228b3d584d00
Reviewed-on: https://chromium-review.googlesource.com/1252524Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595501}

This CL replaces Chrome-specific tinting view classes with their
AppCompat equivalents: TintedImageView -> AppCompatImageView and
TintedImageButton -> AppCompatImageButton.
1. Entries in XML layouts have fully qualified names because some
   layouts are inflated outside AppCompatActivity, so AppCompat magic
   doesn't work for them.
2. AppCompatImageView doesn't have setTint, so
   ImageViewCompat.setImageTintList is used instead.
3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
   so these are replaced, too.

Bug: 727723
Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1
Reviewed-on: https://chromium-review.googlesource.com/1245786
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595500}

Charlie points out a bug at https://crbug.com/863471#c2: |name_|
and |value_| should be cleared if |other| is of LOOKUP type
but |*this| is not.  This does not cause any leaks or undefined
behavior, but is potentially a waste of memory.

As much as I would love to remove spdy::HpackEntry::operator=()
altogether, this causes the compile to fail on Windows.  Somehow
assignment operator is needed to put HpackEntry in a std::dequeue.
See win_chromium_compile_dbg_ng trybot failures on Patch Set 2.

This CL lands server changes 212433946 and 215208407 by bnc.

BUG=488484

Change-Id: Ia64c9a50232297f333f587c0d68de650d93f77db
Reviewed-on: https://chromium-review.googlesource.com/1252085
Commit-Queue: Bence Béky <bnc@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595499}

Bug: 725061
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9bec1e76635379dd7a09a5160e1dff69074692f9
Reviewed-on: https://chromium-review.googlesource.com/1183232Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595498}

There are a lot of features of DMG files that we don't support, and some
of these can be used to deliver malware. We should always send a ping
when we detect a DMG file, instead of relying on detecting the contained
binary.

Bug: 882927
Change-Id: Idf7523f575a5d9778ab5d14ea1112317118fd2ed
Reviewed-on: https://chromium-review.googlesource.com/1225050Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595497}

Bug: 101600
Change-Id: Ide53ff3455d66ec222dd7a92441161ae7a1f5962
Reviewed-on: https://chromium-review.googlesource.com/1251322Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595496}

Unused after https://chromium-review.googlesource.com/1252245

Bug: 832676
Change-Id: If22ce2914aab2cc4fe518ee10935830b53f6cbf7
Reviewed-on: https://chromium-review.googlesource.com/1255202Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595495}

https://chromium.googlesource.com/angle/angle.git/+log/a78092cb2557..5ddbdbf70c50


git log a78092cb2557..5ddbdbf70c50 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 jmadill@chromium.org Vulkan: Fix bugs in glGenerateMipmaps.


Created with:
  gclient setdep -r src/third_party/angle@5ddbdbf70c50

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I89d7ab1e7eb55af9b90b707f1677de75d5e192bb
Reviewed-on: https://chromium-review.googlesource.com/1254641Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595494}

Element::setAttribute() implementation with TrustedType modified to
prevent insecure case-insensitive attributes change with strings.

Bug: 739170
Change-Id: Ia0636f4791cbc204b679de510e5c676de817dd11
Reviewed-on: https://chromium-review.googlesource.com/1238539
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595493}

In components/password_manager/core/browser/BUILD.gn:unit_test,
the .../form_parsing:unit_tests dependency is added twice:
once unconditionally and once for iOS.
The latter is older but now obviously unneeded.
So this CL removes the latter.

Bug: 845426

Change-Id: Iba83449d74cf041369dbced5506d1055f7686e7a
Reviewed-on: https://chromium-review.googlesource.com/1252482Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595492}

Following bot results are included.
10090 10094 10097 10100 10108 10114 10119 10133 10135 10146
10156 10170 10178 10184 10188 10201

2 lines were removed and 6 lines were deflaked by consecutive
results since 10108.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibce2757c1abe3ef73fec672756278d870abca479
Reviewed-on: https://chromium-review.googlesource.com/1248882
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595491}

https://skia.googlesource.com/skia.git/+log/e8e2bb1384ad..3ad86d0c8bc4


git log e8e2bb1384ad..3ad86d0c8bc4 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 michaelludwig@google.com Accept processor test seed from command line


Created with:
  gclient setdep -r src/third_party/skia@3ad86d0c8bc4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Id435576cae77f5cb11641d30a3ccac03cd22a064
Reviewed-on: https://chromium-review.googlesource.com/1253825Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595490}

This CL does the following changes to the code used by
ChromePasswordManagerClient:

(1) Extracts its platform-independent part into the core component.
    This will be useful when adding these metrics to iOS.
(2) Adds tests for that code.
(3) Replaces an obsolete guard against race-conditions with a
    thread-safe singleton pattern making use of modern C++.

Bug: 887409
Change-Id: Ie9ad57d75df3bcebf491aa3f32c5f4919ca93f5b
Reviewed-on: https://chromium-review.googlesource.com/1251543
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595489}

api_test_utils::CreateExtension() variants are no longer really useful
with the new-and-improved ExtensionBuilder class. Remove them to reduce
code and have one fewer ways of constructing test extension objects.

While we're at it, const-ify the creation sites.

TBR=atwilson@chromium.org
(just updating background_mode_manager_unittest to use a builder)

Bug: 889925
Change-Id: I99087834e6b4c30a43c0badb0245295e0e1de525
Reviewed-on: https://chromium-review.googlesource.com/1252766
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595488}

This CL changes the currentTime algorithm to respect the start and end
scroll offset specified for the ScrollTimeline. It does not change the
compositor logic - that is left for a followup.

https://wicg.github.io/scroll-animations/#dom-scrolltimeline-startscrolloffset

Bug: 885196
Change-Id: I732a39659f1f354a8dec982bf75e14f11c0f2134
Reviewed-on: https://chromium-review.googlesource.com/1238376
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595487}

This reverts commit 49993008.

Reason for revert: maintenance over, reenabling CQ

Original change's description:
> Drain the CQ starting at 11AM PST for emergency lab network maintenance.
> 
> Maintenance will last about an hour. Drain the CQ for the duration of
> this.
> 
> NOTRY=true
> TBR=jbudorick, tandrii
> 
> Change-Id: Ic5114c910c431ddd92cacfc323d7cd420cc9657a
> Reviewed-on: https://chromium-review.googlesource.com/1255222
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595479}

TBR=tandrii@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: Ia66d9c492cca5001bfffbbc40992f49cd5b108aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1255582Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595486}

On the about:omnibox page, the transition table-header is a hyperlink to the relevant code segment explaining page transitions. This cl fixes that link.
Previous broken link: http://code.google.com/codesearch#OAMlx_jo-ck/src/content/public/common/page_transition_types.h&exact_package=chromium&l=24
New link: https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h?q=page_transition_types.h&sq=package:chromium&dr=CSs&l=14

Change-Id: I75512d5d6b5420396f8ee22271798c365e4c6c90
Reviewed-on: https://chromium-review.googlesource.com/1252010Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595485}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ddc705933d3f..fe90a1d2dcbe


git log ddc705933d3f..fe90a1d2dcbe --date=short --no-merges --format='%ad %ae %s'
2018-10-01 jbolz@nvidia.com Enable /MP4 (parallel build across 4 cores for MSVC) for SPIRV-Tools/source[/opt] (#1930)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@fe90a1d2dcbe

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3bb22dffe11913d8fce558b19f164570bc313854
Reviewed-on: https://chromium-review.googlesource.com/1254522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595484}

This adds a new value to Download.IOSDownloadMimeType histogram.

From graphics.pixar.com:
USD is the core of Pixar's 3D graphics pipeline, used in every 3D
authoring and rendering application, including Pixar's proprietary
Presto animation system.

USD previews are supported by Safari and logging the usage will help to
decide the priority of supporting USD previews in Chrome.

Bug: 883399
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I40ceac24f21316f2e5681f1f8af9ea538ac7509e
Reviewed-on: https://chromium-review.googlesource.com/1252363Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595483}

This new policy maps to the CloudDpc policy
vpnConfigDisabled, which turns off the user's ability
to modify their VPN configuration by disabling the settings
UI. In the future, we also want to apply this policy to
Chrome settings.

BUG=b:72861260
BUG=873123
TEST=unit test

Change-Id: I7c4046f95790350f9a44c311972afc3a3ad68d84
Reviewed-on: https://chromium-review.googlesource.com/1251586Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595482}