GitLab

https://skia.googlesource.com/skia.git/+log/8b0f9d18ddf8..5820b0c3f3ce


git log 8b0f9d18ddf8..5820b0c3f3ce --date=short --no-merges --format='%ad %ae %s'
2019-01-03 michaelludwig@google.com Use specialized quad lists in rectangle ops
2019-01-03 reed@google.com change textutils to require font param
2019-01-03 kjlubick@google.com [canvaskit] Refactor skottie into own file
2019-01-03 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-03 robertphillips@google.com Make the RRectEffect's screen coords be Float4 (rather than Half4)
2019-01-03 michaelludwig@google.com Normalize vectors in dot product for quad type calculations.
2019-01-03 halcanary@google.com SkPDF: eliminalte one member function
2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4627b3705d59..9fa54eab2590 (1 commits)
2019-01-03 reed@google.com use drawSimpleText
2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e9b211dd665b..8b9d1f9db8a8 (1 commits)
2019-01-03 reed@google.com remove legacy drawPosText (and variants)


Created with:
  gclient setdep -r src/third_party/skia@5820b0c3f3ce

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:915025,chromium:917242,chromium:b/122105577
TBR=bungeman@chromium.org

Change-Id: I6d8fd6fb28bbee8eb2eca4dc1e3118139b57ae65
Reviewed-on: https://chromium-review.googlesource.com/c/1394922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619822}

Bug:

Change-Id: Ie49fde45c2efc4c70fbfa8e99841541064e7540d
Reviewed-on: https://chromium-review.googlesource.com/c/1395158Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619821}

The recently added timer performance test for __rdtsc fails to compile
on ARM64, for obvious reasons. This change fixes the test to use the
ARM64 cycle counter when building for that platform.

The ReadCycleCounter definition was copied from base\time\time_win.cc

Bug: 893460
Change-Id: I0d891c5a197e097084a765ab66e9da1b4173b418
Reviewed-on: https://chromium-review.googlesource.com/c/1394987Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619820}

Bug: 918848

Change-Id: I1b712a3aee6f8950160886141065e1b0a3799c34
Reviewed-on: https://chromium-review.googlesource.com/c/1394873
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619819}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5f346a1b0b4..c48496fe54a9


git log b5f346a1b0b4..c48496fe54a9 --date=short --no-merges --format='%ad %ae %s'
2019-01-03 jclinton@chromium.org cbuildbot/manifest_version.py: Use Gerrit autosubmit feature throughout


Created with:
  gclient setdep -r src/third_party/chromite@c48496fe54a9

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I5620619fb1301138d4ad1c23725ab15725756d0d
Reviewed-on: https://chromium-review.googlesource.com/c/1394992Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619818}

This CL moves handling of the "sandbox.content_security_policy" to the
CSPHandler from SandboxedPageHandler. This should have no behavior change. This
is in preparation of introducing the "content_security_policy.sandbox" manifest
key.

BUG=914224

Change-Id: I27e839a09211d7fccc0104e6195d6c123cca8ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1391877
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619817}

Bug: 889106
Change-Id: I7c5fa213d3ca323b495d1e785605e9e1f1b6f986
Reviewed-on: https://chromium-review.googlesource.com/c/1385482Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619816}

PVer4 rolled out in M57.

I had added code to delete PVer3's files from disk along with a comment
saying:
// This method can be removed after the UMA metrics for the following prefix
// go down to 0 in Stable: "SafeBrowsing.V4UnusedStoreFileExists.V3."

Well [1][2] shows that this metric is down to 0 for all stores now.
[1]: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=6ebed968120f27fb42f41b6a21afb541
[2]: http://screen/NWvJt0wwNjv

R=drubery

Bug: 916192
Change-Id: I504c51c32a1247aa3375c13c902ec12612c46429
Reviewed-on: https://chromium-review.googlesource.com/c/1382896
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619815}

As per report at crbug.com/910044

Bug: 910044
Change-Id: I43b4467710b44cb9a6c2b755e23512d7b7318479
Reviewed-on: https://chromium-review.googlesource.com/c/1394398
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619814}

Adds UKM metrics about the Lite Page Redirect preview including a bool
if it was committed and what navigation restart penalty it incurred.

Bug: 917491
Change-Id: I6db29a49b2ec8d0ac8127209dcf2a5925d325f7a
Reviewed-on: https://chromium-review.googlesource.com/c/1394792Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619813}

Split the Cocoa-facing parts of JavaScriptAppModalDialogCocoa into a
separate views_bridge_mac::AlertBridge class, implementing a mojo
interface of the same name.

The mojo interface has a single method, Show, which has a single
callback, indicating the disposition of the alert.

Make JavaScriptAppModalDialogCocoa instantiate
views_bridge_mac::AlertBridge across mojo either in-process or
out-of-process as needed. Note that this subtly changes the behavior of
JavaScriptAppModalDialogCocoa::AcceptAppModalDialog in that it will no
longer attempt to read the dialog's text when programmatically
quitting (note that this feature may be dead code).

This makes alerts appear in the appropriate process. Note that the
alerts of PWAs and of Chrome are still interconnected. Only one alert
may be present at once, and an active alert will take focus from Chrome
and all PWAs.

Bug: 898604
Change-Id: I37267cf7aa41d8e68cb2d342a5058e257b2d4385
Reviewed-on: https://chromium-review.googlesource.com/c/1390757Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619812}

We still intend to use these histograms for analysis. Looks like I was
a little too ambitious with how long it would take to be done with these.

Bug: 915890
Change-Id: Iebbd33fb9bc7fc0df698abe431e9dde7e45f190b
Reviewed-on: https://chromium-review.googlesource.com/c/1393891Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619811}

IsBrowserSideNavigationEnabled() is now always returning true, causing
this test to be disabled. It does pass now, so we can potentially
enable it if it is still valid.

Bug: 789577
Change-Id: I85438a626b6b764c4ad07e6e74d7cb08c8adad4a
Reviewed-on: https://chromium-review.googlesource.com/c/1394932Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619810}

Change-Id: Ia467b55e2e56df946dfd7a0268c3bc1ccad2f291
Reviewed-on: https://chromium-review.googlesource.com/c/1391719Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619809}

https://dawn.googlesource.com/dawn.git/+log/74ec15010f8a..0b364067d04c


git log 74ec15010f8a..0b364067d04c --date=short --no-merges --format='%ad %ae %s'
2019-01-03 cwallez@chromium.org MetalBackend.h: Remove dead declarations


Created with:
  gclient setdep -r src/third_party/dawn@0b364067d04c

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I4f2dcf9fd64daa5cacd7d0642e4b5e4004f5df96
Reviewed-on: https://chromium-review.googlesource.com/c/1394826Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619808}

This CL changes CSPHandler so that it can be used for both extensions and
platform apps without creating a different instance for the two. This helps
simplify the code.

BUG=914224

Change-Id: Ib99fd306071514706d6a3a6b032870f016736a9e
Reviewed-on: https://chromium-review.googlesource.com/c/1394912Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619807}

When QuicSession::ClosePendingStream, before remove the pending stream
from the pending_stream_map_, QuicSession::SendRstStream is invoked to
send a reset acknowledgement to the peer. In Chromium,
QuicChromiumClientSession overrides SendRstStream method, and calls into
GetOrCreateDynamicStreamImpl() to close the pending stream as well as
remove from pending_stream_map_. QuicSession holding the already deleted
iterator will attempt to remove the entry again.

This change adds iterator check right before removing the entry to avoid
use after free issue.

Bug: 918849, 918890
Change-Id: I27b7a4433d6783e4484a5dcb49446d89e997b8bf
Reviewed-on: https://chromium-review.googlesource.com/c/1394920
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619806}

This reverts commit 0cf17084

Bug: internal b/119639315
Test: CQ
Change-Id: Ibbd4e8469895299f938549bb146641504643d3f3
Reviewed-on: https://chromium-review.googlesource.com/c/1387464Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Marzena Dell'Aquila <mdellaquila@google.com>
Cr-Commit-Position: refs/heads/master@{#619805}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5823360bf2c2..447d7854291e


Created with:
  gclient setdep -r src-internal@447d7854291e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I326368704d0cc31a04b2a7ec45d39f16fe11b464
Reviewed-on: https://chromium-review.googlesource.com/c/1394983Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619804}

Turns out this test is failing on other debug builds as well, e.g.:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/76911

it also has failed on a Mac 10.12 rel bot, so updating to include all Mac bots

Bug: 918905
Change-Id: I30628e6ee16674d8b961cbbbd273255f4429ad5e
Reviewed-on: https://chromium-review.googlesource.com/c/1394927
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619803}

Ink is now open source at https://github.com/google/ink. As discussed
in go/ink-in-chromium the short term plan is to include build artifacts
based on those sources rather than attempt to produce as part of the
chromium build.

That strategy is demonstrated in https://chromium-review.googlesource.com/c/chromium/src/+/1393204

Bug: 902646, 818624
Change-Id: I65f0e3eeb406f72c8c26fb71c4de846c557ba17c
Reviewed-on: https://chromium-review.googlesource.com/c/1393583Reviewed-by: François Degros <fdegros@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619802}

Remove
Event.CompositorThreadEventQueue.CoalescedCount
Event.CompositorThreadEventQueue.Continuous.HeadQueueingTime
Event.CompositorThreadEventQueue.Continuous.TailQueueingTime
Event.CompositorThreadEventQueue.NonContinuous.QueueingTime

Bug: 796006
Change-Id: Icc78eb8c6fbd47baeaaca5e1de50126744d9180e
Reviewed-on: https://chromium-review.googlesource.com/c/1392737Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619801}

Historically, the struct RequestNavigationParams was introduced during
the development of PlzNavigate navigation code (now the only navigation
code). It made a lot more sense initially for this struct to be named
like that, however as the codebase has evolved, it no longer makes as
much sense. It is much more correct to be named CommitNavigationParams
as it carries parameters needed to commit a navigation.
This CL carries out this rename across the codebase.

Change-Id: Icdfbda7d3d3f337ad3d8730efe5d3cc94822286f
Reviewed-on: https://chromium-review.googlesource.com/c/1394825
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619800}

This cl:
1) Moves a bunch of tests from WindowSelectorTest to new
ScopedTransformOverviewWindowTest file.
2) Moves some static class constants to a newly introduced overview
constants file.

Test: ash_unittests ScopedTransformOverviewWindowTest*
Bug: 914147
Change-Id: I1c81533a0d0cb245c05ce4a4d288b574c0fc1784
Reviewed-on: https://chromium-review.googlesource.com/c/1394324
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619799}

Bug: 322303
Change-Id: I33f288443c86dba67e4cd3e1db564c02604dea03
Reviewed-on: https://chromium-review.googlesource.com/c/1394988Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619798}

Previously video with object-fit:none or object-fit:cover was
not clipped when the contents overflowed the replaced content
box, because it was treated as an image that was supposed
not to paint outside of the replaced content box but not true.

Simplify overflow clip logic of replaced element. Remove the
dependency of image overflow clip on compositing state.

Now media no longer inherit overflow clip rule from image to
ensure overflowing contents of media are clipped.

ReplacedPainter will emit paint chunk with overflow clip
depending on paint property only. No longer depends on other
conditions. This applies to all replaced elements.

Bug: 912357
Change-Id: I5de102f7b6b9ad79f372392de44012deb8a9cfec
Reviewed-on: https://chromium-review.googlesource.com/c/1387152
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619797}

- Shares that require credentials are no longer remembered.
- Previously, all shares would be persisted regardless of whether or
  not they had credentials.
- A future CL will resume persistence on all shares.

Bug: chromium:913691
Test: emerges
Change-Id: I7dd5290d8b5af60bf6a9d14ac69e2bef5ba6c1c2
Reviewed-on: https://chromium-review.googlesource.com/c/1372915Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619796}

https://chromium.googlesource.com/catapult.git/+log/2667a52a4bde..86c48a10110c


git log 2667a52a4bde..86c48a10110c --date=short --no-merges --format='%ad %ae %s'
2019-01-03 nednguyen@google.com Remove nednguyen@ from catapult OWNERS files


Created with:
  gclient setdep -r src/third_party/catapult@86c48a10110c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5c67768600848fd603ca0c01b099d10a512d5c6a
Reviewed-on: https://chromium-review.googlesource.com/c/1394914Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619795}

It just initializes the context, which does almost the same thing
as when the LayoutView is walked.

Change-Id: I8a4b0560bdb1da79361db8c16948f0d67aa236ce
Reviewed-on: https://chromium-review.googlesource.com/c/1394929Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619794}

R=dpapad@chromium.org
BUG=916782

Change-Id: I39b438178bd0f39fbfb0160a8735ffd0f06fb147
Reviewed-on: https://chromium-review.googlesource.com/c/1394365Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619793}

Change-Id: I0b9d04f69d5dba38bdcd0889648023d3ad5939cf
Reviewed-on: https://chromium-review.googlesource.com/c/1394353Reviewed-by: François Degros <fdegros@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619792}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db0055dc786a..4ad409510d23


git log db0055dc786a..4ad409510d23 --date=short --no-merges --format='%ad %ae %s'
2019-01-03 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@4ad409510d23

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ib7cceea6cb7064c9d45ed1443465b7e4cd3dba99
Reviewed-on: https://chromium-review.googlesource.com/c/1394905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619791}

De-virtualize ExtensionFunction::HasPermission(). There's no reason for
it to be virtual, and the only overridden implementation of it
(TabsCaptureVisibleTabFunction) just returns `true`.

Also fix some const-ness issues.

Bug: None
Change-Id: Id5b278553e1fd9f89634bacfec7fe83c794e78e7
Reviewed-on: https://chromium-review.googlesource.com/c/1391720Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619790}

This reverts commit 02979f89.

Reason for revert: Causing failures on linux-xenial-rel bot:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/6075

Original change's description:
> Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource"
> 
> This is a reland of 7c6d18ba
> 
> Original change's description:
> > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource
> >
> > This CL is strictly a refactor that switches the Ads PLMO to count frame
> > data using ResourceDataUseUpdate instead of OnLoadedResource. This will
> > allow us to include incomplete resources and header bytes in future
> > per-frame metrics. This will not change behavior of existing histograms
> > at all.
> >
> > Bug: 878393
> > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251
> > Reviewed-on: https://chromium-review.googlesource.com/c/1372428
> > Commit-Queue: John Delaney <johnidel@chromium.org>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#619436}
> 
> TBR=rsesek@chromium.org
> 
> Bug: 878393
> Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a
> Reviewed-on: https://chromium-review.googlesource.com/c/1393530
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#619760}

TBR=jkarlin@chromium.org,rsesek@chromium.org,johnidel@chromium.org

Change-Id: Ia755a547df8982402942b3430e6680ed1e97f3a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878393
Reviewed-on: https://chromium-review.googlesource.com/c/1394949Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619789}

Bug: 907236
Change-Id: Id7267ce5a3edec725375738ba069d58431102841
Reviewed-on: https://chromium-review.googlesource.com/c/1394735Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619788}

This ensures that we will paper over any confusions regarding non-stacking
composited layers such as as those created by backface-visibility: hidden.

Setting the bit on the enclosing stacking layer suffices because any
other composited layer must be a stacking child of it, and the
kGraphicsLayerUpdateSubtree is used.

Bug: 916077

Change-Id: I695f9b7a6700e1bed3bc55034916b200a1d7849e
Reviewed-on: https://chromium-review.googlesource.com/c/1394187Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619787}

The two feature flags are incompatible, so make multi-process mash
take precedence.

Fix some direct references to features::kMash for consistency.

TBR=sky@chromium.org

Bug: 918859
Test: chrome --login-manager --enable-features=Mash logs in
Change-Id: I18ac68e5e7bd01962369549b2b966592b9db0105
Reviewed-on: https://chromium-review.googlesource.com/c/1394796
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619786}

The secondary members should not be considered while comparing
profiles.

Change-Id: I56c7b19f5da27b2f7c147b0d005b0686c40a39a9
Reviewed-on: https://chromium-review.googlesource.com/c/1394930
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619785}

Add MultiDrawManager with MultiDrawBeginCHROMIUM and MultiDrawEndCHROMIUM commands to batch chunks of MultiDraw calls

MultiDraw commands that are larger than the transfer buffer are chunked
into multiple commands. This was incorrect because gl_DrawID would get
reset to 0 for each chunk. This change adds Begin and End commands which
allow MultiDraw chunks to be batched and submitted all together when
MultiDrawEndCHROMIUM is received.

This change includes tests which check the expected commands and that
the gl_DrawIDs for commands larger than the transfer buffer are correct.

Bug: chromium:890539
Change-Id: Ida64685be9779b6f6419d247126378a057cb627c
Reviewed-on: https://chromium-review.googlesource.com/c/1372636
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619784}

Bug: 167187
Change-Id: Ia2e184751c33c5894d7e20271b97d693a2062cae
Reviewed-on: https://chromium-review.googlesource.com/c/1392330Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619783}