- 31 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/64a3bb93dcea..9ec47a0bca27 git log 64a3bb93dcea..9ec47a0bca27 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 jiajie.hu@intel.com Validate texture component type in BGL against its shader module declaration Created with: gclient setdep -r src/third_party/dawn@9ec47a0bca27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ide00eb1c32801012658873c0dc07a9e7dbe14dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711203}
-
Mikhail Khokhlov authored
Bug: 1018248 Change-Id: I82dc9af8d17059f014180e7e8daf08a2f0b72499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887691Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#711202}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Id6d956b02758aecaa0710aee56715429f5ffc267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884819 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#711201}
-
Hajime Hoshi authored
The reasons why the back-forward cache is not used is obtained from BackForwardCacheImpl::CanStoreDocument, and this should be the ground truth. Bug: 1004676 Change-Id: Ibff1eb26665dfbb29635181353657a871bb7e0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889890Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711200}
-
Omer Katz authored
Both types are identical so we can merge them into one. Leaving MarkingItem as an alias for readability. There are a few cases where we had a TraceDescriptor which we had to unbox to create a new MarkingItem. Making MarkingItem and TraceDescriptor the same type avoids this. Bug: 986235 Change-Id: Ie5e596abed358c2663ae32ac1b9e279757f57e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890436 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711199}
-
Tanmoy Mollik authored
SyncEncryptionKeysTabHelper::EncryptionKeyApi::SetEncryptionKeys() should pass gaia_id to AddTrustedVaultDecryptionKeys() SyncUserSettings::AddTrustedVaultDecryptionKeys() expects gaia_id as per the implementation https://cs.chromium.org/chromium/src/components/sync/driver/sync_service_crypto.cc?l=324&rcl=6b95460e56dc3cf417134e8eb1baed68daa55a34 It should not be getting a CoreAccountId object. Change-Id: I1e3dddd14539d256e0083c8cb59e81ffeda45d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886827Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#711198}
-
Caleb Raitto authored
IIUC, the iframe content is fetched from another resource, not written inline. Make it clear that we're presenting a devtools-like view of the frame content. Change-Id: I43adb622bcc03ef1d51429386f11966de0171dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890476Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#711197}
-
Eero Häkkinen authored
This adds no BOM decoding option to TextResourceDecoderOptions which disabled BOM checking in the decoder. Bug: 796192 Change-Id: Id0eb00dca451c4898d9ae00f11bf08e7fbb33a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796366Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#711196}
-
Alex Clarke authored
We're seeing expensive low priority tasks getting in the way of navigation tasks, so we should turn this logic off. It's an oversight that it was ever enabled on the UI and IO thread in the first place. This change has exposed a few latent issues: 1. BackgroundSyncTest is failing on the bots due to an infra issue where Play Services is not up to date. 2. Several extension tests where failing due to unwanted TaskPriority propagation for tasks posted from GetExtensionFileTaskRunner() to the UI thread. These tasks where inheriting the sequence's USER_VISIBLE priority and running much later than expected as a result of removing the anti-starvation code. I've worked around that by explicitly setting the priority to the default which is USER_BLOCKING. 3. Some navigations in the UrlOverridingTest are actually getting canceled by the InterceptNavigationThrottle. Previously the task notifying this didn't run in time to be picked up by the test, now they are we need to update the test expectations. Bug: 1013535 Change-Id: Ie9e5bc38f62e8a451b9287390752d3bd1c3284c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863410 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711195}
-
Henrik Andreasson authored
This reverts commit d7b4f14f. Reason for revert: Discussed with Chrome Sheriff and decided to land the original CL again since the CL only affects logging and no audio-related functions. Original change's description: > Revert "Adds native WebRTC logs to media::InputController." > > This reverts commit 29ab72b2. > > Reason for revert: [sheriff]suspected culprit for https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/28504 > > Original change's description: > > Adds native WebRTC logs to media::InputController. > > > > These changes will make it possible to track down issues related to > > audio input streams (create/open/close) using native logs. > > > > Focusing on AudioServiceAudioStreams since old streams are going away. > > > > Tbr: olka > > Bug: 1017219 > > Change-Id: Iffbc1880d9eea1868ce1a5e17e298c03328949e0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886676 > > Commit-Queue: Henrik Andreasson <henrika@chromium.org> > > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711176} > > TBR=guidou@chromium.org,henrika@chromium.org > > Change-Id: Ibe7f92aaa821264e3cfd1cc6353c1d1ecae0e134 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017219 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892774 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711191} TBR=guidou@chromium.org,armax@chromium.org,henrika@chromium.org Change-Id: I9bedb45daccd46f0352420688bee1380b48f86ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891174Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#711194}
-
Vasilii Sukhanov authored
There are two bugs fixed together. - HttpAuthManagerImpl::OnLoginSuccesful should care about the case when the password store isn't done. In such a case the prompt should not be invoked. - ManagePasswordsState should account for the method parameters may depend on the internal memeber |form_manager_|. Bug: 1017481 Change-Id: Ib63d1c7480cc2a5130d943e36cb0a02f9b0af7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890437 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#711193}
-
Hajime Hoshi authored
Bug: 1004676 Change-Id: I7d6ef345c9abea66d47cc2808ebb8aebe14eef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892634Reviewed-by:
-
Armando Miraglia authored
This reverts commit 29ab72b2. Reason for revert: [sheriff]suspected culprit for https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/28504 Original change's description: > Adds native WebRTC logs to media::InputController. > > These changes will make it possible to track down issues related to > audio input streams (create/open/close) using native logs. > > Focusing on AudioServiceAudioStreams since old streams are going away. > > Tbr: olka > Bug: 1017219 > Change-Id: Iffbc1880d9eea1868ce1a5e17e298c03328949e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886676 > Commit-Queue: Henrik Andreasson <henrika@chromium.org> > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711176} TBR=guidou@chromium.org,henrika@chromium.org Change-Id: Ibe7f92aaa821264e3cfd1cc6353c1d1ecae0e134 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892774Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711191}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id117193a8707693615ca7c9345c3af3f50da2743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892751Reviewed-by:
-
Christian Dullweber authored
This reverts commit 1205b351. Reason for revert: Accidentally disabled the wrong test. The flaky test seems ok again, so just reverting this CL. Original change's description: > Disable flaky TaskManagerBrowserTest.NoticeHostedAppTabAfterReload on Linux > > Tbr: afakhry@chromium.org > Bug: 1017110 > Change-Id: I3c153b07a4d6c381b7c85684d0e59f09b71712b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875259 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708555} TBR=afakhry@chromium.org,dullweber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017110 Change-Id: Ieda5cfa39e22dd0b965e27d08db6d4962baedde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892771Reviewed-by:
-
Arthur Hemery authored
PerNavigationMojoInterface is now on by default and the flag has been removed. Bug: 968090 Change-Id: I1eb346319fba02cd7d6f22d8a1db444162ea743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886675Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711188}
-
Johannes Kron authored
Bug: chromium:1007526 Change-Id: I05ca79c5b142737eb0549119278b3725d64613f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886670Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#711187}
-
Marina Sakai authored
This CL removes macro-generated fucntions for private properties of CustomElementLifecycle, and replaces them with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: If4cd6487c11e4999f2165bf1ea684c573465a248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892315 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711186}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7e2cba6a5241..618ee509421f git log 7e2cba6a5241..618ee509421f --date=short --no-merges --format='%ad %ae %s' 2019-10-30 dneto@google.com Fix some clang-tidy issues in graphics_robust_access_pass (#2998) 2019-10-30 stevenperron@google.com Add description of wrap-opkill. (#3000) 2019-10-30 kubak@google.com [opt] Do not compare optimized binary with an invalidated buffer (#2999) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@618ee509421f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: Icae7cd22ac49ce55040477cca0802d593a99c607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892047Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/841b01678c49..6946043676e7 git log 841b01678c49..6946043676e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 7e2cba6a5241..618ee509421f (3 commits) Created with: gclient setdep -r src/third_party/angle@6946043676e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: Ifd9bc93f8590d99e5e601ceb1c766feee3bd0903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892559Reviewed-by:
-
Marina Sakai authored
This CL removes macro-generated functions for private properties of MessageChannel by using the new API GetSymbol created in CL1877490. Bug: 715418 Change-Id: I913997334d77807bedc5d2cc8022788c0daa80fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888616 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
-
Caleb Rouleau authored
The possible_browser is not used. The skipping is done later when you try to run the story (in story_runner.py), so skipping here is unnecessary. This change saves ~2 seconds per Android test. The tests seem to run in parallel, so it is unclear how much real time this will save. Bug: 944909 Change-Id: I7e89d7692a79afefcb2706fbaa4d9ce6c1af21e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887873 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
Re-enable SigninSyncConfirmationTest and ProfileMenuViewExtensionsTestWithScopedAccountConsistency tests. This CLs removes chrome/test/data/webui/signin_browsertest.{h|cc} as they are now obsolete. And it also re-enables SigninSyncConfirmationTest.Dialog test as it should be working now. Bug: 862573 Change-Id: I2de61f71ad7ba3935a358ea0d4d8a1864199e1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890077 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: -
Tobias Sargeant authored
Enable Crashpad collection of minidumps on Android. Other platforms are skipped because the concept of the user data directory is OS-specific. On Android specifically crashes are written to [app-data-dir]/cache/Crashpad. Test: manual Test: Check current crash count with: Test: adb shell ls '/data/data/org.chromium.weblayer.shell/cache/Crashpad/pending/*.dmp' | wc -l Test: load chrome://crash or chrome://inducebrowsercrashforrealz Test: Check crash count has increased by 1 Change-Id: I9718754dc4218e7e2f2e7737de420db83d4de14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883653 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711180}
-
Michael Lippautz authored
This removes - the inline vector arena as they are no different then normal vectors - all but a single vector arena as the heuristics for promptly freeing no longer apply and having multiple arenas causes fragmentation issues Bug: 1014932 Change-Id: I7b5cbd9c2f617bedb921cd5e83cb115bd97bdd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863804Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Yi Su authored
Extend the expiration date of 2 metrics for iOS copy image feature: ContextMenu.iOS.GetImageDataByJsResult ContextMenu.iOS.CopyImage Also add gambard@ as backup owner of some metrics. Bug: 1018791 Change-Id: I297f01e1430cb0457b59a11dd22b19de8acd5a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890052Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711178}
-
Armando Miraglia authored
TBR=mmoskvitin Bug: 1020070 Change-Id: I2c5f2790ec98ed7587f73cc15a88eeb059303809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891193Reviewed-by:
-
henrika authored
These changes will make it possible to track down issues related to audio input streams (create/open/close) using native logs. Focusing on AudioServiceAudioStreams since old streams are going away. Tbr: olka Bug: 1017219 Change-Id: Iffbc1880d9eea1868ce1a5e17e298c03328949e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886676 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#711176}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/7a52be2a83..c7284e19a2 TBR=aerotwist@chromium.org Change-Id: Iea2aa69554eeb2b3b5012f4006abcfd8b4673acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891293Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711175}
-
Leon Han authored
This CL introduces a new record type 'absolute-url' based on the spec change: https://github.com/w3c/web-nfc/pull/373 Now we read/write records containing urls like: 'absolute-url' --> TNF_ABSOLUTE_URI 'url' --> TNF_WELL_KNOWN and RTD_URI BUG=520391 Change-Id: I7b7a57c613eb1581efa01fd148c6083b26cd078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881786Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#711174}
-
Peter E Conn authored
One fewer TWA specific classes in the Verifier. Bug: 1017114 Change-Id: Ie4602b9b120f9e39efe1bd0cca2b9e9b76c104c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890430Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711173}
-
Mikel Astiz authored
This reverts commit 38ebe59c. Reason for revert: likely culprit for flakiness in SingleClientUserEventsSyncTest.Encryption. Bug: 1020070 Original change's description: > Rewrite sync tests to use custom passphrase logic > > SingleClientUserEventsSyncTest.Encryption and > TwoClientSessionsSyncTest.NoHistoryIfEncryptionEnabled used > EnableEncryption(), which only works with Directory implementation of > Nigori and outdated. They were rewritten to enable custom passphrase > instead. > > Bug: 922900 > Change-Id: Ia5fedeae5b7c7071c1ecc82063e5742934caf2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890316 > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710839} TBR=mastiz@chromium.org,mmoskvitin@google.com Change-Id: Ie1e8e934c34678b5c96d7a42e293faaefc117c70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891172Reviewed-by:
-
Anastasiia Nikolaienko authored
Project Beaker on Chrome OS is going to allow child users the addition of secondary accounts, but it's going to be limited to web only. - If user has transitioned from child account to regular - TriggerAccountsPushToArc will add accounts to ARC on startup. - If user has transitioned from regular account to child - HandleSupervisionTransition will remove all secondary accounts from ARC. Update is going to be executed on startup, since to transition to another type, user need to sign-out and sign-in again (I think). ARC CL: http://ag/9615344 Bug: 1017160 Change-Id: I323a18aca9c9f63e6a3869d9b9dd4dd34432c31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876089Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#711171}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers. The indirect call here is already unchecked due to the blacklist entry added in https://crrev.com/c/1888716 Bug: 1018834 Change-Id: I68dc018737be985e0bf968d37d117321f53d86ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890986 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#711170}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7677c2ab05a0..9de9e749612a git log 7677c2ab05a0..9de9e749612a --date=short --no-merges --format='%ad %ae %s' 2019-10-31 sanikak@chromium.org auto_updater: Restructuring Transfer Abstract Base Class Created with: gclient setdep -r src/third_party/chromite@9de9e749612a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id778285b5f3d4c652ece02e1366103c2e9ca03ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892065Reviewed-by:
-
Sigurd Schneider authored
This CL also adds more tests to test not only per block, but also per function coverage. This CL effectively reverts the commit: [devtools] Disable tests that (implicitly) test per-block coverage This reverts commit 495e3645. crrev.com/c/1879455 Bug: chromium:1004203, chromium:1009396 Change-Id: I99373bdd1aa4457b727cfac82c9186717a1d6134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883570Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f85f630. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" f701be68 "[css-pseudo] Restrict the properties allowed in ::marker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I6a9a0cc4c366888607f99899398aac4f22e07491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891552Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711167}
-
Yang Guo authored
Bug: 1011259 Change-Id: I97cb5b2956e2f847a534356ab66bc5b02cac27e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881552 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#711166}
-
Miyoung Shin authored
This CL converts TextSuggestionHost mojom interface client in blink to use BrowserInterfaceBroker. Since TextSuggestionHostAndroid life cycle is managed by RenderWidgetHostConnector, this CL gets its object from RenderWidgetHostViewAndroid to register its binder. Bug: 936482 Change-Id: Iccce03e58d9b79ccc8a5f8c011b8ca58e9ed41ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885866 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711165}
-
Alexey Baskakov authored
This is a reland of 5a0adcbe Let's exclude Win platform for now. This is a useful finding which requires investigation. Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Bug: 1019102 Change-Id: I2d01c2a9f5eb94107a4dfc4fea041bdb18871fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892651 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711164}
-
