- 15 Aug, 2019 40 commits
-
-
Mike Frysinger authored
The brotli logic was mostly using bytes already, but a few places were still mixing in strings. Change them over to bytes so the tests pass on Python 3. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I23ed796b7f3483de001a77e548c0d786b53dadf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756243 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#687411}
-
Robbie McElrath authored
See crbug.com/989225#c25 for more details. Bug: 989225 Change-Id: Ib2b9ef82ea881cdc59d2940dfe54d197d53f67bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742381Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#687410}
-
Jeffrey Cohen authored
Bug: 991873 Change-Id: Ic3699c7746fe0d06b19272ce0bbdbba554915914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745392 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#687409}
-
Chris Hamilton authored
This will enable tracking of inbound IPCs that cause tasks to be queued against frozen renderers. BUG=950668 Change-Id: I24252b7859abb22168834f96121a6032d0991f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756251 Auto-Submit: Chris Hamilton <chrisha@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#687408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0b1cbfc167ec..1c51f4ee48f5 git log 0b1cbfc167ec..1c51f4ee48f5 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 dhanyaganesh@chromium.org lib/git: Print Cmd everytime we push to branch 2019-08-15 wbbradley@chromium.org metrics: create framework for metric event gathering Created with: gclient setdep -r src/third_party/chromite@1c51f4ee48f5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id7e663e7a942091243ccda621e1392b017f76af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687407}
-
Mike Frysinger authored
The policy logic sorts a bunch of its keys already to keep the output stable, especially for unittests. The policy_definitions section is not currently sorted which leads to unittest failures on Python 3 as it happens to iterate differently. Sort the keys to fix it. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Iacd30d0edc2a597ada265b4b69664a8d19d9629c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755389Reviewed-by:
-
Ken Rockot authored
This adds a GetNetworkConfigService API to ash/public for binding pipes to the in-process Network Config service instance, rather than having clients go through the Service Manager via Connector. Because the instance is effectively owned by Ash, CrosNetworkConfigTestHelper has also been moved to ash/public/cpp/test where it can more conveniently override the binding behavior. Bug: 977637 Change-Id: If47abb12f33ca0e55f2bffdfb19f0f129e5d1f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754598Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#687405}
-
Caitlin Fischer authored
Paragraphs are now respected when a node with a child node whose text is split into paragraphs is encountered. Example of such a node: <tag> Paragraph 1. Still paragraph 1. Paragraph 2. </tag> Also, adds additional tests. Bug: 993948 Change-Id: I07c257e52a33026f5607946aa36b5e9ee5480056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754124 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#687404}
-
Evan Stade authored
Recent changes have removed their usage throughout the codebase. Bug: 268984 Change-Id: Ie45823b4bb5276bf497ff68124163b81c938c09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756388Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687403}
-
Vasiliy Telezhnikov authored
This CL fixes implementation WaitForLayout. Previous implementation was pretty unreliable and significantly depended on timing in different parts of code. Bug: 989649 Change-Id: Ied747ad5f729faa3dd1652b73b186f57007842a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731778 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#687402}
-
Andrew Grieve authored
* optparse -> argparse * Removes proguard_util.py by inlining relevant logic * Ensures all outputs are written to temporary files, and then moved into place upon success * Fixes --proguard-config-exclusions not being applied for R8. * Fixes -assumevalues sdkint expression for non-R8 (it failed for -assumenosideeffects). * Unifies output hiding logic for R8/ProGuard * Makes --expected-configs-file work for non-R8 mode * And runs it before the proguard step for faster feedback. * Removes ProGuard-only --apply-mapping logic of stripping methods (no longer relevant). Change-Id: I91aa80a52afbba674b4bbc10f41f7470142daa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752842 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687401}
-
Stephen Chenney authored
In various investigations we have struggled to identify whether a perf regression is due to a style change or a layout change. Improve this situation by splitting the metric. There are some consequences to this. UMA will report layout and style for each sub-frame as a separate entry, rather than the previous behavior of recording an UMA entry for the main frame layout plus all child frames, and probably one for each child frame too. The result might be clearer now. We also losing coverage of some tasks within the UpdateStyleAndLayoutRecursive call because we do not want the intervals to become intertwined (in other words, we want to be sure we are not double counting). And building the layout tree is included in Style, because that's how the code is written. Finally, the ForcedStyleAndLayout metrics remain unchanged. A follow on task will attempt to disambiguate those from document lifecycle updates. No UKM privacy review is required because we are not gathering any additiomal information. R=eae@chromium.org, futhark@chromium.org, ikilpatrick@chromium.org, rkaplow@chromium.org Bug: None Change-Id: Ifc05e653c3d557b24178a61c54508ab6919f1759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752084Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#687400}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b218519a4b1..a28a6959c0b6 git log 5b218519a4b1..a28a6959c0b6 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-15 robertphillips@google.com Revert "Go back to blacklisting MSAA on all Intel GPUs" 2019-08-15 herb@google.com Add empty check for mask case. Small cleanups elsewhere. 2019-08-15 bungeman@google.com Restore SkFontMetrics documentation. 2019-08-15 bsalomon@google.com Turn off -Wreturn-std-move-in-c++11 2019-08-15 brianosman@google.com Go back to blacklisting MSAA on all Intel GPUs 2019-08-15 brianosman@google.com Remove MakeCrossContextFromEncoded, unused argument from ...FromPixmap Created with: gclient setdep -r src/third_party/skia@a28a6959c0b6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:527565 chromium:983926,chromium:881505,chromium:527565 chromium:983926 Change-Id: I4adbb557fa14af3262c5c85acaa9097048e40065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756565Reviewed-by:
-
Devlin Cronin authored
Add a test file (currently with a single test) for manifest v3 related sanity checks, where we can exercise core functionality of extensions and make sure it works with manifest v3. This isn't intended to replace more targeted and robust tests for specific features, and instead to just serve as a suite of end-to-end integration tests. Currently, the single test is of programmatic script injection with a service worker-based extension. Bug: 993912 Change-Id: I35406ac73ab3ea50d152509068191a68b5fccb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754529Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687398}
-
Haiyang Pan authored
to fix compile failures for builders ToTiOS and ToTiOSDevice This CL should be reverted once crbug.com/994039 is resolved TBR=jbudorick Bug: 994039,994066 Change-Id: Idc833d5824e23ca230cd6d1235d1deff4f890366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754150 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687397}
-
David Bokan authored
As of crrev.com/c/1699381 tests now run with fractional scrolling enabled so this test passes and can be re-enabled. Bug: 920417 Change-Id: I39739e2f1e27f38ed10271b096841a778f3452c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756548 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#687396}
-
Chris Lu authored
This will make it possible to use it in Showcase. Both the buttonfactory and the stackView of the BadgeViewController have to be initialized in init in order for addBadge: to successfully add badges from a Showcase coordinator. Bug: 976901 Change-Id: I2a98150cbe64e3b407295224514da6220d393ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755050 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#687395}
-
Wez authored
The CookieManager API can be used to query and observe changes to the cookies in a fuchsia.web.Context. Queries and observations can be global, restricted by URL, or to a particular URL and cookie name. Bug: 858853 Change-Id: Ibe9c9ac6fc6a0fea37c6170731e5345fdbdd0a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673602 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#687394}
-
Xing Liu authored
OnePlus devices uses modified Android OS and track analytics when foreground service is stopped. This introduces a crash in the process that runs ActivityManagerService, and send a signal to app process and triggers NullPointerException. This CL tries catch this exception, and make call sites to use the new utility function. TBR=mlamouri@chromium.org Bug: 992347 Change-Id: I8ec0e6b1ccb1a23469369811f3f74bf83dbb4612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753675 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#687393}
-
Evan Stade authored
This relands commit 7a5df8d5 Reverting didn't fix the test, and the test was also found to have been flaky before the original commit. Bug: 268984, 990692 Change-Id: I26c8c264e345e0cec6e0677e9fd28517f96d0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748603 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Tom McKee authored
In the User Timing L3 spec (https://w3c.github.io/user-timing/#performancemeasureoptions-dictionary), PerformanceMeasureOptions dictionaries can have a 'duration' member. This gives users better control over what timespan gets covered when calling `performance.measure()`. WPT coverage is also extended to check that user agents support the 'duration' member and raise errors as specified. Bug: 953848 Change-Id: Ibd2a9536b1688e19bebfd559dcf9f3437b7d89e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753741 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#687391}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f46449fa..2e905346 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e5a0c092581f607749f1bd5fd4478e00c84db8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687390}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f8a16aca062..144a3f5d5e0f git log 5f8a16aca062..144a3f5d5e0f --date=short --no-merges --format='%ad %ae %s' 2019-08-15 chrisforbes@google.com Add missing Reactor/CPUID.cpp to GLES side of build Created with: gclient setdep -r src/third_party/swiftshader@144a3f5d5e0f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I49764b03aa4836ddf701994cf6b6bbfcb8e44089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756564Reviewed-by:
-
Nick Harper authored
The ENCRYPTION_FIRST_ESTABLISHED event is only sent from MockCryptoClientStream. This CL changes it to ENCRYPTION_REESTABLISHED to allow for a quiche merge to remove the ENCRYPTION_FIRST_ESTABLISHED value. Change-Id: I75bf180ef9d07feb9c4f8beb41fe7c691e7072fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752119 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687388}
-
jonross authored
Add docs to GpuIntegrationTest._RestartBrowser to describe when Browser can be None. This is a follow up to the previous review: https://chromium-review.googlesource.com/c/chromium/src/+/1715778 Bug: 985530 Change-Id: Icd249b5e118cfc2869abb78b4a8fcd3b3088a0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753806Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#687387}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be74c47db7dd..1d742ce88a19 git log be74c47db7dd..1d742ce88a19 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 clemendeng@google.com Deleted unnecessary built-in conditions 2019-08-15 jmadill@chromium.org Remove GL/EGL function pointers from tests. Created with: gclient setdep -r src/third_party/angle@1d742ce88a19 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I02894bde475b519bb14ae5dfa203ab88b79eabaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756330Reviewed-by:
-
Chris Findeisen authored
Logs in renderer process currently return 1 on linux due to the PID namespaces. Instead we should get the pid outside of the sandboxed namespace. There is a API to support getting this pid, but it's not used in base/logging, partially because the pid was mangled to protect it from being misused and sent to POSIX apis. Thus, this CL refactors the GetUniqueIdForProcess to return a more typesafe value while still allowing the real pid to be logged via the << operator. BUG=501069 Change-Id: I9726780047e039af582dfabeb3067f9f7e75e085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730256Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ricky Zhou <rickyz@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
e163efb37210 Added CPU revision implementation for ARM64 63782c8333c9 Added Windows on ARM support to SystemSnapshot::CPUVendor 8b8066297c2a [fuchsia] remove obsolete FIDL string.cc include 2faae40e8e63 Fuchsia: Update docs to mention target_os in .gclient 1b2f448720ee Fuchsia: de-port generate_dump da3384a7088a Fuchsia: remove fuchsia.net.SocketProvider from cmx 70d10eb6296b client_win: Switch Release Load/Acq Store->Rel Store/Acq Load 08f070325eb7 Fix the build with NDK r20 a34bca8611b6 Disable warning when building gmock tests 5a0e18e41761 Refactor 'whitelist' -> 'annotations whitelist' bde5196af508 Add ProcessMemorySanitized 6225d7890687 Don't use a regex to test the CPU vendor string Bug: 891999, 973167 Change-Id: I0a397eee4f48612f656cd07ba6785e64612f2f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755011 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#687384}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7053241136b9..2ae52adeeedd git log 7053241136b9..2ae52adeeedd --date=short --no-merges --format='%ad %ae %s' 2019-08-15 rmhasan@google.com [Telemetry] Cleanup dictionary that maps the old expectations format's tags to the new tags Created with: gclient setdep -r src/third_party/catapult@2ae52adeeedd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:973936 Change-Id: I83ebdd3e00a805b9e8e2c4836df69b9e1679ad8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756563Reviewed-by:
-
Scott Violet authored
And does some minimal wiring. BUG=993813 TEST=none Change-Id: I2b27f7e6af0a49fccfac30ca055bf62a62d6db76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753557 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#687382}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f411acf552ca..c45acb9c5de5 git log f411acf552ca..c45acb9c5de5 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c45acb9c5de5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Iea22a9465291fe932f45c4095b1ba20b822101d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755345Reviewed-by:
-
Reilly Grant authored
This change adds getSignals() and setSignals() methods to the SerialPort interface which call the existing GetControlSignals() and SetControlSignals() Mojo methods. Bug: 884928 Change-Id: I5aace2e5fbd5ccad0c5b88a588ddd3de3f1a30d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747979 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#687380}
-
Brian Salomon authored
Bug: 990918 Change-Id: I01625c93fa7f901414d59b80c7d78abb93ce68ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756149Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#687379}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ c152cc559..4abb566fb (11 commits) https://quiche.googlesource.com/quiche.git/+log/c152cc559e6c..4abb566fbbc6 $ git log c152cc559..4abb566fb --date=short --no-merges --format='%ad %ae %s' 2019-08-14 vasilvv Improve logging for BandwidthSampler map size bug entry. 2019-08-14 bnc Call BlockingManager methods from QpackEncoder when decoder stream instructions arrive. 2019-08-14 bnc Refactor QpackEncoderTest. 2019-08-13 nharper gfe-relnote: Call QuicSession::OnCryptoHandshakeEvent in TLS handshake. Protected by quic_supports_tls_handshake. 2019-08-13 bnc Only send Header Acknowledgement from QpackDecoder if required insert count is not zero. 2019-08-13 quiche-dev gfe-relnote: Stop registering ephemeral QBONE streams in the blocked list. Not flag protected, no functional change other than to reduce memory pressure. 2019-08-13 wub Internal QUICHE change 2019-08-13 dschinazi Send correct version negotiation to prober 2019-08-13 fkastenholz Add convience functions to end_to_end test 2019-08-13 renjietang Removed unused UberQuicStreamIdManager methods. 2019-08-13 dschinazi Client-side workaround for probes receiving unexpected length prefixes Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: Ic2673a098e7ac038673ded4bcc9775a197751c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756156Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Ian Swett <ianswett@chromium.org> Cr-Commit-Position: refs/heads/master@{#687378}
-
Ted Meyer authored
Change-Id: Idd502786dc49b4bef25ae22e86a44ef6516275c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756436Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eefe89513262..0b1cbfc167ec git log eefe89513262..0b1cbfc167ec --date=short --no-merges --format='%ad %ae %s' 2019-08-15 saklein@chromium.org ArtifactsService: Add CPE export functionality. 2019-08-15 seanabraham@chromium.org chromeos_config: make mistral experimental Created with: gclient setdep -r src/third_party/chromite@0b1cbfc167ec The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4fef182393a24e615cb4cadc804f71850dcd714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756547Reviewed-by:
-
Mitsuru Oshima authored
* Update the widget bounds when added to the root window only when window is dragging (and dropped). This is necessary to keep the bounds of the window at target position (as the window has the bounds of the previous display). The correct bounds will be sent from Android (which should be (almost) same as current one). * Use the display id to compute the local bounds in zcr_remote_shell.cc Bug: b/130897153 Test: manual. make external display primary, and have one window there. disconnet display. Change-Id: Icd594e48efa9a5118f957d914a86147c68052b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745767 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#687375}
-
Tom McKee authored
The following histograms were marked as 'heartbeat' metrics in histograms.xml but are not considered heartbeat metrics anymore. Event.Latency.ScrollBegin.Wheel.TimeToScrollUpdateSwapBegin4 Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin4 PageLoad.PaintTiming.ForegroundToFirstContentfulPaint PageLoad.PaintTiming.ForegroundToFirstPaint PageLoad.PaintTiming.NavigationToFirstImagePaint This change removes the stale 'heartbeat' designation and also sets an expiry date of about one year on each histogram. This way, stale histograms get taken out of circulation eventually but not before owners have a chance to review. Bug: 991343 Change-Id: I1125602cd1cd267a6c363ca40609ee650deff8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754281Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Tom McKee <tommckee@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#687374}
-
Dominik Röttsches authored
Organise Blink font fallback into two main functions: * Retrieving a fallback font from the legacy path which finds a fallback font from hard-coded lists that have been curated manually and maintained. * Retrieving a fallback font through DWrite fallback API, either by calling Skia API in-process, which in turn uses DWriteFontProxy out of process bridging, or calling a Mojo method to retrieve a fallback family name. Use the LegacyWindowsDWriteFontFallbackEnabled RunTimeEnabledFeature to decide which fallback font to return, if the flag is on, always use DWrite. If the flag is off, on Windows 8 and below, only use the hard-coded fallback path. On Windows 8.1 and above, prioritze the hard-coded path, but try the API path if the hard-coded path did not find a result. This is intended as an interim flag to control which fallback font code path to use and to measure quality and availability of fallback fonts in the new code path. The flag is to be removed once we are confident to switch to the new code. Add UMA metric to record 4 different cases * Legacy hard-coded list did not find a font * API based fallback did not find a font * No font was found by either * Legacy fallback and API fallback disagreed on fallback font Record these metrics per ICU UBlockCode. Using API based fallback leads to a number of improvements exposed by some of our tests. For Japanese locales, Yu Gothic UI is selected in favor of Yu Gothic, which chooses the better screen-optimized, more modern variant of the font (fast/text/international/001.html, fast/text/international/002.html, fast/text/international/wrap-CJK-001.html). For traditional Chinese, YaHeng UI is selected in favor of SimSun, improving screen display of Chinese ideographs ( fast/text/justify-ideograph-complex.html, fast/text/justify-ideograph-simple.html). For untagged Han ideographs, Yu Gothic UI and Microsoft JhengHei UI are chosen vs. SimSun-ExtB and SimSun before. For Thai, Leelawade UI is selected over Tahoma. So, with less hand-curated fonts and removing code, we get much improved CJK and Thai fallback. Brief design doc linked from the bug. Bug: 976737 Change-Id: I3adff65cddb50061c884b81a3ae00de75d4ba735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708138 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Tricia Crichton authored
In the log_replay tool, the functions to compare logged and replayed commands were using the old ELEMENT tag. Updated this to the new W3C tag so that element Ids would be marked as variable, and not explicitly compared. This resolved 3 test failures, leaving 4 failures in client_replay_test.py needing future corrections for W3C mode. Bug: chromedriver:3076 Change-Id: I20d079992f7d69680b1b8dc53ff9e9c6b19822e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756431 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687372}
-
