- 28 May, 2020 40 commits
-
-
Shimi Zhang authored
There is another crash caused by StrictMode violation on Samsung devices This particular one was caused by reading the OEM specific clipboard, which we don't have direct control with. Bug: 1082701 Change-Id: Icce51bdecff57cd88dffc504d8b38f66aa92ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211360 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#772735}
-
Mohsen Izadi authored
WidgetBaseInputHandler::HandlingState::injected_scroll_params is a unique_ptr of a vector that is initialized on first use and never destroyed. It can simply be a vector to make code easier to read. Bug: None Change-Id: Ie2e965b142ea28d2e9635790cb41e9bfeb3a21e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083858 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772734}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/787495f0ba2e..aecba11114cf $ git log 787495f0b..aecba1111 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 junyer Refuse to rewrite when MaxSubmatch() is too large. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org CC=mmoroz@chromium.org Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: Ie5f8daab7d432ee895e1b60415d3e65bb3747a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218454 Commit-Queue: Paul Wankadia <junyer@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772733}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fdd70eae3267..0387dfcbf8e0 2020-05-28 simonmacm@google.com Merge "Fix time-in-state thread ordering inside processes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I460295ba5feee31830cc862861cb613daa5a5797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772732}
-
Haiyang Pan authored
This reverts commit fcd03993. Reason for revert: Tests fail on quite a few android builders. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=media_unittests&tests=SurfaceTextureTransformTest Original change's description: > Fix SurfaceTexture DecomposeTransformMatrix > > This CL handles adds handling of few more cases: > * Small videos have bad matrix. We get small sizes likely because > decoding errors > * Shrink amount other than 1.0. This is best guess approach as there is > no way knowing what shrink amount was used. > * Empty matrix case (when either of scales is zero). Shouldn't happen > outside of small size case. > > This CL also add fallback to visible_size if coded_size/visible_rect > seem wrong or matrix was broken and adds DumpWithoutCrashing for that > case. > > Bug: 1081695, 1086624, 1076564 > Change-Id: Ife0b70bc85b9249fa2805df1db59733ac8cdbd53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216731 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772493} TBR=backer@chromium.org,vasilyt@chromium.org Change-Id: I1fe1e970dcd4db63c5ec1a7f7e39452a0ca37202 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1081695, 1086624, 1076564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220268Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#772731}
-
James Cook authored
SyncInternalsWebUITest.SyncDisabledByDefaultChromeOS is kind of a change-detector test. It exists because historically Chrome OS had a different 'Disable reasons' value on chrome://sync-internals. SplitSettingsSync makes 'Disable reasons' match all other platforms, but there's no good way to change JS test expectations based on a platform-specific C++ feature flag. Don't assert the value of 'Disable reasons', and leave a TODO to use the cross-platform test when SplitSettingsSync is the default. Bug: 1060289, 1087165 Change-Id: Idaf7f608051dc979033a225425e8eb4057d63ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219021Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#772730}
-
Aya ElAttar authored
1. Changed member value from a public member to a private one. 2. Added a setter & getter for value, so any reference doesn't need to swap to use base::Optional when its type is changed. 3. Added non const iterators for PolicyMap to be able to get a non-const reference to value in schema_map.cc Bug: 1083984 Change-Id: I3e82e619de466963f4a8043876f2b897ec2f6ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216075 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#772729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0b9eddaa2663..d85a68f5582f 2020-05-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-28 shaochuan@chromium.org packages: update target assumption in determine_android_branch 2020-05-28 vapier@chromium.org sysroot_lib: use full path to pkg-config in our wrapper 2020-05-27 dhanyaganesh@chromium.org config: Remove x86 boards from chromeos_config_boards 2020-05-27 dhanyaganesh@chromium.org config: Remove arm_internal boards that we don't need 2020-05-27 navil@google.com chromeos_config: release-basic builder dryrun of ManifestSync. 2020-05-27 saklein@chromium.org cros_logging: Add documentation for log levels. 2020-05-27 saklein@chromium.org Misc scripts: Remove verbose option. 2020-05-27 saklein@chromium.org commandline: Add verbose option. 2020-05-27 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-27 dburger@chromium.org Raise full builders timeouts. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0bf78ad112525e6541ce63c08e49b5de8c6e984e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220170Reviewed-by:
-
Stepan Khapugin authored
Factors out the overlay code into its own VC. Bug: 1072408 Change-Id: Ia6c6c779cff5c84a1471e6496f535ee0e35bd589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218838Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772727}
-
Juanmi Huertas authored
Marking kAcceleratedDirect3dResourceUsage as deprecated. Refactoring tests to use directly CreatePassThroughProvider and refactoring CanvasRenderingContextHost to stop using Create. Adding to this CL as well the removal of a couple of methods that were going to stop being used, and would have ended with some internal NOTREACHED(). Bug: 1035589 Change-Id: I8ed92e97e494f6747513544d2dd73a4b546c1e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210492Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#772726}
-
Tarun Bansal authored
Adds a new class (data_use_prefs_tracker) that tracks the data use for last 60 days on metered connections. Right now, the use is split across foreground vs. background as well as user-initiated vs. services. This will help us understand if Chrome is consuming too much data in the background as well as if the traffic is consumed by services vs. user-initiated requests. Next CL will add prefs to track data use for individual services as well as by different content types (for user-initiated traffic). Change-Id: I90a4bdcfa92ad8ee50212b9d2bd780c42565bd43 Bug: 1081804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193935 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#772725}
-
Sasha McIntosh authored
The JPEG YUV decoding experiment has concluded and can now be enabled on TOT. This change enables YUV decoding for JPEG images by default and removes the field trial testing config. Bug: 919627 Change-Id: Ic3742750af59fa3b4e6dedc2f55424d4a87afcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216712Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772724}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4feef9cc..64a8a637 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic50815f77ca520c1581f5bcf930b686bc88e4048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772723}
-
Michael Thiessen authored
This is part 1 of 3(?). The end goal is make CommandLineFlags work for batched tests. Part 1 (this CL) gets rid of ordering concerns between class/method/field level flags by only allowing the test methods themselves to remove flags. We only had one existing case of wanting to do this, and it was actually a no-op. Part 2 will split out performing class-level CommandLineFlags parsing, and method-level CommandLine parsing. Part 3 will remove the reset() when applying CommandLineFlags modifications, and have CommandLineFlags undo the changes it makes for the test/class when the test/class finishes running. Bug: 989569 Change-Id: Icc2d3c9afca13febf55cc0e5dbaeff882ca2e9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216288Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#772722}
-
Fergal Daly authored
R=cmp@chromium.org Change-Id: I41c75606cbf211cf472963174845aef65a756aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192992Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#772721}
-
danakj authored
When dumping the navigation history, dump windows opened by the main test window also. R=avi@chromium.org Bug: 771003, 1069111 Change-Id: I6fad87666ee9542c51648dc7bf6cba493a105bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218482Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70728ef8e71e..bbc6f0a82d92 2020-05-28 bungeman@google.com Initialize ICU before use in SkParagraph. 2020-05-28 bungeman@google.com Move SkParagraph bits into skparagraph directory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ifd4394847b638b990060d5ce4777632efe60472f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220167Reviewed-by:
-
danakj authored
The test is passing with the changes made to the test harness. R=avi@chromium.org Bug: 801992, 801338, 1069111 Change-Id: If56cf2756e5ce272eb8619ca438f6fb04ee82be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218478Reviewed-by:
-
Leonard Grey authored
This reverts commit 43233e9d. Reason for revert: [Sheriff] Compile failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879044512710669184/+/steps/compile/0/stdout Original change's description: > Android: Remove enable_turbine flag > > Now that r8 has been updated to remove unnecessary bridge methods and > turbine is turned back on for all targets, and robolectric has been > moved into android_deps, we no longer need this enable_turbine flag. Now > we can assume that all non-prebuilt java targets have a turbine header. > > Bug: 1056299 > Change-Id: Id3a1d77e572fcd5d231c61deb28b444603dc1a47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219670 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772695} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I3a59f2ebe466bea657d7c18f039ed83f72ad1071 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219515Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772717}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: I121c6a8c86efbd205e2886372691d295f0a13e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214918Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772716}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: Ia53108bb26aab9232c93e19514e0c63ddb1518d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216291Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fb71e30e397..1a30c50dcab0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085579 Tbr: lgrey@google.com,jdoerrie@google.com Change-Id: I7e1615050c22a738784e72ffd5c7e5a2905e3d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219785Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772714}
-
Akihiro Ota authored
(repros 0/10 times). was available for system language (at startup). Bug: 1086640 Test: Manually verify by running ChromeVox startup 10 times Change-Id: I8c735a58e6c943916792430bb96e6b2ccf3eeb88 AX-Relnotes: Fix voice switching issue where ChromeVox said no voice Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216379 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772713}
-
Sahel Sharify authored
Without this fix the following warning appears while reading the supported delegation meta data: W Bundle : Key org.chromium.payment_supported_delegations expected String[] but value was a java.lang.Integer. The default value <null> was returned. The fix is tested with a demo native payment app. Bug: 1026667 Change-Id: Ifcc372bfb035766b4ea874bba59692cb9999c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218752 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772712}
-
Leszek Swirski authored
Change-Id: Ib31acd25b1929d45137deec969a42e654f4c9755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220087 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772711}
-
Khushal Sagar authored
R=ellyjones@chromium.org Bug: 1056730 Change-Id: I7b23d7d9cc74a4f50be5a493009ac331377dc5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218717 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#772710}
-
Roman Sorokin authored
This CL hardcodes signin profile test extension id for autotestPrivate api and for signin screen. The extension could be loaded on the test image only. Related CLs: CL:2172687 - tast test using the new test extension CL:*2942076 - key for the new test extension Bug: 941107 Change-Id: Ic057d2e0c8898fbb2a8e96054024b79651f132a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521272Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb29d3aed1ca..f55afd74b600 2020-05-28 almuthanna@google.com Convert Layout test for long trace trimming 2020-05-28 alexrudenko@chromium.org Rename inspector overlay build target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1078267 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28c692c6656f9a5732735ab21471353c59b6de07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220166Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=johnidel Bug: 1087406 Change-Id: I86e0a81bb5a304f387e68233d33976f0460f702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220006Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772707}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f57d6dd. With Chromium commits locally applied on WPT: 4ad6e935 "Move mouseevent_key_pressed.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib68b1198c774d6af78706403fae21ded8ae8472b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772706}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: If1dfc2bb9fc3c754ce43e9e8e0beff3c95426709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218451Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772705}
-
Johannes Kron authored
Will be used to trace detailed events such as the sending of RTP packets. See https://webrtc-review.googlesource.com/c/src/+/176231 Bug: webrtc:11617 Change-Id: I3c0d17190805cf39e72e5615af7c4cc3482d8602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219497 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#772704}
-
Ben Kelly authored
Bug: 1059802 Change-Id: I75965b55127c5ae9319b309d5adad62f6923a943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219074Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#772703}
-
David Van Cleve authored
To be in line with other new security-relevant Web Platform features, we only allow callers to execute Trust Tokens operations in secure contexts. Usually, WebIDL restricts functionality to secure contexts with the [SecureContext] extended attribute. This is how we initially implemented the restrictions on the three Trust Tokens interfaces (fetch, XHR, and iframe). However, this doesn't work for the fetch interface, because the [SecureContext] extended attribute doesn't work on dictionary members (like the `trustToken` member in request_init.idl); instead, it silently no-ops! This change: 1. removes the useless SecureContext attribute from RequestInit; 2. adds an explicit check that a Fetch request bearing Trust Tokens parameters is coming from a secure context, throwing a TypeError if not; and 3. for good measure, adds tests ensuring the XHR and iframe interfaces are only available in secure contexts, too. R=csharrison, yhirano Fixed: 1087200 Change-Id: If19f89251d9ab0ea16e8bb80216b5ef8d2f91b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217855Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772702}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_DidPrintContent_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy the preview UI messages. Bug: 1008939 Change-Id: I35449ebcf5ed89c9d1282997b6b10b2e674c78cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212110Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
gogerald authored
This CL also modifies the single tab switcher to explicitly selecting the current tab when clicking back button. Bug: 1085242 Change-Id: Ia2032d7e0f8a214d40f6554a5f2117be51b46c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212483 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#772700}
-
Mike Klein authored
This moves where dither happens in CPU rendering to more closely match where it happens in GPU rendering. Bug: skia:10000 Change-Id: I184fd73599129596f3896ce716366f65fce60348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219071 Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#772699}
-
Olesia Marukhno authored
Add restarting the timer on user interaction. Bug: 1019129 Change-Id: I9c2fd0320761747cefbf5b0407ed6989ca804699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214948 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772698}
-
Ehimare Okoyomon authored
Create PageInfoSubpageController and PageInfoSubpage for control of a specific section of the page info v2. Componentized the cookies section as an example. https://screenshot.googleplex.com/XnhMwuBkVzG.png Bug: 1077766 Change-Id: I7bf71c62859bcae7b2f24bd9509947c003a51c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209070 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#772697}
-
Annie Sullivan authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2218908 The CL was reverted due to failures: https://chromium-swarm.appspot.com/task?id=4c70451b557f4a10 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879124242719394576/+/steps/browser_tests/0/logs/Deterministic_failure:_LayoutInstabilityTest.OOPIFSubframeWeighting__status_CRASH_/0 ../../chrome/browser/page_load_metrics/integration_tests/layout_instability_browsertest.cc:152: Failure Value of: cls_values[i].has_value() Actual: false Expected: true This looks like one of the scores in the loop isn't getting set correctly. I'm not sure which, so this CL also fixes the check of scores and is more explicit about which score is being checked. Bug: 943668 Change-Id: Icd0203fa8b6521b83605ab1c1210376c2f7a8356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219112Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772696}
-
