- 23 Jul, 2020 22 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19031583c314..82e85676c3b3 2020-07-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8d6c555e..24ce4f08 (790803:790975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a6a28fb4c5f99030e68e97808b71eb17d845a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791102}
-
Mason Freed authored
With [1], these tests hopefully no longer fail. This CL re-enables them, with the hope that they are no longer flaky. Several of these needed a re-baseline to capture the correct focused highlight color. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1084509#c21 Bug: 1050039 Fixed: 1104118, 1104134, 1104186, 1100783, 1057518 Change-Id: Ia1765b65064a50e912f9ee2f25aa4b4a32564011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310928Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#791101}
-
mhasank authored
In this change we simply forward the error message to UI. We will add the message strings in another CL. BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow i Change-Id: I3191c238912762f8469dfcd473c41ce265a01254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305232 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791100}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3e7ab19bbf9..d115cfdcf564 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107615,chromium:912681 Tbr: kelvinjiang@google.com Change-Id: Ie772ba32f307298b81aad95306fb35cb5e6d285d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791099}
-
Mason Freed authored
A new Origin Trial [1] has been approved for M85-M87. This CL connects that origin trial to the runtime enabled feature for DeclarativeShadowDOM. [1] https://developers.chrome.com/origintrials/#/register_trial/2024368032503037953 Bug: 1042130 Change-Id: If0e695318690b29cb6bad0bb5a24217105984069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307617 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791098}
-
Kelvin Jiang authored
This reverts commit d108df6e. Reason for revert: Highly likely this is the culprit behind test failures seen on https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SSLUITest.SHA1IsDefaultDisabled&testType=browser_tests%20on%20Mac-10.15 Original change's description: > Add CertVerifierBuiltin fieldtrial_testing_config for mac. > > Bug: 973650 > Change-Id: I60375e858ac017b2b1ae96ad7bff8ce8aa6ffc97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310830 > Commit-Queue: Matt Mueller <mattm@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790974} TBR=isherman@chromium.org,mattm@chromium.org Change-Id: I7b3ad283cd048880f4920cac1472f3fbe208f238 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973650 1108632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315444Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791097}
-
Aaron Colwell authored
All callers were passing in nullptr so this parameter is unnecessary. Bug: 1085275 Change-Id: Ifd0b4deaab7eb260fe9707d3fdb6a690cdb38609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313958 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791096}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8af044eac104..b2282feee0a7 2020-07-22 cduvall@chromium.org Allow running perf tests with WebView bundles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: wenbinzhang@google.com Change-Id: I53c7e0d1bb872b9e109fd9b675276a1f5fb7402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791095}
-
Bugs Nash authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/PenDi3owOAqT-xriRmTfurHOouc2PQ5O-N95V0fVU5UC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202007210800_RC00.html Bug: b/161310363, b/161108779, b/151564533, b/161108779, b/161193549, b/161654757, b/161294780, b/161762241 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I62a49f8fd7ab583a73130ce86677fad3583dd7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310512Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#791094}
-
Jenny Zhang authored
The "New Window" menu item is added to both shelf and app list context menu for Lacros Chrome. It will launch Lacros Chrome in a new window, similar to ash Chrome's "New Window" behavior. Bug: 1103012 Change-Id: Iffe477540637ec90b236c08c42ada9a64e37c0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311088Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791093}
-
Alexey Baskakov authored
BackwardCompatibility_WebAppWithOnlyRequiredFields tests the reading of the minimal proto data with `required` fields only. Any new fields in web_app.proto should be `optional` since the BMO project launch: we need backward compatibility for any previous user's data state. If `required` field gets added into web_app.proto, this test fails. It is still possible to add required fields to optional/repeated protos, like WebAppShortcutsMenuItemInProto, and this test will pass, so it's won't catch 100% of new required fields (only minimal). Bug: 1104718 Change-Id: I1a76f19df6f9f5f81c838fc029467f1cd48c10a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302977 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#791092}
-
Arthur Wang authored
Add more logging into test runner. Bug: 1060399 Change-Id: I4bdc9ac8413f8ea04433ae927106f73d94788330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253083 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791091}
-
Nico Weber authored
This reverts commit fc86bd6c. Reason for revert: https://crbug.com/1108561 Original change's description: > mac/arm: Update to Xcode 12 beta 3. > > Bug: 1098899 > Change-Id: I9423e63db7f55fe4c18271a26ff60cee6b802bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314676 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791026} TBR=thakis@chromium.org,mark@chromium.org Change-Id: Ie6cdf343a6ed9530f3318530d50831f6a3197cce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315480Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#791090}
-
Kelvin Jiang authored
This reverts commit 2112dd99. Reason for revert: Suspected culprit for compile failure: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/15974 Original change's description: > Generate a small JS binary for parsing the X-Client-Data header > > This header contains serialized and base64-encoded protocol buffers. > This utility simply base64-decodes the serialized data, and then > parses the proto via compiled JSPB parsing. > > R=mathias@chromium.org, yangguo@chromium.org > > Bug: 1103854 > Change-Id: I233683468fdb189f206c819f650c07eae34525d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301121 > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Auto-Submit: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791067} TBR=isherman@chromium.org,dpranke@google.com,asvitkine@chromium.org,yangguo@chromium.org,mathias@chromium.org Change-Id: I3b88ca6713b76e02705c9bc7d031c0d7a1501ab1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315201Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791089}
-
James Cook authored
chops recently updated the depot_tools input_api, which makes this possible. input_api.DEFAULT_ALLOW_LIST -> input_api.DEFAULT_FILES_TO_CHECK input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP For named parameters: white_list/whitelist -> files_to_check black_list/blacklist -> files_to_skip Bug: 1098562 Change-Id: I7035bb8048430a82ebd0aeb3ae8f0edf9e134570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315243Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#791088}
-
chrome://flagsXinghui Lu authored
Add kEnhancedProtection and kSafeBrowsingSecuritySectionUIAndroid under chrome://flags on Android. kEnhancedProtection is only added on Android because this feature is already launched on desktop platforms in M83. Bug: 1097310 Change-Id: Ib0d01d2953d66b0e393b66c4fcdf668384c87be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310847 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d73e198..22d918bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I358b5adc3ffa7187a152e84e45871b87387c3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315316Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791086}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf2eeb0ca5a4f90d01e205e1c2c5391371e4e325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791085}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9ced4f3da51..184f6013466b 2020-07-22 mtklein@google.com JIT load64_{lo,hi} 2020-07-22 bsalomon@google.com Fix Chrome pixel tests after separating Mip from MinMag filtering. 2020-07-22 tdenniston@google.com Show mirror drawn with SkStroke (toy stroker) 2020-07-22 tdenniston@google.com Add path recorder class (toy stroker) 2020-07-22 westont@google.com [infra] Move iPhone11 jobs to iOS-13.6. 2020-07-22 kjlubick@google.com [canvaskit] Publish 0.17.2 2020-07-22 mtklein@google.com JIT store64 2020-07-22 egdaniel@google.com Reland "Add GrContext api to update compressed backend textures." 2020-07-22 westont@google.com [infra] Add ios-dev-image-13.6 asset. 2020-07-22 westont@google.com [infra] Add ios-dev-image-13.5 asset 2020-07-22 bsalomon@google.com Separate MIP filtering from min/mag filtering. 2020-07-22 adlai@google.com Migrate SkImage::flush methods to GrDirectContext 2020-07-22 bsalomon@google.com A few more suggest override clang 12 warning tests 2020-07-22 nifong@google.com Bump version of mskp files for skpbench If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099255 Tbr: robertphillips@google.com Change-Id: I8092a10203720a0db5009a738cf1f2881d5f6600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791084}
-
Jason Lin authored
The return value is also changed from a boolean to a clearer enum. The renaming is to reduce confusion: * CanClose() is called only when we do want to close the window. This is the only call path: Widget::CloseWithReason() -> NonClientView::CanClose() -> ClientView::CanClose() * ClientView::CanClose() is only overridden by BrowserView and WebDialogView, and both of them are actually doing closing logic instead of acting like a harmless predicate. For example, WebDialogView::CanClose() dispatchs an unload event for the web contents, which leads to the web contents being closed. The follow up CL 2278793 refactors WebDialogView::CanClose() (now OnWindowCloseRequested()) so that WebDialogDelegate::OnDialogCloseRequested() is called and has a chance to stop the web contents being closed. This will allow us to remove the hacky closing logic in Crostini{Installer,Ungrader}Dialog. Bug: 970196 Change-Id: I98ade7a88975a4a43e7b453cb1356c0b398a0f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247838 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#791083}
-
Xianzhu Wang authored
Add FragmentData::VisualRectIn2DTranslationRoot() for LayoutShiftTracker. It's currently based on FragmentData::VisualRect() and OffsetTo2DTranslationRoot(). When we remove VisualRect(), we'll remove FragmentData::visual_rect_ and offset_to_2d_translation_root_, and store visual_rect_in_2d_translation_root_ only. We don't need any more change to LayoutShiftTracker when we remove Fragment::VisualRect(). Bug: 1107724 Change-Id: I8f6f7bfe8677180a2062fb7f67f73ff7ca6ce1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311676Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791082}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed914d124174..cc02814e07b3 2020-07-22 isherman@chromium.org Add a utility for parsing the X-Client-Data header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103854 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaff3aa6b476fc037b4a00967042dccf0c337bcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791081}
-
- 22 Jul, 2020 18 commits
-
-
Miguel Casas authored
Remove use of blacklist in VaapiWrapper as per guidelines in https://tools.ietf.org/id/draft-knodel-terminology-00.html#rfc.section.1.2 Change-Id: Iffee2570d8ed6c0340ea6624b774b5cb892e18f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314994 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#791080}
-
Qiaofei Ye authored
... and WGI, add WGI class skeleton. This CL is part of the feature to make Windows.Gaming.Input (WGI) turned on by default on Chromium. WGI will provide game controller support on Windows 10 desktop, WCOS, and Xbox. The WGI also provides support for gamepad-specific Plug & Play APIs, even on WCOS devices. This feature can work on both Windows Desktop (win32 apps) and Windows 10X. This change Added the skeleton of class WGIDataFetcherWin. In the future, we will have separate data fetchers for separate APIs (XInput & WGI). In the following CL, we will perform the renaming of gamepad_platform_data_fetcher to XInputDataFetcherWin. Since this feature is under a experiment controlled rollout, the change is put behind a feature flag "kEnableWindowsGamingInputDataFetcher", and is turned off by default. Bug: 1098876 Change-Id: I1780e98c912d3472bebe91934f1c375db24312cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293615 Commit-Queue: Qiaofei Ye <qiaye@microsoft.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#791079}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a45603bd6801..6a8a74986c35 2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2eb81ffa449cbe42c2c0feb32e2571d7e69b4e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791078}
-
Salvador Guerrero authored
The following tests have been disabled TabGridDialogTest#testSwipeToDismiss_Dialog TabGridDialogTest#testUndoClosureInDialog_TabStrip TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeDisabled TabGridDialogTest#testBackPressCloseDialog TabGridDialogTest#testTabGridDialogAnimation TabGridDialogTest#testDialogToolbarMenuShareGroup TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeEnabled TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeDisabled TabGridDialogTest#testClickScrimCloseDialog TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeEnabled TabGridDialogTest#testSelectionEditorUngroup TabGridDialogTest#testDisableTabGroupsContinuation TabGridDialogTest#testUndoClosureInDialog_GTS TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeDisabled TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeEnabled TabGridDialogTest#testDialogInitialShowFromStrip TabGridDialogTest#testTabGroupNaming TBR=yusufo@chromium.org Bug: 1108547 Change-Id: I8edcbc15398dbd71573f9e1310b089038c42f979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314664Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#791077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/caa2f149fb8b..dc3f2b55c360 2020-07-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I43580553204c3c799a690734a86fcbae0b0ab32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791076}
-
Wei Li authored
Link's title should be optional at the construction time. It may be set separately. Bug: 1108460 Change-Id: Id4ee8a5030d6c6dd0d4ea7e900512214e3faef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314037 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791075}
-
Ghazale Hosseinabadi authored
This CL adds PopupRepeatedOpening test, which verifies that sessionStorage does not persist between repeated opening and closing of a popup. Bug: 42599 Change-Id: I837dd93bb12225619707127304802cff3e2d407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297687Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791074}
-
Victor Vasiliev authored
This has been previously blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1046390. Change-Id: I1c0d68dc56d109be6189df0cfb8fc04230949a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302721 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791073}
-
Meredith Lane authored
This reverts commit 780e443e. Reason for revert: Suspected Culprit for tree closure: https://ci.chromium.org/p/chromium/builders/ci/mac-arm64/2964? Original change's description: > Update core items for macOS Big Sur. > > - Update the base::mac::IsOS*() functions. Introduce a parallel set > of IsOS#() functions to match the IsOS10_#() functions. Update all > tests to match, and update callers where appropriate. > - Turn on the CFAllocator OOM killer for Big Sur, as the > internals of CFAllocator have not changed. > > BUG=45650, 1101439 > TEST=base_unittests > > Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791051} TBR=avi@chromium.org,mark@chromium.org,kelvinjiang@chromium.org Change-Id: I86460b6921c2b141d69d44351c6c2702e85dff67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 45650 Bug: 1101439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315357Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#791072}
-
Austin Eng authored
The WebGPU API provides facilities to create mapped GPUBuffers backed by shared memory. This makes it very easy for JavaScript to make large transfer buffer allocations which fail allocation and instantly lose the context. This CL adds an option to CommandBuffer::CreateTransferBuffer and MappedMemoryManager::Alloc to not lose the context on OOM but instead fail gracefully. Bug: dawn:450 Change-Id: I7311dd2ab685a150574056fbe9df5fa1724e4b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310831Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#791071}
-
zhaoyangli authored
Simulators created within test runner should be removed. However this was lost when migrating to xcodebuild_runner. Bug: 1108012 Change-Id: Ib59f1c4a580acad28fb3829238f6601a460af3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310673Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791070}
-
Scott Violet authored
This function is only used in chrome, and should be moved there. BUG=1076463 TEST=covered by tests Change-Id: I5916d68e5761635839e6ce1db680d45116ea0331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311520Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791069}
-
Devlin Cronin authored
Add support for a "match_data_urls" field in content scripts specified in an extension's manifest. This CL adds the parsing logic and related unittests, behind a base::Feature. Future CLs will add support for the actual injection of scripts into these data URLs, as well as expanding the support to include dynamic script injections. Bug: 55084 Change-Id: I288c66dfb901e9cb77d09562cf943a223adcb8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292697Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791068}
-
Ilya Sherman authored
This header contains serialized and base64-encoded protocol buffers. This utility simply base64-decodes the serialized data, and then parses the proto via compiled JSPB parsing. R=mathias@chromium.org, yangguo@chromium.org Bug: 1103854 Change-Id: I233683468fdb189f206c819f650c07eae34525d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301121 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#791067}
-
Nick Harper authored
Change-Id: I3f5bd166da9b104128ade1891e427e8953083c83 Bug: 855690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314556Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791066}
-
Ahmed Mehfooz authored
Ux specs are attached in the bug. Bug: 1106054 Change-Id: Ie8982f5b07a6330e16d76da19b3e36f48fc9731a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300633 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791065}
-
Ian Struiksma authored
Bring up win1909 to tests before rolling out to larger machine pool. Bug: 990885 Change-Id: Id3900e8f04a386bd2e6fe81dee4799bc747cdfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311124 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791064}
-
Tommy Li authored
We've always returned the current page's URL as a verbatim default match for ZeroSuggest (with the exception of on the NTP). However, we don't need this anymore on Desktop. This CL preserves the most-visited mode's behavior, but removes the verbatim match from all remotely fetched (from the suggest server) ZeroSuggest results on Desktop. We leave Android and iOS alone. Android needs the verbatim match for the Search Ready Omnibox edit widget. iOS we're leaving alone because there's no strong reason to change it. Bug: 1095843, 1106096 Change-Id: Iac6c1ee401a93cda05df7cc96d5e176e3d36f3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308944 Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791063}
-