- 24 Aug, 2020 40 commits
-
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/sessions This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1110266 Change-Id: I9336dc1817cb5c195a366e613c4af4cb8c3d57c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371258 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801061}
-
David Black authored
After this change, clipboard data which contains *only* custom data will be omitted from history *unless* that custom data is recognized file system data. Bug: 1108902, 1119931 Change-Id: Id7a5b13089b7175878c1ec8018539cc013d2109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369349Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801060}
-
Sinan Sahin authored
With this CL, we inflate the view right before showing it and destroy it when it's hidden. Animations are also set to null when they end. Bug: 1005843 Change-Id: I2fd05939bd81eb7155a48744cfca33a1bc319e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355005Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#801059}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /weblayer This CL was uploaded by git cl split. R=nator@chromium.org Bug: 1110266 Change-Id: I43b0a1f583fd61f28a52315b1a81445306a44f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371305 Commit-Queue: Sean McAllister <smcallis@google.com> Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#801058}
-
Eugene But authored
StartLeakingMemory leaks memory by repeatedly allocating memory using operator new. This causes UTE in debug Chromium build, but not in release Chrome build. It's possible that release build has some optimization that throw away memory allocation, so this CL adds allocated memory to NSArray<NSData*> container to ensure the leak. Bug: 1103752 Change-Id: I162250621bfbded39145e594ec135b4bf46261ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368145 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801057}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I91d0688616346b5a0da121f19ed53c399428f397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801056}
-
Nate Fischer authored
This batches a bunch of test suites which seem to obviously be unit tests (most of these have comments which indicate this, or run in SINGLE_PROCESS only). Fixed: 1120843 Test: run_webview_instrumentation_test_apk -A Batch=UnitTests Change-Id: I801e30f17ac03d1c871c7a079786b993972ceea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369616 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801055}
-
Tal Pressman authored
Change-Id: Ibe648c7f20b9866bdafc724b3fb3777d30e1a464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371147Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#801054}
-
Wei Li authored
Instead of using an InitParams with options, this CL refactors to use various setter functions to set the optional views and layout parameters. The above change will allow the default constructability of MessageBoxView class. BUG=1108460 Change-Id: I16a31e95fabef2b46281889777146e2888cde9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367645 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Experimental data looks good so the feature will now be enabled by default. Bug: 1040039 Change-Id: I5e89bce109fcc03b95fe46c2350a009aadc59278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372286Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#801052}
-
Asanka Herath authored
R=caraitto@chromium.org Bug: 973801 Change-Id: Ice5b139becd3af1c163246d1fe2139c0bccc8c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370602Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#801051}
-
Nate Chapin authored
Change-Id: I1eedafc3ccca37f9d57b2169f43926940dcd9684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342273Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#801050}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec3fd1e6930e..d989a67c59d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmonette@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmonette@google.com,drott@google.com Change-Id: Id6a9903405275004f0cf40e832db15197ba50c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801049}
-
Maksim Sisov authored
non-Ozone/X11 uses the GetCustomFramePrefDefault() method to determine whether a custom frame needs to be used. In contrast, Ozone/X11 always set that to false. That looks like an inconsistency between twos. Thus, use that method instead. PS: I had to remove constexpr from the kX11PlatformProperties to be able to change the value. It doesn't seem to be possible to call the GetCustomFramePrefDefault method from initializer as long as that method isn't constexpr and cannot be changed to that either. Bug: 789065 Change-Id: Ibd5e7387ea6d3e473f217638f203f74ae42c530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372462Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#801048}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/ui/global_media_controls This CL was uploaded by git cl split. R=steimel@chromium.org Bug: 1110266 Change-Id: Id2f3bd9416254e8dc8734dd43a874910e0697280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370284 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801047}
-
Jarryd authored
Quota Change event is not yet spec'd, so this change updates the name to reflect that. Change-Id: I6a4f1bba1bdece6efd577cba39fb2a0ca8b5ee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369256 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#801046}
-
dpapad authored
Specifically deleting: - paper-amber - paper-blue - paper-brown - paper-cyan - paper-deep-orange - paper-deep-purple - paper-green - paper-indigo - paper-light-green - paper-lime - paper-pink - paper-purple - paper-teal Bug: 1062154 Change-Id: I5cdcfe018781add74a508588be1d996fc30c9528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371744 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#801045}
-
Jan Wilken Dörrie authored
This change removes calls to StringPiece16::as_string() from the code base and uses the explicit to base::string16 instead. Furthermore, it now disables as_string() for all string types but std::string, so that no further usages are introduced. Removing BasicStringPiece::as_string() completely is desired, but requires more work. TBR=dcheng Bug: 1049498 Change-Id: I50cfb91dc79f63c0e4207900e041cb2e577fcb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364510 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkApnlistTest* Change-Id: Ie5e53f81cfed55da95d7c6f9c1df25338850ba3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372886 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ef7447334713..c3e3c30b0d7f 2020-08-24 rharrison@chromium.org Roll 4 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I542c7235e9d727519ff33e932cefbbeb93a21a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372770Reviewed-by:
-
David Tseng authored
This change plumbs through the idea of a generated event type directly onto the AutomationEvent interface. GeneratedEvents are those defined in ui/accessibility/ax_event_generator.h. This is a straight-forward way for chrome.automation to make use of the underlying data. Note also that future authors can add additional events to chrome.automation.GeneratedEventType without touching ax::mojom::Event or ui::AXEventGenerator::Event. We only enforce that all ui::AXEventGenerator::Event types are in chrome.automation.GeneratedEventType, but not the reverse. See the fixed bug for an application of this change. Test: manually and browser_tests --gtest_filter=ChromeVox*.SortDirection. Fixed: 1112983 AX-relnotes: adds support for aria-sort output in ChromeVox. Change-Id: I27a34e988ce7ca8988ab2ee177e9022b7bc54610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353704 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#801041}
-
Michael Checo authored
• Adjusted file input size to accommodate long localized text Screenshots: Before: • add manufacturer/model dialog: http://shortn/_vclFeWHF7F • edit dialog: http://shortn/_7jVZAAwuxU After: • add manufacturer/model dialog: http://shortn/_r1l2s42oOu • edit dialog: http://shortn/_Nv8DPj55sE BUG=1100158 TEST=manual inspection Change-Id: I1d65cc68f5730c1cc94ac22a54834e9d7ffaae65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357415Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#801040}
-
Michael Checo authored
• Removes the line in all add printer dialogs. Screenshots: Before: • add printer dialog: http://shortn/_dkhOXdVpWr • add print server dialog: http://shortn/_Gn4L7Ppngv After: • add printer dialog: http://shortn/_aQz95BZyxN • add print server dialog: http://shortn/_KP8sxGsFZA BUG=1057030 TEST=manual inspection Change-Id: Ic6c68253a7d0c01d58d9224afe6147940a9d0e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354966Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I632870e4b9d0cb121d6fcc426a128a0d84052269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353131 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801038}
-
Yue Zhang authored
This CL adds a snack bar to TabGridDialog that handles closure within dialog. Note that this change doesn't prevent the original snack bar from showing when closure happens, so there will be two snack bars showing when a closure happens within dialog. This issue will be addressed by later CLs. Bug: 1119899 Change-Id: If0e5b010996a80c9a111c8bf2cb8af44feb63124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368236 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801037}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c86d8fb76ac3..1c96e6739bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6adb005b3025b63999dedaf9e8a86564bcfde700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372771Reviewed-by:
-
Tommy Steimel authored
This CL is a followup of crrev.com/c/2365314 which removes the code that is deprecated by that CL. There is a chrome-internal CL that must land after that CL and before this CL in order to avoid a broken state. Bug: b:154517281 Change-Id: I21e0363a0744600b8d91857d53d435841b17145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367934 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801035}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09b5e6b1950b..7ce9947d8103 2020-08-24 lehoangq@gmail.com Metal: autogen for 3D texture's mipmap generating shader. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I4fd85ab07f6b6827425f89dbcf045a3e74fcd454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372768Reviewed-by:
-
Matthew Wolenetz authored
This reverts commit 71256e1f. Reason for revert: Either this or the next devtools roll (already reverted) are suspected in closing tree crbug 1121242 Original change's description: > Roll DevTools Frontend from 5a8fc1fe06a2 to 01f7fadf76bf (3 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..01f7fadf76bf > > 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md > 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag > 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I3de852373f7bc1b728fa28cdc53965ad9d15fd73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372006 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800966} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iefb5604454d6a9ccb1b832535a708cdc680510dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372892Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801033}
-
Matthew Wolenetz authored
This reverts commit 8c45be6d. Reason for revert: Either this or the previous devtools roll are suspected in closing tree crbug 1121242 Original change's description: > Roll DevTools Frontend from 01f7fadf76bf to ecc4ecb65cd8 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01f7fadf76bf..ecc4ecb65cd8 > > 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ieb099222e319b09a3c54525341520a9f8e1322d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370523 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800979} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3930a85f217d2cb99fefae80b25754820310cdbf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372891Reviewed-by:
-
Matthew Wolenetz authored
This reverts commit 1bc8019f. Reason for revert: One or both of the two previous devtools rolls are suspected in tree closure - crbug 1121242 Original change's description: > Roll DevTools Frontend from ecc4ecb65cd8 to 6702add20dd3 (2 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ecc4ecb65cd8..6702add20dd3 > > 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. > 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I7d06cf9b8d0a1c1d72d1dbac6ba2c466d04ae487 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371337 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800995} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95e0189bf83a3b2fc65905c8f9cdacfa6cd44880 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372730 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I36e17af8164e44b0f7e81c6513ce044370bc424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372694Reviewed-by:
-
Omer Katz authored
This reverts commit 0a610db7. Reason for revert: The same stack trace still appears on new crashes. Original change's description: > Speculative CHECK to pinpoint crash. > > The issue below correlates to element_under_pointer_.at returning a > nullptr. All calls to element_under_pointer_.at but one are prefaced > with an if(element_under_pointer_.Contains(...)) check. > That one call is prefaced with a DCHECK. Most likely culprit is that > there is a real-world case in which the DCHECK doesn't hold and is > not covered by our tests. > Making the DCHECK a CHECK should confirm that. We'd still get the > same number of crashes overall, but with a different stacktrace. > > Bug: 1114579 > Change-Id: Ie28c971ed2114cf4a780f9eb5366c60d7669315c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359081 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798657} TBR=haraken@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114579 Change-Id: I9ff7e81bbe50484718ced3fd1cc97f900427be07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372366Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801029}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f9f6adb625c4..cdc009c24afa 2020-08-22 wl@gnu.org * src/truetype/ttgload.c (TT_Get_VMetrics): Add tracing message. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ibb8813accd8e8efcbddbe46ac6ec4722f4014dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370213 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801028}
-
Philipp Hancke authored
Adds usage counters for the promise versions of - setLocalDescription - setRemoteDescription - createOffer - createAnswer as well as now counters for the total of each. The usage counters for these have only been applied to the non-promise versions so far. BUG=None Change-Id: I50757cc66821cde7f46b3a864d33965f7543ed70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361686Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#801027}
-
Liquan (Max) Gu authored
Context: Organize the logic of parseAndValidateDetailsOrDisconnectFromClient to prepare for splitting it into business logic and UI logic. The change of this CL is done based on the discussion[1]. Change: * Rename setShippingOption into setShippingOptionIfValid so as to be explicit about the validation purpose. * Close client before SkipToGPay error out. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1787117/5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#1243 Change-Id: I918fb133444d32797b7a71d3aede4586c3c0cb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372802 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801026}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/216b984d3946..87d42e5d12b3 2020-08-24 bsalomon@google.com A new way to specify YUVA planar data from SkCodec to SkImage_Lazy 2020-08-24 johnstiles@google.com Disable ClangTidy namespace comments for short blocks. 2020-08-24 mtklein@google.com style guide tweaks 2020-08-24 tmoniuszko@opera.com Remove duplicated header file from sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I1b7107dfc7589355de0ae371862d56c274f9e960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372685Reviewed-by:
-
Peter Marshall authored
The agent can be disabled when this message arrives, just like the undo() and redo() methods above. Check for this explicitly because it sets history_ back to null which can cause a nullptr dereference. Bug: 1115856 Change-Id: I503a8dffc5abd3b490d6ca21ae22f0edafb8e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367680 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#801024}
-
Becca Hughes authored
The consent covers both background fetching and safe search. BUG=1120621 Change-Id: I32dbec2b9b1644654ca3f465ef4c7986c952e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369296 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70b2cf8b368d..d37b0ec2bb0c 2020-08-24 minyue@webrtc.org Passing the estimated capture clock offset to SendVideo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a243a433eb1beb57925f3649c9695900f470073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372689Reviewed-by:
-
